branch develop updated (43baa50c -> 947ac635)
This is an automated email from the git hooks/post-receive script. New change to branch develop in repository faxtomail. See https://gitlab.nuiton.org/codelutin/faxtomail.git from 43baa50c - fixes #10094 : Ne pas bloquer la réception des mails sur une OutOfMEmoryError new 0e9c3f33 Improve helper new 6b102bfc Try with ressource new 947ac635 - fixes #10094 : Mail bloquant - Libération des ressources ! The 3 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "adds" were already present in the repository and have only been added to this reference. Detailed log of new commits: commit 947ac6358f9d256000993bd74ae48d275579a297 Author: jcouteau <couteau@codelutin.com> Date: Wed Sep 19 15:43:37 2018 +0200 - fixes #10094 : Mail bloquant - Libération des ressources ! commit 6b102bfcccacf050f5c19f331deb1203ed76ebca Author: jcouteau <couteau@codelutin.com> Date: Wed Sep 19 14:17:15 2018 +0200 Try with ressource commit 0e9c3f330f1cf9aa60286f3cef1bfd5c6a07b780 Author: jcouteau <couteau@codelutin.com> Date: Wed Sep 19 14:14:26 2018 +0200 Improve helper Summary of changes: .../services/service/EmailServiceTest.java | 30 ++++++++++++---------- .../faxtomail/web/job/MailFilterJob.java | 15 +++++------ 2 files changed, 23 insertions(+), 22 deletions(-) -- To stop receiving notification emails like this one, please contact codelutin.com SCM administrator <admin+scm@codelutin.com>.
This is an automated email from the git hooks/post-receive script. New commit to branch develop in repository faxtomail. See https://gitlab.nuiton.org/codelutin/faxtomail.git commit 0e9c3f330f1cf9aa60286f3cef1bfd5c6a07b780 Author: jcouteau <couteau@codelutin.com> Date: Wed Sep 19 14:14:26 2018 +0200 Improve helper --- .../franciaflex/faxtomail/services/service/EmailServiceTest.java | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/faxtomail-service/src/test/java/com/franciaflex/faxtomail/services/service/EmailServiceTest.java b/faxtomail-service/src/test/java/com/franciaflex/faxtomail/services/service/EmailServiceTest.java index 0ffb7f7b..17e47cad 100644 --- a/faxtomail-service/src/test/java/com/franciaflex/faxtomail/services/service/EmailServiceTest.java +++ b/faxtomail-service/src/test/java/com/franciaflex/faxtomail/services/service/EmailServiceTest.java @@ -552,16 +552,18 @@ public class EmailServiceTest extends AbstractFaxToMailServiceTest { * @throws IOException */ public void generateImageForEachPage() throws IOException { - File pdf = new File("src/test/resources/pdf/10004.pdf"); + File pdf = new File("src/test/resources/pdf/10094.pdf"); //Pre-generate PDF rendering PDDocument pdDocument = PDDocument.load(pdf); PDFRenderer renderer = new PDFRenderer(pdDocument); for (int i = 0; i < pdDocument.getNumberOfPages(); i++) { - BufferedImage pageImage = renderer.renderImage(0, 1.5f); - File tempFile = File.createTempFile("10004-"+0, ".png"); + System.out.println("Generate page " + i); + BufferedImage pageImage = renderer.renderImage(i, 1.5f); + File tempFile = File.createTempFile("10094-"+i+"-", ".png"); tempFile.createNewFile(); + System.out.println(tempFile.getName()); ByteArrayOutputStream baos = new ByteArrayOutputStream(); ImageIO.write( pageImage, "png", baos ); -- To stop receiving notification emails like this one, please contact codelutin.com SCM administrator <admin+scm@codelutin.com>.
This is an automated email from the git hooks/post-receive script. New commit to branch develop in repository faxtomail. See https://gitlab.nuiton.org/codelutin/faxtomail.git commit 6b102bfcccacf050f5c19f331deb1203ed76ebca Author: jcouteau <couteau@codelutin.com> Date: Wed Sep 19 14:17:15 2018 +0200 Try with ressource --- .../services/service/EmailServiceTest.java | 30 ++++++++++++---------- 1 file changed, 16 insertions(+), 14 deletions(-) diff --git a/faxtomail-service/src/test/java/com/franciaflex/faxtomail/services/service/EmailServiceTest.java b/faxtomail-service/src/test/java/com/franciaflex/faxtomail/services/service/EmailServiceTest.java index 17e47cad..0699c5ad 100644 --- a/faxtomail-service/src/test/java/com/franciaflex/faxtomail/services/service/EmailServiceTest.java +++ b/faxtomail-service/src/test/java/com/franciaflex/faxtomail/services/service/EmailServiceTest.java @@ -555,23 +555,25 @@ public class EmailServiceTest extends AbstractFaxToMailServiceTest { File pdf = new File("src/test/resources/pdf/10094.pdf"); //Pre-generate PDF rendering - PDDocument pdDocument = PDDocument.load(pdf); - PDFRenderer renderer = new PDFRenderer(pdDocument); + try (PDDocument pdDocument = PDDocument.load(pdf)) { + PDFRenderer renderer = new PDFRenderer(pdDocument); - for (int i = 0; i < pdDocument.getNumberOfPages(); i++) { - System.out.println("Generate page " + i); - BufferedImage pageImage = renderer.renderImage(i, 1.5f); - File tempFile = File.createTempFile("10094-"+i+"-", ".png"); - tempFile.createNewFile(); - System.out.println(tempFile.getName()); + for (int i = 0; i < pdDocument.getNumberOfPages(); i++) { + System.out.println("Generate page " + i); + BufferedImage pageImage = renderer.renderImage(i, 1.5f); + File tempFile = File.createTempFile("10094-" + i + "-", ".png"); + tempFile.createNewFile(); + System.out.println(tempFile.getName()); - ByteArrayOutputStream baos = new ByteArrayOutputStream(); - ImageIO.write( pageImage, "png", baos ); - baos.flush(); - byte[] imageInByte = baos.toByteArray(); - baos.close(); + try (ByteArrayOutputStream baos = new ByteArrayOutputStream()) { + ImageIO.write(pageImage, "png", baos); + baos.flush(); + byte[] imageInByte = baos.toByteArray(); + baos.close(); - Files.write(imageInByte, tempFile); + Files.write(imageInByte, tempFile); + } + } } } -- To stop receiving notification emails like this one, please contact codelutin.com SCM administrator <admin+scm@codelutin.com>.
This is an automated email from the git hooks/post-receive script. New commit to branch develop in repository faxtomail. See https://gitlab.nuiton.org/codelutin/faxtomail.git commit 947ac6358f9d256000993bd74ae48d275579a297 Author: jcouteau <couteau@codelutin.com> Date: Wed Sep 19 15:43:37 2018 +0200 - fixes #10094 : Mail bloquant - Libération des ressources ! --- .../com/franciaflex/faxtomail/web/job/MailFilterJob.java | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/faxtomail-ui-web/src/main/java/com/franciaflex/faxtomail/web/job/MailFilterJob.java b/faxtomail-ui-web/src/main/java/com/franciaflex/faxtomail/web/job/MailFilterJob.java index 13b14974..2e5ba6cb 100644 --- a/faxtomail-ui-web/src/main/java/com/franciaflex/faxtomail/web/job/MailFilterJob.java +++ b/faxtomail-ui-web/src/main/java/com/franciaflex/faxtomail/web/job/MailFilterJob.java @@ -228,14 +228,10 @@ public class MailFilterJob extends AbstractFaxToMailJob { } for (Message message:folder.getMessages()){ -// for (int i = 0 ; i < count ; i++) { try { Email email = new EmailImpl(); email.setFax(emailAccount.isFaxAccountType()); -// int messageNumber = count - i; -// Message message = folder.getMessage(messageNumber); - Charset charset = FaxToMailServiceUtils.getCharset(message); Set<String> modifiedProperties = new HashSet<>(); @@ -462,13 +458,14 @@ public class MailFilterJob extends AbstractFaxToMailJob { if (isFileAPDF(attachment.getOriginalFile())) { //Pre-generate PDF rendering - PDDocument pdDocument = PDDocument.load(attachment.getOriginalFile().getContent()); - PDFRenderer renderer = new PDFRenderer(pdDocument); + try (PDDocument pdDocument = PDDocument.load(attachment.getOriginalFile().getContent())) { + PDFRenderer renderer = new PDFRenderer(pdDocument); - for (int i = 0; i < pdDocument.getNumberOfPages(); i++) { - BufferedImage pageImage = renderer.renderImage(i); + for (int i = 0; i < pdDocument.getNumberOfPages(); i++) { + BufferedImage pageImage = renderer.renderImage(i); - emailService.createGeneratedPDFPage(attachment, pageImage); + emailService.createGeneratedPDFPage(attachment, pageImage); + } } } } -- To stop receiving notification emails like this one, please contact codelutin.com SCM administrator <admin+scm@codelutin.com>.
participants (1)
-
codelutin.com scm