branch develop updated (2a42952 -> 0202b47)
This is an automated email from the git hooks/post-receive script. New change to branch develop in repository i18n. See https://gitlab.nuiton.org/nuiton/i18n.git from 2a42952 Make sure org.nuiton.i18n.I18nUtil#containsDirectDirectory does not fail if the ZIP is not a valid ZIP file new 0202b47 Add unit test to prevent regressions on containsDirectDirectory on zip files The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "adds" were already present in the repository and have only been added to this reference. Detailed log of new commits: commit 0202b475ea850ff5e33aae7e4e31f3693112e266 Author: jcouteau <couteau@codelutin.com> Date: Mon Jan 6 15:54:27 2020 +0100 Add unit test to prevent regressions on containsDirectDirectory on zip files Summary of changes: .../src/test/java/org/nuiton/i18n/I18nUtilTest.java | 19 +++++++++++++++++++ nuiton-i18n/src/test/resources/zip/not-a-zip.zip | 1 + nuiton-i18n/src/test/resources/zip/zip.zip | Bin 0 -> 280 bytes 3 files changed, 20 insertions(+) create mode 100644 nuiton-i18n/src/test/java/org/nuiton/i18n/I18nUtilTest.java create mode 100644 nuiton-i18n/src/test/resources/zip/not-a-zip.zip create mode 100644 nuiton-i18n/src/test/resources/zip/zip.zip -- To stop receiving notification emails like this one, please contact nuiton.org SCM administrator <admin+scm@nuiton.org>.
This is an automated email from the git hooks/post-receive script. New commit to branch develop in repository i18n. See https://gitlab.nuiton.org/nuiton/i18n.git commit 0202b475ea850ff5e33aae7e4e31f3693112e266 Author: jcouteau <couteau@codelutin.com> Date: Mon Jan 6 15:54:27 2020 +0100 Add unit test to prevent regressions on containsDirectDirectory on zip files --- .../src/test/java/org/nuiton/i18n/I18nUtilTest.java | 19 +++++++++++++++++++ nuiton-i18n/src/test/resources/zip/not-a-zip.zip | 1 + nuiton-i18n/src/test/resources/zip/zip.zip | Bin 0 -> 280 bytes 3 files changed, 20 insertions(+) diff --git a/nuiton-i18n/src/test/java/org/nuiton/i18n/I18nUtilTest.java b/nuiton-i18n/src/test/java/org/nuiton/i18n/I18nUtilTest.java new file mode 100644 index 0000000..410ee97 --- /dev/null +++ b/nuiton-i18n/src/test/java/org/nuiton/i18n/I18nUtilTest.java @@ -0,0 +1,19 @@ +package org.nuiton.i18n; + +import org.junit.Assert; +import org.junit.Test; + +import java.net.URL; + +public class I18nUtilTest { + + @Test + public void testContainsDirectDirectory() throws Exception { + URL url = this.getClass().getResource("/zip/not-a-zip.zip"); + Assert.assertFalse(I18nUtil.containsDirectDirectory(url, "")); + + url = this.getClass().getResource("/zip/zip.zip"); + Assert.assertTrue(I18nUtil.containsDirectDirectory(url, "test")); + Assert.assertFalse(I18nUtil.containsDirectDirectory(url, "testFailing")); + } +} diff --git a/nuiton-i18n/src/test/resources/zip/not-a-zip.zip b/nuiton-i18n/src/test/resources/zip/not-a-zip.zip new file mode 100644 index 0000000..678acb4 --- /dev/null +++ b/nuiton-i18n/src/test/resources/zip/not-a-zip.zip @@ -0,0 +1 @@ +This is not a zip file... \ No newline at end of file diff --git a/nuiton-i18n/src/test/resources/zip/zip.zip b/nuiton-i18n/src/test/resources/zip/zip.zip new file mode 100644 index 0000000..2021735 Binary files /dev/null and b/nuiton-i18n/src/test/resources/zip/zip.zip differ -- To stop receiving notification emails like this one, please contact nuiton.org SCM administrator <admin+scm@nuiton.org>.
participants (1)
-
nuiton.org scm