Author: tchemit Date: 2009-10-30 21:27:43 +0100 (Fri, 30 Oct 2009) New Revision: 32 Modified: trunk/maven-jredmine-plugin/src/main/java/org/nuiton/jredmine/plugin/AbstractRedmineMojo.java trunk/maven-jredmine-plugin/src/main/java/org/nuiton/jredmine/plugin/DisplayDataMojo.java Log: clean code Modified: trunk/maven-jredmine-plugin/src/main/java/org/nuiton/jredmine/plugin/AbstractRedmineMojo.java =================================================================== --- trunk/maven-jredmine-plugin/src/main/java/org/nuiton/jredmine/plugin/AbstractRedmineMojo.java 2009-10-30 20:27:01 UTC (rev 31) +++ trunk/maven-jredmine-plugin/src/main/java/org/nuiton/jredmine/plugin/AbstractRedmineMojo.java 2009-10-30 20:27:43 UTC (rev 32) @@ -303,7 +303,7 @@ if (isSafe()) { - String message = null; + String message; if (error != null) { message = "safe mode is on and could not init goal [" + getClass().getSimpleName() + "] for reason " + error.getMessage(); } else { @@ -437,10 +437,7 @@ } try { this.releaseProject = service.getProject(projectId); - if (releaseProject == null) { - return false; - } - return true; + return releaseProject != null; } catch (RedmineServiceException e) { getLog().warn("could not retreave project '" + projectId + "', goal is skip"); if (verbose) { Modified: trunk/maven-jredmine-plugin/src/main/java/org/nuiton/jredmine/plugin/DisplayDataMojo.java =================================================================== --- trunk/maven-jredmine-plugin/src/main/java/org/nuiton/jredmine/plugin/DisplayDataMojo.java 2009-10-30 20:27:01 UTC (rev 31) +++ trunk/maven-jredmine-plugin/src/main/java/org/nuiton/jredmine/plugin/DisplayDataMojo.java 2009-10-30 20:27:43 UTC (rev 32) @@ -113,13 +113,13 @@ RedmineModelScope scope = entry.getScope(); Object[] datas = ((RedmineServiceImplementor) service).getDatas(entry.getModelType(), projectId, versionId); - buffer.append("\nValues of '" + entry).append('\''); + buffer.append("\nValues of '").append(entry).append('\''); if (scope == RedmineModelScope.project || scope == RedmineModelScope.version) { - buffer.append(" for project " + projectId); + buffer.append(" for project ").append(projectId); } buffer.append('\n'); for (Object data : datas) { - buffer.append(" - " + ((IdAble) data).getId()).append(" = ").append(((I18nAble) data).getName()).append('\n'); + buffer.append(" - ").append(((IdAble) data).getId()).append(" = ").append(((I18nAble) data).getName()).append('\n'); } } System.out.println(buffer.toString()); @@ -148,7 +148,7 @@ if (scope == RedmineModelScope.project || scope == RedmineModelScope.version) { // check projectId used - if (projectId == null && projectId.isEmpty()) { + if (projectId == null || projectId.isEmpty()) { throw new MojoFailureException("could not use the data type " + result + " since it is not a project requires and projectId was not filled"); } }