This is an automated email from the git hooks/post-receive script. New commit to branch feature/refactor_reference in repository observe. See http://git.codelutin.com/observe.git commit c650adc006fcb47cc1dab6e20be09a9de52afe49 Author: Tony CHEMIT <chemit@codelutin.com> Date: Fri Nov 20 08:43:18 2015 +0100 Fix generic --- .../src/main/java/fr/ird/observe/services/dto/ReferenceSetDto.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/observe-services-model/src/main/java/fr/ird/observe/services/dto/ReferenceSetDto.java b/observe-services-model/src/main/java/fr/ird/observe/services/dto/ReferenceSetDto.java index ad27724..7a03b5b 100644 --- a/observe-services-model/src/main/java/fr/ird/observe/services/dto/ReferenceSetDto.java +++ b/observe-services-model/src/main/java/fr/ird/observe/services/dto/ReferenceSetDto.java @@ -62,8 +62,8 @@ public class ReferenceSetDto<R extends IdDto> extends AbstractReferenceSetDto { .toString(); } - public ReferenceDto getReference(int index) { - ReferenceDto o = getChild(reference, index); + public ReferenceDto<R> getReference(int index) { + ReferenceDto<R> o = getChild(reference, index); return o; } -- To stop receiving notification emails like this one, please contact codelutin.com SCM administrator <admin+scm@list.forge.codelutin.com>.

This is an automated email from the git hooks/post-receive script. New commit to branch feature/refactor_reference in repository observe. See http://git.codelutin.com/observe.git commit 7a56f19416b98913ff56e04fde0040c53bd2efe1 Author: Tony CHEMIT <chemit@codelutin.com> Date: Fri Nov 20 08:43:30 2015 +0100 Ajout d'une méthode utile pour récupérer tous les types de lables d'un formulaire --- .../fr/ird/observe/services/dto/ReferenceSetDtos.java | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/observe-services-model/src/main/java/fr/ird/observe/services/dto/ReferenceSetDtos.java b/observe-services-model/src/main/java/fr/ird/observe/services/dto/ReferenceSetDtos.java index eb12ec1..5667457 100644 --- a/observe-services-model/src/main/java/fr/ird/observe/services/dto/ReferenceSetDtos.java +++ b/observe-services-model/src/main/java/fr/ird/observe/services/dto/ReferenceSetDtos.java @@ -22,11 +22,15 @@ package fr.ird.observe.services.dto; * #L% */ +import com.google.common.base.Function; import com.google.common.base.Predicate; +import com.google.common.collect.Iterables; +import com.google.common.collect.Sets; import java.util.Date; import java.util.LinkedHashSet; import java.util.Objects; +import java.util.Set; public class ReferenceSetDtos extends AbstractReferenceSetDtos { @@ -65,5 +69,18 @@ public class ReferenceSetDtos extends AbstractReferenceSetDtos { } + public static Set<Class<?>> getTypes(Iterable<ReferenceSetDto> referenceSets) { + + Set<Class<?>> types = Sets.newLinkedHashSet(Iterables.transform(referenceSets, new Function<ReferenceSetDto, Class<?>>() { + + @Override + public Class<?> apply(ReferenceSetDto input) { + return input.getType(); + } + })); + return types; + + } + } -- To stop receiving notification emails like this one, please contact codelutin.com SCM administrator <admin+scm@list.forge.codelutin.com>.

This is an automated email from the git hooks/post-receive script. New commit to branch feature/refactor_reference in repository observe. See http://git.codelutin.com/observe.git commit 295365d61e3c205e4d3eee0274bb1bf55fdf0b0d Author: Tony CHEMIT <chemit@codelutin.com> Date: Fri Nov 20 08:44:35 2015 +0100 Suppression classe non utilisée --- .../ird/observe/db/ObserveReferentialCacheKey.java | 33 ---------------------- 1 file changed, 33 deletions(-) diff --git a/observe-application-swing/src/main/java/fr/ird/observe/db/ObserveReferentialCacheKey.java b/observe-application-swing/src/main/java/fr/ird/observe/db/ObserveReferentialCacheKey.java deleted file mode 100644 index 3eda009..0000000 --- a/observe-application-swing/src/main/java/fr/ird/observe/db/ObserveReferentialCacheKey.java +++ /dev/null @@ -1,33 +0,0 @@ -package fr.ird.observe.db; - -import com.google.common.base.Optional; -import fr.ird.observe.services.dto.referential.ReferentialDto; - -/** - * Created on 10/11/15. - * - * @author Tony Chemit - chemit@codelutin.com - */ -public class ObserveReferentialCacheKey<D extends ReferentialDto> { - - private final Class<D> type; - - private final Optional<String> context; - - public ObserveReferentialCacheKey(Class<D> type, Optional<String> context) { - this.type = type; - this.context = context; - } - - public Class<D> getType() { - return type; - } - - public Optional<String> getContext() { - return context; - } - - public static <D extends ReferentialDto> ObserveReferentialCacheKey<D> of(Class<D> type, String optionalContext) { - return new ObserveReferentialCacheKey<>(type, Optional.fromNullable(optionalContext)); - } -} -- To stop receiving notification emails like this one, please contact codelutin.com SCM administrator <admin+scm@list.forge.codelutin.com>.

This is an automated email from the git hooks/post-receive script. New commit to branch feature/refactor_reference in repository observe. See http://git.codelutin.com/observe.git commit 3cc570b7b0460ce9c31cff551dceedec891b519a Author: Tony CHEMIT <chemit@codelutin.com> Date: Fri Nov 20 09:49:42 2015 +0100 Amélioration des logs + bien transformer les références vers référentiels + prise en compte des champs techniques --- .../fr/ird/observe/services/dto/ReferenceDto.java | 20 +++++++--- .../dto/gson/ObserveReferenceSetAdapter.java | 2 +- .../dto/reference/ObserveReferenceSet.java | 44 +++++++++++++++++++--- .../dto/reference/ObserveReferenceSetRequest.java | 10 +++++ .../dto/reference/ObserveReferenceSetResult.java | 4 +- .../dto/reference/ObserveReferentialReference.java | 34 +++++++++++------ .../definition/ObserveReferenceSetDefinition.java | 19 ++++++++++ .../ObserveReferenceSetRequestKeyDefinition.java | 21 ++++++++--- .../dto/referential/ReferentialReferenceDto.java | 30 ++++++++++----- .../dto/reference/ObserveReferenceSetBuilder.java | 27 +++++++++---- .../services/service/ReferenceSetServiceTopia.java | 23 +++++++---- 11 files changed, 177 insertions(+), 57 deletions(-) diff --git a/observe-services-model/src/main/java/fr/ird/observe/services/dto/ReferenceDto.java b/observe-services-model/src/main/java/fr/ird/observe/services/dto/ReferenceDto.java index 7301ecf..06b9a3e 100644 --- a/observe-services-model/src/main/java/fr/ird/observe/services/dto/ReferenceDto.java +++ b/observe-services-model/src/main/java/fr/ird/observe/services/dto/ReferenceDto.java @@ -31,6 +31,8 @@ import fr.ird.observe.services.dto.longline.SetLonglineDto; import fr.ird.observe.services.dto.referential.I18nReferentialDto; import fr.ird.observe.services.dto.seine.ActivitySeineDto; import fr.ird.observe.services.dto.seine.SetSeineDto; +import org.apache.commons.logging.Log; +import org.apache.commons.logging.LogFactory; import org.nuiton.util.beans.Binder; import org.nuiton.util.beans.BinderFactory; @@ -50,6 +52,9 @@ public class ReferenceDto<D extends IdDto> extends AbstractReferenceDto { private static final long serialVersionUID = 1L; + /** Logger. */ + private static final Log log = LogFactory.getLog(ReferenceDto.class); + protected Class<D> type; protected List<String> labelPropertyNames; @@ -160,12 +165,17 @@ public class ReferenceDto<D extends IdDto> extends AbstractReferenceDto { @Override public String toString() { - return MoreObjects.toStringHelper(this) - .add("type", type.getName()) - .add("id", id) - .add("labelPropertyNames", labelPropertyNames) + MoreObjects.ToStringHelper toStringHelper = MoreObjects.toStringHelper(this) + .add("type", type.getSimpleName()) + .add("id", id); + + if (log.isDebugEnabled()) { + toStringHelper + .add("labelPropertyNames", labelPropertyNames) + .add("labelPropertyTypes", Arrays.toString(labelPropertyTypes)); + } + return toStringHelper .add("labelPropertyValues", Arrays.toString(labelPropertyValues)) - .add("labelPropertyTypes", Arrays.toString(labelPropertyTypes)) .toString(); } } diff --git a/observe-services-model/src/main/java/fr/ird/observe/services/dto/gson/ObserveReferenceSetAdapter.java b/observe-services-model/src/main/java/fr/ird/observe/services/dto/gson/ObserveReferenceSetAdapter.java index 300ae53..c37b255 100644 --- a/observe-services-model/src/main/java/fr/ird/observe/services/dto/gson/ObserveReferenceSetAdapter.java +++ b/observe-services-model/src/main/java/fr/ird/observe/services/dto/gson/ObserveReferenceSetAdapter.java @@ -83,7 +83,7 @@ public class ObserveReferenceSetAdapter implements JsonDeserializer<ObserveRefer result.setVersion((long) context.deserialize(jsonObject.get(ReferentialDto.PROPERTY_VERSION), long.class)); result.setCreateDate((Date) context.deserialize(jsonObject.get(ReferentialDto.PROPERTY_CREATE_DATE), Date.class)); - result.setLastUpdate((Date) context.deserialize(jsonObject.get(ReferentialDto.PROPERTY_LAST_UPDATE), Date.class)); + result.setLastUpdateDate((Date) context.deserialize(jsonObject.get(ReferentialDto.PROPERTY_LAST_UPDATE), Date.class)); result.setEnabled((Boolean) context.deserialize(jsonObject.get(ReferentialDto.PROPERTY_ENABLED), boolean.class)); result.setNeedComment((Boolean) context.deserialize(jsonObject.get(ReferentialDto.PROPERTY_NEED_COMMENT), boolean.class)); diff --git a/observe-services-model/src/main/java/fr/ird/observe/services/dto/reference/ObserveReferenceSet.java b/observe-services-model/src/main/java/fr/ird/observe/services/dto/reference/ObserveReferenceSet.java index 79b98cb..9abd500 100644 --- a/observe-services-model/src/main/java/fr/ird/observe/services/dto/reference/ObserveReferenceSet.java +++ b/observe-services-model/src/main/java/fr/ird/observe/services/dto/reference/ObserveReferenceSet.java @@ -5,6 +5,10 @@ import fr.ird.observe.services.dto.IdDto; import fr.ird.observe.services.dto.ReferenceDto; import fr.ird.observe.services.dto.ReferenceSetDto; import fr.ird.observe.services.dto.reference.definition.ObserveReferenceSetDefinition; +import fr.ird.observe.services.dto.referential.ReferentialDto; +import fr.ird.observe.services.dto.referential.ReferentialReferenceDto; +import org.apache.commons.logging.Log; +import org.apache.commons.logging.LogFactory; import java.io.Serializable; import java.util.Collection; @@ -19,6 +23,9 @@ public class ObserveReferenceSet<D extends IdDto, R extends ObserveReference> im private static final long serialVersionUID = 1L; + /** Logger. */ + private static final Log log = LogFactory.getLog(ObserveReferenceSet.class); + protected ObserveReferenceSetDefinition<D> definition; protected Collection<R> values; @@ -70,22 +77,47 @@ public class ObserveReferenceSet<D extends IdDto, R extends ObserveReference> im result.setLastUpdate(lastUpdate); result.setName(name); + boolean referential = ReferentialDto.class.isAssignableFrom(type); + for (R value : values) { - ReferenceDto<D> referenceDto = new ReferenceDto<>(); - referenceDto.init(type, propertyNames, propertyTypes, value.getValues()); - result.addReference(referenceDto); + if (referential) { + + ObserveReferentialReference referentialValue = (ObserveReferentialReference) value; + ReferentialReferenceDto referenceDto = new ReferentialReferenceDto<>(); + referenceDto.init(type, propertyNames, propertyTypes, value.getValues()); + referenceDto.setId(value.getId()); + referenceDto.setCreateDate(referentialValue.getCreateDate()); + referenceDto.setEnabled(referentialValue.isEnabled()); + referenceDto.setLastUpdate(referentialValue.getLastUpdateDate()); + referenceDto.setNeedComment(referentialValue.isNeedComment()); + referenceDto.setVersion(referentialValue.getVersion()); + result.addReference(referenceDto); + + } else { + + ReferenceDto<D> referenceDto = new ReferenceDto<>(); + referenceDto.setId(value.getId()); + referenceDto.init(type, propertyNames, propertyTypes, value.getValues()); + result.addReference(referenceDto); + + } } return result; } - + @Override public String toString() { - return MoreObjects.toStringHelper(this) - .add("definition", definition) + MoreObjects.ToStringHelper toStringHelper = MoreObjects.toStringHelper(this); + if (log.isDebugEnabled()) { + toStringHelper.add("definition", definition); + } else { + toStringHelper.add("type", definition.getType().getSimpleName()); + } + return toStringHelper .add("values", values == null ? 0 : values.size()) .add("lastUpdate", lastUpdate) .toString(); diff --git a/observe-services-model/src/main/java/fr/ird/observe/services/dto/reference/ObserveReferenceSetRequest.java b/observe-services-model/src/main/java/fr/ird/observe/services/dto/reference/ObserveReferenceSetRequest.java index 25ea7b6..69cbda3 100644 --- a/observe-services-model/src/main/java/fr/ird/observe/services/dto/reference/ObserveReferenceSetRequest.java +++ b/observe-services-model/src/main/java/fr/ird/observe/services/dto/reference/ObserveReferenceSetRequest.java @@ -13,6 +13,8 @@ public class ObserveReferenceSetRequest { private String requestName; + private boolean loadTechnicalInformations; + private ImmutableMap<String, Date> lastUpdateDates; public String getRequestName() { @@ -30,4 +32,12 @@ public class ObserveReferenceSetRequest { public void setLastUpdateDates(ImmutableMap<String, Date> lastUpdateDates) { this.lastUpdateDates = lastUpdateDates; } + + public boolean isLoadTechnicalInformations() { + return loadTechnicalInformations; + } + + public void setLoadTechnicalInformations(boolean loadTechnicalInformations) { + this.loadTechnicalInformations = loadTechnicalInformations; + } } diff --git a/observe-services-model/src/main/java/fr/ird/observe/services/dto/reference/ObserveReferenceSetResult.java b/observe-services-model/src/main/java/fr/ird/observe/services/dto/reference/ObserveReferenceSetResult.java index 2812e03..8eb4bf1 100644 --- a/observe-services-model/src/main/java/fr/ird/observe/services/dto/reference/ObserveReferenceSetResult.java +++ b/observe-services-model/src/main/java/fr/ird/observe/services/dto/reference/ObserveReferenceSetResult.java @@ -56,9 +56,9 @@ public class ObserveReferenceSetResult<R extends ObserveReference> { this.referenceSetsMapBuilder = ImmutableMap.builder(); } - public Builder addKey(String name, ObserveReferenceSet<?, R> referenceSet) { + public Builder addReferenceSet(String name, ObserveReferenceSet<?, R> referenceSet) { if (log.isInfoEnabled()) { - log.info("Add reference set " + name + " : " + referenceSet); + log.info(String.format("Add reference set : %s", referenceSet)); } referenceSetsMapBuilder.put(name, referenceSet); return this; diff --git a/observe-services-model/src/main/java/fr/ird/observe/services/dto/reference/ObserveReferentialReference.java b/observe-services-model/src/main/java/fr/ird/observe/services/dto/reference/ObserveReferentialReference.java index f82dd81..083eccb 100644 --- a/observe-services-model/src/main/java/fr/ird/observe/services/dto/reference/ObserveReferentialReference.java +++ b/observe-services-model/src/main/java/fr/ird/observe/services/dto/reference/ObserveReferentialReference.java @@ -1,6 +1,8 @@ package fr.ird.observe.services.dto.reference; import com.google.common.base.MoreObjects; +import org.apache.commons.logging.Log; +import org.apache.commons.logging.LogFactory; import java.util.Arrays; import java.util.Date; @@ -14,13 +16,16 @@ public class ObserveReferentialReference extends ObserveReference { private static final long serialVersionUID = 1L; + /** Logger. */ + private static final Log log = LogFactory.getLog(ObserveReferentialReference.class); + protected boolean needComment; protected boolean enabled; protected Date createDate; - protected Date lastUpdate; + protected Date lastUpdateDate; protected long version; @@ -40,12 +45,12 @@ public class ObserveReferentialReference extends ObserveReference { this.enabled = enabled; } - public Date getLastUpdate() { - return lastUpdate; + public Date getLastUpdateDate() { + return lastUpdateDate; } - public void setLastUpdate(Date lastUpdate) { - this.lastUpdate = lastUpdate; + public void setLastUpdateDate(Date lastUpdateDate) { + this.lastUpdateDate = lastUpdateDate; } public Date getCreateDate() { @@ -66,13 +71,18 @@ public class ObserveReferentialReference extends ObserveReference { @Override public String toString() { - return MoreObjects.toStringHelper(this) - .add("id", id) - .add("needComment", needComment) - .add("enabled", enabled) - .add("version", version) - .add("createDate", createDate) - .add("lastUpdate", lastUpdate) + MoreObjects.ToStringHelper toStringHelper = MoreObjects.toStringHelper(this) + .add("id", id); + + if (log.isDebugEnabled()) { + toStringHelper + .add("needComment", needComment) + .add("enabled", enabled) + .add("version", version) + .add("createDate", createDate) + .add("lastUpdate", lastUpdateDate); + } + return toStringHelper .add("values", Arrays.asList(values)) .toString(); } diff --git a/observe-services-model/src/main/java/fr/ird/observe/services/dto/reference/definition/ObserveReferenceSetDefinition.java b/observe-services-model/src/main/java/fr/ird/observe/services/dto/reference/definition/ObserveReferenceSetDefinition.java index 3a5f327..b510ab4 100644 --- a/observe-services-model/src/main/java/fr/ird/observe/services/dto/reference/definition/ObserveReferenceSetDefinition.java +++ b/observe-services-model/src/main/java/fr/ird/observe/services/dto/reference/definition/ObserveReferenceSetDefinition.java @@ -1,8 +1,12 @@ package fr.ird.observe.services.dto.reference.definition; +import com.google.common.base.MoreObjects; import fr.ird.observe.services.dto.IdDto; +import org.apache.commons.logging.Log; +import org.apache.commons.logging.LogFactory; import java.io.Serializable; +import java.util.Arrays; import java.util.LinkedList; /** @@ -16,6 +20,9 @@ public class ObserveReferenceSetDefinition<D extends IdDto> implements Serializa private static final long serialVersionUID = 1L; + /** Logger. */ + private static final Log log = LogFactory.getLog(ObserveReferenceSetDefinition.class); + /** * Le type du dto qui doit être transformé en références. * {@link ObserveReferenceSetDefinition#getType()}. @@ -48,6 +55,18 @@ public class ObserveReferenceSetDefinition<D extends IdDto> implements Serializa return propertyNames; } + @Override + public String toString() { + MoreObjects.ToStringHelper toStringHelper = MoreObjects.toStringHelper(this) + .add("type", type.getSimpleName()); + if (log.isDebugEnabled()) { + toStringHelper + .add("propertyNames", Arrays.toString(propertyNames)) + .add("propertyTypes", Arrays.toString(propertyTypes)); + } + return toStringHelper.toString(); + } + public static class Builder<D extends IdDto> { private final Class<D> type; diff --git a/observe-services-model/src/main/java/fr/ird/observe/services/dto/reference/definition/ObserveReferenceSetRequestKeyDefinition.java b/observe-services-model/src/main/java/fr/ird/observe/services/dto/reference/definition/ObserveReferenceSetRequestKeyDefinition.java index b086c7e..5272c90 100644 --- a/observe-services-model/src/main/java/fr/ird/observe/services/dto/reference/definition/ObserveReferenceSetRequestKeyDefinition.java +++ b/observe-services-model/src/main/java/fr/ird/observe/services/dto/reference/definition/ObserveReferenceSetRequestKeyDefinition.java @@ -3,8 +3,11 @@ package fr.ird.observe.services.dto.reference.definition; import com.google.common.base.MoreObjects; import fr.ird.observe.services.dto.IdDto; import fr.ird.observe.services.dto.referential.ReferentialDto; +import org.apache.commons.logging.Log; +import org.apache.commons.logging.LogFactory; import java.io.Serializable; +import java.util.Arrays; import java.util.Objects; /** @@ -16,6 +19,9 @@ public class ObserveReferenceSetRequestKeyDefinition<D extends IdDto> implements private static final long serialVersionUID = 1L; + /** Logger. */ + private static final Log log = LogFactory.getLog(ObserveReferenceSetRequestKeyDefinition.class); + private final Class<? extends IdDto> parentType; private final ObserveReferenceSetDefinition<D> referenceSetDefinition; @@ -66,12 +72,15 @@ public class ObserveReferenceSetRequestKeyDefinition<D extends IdDto> implements @Override public String toString() { - return MoreObjects.toStringHelper(this) - .add("parentType", parentType) + MoreObjects.ToStringHelper toStringHelper = MoreObjects.toStringHelper(this) + .add("parentType", parentType.getSimpleName()) .add("name", name) - .add("type", referenceSetDefinition.getType()) - .add("propertyNames", referenceSetDefinition.getPropertyNames()) - .add("propertyTypes", referenceSetDefinition.getPropertyTypes()) - .toString(); + .add("type", referenceSetDefinition.getType().getSimpleName()); + if (log.isDebugEnabled()) { + toStringHelper + .add("propertyNames", Arrays.toString(referenceSetDefinition.getPropertyNames())) + .add("propertyTypes", Arrays.toString(referenceSetDefinition.getPropertyTypes())); + } + return toStringHelper.toString(); } } diff --git a/observe-services-model/src/main/java/fr/ird/observe/services/dto/referential/ReferentialReferenceDto.java b/observe-services-model/src/main/java/fr/ird/observe/services/dto/referential/ReferentialReferenceDto.java index b594ae4..626d4bd 100644 --- a/observe-services-model/src/main/java/fr/ird/observe/services/dto/referential/ReferentialReferenceDto.java +++ b/observe-services-model/src/main/java/fr/ird/observe/services/dto/referential/ReferentialReferenceDto.java @@ -27,6 +27,8 @@ import com.google.common.base.Preconditions; import com.google.common.collect.ImmutableList; import com.google.common.collect.ImmutableSet; import fr.ird.observe.services.dto.constants.ReferentialLocale; +import org.apache.commons.logging.Log; +import org.apache.commons.logging.LogFactory; import java.io.Serializable; import java.util.Arrays; @@ -35,6 +37,9 @@ public class ReferentialReferenceDto<D extends ReferentialDto> extends AbstractR private static final long serialVersionUID = 1L; + /** Logger. */ + private static final Log log = LogFactory.getLog(ReferentialReferenceDto.class); + public static final String PROPERTY_LABEL = "label"; public static final ImmutableSet<String> I18N_PROPERTY_NAMES = ImmutableSet.of( @@ -94,17 +99,22 @@ public class ReferentialReferenceDto<D extends ReferentialDto> extends AbstractR @Override public String toString() { - return MoreObjects.toStringHelper(this) - .add("type", type.getName()) - .add("id", id) - .add("enabled", enabled) - .add("needComment", needComment) - .add("createDate", createDate) - .add("lastUpdate", lastUpdate) - .add("version", version) - .add("labelPropertyNames", labelPropertyNames) + MoreObjects.ToStringHelper toStringHelper = MoreObjects.toStringHelper(this) + .add("type", type.getSimpleName()) + .add("id", id); + + if (log.isDebugEnabled()) { + toStringHelper + .add("enabled", enabled) + .add("needComment", needComment) + .add("createDate", createDate) + .add("lastUpdate", lastUpdate) + .add("version", version) + .add("labelPropertyNames", labelPropertyNames) + .add("labelPropertyTypes", Arrays.toString(labelPropertyTypes)); + } + return toStringHelper .add("labelPropertyValues", Arrays.toString(labelPropertyValues)) - .add("labelPropertyTypes", Arrays.toString(labelPropertyTypes)) .toString(); } } diff --git a/observe-services-topia/src/main/java/fr/ird/observe/services/dto/reference/ObserveReferenceSetBuilder.java b/observe-services-topia/src/main/java/fr/ird/observe/services/dto/reference/ObserveReferenceSetBuilder.java index bda5a57..3845e25 100644 --- a/observe-services-topia/src/main/java/fr/ird/observe/services/dto/reference/ObserveReferenceSetBuilder.java +++ b/observe-services-topia/src/main/java/fr/ird/observe/services/dto/reference/ObserveReferenceSetBuilder.java @@ -49,9 +49,14 @@ public class ObserveReferenceSetBuilder<D extends IdDto, R extends ObserveRefere private Date lastUpdateDate; + private boolean loadTechnicalInformations; + public static <D extends IdDto, R extends ObserveReference> ObserveReferenceSetBuilder<D, R> of( - ReferentialLocale referentialLocale, ObserveReferenceSetDefinition<D> definition, Class<TopiaEntity> entityType) { + ReferentialLocale referentialLocale, + ObserveReferenceSetDefinition<D> definition, + Class<TopiaEntity> entityType, + boolean loadTechnicalInformations) { ObserveReferenceSetBuilder<D, R> referenceDtoBuilder = new ObserveReferenceSetBuilder<>(); @@ -59,6 +64,7 @@ public class ObserveReferenceSetBuilder<D extends IdDto, R extends ObserveRefere referenceDtoBuilder.referentialLocaleOrdinal = referentialLocale.ordinal(); referenceDtoBuilder.binder = BinderFactory.newBinder(entityType); referenceDtoBuilder.propertyNames = definition.getPropertyNames(); + referenceDtoBuilder.loadTechnicalInformations = loadTechnicalInformations; List<String> entityPropertyNames = new ArrayList<>(); @@ -130,14 +136,21 @@ public class ObserveReferenceSetBuilder<D extends IdDto, R extends ObserveRefere result.setValues(propertyValues); result.setId(entity.getTopiaId()); - result.setVersion(entity.getTopiaVersion()); - result.setCreateDate(entity.getTopiaCreateDate()); + ReferenceEntity referenceEntity = (ReferenceEntity) entity; - result.setEnabled(referenceEntity.isEnabled()); - result.setNeedComment(referenceEntity.isNeedComment()); - result.setLastUpdate(referenceEntity.getLastUpdate()); - result.setEnabled(fr.ird.observe.entities.constants.ReferenceStatus.enabled == referenceEntity.getStatus()); + + if (loadTechnicalInformations) { + + result.setVersion(entity.getTopiaVersion()); + result.setCreateDate(entity.getTopiaCreateDate()); + result.setEnabled(referenceEntity.isEnabled()); + result.setNeedComment(referenceEntity.isNeedComment()); + result.setLastUpdateDate(referenceEntity.getLastUpdate()); + result.setEnabled(fr.ird.observe.entities.constants.ReferenceStatus.enabled == referenceEntity.getStatus()); + + } + references.add((R) result); diff --git a/observe-services-topia/src/main/java/fr/ird/observe/services/service/ReferenceSetServiceTopia.java b/observe-services-topia/src/main/java/fr/ird/observe/services/service/ReferenceSetServiceTopia.java index a017b15..509b086 100644 --- a/observe-services-topia/src/main/java/fr/ird/observe/services/service/ReferenceSetServiceTopia.java +++ b/observe-services-topia/src/main/java/fr/ird/observe/services/service/ReferenceSetServiceTopia.java @@ -34,6 +34,8 @@ public class ReferenceSetServiceTopia extends ObserveServiceTopia implements Ref String requestName = request.getRequestName(); ObserveReferenceSetRequestDefinition requestDefinition = ObserveReferenceSetRequestDefinitions.get(requestName); + boolean loadTechnicalInformations = request.isLoadTechnicalInformations(); + ObserveReferenceSetResult.Builder<ObserveReference> resultBuilder = ObserveReferenceSetResult.builder(requestName); for (ObserveReferenceSetRequestKeyDefinition definition : requestDefinition.getKeys()) { @@ -41,10 +43,10 @@ public class ReferenceSetServiceTopia extends ObserveServiceTopia implements Ref boolean referential = definition.isReferential(); Preconditions.checkArgument(!referential, "Can't obtain referenceSet of referential here, but try with " + definition); - ObserveReferenceSet<IdDto, ObserveReference> referenceSet = loadDataReferenceSet(definition); + ObserveReferenceSet<IdDto, ObserveReference> referenceSet = loadDataReferenceSet(definition, loadTechnicalInformations); String name = definition.getName(); - resultBuilder.addKey(name, referenceSet); + resultBuilder.addReferenceSet(name, referenceSet); } @@ -59,6 +61,8 @@ public class ReferenceSetServiceTopia extends ObserveServiceTopia implements Ref ObserveReferenceSetRequestDefinition requestDefinition = ObserveReferenceSetRequestDefinitions.get(requestName); + boolean loadTechnicalInformations = request.isLoadTechnicalInformations(); + ObserveReferenceSetResult.Builder<ObserveReferentialReference> resultBuilder = ObserveReferenceSetResult.builder(requestName); ImmutableMap<String, Date> lastUpdateDates = request.getLastUpdateDates(); Preconditions.checkNotNull(lastUpdateDates); @@ -71,9 +75,9 @@ public class ReferenceSetServiceTopia extends ObserveServiceTopia implements Ref String name = definition.getName(); Date lastUpdateDate = lastUpdateDates.get(name); - ObserveReferenceSet<ReferentialDto, ObserveReferentialReference> referenceSet = loadReferentialReferenceSet(definition, lastUpdateDate); + ObserveReferenceSet<ReferentialDto, ObserveReferentialReference> referenceSet = loadReferentialReferenceSet(definition, lastUpdateDate, loadTechnicalInformations); if (referenceSet != null) { - resultBuilder.addKey(name, referenceSet); + resultBuilder.addReferenceSet(name, referenceSet); } } @@ -82,11 +86,11 @@ public class ReferenceSetServiceTopia extends ObserveServiceTopia implements Ref } - protected <D extends IdDto> ObserveReferenceSet<D, ObserveReference> loadDataReferenceSet(ObserveReferenceSetRequestKeyDefinition<D> requestKeyDefinition) { + protected <D extends IdDto> ObserveReferenceSet<D, ObserveReference> loadDataReferenceSet(ObserveReferenceSetRequestKeyDefinition<D> requestKeyDefinition, boolean loadTechnicalInformations) { Class<TopiaEntity> entityType = getEntityType(requestKeyDefinition.getType()); - ObserveReferenceSetBuilder<D, ObserveReference> referenceBuilder = ObserveReferenceSetBuilder.of(serviceContext.getReferentialLocale(), requestKeyDefinition.getDefinition(), entityType); + ObserveReferenceSetBuilder<D, ObserveReference> referenceBuilder = ObserveReferenceSetBuilder.of(serviceContext.getReferentialLocale(), requestKeyDefinition.getDefinition(), entityType, loadTechnicalInformations); Iterable<TopiaEntity> entities = getEntities(requestKeyDefinition, Collections.<String, Object>emptyMap()); @@ -101,7 +105,7 @@ public class ReferenceSetServiceTopia extends ObserveServiceTopia implements Ref } - protected <D extends ReferentialDto> ObserveReferenceSet<D, ObserveReferentialReference> loadReferentialReferenceSet(ObserveReferenceSetRequestKeyDefinition<D> requestKeyDefinition, Date lastUpdateDate) { + protected <D extends ReferentialDto> ObserveReferenceSet<D, ObserveReferentialReference> loadReferentialReferenceSet(ObserveReferenceSetRequestKeyDefinition<D> requestKeyDefinition, Date lastUpdateDate, boolean loadTechnicalInformations) { Class<TopiaEntity> entityType = getEntityType(requestKeyDefinition.getType()); @@ -110,7 +114,10 @@ public class ReferenceSetServiceTopia extends ObserveServiceTopia implements Ref ObserveReferenceSet<D, ObserveReferentialReference> referenceSet; if (lastUpdateOptional.isPresent() && (lastUpdateDate == null || lastUpdateOptional.get().after(lastUpdateDate))) { - ObserveReferenceSetBuilder<D, ObserveReferentialReference> referenceBuilder = ObserveReferenceSetBuilder.of(serviceContext.getReferentialLocale(), requestKeyDefinition.getDefinition(), entityType); + ObserveReferenceSetBuilder<D, ObserveReferentialReference> referenceBuilder = ObserveReferenceSetBuilder.of(serviceContext.getReferentialLocale(), + requestKeyDefinition.getDefinition(), + entityType, + loadTechnicalInformations); referenceBuilder.setLastUpdateDate(lastUpdateOptional.get()); -- To stop receiving notification emails like this one, please contact codelutin.com SCM administrator <admin+scm@list.forge.codelutin.com>.

This is an automated email from the git hooks/post-receive script. New commit to branch feature/refactor_reference in repository observe. See http://git.codelutin.com/observe.git commit 35a01690414806ad7e29e91d376cb48fc1cbaa01 Author: Tony CHEMIT <chemit@codelutin.com> Date: Fri Nov 20 10:16:28 2015 +0100 Fix some tests --- .../service/seine/TripSeineServiceRestTest.java | 46 ++-------------------- .../services/service/AbstractServiceTopiaTest.java | 12 +++++- .../fr/ird/observe/services/service/RigthTest.java | 4 +- ...tLonglineDetailCompositionServiceTopiaTest.java | 18 ++++----- .../seine/TargetSampleServiceTopiaTest.java | 3 +- .../seine/TripSeineGearUseServiceTopiaTest.java | 6 +-- 6 files changed, 29 insertions(+), 60 deletions(-) diff --git a/observe-services-rest/src/test/java/fr/ird/observe/services/service/seine/TripSeineServiceRestTest.java b/observe-services-rest/src/test/java/fr/ird/observe/services/service/seine/TripSeineServiceRestTest.java index a986048..9f17864 100644 --- a/observe-services-rest/src/test/java/fr/ird/observe/services/service/seine/TripSeineServiceRestTest.java +++ b/observe-services-rest/src/test/java/fr/ird/observe/services/service/seine/TripSeineServiceRestTest.java @@ -95,47 +95,9 @@ public class TripSeineServiceRestTest extends AbstractServiceRestTest { } @Test - public void loadToReadTest() throws Exception { + public void loadFormTest() throws Exception { - FormDto<TripSeineDto> formDto = service.loadToRead(TRIP_SEINE_ID_1); - - Assert.assertNotNull(formDto); - TripSeineDto tripSeineDto = formDto.getForm(); - - Assert.assertNull(tripSeineDto.getCaptain()); - - Assert.assertEquals("fr.ird.observe.entities.referentiel.Person#1355399844272#0.32586441962131485", tripSeineDto.getObserver().getId()); - Assert.assertEquals("Fanchon", tripSeineDto.getObserver().getPropertyValue(PersonDto.PROPERTY_FIRST_NAME)); - Assert.assertEquals("Varenne", tripSeineDto.getObserver().getPropertyValue(PersonDto.PROPERTY_LAST_NAME)); - Assert.assertNull(tripSeineDto.getDataEntryOperator()); - Assert.assertEquals("fr.ird.observe.entities.referentiel.Vessel#1306847717532#0.7435948873477364", tripSeineDto.getVessel().getId()); - Assert.assertEquals("835", tripSeineDto.getVessel().getPropertyValue(VesselDto.PROPERTY_CODE)); - Assert.assertEquals("BERNICA", tripSeineDto.getVessel().getPropertyValue("label")); - Assert.assertEquals("fr.ird.observe.entities.referentiel.Ocean#1239832686152#0.8325731048817705", tripSeineDto.getOcean().getId()); - Assert.assertEquals("2", tripSeineDto.getOcean().getPropertyValue(OceanDto.PROPERTY_CODE)); - Assert.assertEquals("Indien", tripSeineDto.getOcean().getPropertyValue("label")); - Assert.assertNull(tripSeineDto.getDepartureHarbour()); - Assert.assertNull(tripSeineDto.getLandingHarbour()); - Assert.assertNull(tripSeineDto.getErsId()); - Assert.assertEquals(DateUtil.createDate(25, 1, 2013), tripSeineDto.getStartDate()); - Assert.assertEquals(DateUtil.createDate(27, 2, 2013), tripSeineDto.getEndDate()); - Assert.assertNull(tripSeineDto.getFormsUrl()); - Assert.assertNull(tripSeineDto.getReportsUrl()); - Assert.assertTrue(tripSeineDto.getComment().startsWith("Caractéristiques de la senne")); - - assertReadLabels(formDto, 8, - ProgramDto.class, - PersonDto.class, - VesselDto.class, - OceanDto.class, - HarbourDto.class); - - } - - @Test - public void loadToEditTest() throws Exception { - - FormDto<TripSeineDto> formDto = service.loadToEdit(TRIP_SEINE_ID_1); + FormDto<TripSeineDto> formDto = service.loadForm(TRIP_SEINE_ID_1); Assert.assertNotNull(formDto); TripSeineDto tripSeineDto = formDto.getForm(); @@ -205,7 +167,7 @@ public class TripSeineServiceRestTest extends AbstractServiceRestTest { @Test public void saveUpdateTest() { - FormDto<TripSeineDto> formDto = service.loadToEdit(TRIP_SEINE_ID_1); + FormDto<TripSeineDto> formDto = service.loadForm(TRIP_SEINE_ID_1); TripSeineDto tripSeineDto = formDto.getForm(); @@ -233,7 +195,7 @@ public class TripSeineServiceRestTest extends AbstractServiceRestTest { service.save(formDto.getForm()); - FormDto<TripSeineDto> formDtoReload = service.loadToRead(TRIP_SEINE_ID_1); + FormDto<TripSeineDto> formDtoReload = service.loadForm(TRIP_SEINE_ID_1); TripSeineDto tripSeineDtoReload = formDtoReload.getForm(); Assert.assertEquals(tripSeineDto.getCaptain().getId(), tripSeineDtoReload.getCaptain().getId()); diff --git a/observe-services-topia/src/test/java/fr/ird/observe/services/service/AbstractServiceTopiaTest.java b/observe-services-topia/src/test/java/fr/ird/observe/services/service/AbstractServiceTopiaTest.java index 56b9d85..a7b6ecf 100644 --- a/observe-services-topia/src/test/java/fr/ird/observe/services/service/AbstractServiceTopiaTest.java +++ b/observe-services-topia/src/test/java/fr/ird/observe/services/service/AbstractServiceTopiaTest.java @@ -32,7 +32,10 @@ import fr.ird.observe.services.ObserveDataSourceConnectionTopiaTaiste; import fr.ird.observe.services.ObserveService; import fr.ird.observe.services.configuration.ObserveDataSourceConfigurationTopiaH2; import fr.ird.observe.services.configuration.ObserveDataSourceConnection; +import fr.ird.observe.services.dto.FormDto; import fr.ird.observe.services.dto.ReferenceDto; +import fr.ird.observe.services.dto.referential.ReferentialDto; +import fr.ird.observe.services.dto.referential.ReferentialReferenceDto; import org.apache.commons.logging.Log; import org.apache.commons.logging.LogFactory; import org.junit.Assert; @@ -154,7 +157,12 @@ public abstract class AbstractServiceTopiaTest { } - public ObserveReferentialCache getReferentialCache() { - return dataSourceResource.getReferentialCache(); + protected void loadReferenceSets(ReferenceSetService referenceSetService, FormDto<?> formDto) { + dataSourceResource.getReferentialCache().loadReferenceSets(referenceSetService, formDto); } + + protected <R extends ReferentialDto> ReferentialReferenceDto<R> getReference(FormDto<?> formDto, Class<R> type, String propertyName, int index) { + return (ReferentialReferenceDto<R>) formDto.getReferenceSetDto(type, propertyName).getReference(index); + } + } diff --git a/observe-services-topia/src/test/java/fr/ird/observe/services/service/RigthTest.java b/observe-services-topia/src/test/java/fr/ird/observe/services/service/RigthTest.java index 065ac30..cb707bc 100644 --- a/observe-services-topia/src/test/java/fr/ird/observe/services/service/RigthTest.java +++ b/observe-services-topia/src/test/java/fr/ird/observe/services/service/RigthTest.java @@ -147,7 +147,7 @@ public class RigthTest { TripSeineService service = newService(dataSourceConnection, TripSeineService.class); - service.loadToRead(TRIP_SEINE_ID); + service.loadForm(TRIP_SEINE_ID); } protected void testWriteData(String login) throws DatabaseConnexionNotAuthorizedException, DatabaseNotFoundException, BabModelVersionException { @@ -156,7 +156,7 @@ public class RigthTest { TripSeineService service = newService(dataSourceConnection, TripSeineService.class); - FormDto<TripSeineDto> tripSeineDtoFormDto = service.loadToEdit(TRIP_SEINE_ID); + FormDto<TripSeineDto> tripSeineDtoFormDto = service.loadForm(TRIP_SEINE_ID); service.save(tripSeineDtoFormDto.getForm()); } diff --git a/observe-services-topia/src/test/java/fr/ird/observe/services/service/longline/SetLonglineDetailCompositionServiceTopiaTest.java b/observe-services-topia/src/test/java/fr/ird/observe/services/service/longline/SetLonglineDetailCompositionServiceTopiaTest.java index 28a4fbc..30ca7a9 100644 --- a/observe-services-topia/src/test/java/fr/ird/observe/services/service/longline/SetLonglineDetailCompositionServiceTopiaTest.java +++ b/observe-services-topia/src/test/java/fr/ird/observe/services/service/longline/SetLonglineDetailCompositionServiceTopiaTest.java @@ -118,36 +118,36 @@ public class SetLonglineDetailCompositionServiceTopiaTest extends AbstractServic branchlineDto.setBranchlineLength(1.2f); branchlineDto.setTracelineLength(2.8f); - ReferentialReferenceDto<LineTypeDto> topType = formDto.getReferentialReferenceById(LineTypeDto.class, "fr.ird.observe.entities.referentiel.longline.LineType#1239832686157#0.1"); + ReferentialReferenceDto<LineTypeDto> topType = formDto.getReferentialReferenceById(LineTypeDto.class, BranchlineDto.PROPERTY_TOP_TYPE, "fr.ird.observe.entities.referentiel.longline.LineType#1239832686157#0.1"); branchlineDto.setTopType(topType); - ReferentialReferenceDto<LineTypeDto> tracelineType = formDto.getReferentialReferenceById(LineTypeDto.class, "fr.ird.observe.entities.referentiel.longline.LineType#1239832686157#0.3"); + ReferentialReferenceDto<LineTypeDto> tracelineType = formDto.getReferentialReferenceById(LineTypeDto.class, BranchlineDto.PROPERTY_TRACELINE_TYPE, "fr.ird.observe.entities.referentiel.longline.LineType#1239832686157#0.3"); branchlineDto.setTracelineType(tracelineType); branchlineDto.setDepthRecorder(true); branchlineDto.setHookLost(false); branchlineDto.setTraceCutOff(false); branchlineDto.setTimer(true); - branchlineDto.setTimeSinceContact(25478l); + branchlineDto.setTimeSinceContact(25478L); branchlineDto.setTimerTimeOnBoard(DateUtil.createDate(14, 57, 10, 2, 8, 2009)); branchlineDto.setWeightedSnap(true); branchlineDto.setSnapWeight(0.8f); branchlineDto.setWeightedSwivel(true); branchlineDto.setSwivelWeight(0.45f); - ReferentialReferenceDto<HookTypeDto> hookType = formDto.getReferentialReferenceById(HookTypeDto.class, "fr.ird.observe.entities.referentiel.longline.HookType#1239832686152#0.2"); + ReferentialReferenceDto<HookTypeDto> hookType = formDto.getReferentialReferenceById(HookTypeDto.class, BranchlineDto.PROPERTY_HOOK_TYPE, "fr.ird.observe.entities.referentiel.longline.HookType#1239832686152#0.2"); branchlineDto.setHookType(hookType); - ReferentialReferenceDto<HookSizeDto> hookSize = formDto.getReferentialReferenceById(HookSizeDto.class, "fr.ird.observe.entities.referentiel.longline.HookSize#1239832686151#0.6"); + ReferentialReferenceDto<HookSizeDto> hookSize = formDto.getReferentialReferenceById(HookSizeDto.class, BranchlineDto.PROPERTY_HOOK_SIZE, "fr.ird.observe.entities.referentiel.longline.HookSize#1239832686151#0.6"); branchlineDto.setHookSize(hookSize); branchlineDto.setHookOffset(24); - ReferentialReferenceDto<BaitTypeDto> baitType = formDto.getReferentialReferenceById(BaitTypeDto.class, "fr.ird.observe.entities.referentiel.longline.BaitType#1239832686124#0.8"); + ReferentialReferenceDto<BaitTypeDto> baitType = formDto.getReferentialReferenceById(BaitTypeDto.class, BranchlineDto.PROPERTY_BAIT_TYPE, "fr.ird.observe.entities.referentiel.longline.BaitType#1239832686124#0.8"); branchlineDto.setBaitType(baitType); - ReferentialReferenceDto<BaitSettingStatusDto> baitSettingStatus = formDto.getReferentialReferenceById(BaitSettingStatusDto.class, "fr.ird.observe.entities.referentiel.longline.BaitSettingStatus#1239832686123#0.1"); + ReferentialReferenceDto<BaitSettingStatusDto> baitSettingStatus = formDto.getReferentialReferenceById(BaitSettingStatusDto.class, BranchlineDto.PROPERTY_BAIT_SETTING_STATUS, "fr.ird.observe.entities.referentiel.longline.BaitSettingStatus#1239832686123#0.1"); branchlineDto.setBaitSettingStatus(baitSettingStatus); - ReferentialReferenceDto<BaitHaulingStatusDto> baitHaulingStatus = formDto.getReferentialReferenceById(BaitHaulingStatusDto.class, "fr.ird.observe.entities.referentiel.longline.BaitHaulingStatus#1239832686122#0.4"); + ReferentialReferenceDto<BaitHaulingStatusDto> baitHaulingStatus = formDto.getReferentialReferenceById(BaitHaulingStatusDto.class, BranchlineDto.PROPERTY_BAIT_HAULING_STATUS, "fr.ird.observe.entities.referentiel.longline.BaitHaulingStatus#1239832686122#0.4"); branchlineDto.setBaitHaulingStatus(baitHaulingStatus); service.save(compositionDto); - SetLongline setLongline = dataSourceResource.findById(SetLongline.class, SET_LONGLINE_ID); + SetLongline setLongline = dataSourceResource.findById(SetLongline.class, SET_LONGLINE_ID); Section section = setLongline.getSectionByTopiaId(sectionDto.getId()); Assert.assertEquals(sectionDto.getSettingIdentifier(), section.getSettingIdentifier()); diff --git a/observe-services-topia/src/test/java/fr/ird/observe/services/service/seine/TargetSampleServiceTopiaTest.java b/observe-services-topia/src/test/java/fr/ird/observe/services/service/seine/TargetSampleServiceTopiaTest.java index 41625de..09f3bd7 100644 --- a/observe-services-topia/src/test/java/fr/ird/observe/services/service/seine/TargetSampleServiceTopiaTest.java +++ b/observe-services-topia/src/test/java/fr/ird/observe/services/service/seine/TargetSampleServiceTopiaTest.java @@ -27,6 +27,7 @@ import fr.ird.observe.services.dto.FormDto; import fr.ird.observe.services.dto.ReferenceDto; import fr.ird.observe.services.dto.ReferenceSetDto; import fr.ird.observe.services.dto.referential.SpeciesDto; +import fr.ird.observe.services.dto.seine.TargetLengthDto; import fr.ird.observe.services.dto.seine.TargetSampleDto; import fr.ird.observe.services.service.AbstractServiceTopiaTest; import org.junit.Assert; @@ -82,7 +83,7 @@ public class TargetSampleServiceTopiaTest extends AbstractServiceTopiaTest { Assert.assertFalse(targetSampleDto.getDiscarded()); Assert.assertTrue(targetSampleDto.isTargetLengthEmpty()); - ReferenceSetDto<SpeciesDto> speciesDtoReferenceSetDto = formDto.getReferenceSetDto(SpeciesDto.class); + ReferenceSetDto<SpeciesDto> speciesDtoReferenceSetDto = formDto.getReferenceSetDto(SpeciesDto.class, TargetLengthDto.PROPERTY_SPECIES); Assert.assertEquals(1, speciesDtoReferenceSetDto.sizeReference()); ReferenceDto referenceDto = speciesDtoReferenceSetDto.getReference(0); Assert.assertEquals("fr.ird.observe.entities.referentiel.Species#1239832685474#0.8943253454598569", referenceDto.getId()); diff --git a/observe-services-topia/src/test/java/fr/ird/observe/services/service/seine/TripSeineGearUseServiceTopiaTest.java b/observe-services-topia/src/test/java/fr/ird/observe/services/service/seine/TripSeineGearUseServiceTopiaTest.java index 4fbbeae..640c879 100644 --- a/observe-services-topia/src/test/java/fr/ird/observe/services/service/seine/TripSeineGearUseServiceTopiaTest.java +++ b/observe-services-topia/src/test/java/fr/ird/observe/services/service/seine/TripSeineGearUseServiceTopiaTest.java @@ -22,7 +22,6 @@ package fr.ird.observe.services.service.seine; * #L% */ -import com.google.common.collect.Collections2; import com.google.common.collect.ImmutableSet; import com.google.common.collect.Iterables; import fr.ird.observe.entities.seine.GearUseFeaturesMeasurementSeine; @@ -43,7 +42,6 @@ import org.junit.Assert; import org.junit.Test; import org.nuiton.topia.persistence.TopiaEntities; -import java.util.Collection; import java.util.Set; /** @@ -116,7 +114,7 @@ public class TripSeineGearUseServiceTopiaTest extends AbstractServiceTopiaTest { Assert.assertNotNull(formDto.getLabels()); - Collection<Class> types = Collections2.transform(formDto.getLabels(), ReferenceSetDtos.getTypeFunction()); + Set<Class<?>> types = ReferenceSetDtos.getTypes(formDto.getLabels()); Assert.assertTrue(types.contains(GearDto.class)); Assert.assertTrue(types.contains(GearCaracteristicDto.class)); Assert.assertEquals(2, formDto.sizeLabels()); @@ -163,7 +161,7 @@ public class TripSeineGearUseServiceTopiaTest extends AbstractServiceTopiaTest { Assert.assertNotNull(formDto.getLabels()); - Collection<Class> types = Collections2.transform(formDto.getLabels(), ReferenceSetDtos.getTypeFunction()); + Set<Class<?>> types = ReferenceSetDtos.getTypes(formDto.getLabels()); Assert.assertTrue(types.contains(GearDto.class)); Assert.assertTrue(types.contains(GearCaracteristicDto.class)); Assert.assertEquals(2, formDto.sizeLabels()); -- To stop receiving notification emails like this one, please contact codelutin.com SCM administrator <admin+scm@list.forge.codelutin.com>.

This is an automated email from the git hooks/post-receive script. New commit to branch feature/refactor_reference in repository observe. See http://git.codelutin.com/observe.git commit 852ad86b06ff60d326ee6d7330f3da0ab3ab8a11 Author: Tony CHEMIT <chemit@codelutin.com> Date: Fri Nov 20 10:17:00 2015 +0100 Fix api --- .../java/fr/ird/observe/ui/content/list/impl/seine/RoutesUIHandler.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/list/impl/seine/RoutesUIHandler.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/list/impl/seine/RoutesUIHandler.java index 9f591c6..0392ab5 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/list/impl/seine/RoutesUIHandler.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/list/impl/seine/RoutesUIHandler.java @@ -125,7 +125,7 @@ public class RoutesUIHandler extends ContentListUIHandler<TripSeineDto, RouteDto @Override protected void loadParentBean() { TripSeineService service = ObserveSwingApplicationContext.get().newService(TripSeineService.class); - FormDto<TripSeineDto> tripSeineDtoFormDto = service.loadToEdit(getSelectedParentId()); + FormDto<TripSeineDto> tripSeineDtoFormDto = service.loadForm(getSelectedParentId()); getModel().setFormDto(tripSeineDtoFormDto); TripSeineDtos.copyTripSeineDto(tripSeineDtoFormDto.getForm(), getBean()); } -- To stop receiving notification emails like this one, please contact codelutin.com SCM administrator <admin+scm@list.forge.codelutin.com>.