This is an automated email from the git hooks/post-receive script. New commit to branch develop in repository faxtomail. See https://gitlab.nuiton.org/codelutin/faxtomail.git commit a602e920c0bc9c200a3b95a730c754acdccf7a3a Author: jcouteau <couteau@codelutin.com> Date: Wed Sep 26 10:56:36 2018 +0200 Sonar - Remove "Dead store to local variable" --- .../faxtomail/services/service/ConfigurationServiceImpl.java | 4 ++-- .../com/franciaflex/faxtomail/services/service/EmailServiceImpl.java | 2 +- .../faxtomail/services/service/InitFaxToMailServiceImpl.java | 5 +++-- .../com/franciaflex/faxtomail/services/service/LdapServiceImpl.java | 3 --- .../swing/content/demande/demandgroup/DemandGroupCellRenderer.java | 2 -- .../faxtomail/ui/swing/content/reply/ReplyFormUIHandler.java | 2 +- 6 files changed, 7 insertions(+), 11 deletions(-) diff --git a/faxtomail-service/src/main/java/com/franciaflex/faxtomail/services/service/ConfigurationServiceImpl.java b/faxtomail-service/src/main/java/com/franciaflex/faxtomail/services/service/ConfigurationServiceImpl.java index 09d9bfb9..af8fb883 100644 --- a/faxtomail-service/src/main/java/com/franciaflex/faxtomail/services/service/ConfigurationServiceImpl.java +++ b/faxtomail-service/src/main/java/com/franciaflex/faxtomail/services/service/ConfigurationServiceImpl.java @@ -135,9 +135,9 @@ public class ConfigurationServiceImpl extends FaxToMailServiceSupport implements protected void saveConfiguration(Configuration config) { ConfigurationTopiaDao dao = getPersistenceContext().getConfigurationDao(); if (config.isPersisted()) { - config = dao.update(config); + dao.update(config); } else { - config = dao.create(config); + dao.create(config); } } diff --git a/faxtomail-service/src/main/java/com/franciaflex/faxtomail/services/service/EmailServiceImpl.java b/faxtomail-service/src/main/java/com/franciaflex/faxtomail/services/service/EmailServiceImpl.java index 933fc964..4385b3be 100644 --- a/faxtomail-service/src/main/java/com/franciaflex/faxtomail/services/service/EmailServiceImpl.java +++ b/faxtomail-service/src/main/java/com/franciaflex/faxtomail/services/service/EmailServiceImpl.java @@ -981,7 +981,7 @@ public class EmailServiceImpl extends FaxToMailServiceSupport implements EmailSe mailLock = new MailLockImpl(); mailLock.setLockBy(currentUser); mailLock.setLockOn(email); - mailLock = mailLockDao.create(mailLock); + mailLockDao.create(mailLock); if (log.isDebugEnabled()) { log.debug("[LOCK] " + emailId + " locked by " + currentUser.getLogin()); diff --git a/faxtomail-service/src/main/java/com/franciaflex/faxtomail/services/service/InitFaxToMailServiceImpl.java b/faxtomail-service/src/main/java/com/franciaflex/faxtomail/services/service/InitFaxToMailServiceImpl.java index 458a7828..5f890588 100644 --- a/faxtomail-service/src/main/java/com/franciaflex/faxtomail/services/service/InitFaxToMailServiceImpl.java +++ b/faxtomail-service/src/main/java/com/franciaflex/faxtomail/services/service/InitFaxToMailServiceImpl.java @@ -198,8 +198,9 @@ public class InitFaxToMailServiceImpl extends FaxToMailServiceSupport implements MailFolder.PROPERTY_COMPANY, "FX", MailFolder.PROPERTY_USE_CURRENT_LEVEL_REJECT_RESPONSE_MAIL_ADDRESS, true, MailFolder.PROPERTY_USE_CURRENT_LEVEL_REJECT_RESPONSE_MESSAGE, true); - MailFolder faber = folderDao.create(MailFolder.PROPERTY_NAME, "Faber"); - MailFolder franceFermeture = folderDao.create(MailFolder.PROPERTY_NAME, "France Fermetures", + //folders never used + folderDao.create(MailFolder.PROPERTY_NAME, "Faber"); + folderDao.create(MailFolder.PROPERTY_NAME, "France Fermetures", MailFolder.PROPERTY_USE_CURRENT_LEVEL_COMPANY, true, MailFolder.PROPERTY_COMPANY, "FF"); diff --git a/faxtomail-service/src/main/java/com/franciaflex/faxtomail/services/service/LdapServiceImpl.java b/faxtomail-service/src/main/java/com/franciaflex/faxtomail/services/service/LdapServiceImpl.java index f3046486..d4bd3c2b 100644 --- a/faxtomail-service/src/main/java/com/franciaflex/faxtomail/services/service/LdapServiceImpl.java +++ b/faxtomail-service/src/main/java/com/franciaflex/faxtomail/services/service/LdapServiceImpl.java @@ -404,9 +404,6 @@ public class LdapServiceImpl extends FaxToMailServiceSupport implements LdapServ getApplicationConfig().getLdapPassword()); if (connection.isConnected()) { - FaxToMailUserTopiaDao faxtomailUserDao = getPersistenceContext().getFaxToMailUserDao(); - FaxToMailUserGroupTopiaDao faxtomailUserGroupDao = getPersistenceContext().getFaxToMailUserGroupDao(); - // get all users ( String usersBaseDN = "OU=Mac-Groupe,DC=mac-groupe,DC=net"; String usersFilter = "(objectCategory=CN=Person,CN=Schema,CN=Configuration,DC=mac-groupe,DC=net)"; diff --git a/faxtomail-ui-swing/src/main/java/com/franciaflex/faxtomail/ui/swing/content/demande/demandgroup/DemandGroupCellRenderer.java b/faxtomail-ui-swing/src/main/java/com/franciaflex/faxtomail/ui/swing/content/demande/demandgroup/DemandGroupCellRenderer.java index 6592524f..bb80934b 100644 --- a/faxtomail-ui-swing/src/main/java/com/franciaflex/faxtomail/ui/swing/content/demande/demandgroup/DemandGroupCellRenderer.java +++ b/faxtomail-ui-swing/src/main/java/com/franciaflex/faxtomail/ui/swing/content/demande/demandgroup/DemandGroupCellRenderer.java @@ -93,9 +93,7 @@ public class DemandGroupCellRenderer extends DefaultTableCellRenderer { toolTipTextValue = sb.substring(5); } String textValue = t("faxtomail.demandGroupCellRenderer.text", demands != null ? demands.size() : 0); - boolean editable = table.isCellEditable(row, column); toolTipTextValue = String.format(TEXT_PATTERN, toolTipTextValue); -// setEnabled(editable); setText(textValue); setToolTipText(toolTipTextValue); diff --git a/faxtomail-ui-swing/src/main/java/com/franciaflex/faxtomail/ui/swing/content/reply/ReplyFormUIHandler.java b/faxtomail-ui-swing/src/main/java/com/franciaflex/faxtomail/ui/swing/content/reply/ReplyFormUIHandler.java index 13754bfd..bdbaedeb 100644 --- a/faxtomail-ui-swing/src/main/java/com/franciaflex/faxtomail/ui/swing/content/reply/ReplyFormUIHandler.java +++ b/faxtomail-ui-swing/src/main/java/com/franciaflex/faxtomail/ui/swing/content/reply/ReplyFormUIHandler.java @@ -616,7 +616,7 @@ public class ReplyFormUIHandler extends AbstractFaxToMailUIHandler<ReplyFormUIMo } //insert refs après le premier body - StringBuilder returnMessage= new StringBuilder(); + StringBuilder returnMessage; if (message.contains("<body>")) { String[] parts = message.split("(?<=<body>)"); returnMessage = new StringBuilder(parts[0] + "<p>" + refs + "</p>" + parts[1]); -- To stop receiving notification emails like this one, please contact codelutin.com SCM administrator <admin+scm@codelutin.com>.