This is an automated email from the git hooks/post-receive script. New commit to branch develop in repository faxtomail. See https://gitlab.nuiton.org/codelutin/faxtomail.git commit f2d4db6df41fb33cf1dc348a6ca16d5f65ca54fe Author: Kevin Morin <morin@codelutin.com> Date: Mon Apr 18 14:51:24 2016 +0200 ajout de tests --- .../faxtomail/services/FaxToMailServiceUtils.java | 1 + .../services/FaxToMailServiceUtilsTest.java | 44 ++++++++++++++++++++++ .../services/service/EmailServiceTest.java | 14 ------- 3 files changed, 45 insertions(+), 14 deletions(-) diff --git a/faxtomail-service/src/main/java/com/franciaflex/faxtomail/services/FaxToMailServiceUtils.java b/faxtomail-service/src/main/java/com/franciaflex/faxtomail/services/FaxToMailServiceUtils.java index 695d7ba..bee6aae 100644 --- a/faxtomail-service/src/main/java/com/franciaflex/faxtomail/services/FaxToMailServiceUtils.java +++ b/faxtomail-service/src/main/java/com/franciaflex/faxtomail/services/FaxToMailServiceUtils.java @@ -171,6 +171,7 @@ public class FaxToMailServiceUtils { } public static String getDomainForEmailAddress(String emailAddress) { + Preconditions.checkNotNull(emailAddress); return emailAddress.substring(emailAddress.lastIndexOf("@") + 1); } } diff --git a/faxtomail-service/src/test/java/com/franciaflex/faxtomail/services/FaxToMailServiceUtilsTest.java b/faxtomail-service/src/test/java/com/franciaflex/faxtomail/services/FaxToMailServiceUtilsTest.java new file mode 100644 index 0000000..3a3a556 --- /dev/null +++ b/faxtomail-service/src/test/java/com/franciaflex/faxtomail/services/FaxToMailServiceUtilsTest.java @@ -0,0 +1,44 @@ +package com.franciaflex.faxtomail.services; + +import org.junit.Assert; +import org.junit.Test; + +/** + * @author Kevin Morin (Code Lutin) + * @since 2.0.4 + */ +public class FaxToMailServiceUtilsTest { + + @Test + public void testGetDomainForEmailAddress() { + String email = "test@test.com"; + String domain = FaxToMailServiceUtils.getDomainForEmailAddress(email); + Assert.assertEquals("test.com", domain); + + email = "test.com"; + domain = FaxToMailServiceUtils.getDomainForEmailAddress(email); + Assert.assertEquals("test.com", domain); + + try { + FaxToMailServiceUtils.getDomainForEmailAddress(null); + Assert.fail("null email address should throw an excpetion"); + + } catch(NullPointerException e) { + // a NPE should be caught + } + } + + @Test + public void testDecodeSubject() { + try { + String subject = "=?iso-8859-1?Q?Un fax de 1 page(s) a =E9t=E9 re=E7u?="; + Assert.assertEquals("Un fax de 1 page(s) a été reçu", FaxToMailServiceUtils.getDecodedSubject(subject)); + + subject = "Un fax de 1 page(s) a été reçu"; + Assert.assertEquals("Un fax de 1 page(s) a été reçu", FaxToMailServiceUtils.getDecodedSubject(subject)); + + } catch (Exception e) { + Assert.fail(e.getMessage()); + } + } +} \ No newline at end of file diff --git a/faxtomail-service/src/test/java/com/franciaflex/faxtomail/services/service/EmailServiceTest.java b/faxtomail-service/src/test/java/com/franciaflex/faxtomail/services/service/EmailServiceTest.java index 987eec6..6ed7f72 100644 --- a/faxtomail-service/src/test/java/com/franciaflex/faxtomail/services/service/EmailServiceTest.java +++ b/faxtomail-service/src/test/java/com/franciaflex/faxtomail/services/service/EmailServiceTest.java @@ -379,20 +379,6 @@ public class EmailServiceTest extends AbstractFaxToMailServiceTest { } - @Test - public void testDecodeSubject() { - try { - String subject = "=?iso-8859-1?Q?Un fax de 1 page(s) a =E9t=E9 re=E7u?="; - Assert.assertEquals("Un fax de 1 page(s) a été reçu", FaxToMailServiceUtils.getDecodedSubject(subject)); - - subject = "Un fax de 1 page(s) a été reçu"; - Assert.assertEquals("Un fax de 1 page(s) a été reçu", FaxToMailServiceUtils.getDecodedSubject(subject)); - - } catch (Exception e) { - Assert.fail(e.getMessage()); - } - } - // @Test // public void testSendPdfBlanc() { // testSendEmail(""); -- To stop receiving notification emails like this one, please contact codelutin.com SCM administrator <admin+scm@codelutin.com>.