This is an automated email from the git hooks/post-receive script. New commit to branch feature/sync in repository jtimer. See https://gitlab.nuiton.org/chorem/jtimer.git commit 033fa5dac11882cea7fd021f836e0f126afe7e0e Author: servantie <servantie.c@gmail.com> Date: Thu Jun 9 10:59:52 2016 +0200 changed the signature of synchronizeTaskOnURL (removed TimerTask param) + documented method --- .../chorem/jtimer/io/TimerTaskSynchronizer.java | 28 +++++++++++++++------- 1 file changed, 19 insertions(+), 9 deletions(-) diff --git a/src/main/java/org/chorem/jtimer/io/TimerTaskSynchronizer.java b/src/main/java/org/chorem/jtimer/io/TimerTaskSynchronizer.java index 7f48a49..694c43e 100644 --- a/src/main/java/org/chorem/jtimer/io/TimerTaskSynchronizer.java +++ b/src/main/java/org/chorem/jtimer/io/TimerTaskSynchronizer.java @@ -112,11 +112,27 @@ public class TimerTaskSynchronizer implements DataEventListener { List<JsonObject> jsonObjectList = TimerTaskHelper.taskToJSONFormat(task, false, timezone); for (JsonObject object : jsonObjectList) { - synchronizeTaskOnURL(task, object); + boolean successfulSync = synchronizeTaskOnURL(object); + //sync successful -> change the last sync time + if (successfulSync) { + log.debug("Sync successful on " + object.get("URL").getAsString()); + task.setLastSync(LocalDateTime.now()); + } + //-> do not change last sync time + else { + log.debug("Sync failed on " + object.get("URL").getAsString()); + + } + } } - public boolean synchronizeTaskOnURL(TimerTask task, JsonObject object) { + /** + * Sends one synchronization (one JSON object) + * @param object the object to sync + * @return a boolean indicating failure or success + */ + public boolean synchronizeTaskOnURL(JsonObject object) { String updateJsonString = object.toString(); String syncURL = object.get("URL").getAsString(); @@ -171,13 +187,7 @@ public class TimerTaskSynchronizer implements DataEventListener { } } } - if (hasUpdated) { - task.setLastSync(LocalDateTime.now()); - return true; - } else { - log.error("Sync error"); - return false; - } + return hasUpdated; } @Override -- To stop receiving notification emails like this one, please contact chorem.org SCM administrator <admin+scm@chorem.org>.