This is an automated email from the git hooks/post-receive script. New commit to branch develop in repository observe. See https://gitlab.nuiton.org/codelutin/observe.git commit a7331576566ba504f99692cba31deae4f1f44743 Author: Tony CHEMIT <chemit@codelutin.com> Date: Mon Aug 1 13:52:13 2016 +0200 Improve code --- .../AbstractSpeciesFieldDtoValidator.java | 4 +- .../validation/BeanValidatorDetectorTest.java | 2 +- .../main/java/fr/ird/observe/ObserveAdminCLI.java | 2 +- .../main/java/fr/ird/observe/ObserveCLAction.java | 12 +- .../fr/ird/observe/ObserveResourceManager.java | 2 +- .../main/java/fr/ird/observe/ObserveRunner.java | 6 +- .../observe/ObserveSwingApplicationContext.java | 2 +- .../ObserveSwingApplicationConfig.java | 4 +- .../ObserveSwingApplicationConfigOption.java | 2 +- .../fr/ird/observe/db/ObserveSwingDataSource.java | 4 +- .../observe/entities/tripMap/TripMapPointType.java | 2 +- .../fr/ird/observe/ui/ObserveMainUIHandler.java | 2 +- .../src/main/java/fr/ird/observe/ui/UIHelper.java | 8 +- .../observe/ui/actions/ChangeDbLanguageAction.java | 4 +- .../fr/ird/observe/ui/actions/ShowAboutAction.java | 2 +- .../ird/observe/ui/actions/ShowConfigAction.java | 2 +- .../observe/ui/actions/StopH2WebServerAction.java | 1 - .../observe/ui/actions/StopServerModeAction.java | 1 - .../ui/actions/shared/MoveTripsUIAction.java | 6 +- .../fr/ird/observe/ui/admin/AdminActionWorker.java | 2 +- .../java/fr/ird/observe/ui/admin/AdminUIModel.java | 8 +- .../ui/admin/consolidate/ConsolidateUIHandler.java | 2 +- .../ui/admin/export/TripToExportTableModel.java | 2 +- .../ird/observe/ui/admin/report/ReportModel.java | 2 +- .../observe/ui/admin/report/ReportUIHandler.java | 9 +- .../observe/ui/admin/save/SaveLocalUIHandler.java | 2 +- .../validate/ValidateEntityListCellRenderer.java | 7 +- .../ui/admin/validate/ValidateUIHandler.java | 6 +- .../validate/ValidationMessageTableModel.java | 5 +- .../java/fr/ird/observe/ui/content/ContentUI.jaxx | 6 +- .../ird/observe/ui/content/ContentUIHandler.java | 11 +- .../observe/ui/content/ContentUIInitializer.java | 15 +- .../ird/observe/ui/content/ObserveContentUI.java | 7 +- .../content/impl/longline/BranchlineUIHandler.java | 6 +- .../LonglineDetailCompositionUIHandler.java | 44 +- .../LonglineDetailCompositionUIInitializer.java | 4 +- ...onglineDetailCompositionUIValidationHelper.java | 2 +- .../LonglineGlobalCompositionUIHandler.java | 6 +- .../impl/longline/SetLonglineUIHandler.java | 8 +- .../ActivitySeineObservedSystemUIHandler.java | 4 +- .../seine/ActivitySeineObservedSystemUIModel.java | 2 - ...ngObjectTransmittingBuoyOperationUIHandler.java | 6 +- .../impl/seine/FloatingObjectUIHandler.java | 6 +- .../ui/content/impl/seine/SetSeineUIHandler.java | 8 +- .../ui/content/list/ContentListUIHandler.java | 17 +- .../impl/longline/ActivityLonglinesUIHandler.java | 2 +- .../list/impl/seine/ActivitySeinesUIHandler.java | 2 +- .../content/list/impl/seine/RoutesUIHandler.java | 2 +- .../impl/longline/ActivityLonglineUIHandler.java | 8 +- .../open/impl/longline/TripLonglineUIHandler.java | 6 +- .../open/impl/seine/ActivitySeineUIHandler.java | 8 +- .../ui/content/open/impl/seine/RouteUIHandler.java | 6 +- .../open/impl/seine/TripSeineUIHandler.java | 6 +- .../ui/content/ref/ContentReferenceUIHandler.java | 6 +- .../ui/content/ref/UniqueKeyTableModel.java | 6 +- .../observe/ui/content/ref/impl/GearUIHandler.java | 2 +- .../ref/impl/LengthWeightParameterUIHandler.java | 2 +- .../ui/content/ref/impl/ProgramUIHandler.java | 2 +- .../ui/content/ref/impl/SpeciesListUIHandler.java | 2 +- .../ui/content/ref/impl/SpeciesUIHandler.java | 2 +- .../ui/content/ref/impl/VesselUIHandler.java | 2 +- .../observe/ui/content/table/ContentTableMeta.java | 16 +- .../ui/content/table/ContentTableModel.java | 2 +- .../ui/content/table/ContentTableUIHandler.java | 6 +- .../content/table/ContentTableUIInitializer.java | 2 +- .../ui/content/table/ContentTableUIModel.java | 11 +- .../impl/longline/BaitsCompositionUIHandler.java | 2 +- .../impl/longline/BaitsCompositionUIModel.java | 2 + .../longline/BranchlinesCompositionUIHandler.java | 2 +- .../longline/BranchlinesCompositionUIModel.java | 2 + .../impl/longline/CatchAcquisitionModeEnum.java | 2 +- .../impl/longline/CatchLonglineTableModel.java | 5 + .../impl/longline/CatchLonglineUIHandler.java | 12 +- .../table/impl/longline/EncounterUIHandler.java | 2 +- .../table/impl/longline/EncounterUIModel.java | 2 + .../longline/FloatlinesCompositionUIHandler.java | 2 +- .../longline/FloatlinesCompositionUIModel.java | 1 + .../GearUseFeaturesLonglineTableModel.java | 7 +- .../longline/GearUseFeaturesLonglineUIHandler.java | 8 +- .../impl/longline/HooksCompositionUIHandler.java | 2 +- .../impl/longline/HooksCompositionUIModel.java | 1 + .../impl/longline/LonglinePositionHelper.java | 6 +- .../table/impl/longline/SensorUsedUIHandler.java | 2 +- .../table/impl/longline/SensorUsedUIModel.java | 1 + .../content/table/impl/longline/TdrUIHandler.java | 8 +- .../ui/content/table/impl/longline/TdrUIModel.java | 1 + .../seine/GearUseFeatureMeasurementCellEditor.java | 4 +- .../impl/seine/GearUseFeaturesSeineTableModel.java | 7 +- .../impl/seine/GearUseFeaturesSeineUIHandler.java | 8 +- .../impl/seine/ModeSaisieEchantillonEnum.java | 2 +- .../table/impl/seine/NonTargetCatchUIHandler.java | 2 +- .../table/impl/seine/NonTargetCatchUIModel.java | 1 + .../table/impl/seine/NonTargetSampleUIHandler.java | 2 +- .../table/impl/seine/NonTargetSampleUIModel.java | 1 + .../impl/seine/ObjectObservedSpeciesUIHandler.java | 3 +- .../impl/seine/ObjectObservedSpeciesUIModel.java | 1 + .../impl/seine/ObjectSchoolEstimateUIHandler.java | 2 +- .../impl/seine/ObjectSchoolEstimateUIModel.java | 1 + .../table/impl/seine/SchoolEstimateUIHandler.java | 2 +- .../table/impl/seine/SchoolEstimateUIModel.java | 1 + .../table/impl/seine/TargetCatchUIHandler.java | 2 +- .../table/impl/seine/TargetCatchUIModel.java | 1 + .../impl/seine/TargetDiscardCatchUIHandler.java | 4 +- .../impl/seine/TargetDiscardCatchUIModel.java | 1 + .../table/impl/seine/TargetSampleUIHandler.java | 2 +- .../table/impl/seine/TargetSampleUIModel.java | 1 + .../ird/observe/ui/storage/ObstunaAdminAction.java | 8 +- .../ird/observe/ui/storage/RemoteUILauncher.java | 4 +- .../ui/storage/StorageBackupUILauncher.java | 2 +- .../ird/observe/ui/storage/StorageUIHandler.java | 2 - .../ird/observe/ui/storage/StorageUILauncher.java | 2 +- .../fr/ird/observe/ui/storage/StorageUIModel.java | 10 +- .../ui/storage/tabs/DataSelectionModel.java | 17 +- .../ird/observe/ui/storage/tabs/SecurityModel.java | 12 +- .../ui/tree/DataSelectionTreeSelectionModel.java | 4 +- .../fr/ird/observe/ui/tree/ObserveTreeBridge.java | 2 +- .../fr/ird/observe/ui/tree/ObserveTreeHelper.java | 2 +- .../ui/tree/loadors/RootNodeChildLoador.java | 3 - .../ObserveSwingValidatorMessageTableModel.java | 4 +- .../ui/util/table/AbstractSelectTableAction.java | 3 +- .../fr/ird/observe/ui/util/table/EditableList.java | 2 +- .../ui/util/table/EditableTableModelSupport.java | 6 +- .../table/ObserveBooleanTableCellRenderer.java | 13 +- .../observe/ui/util/tripMap/ObserveMapPane.java | 9 +- .../util/tripMap/ObserverMapPanLegendDrawer.java | 24 +- .../ui/util/tripMap/TripMapContentBuilder.java | 4 +- .../observe/ui/util/tripMap/TripMapUIHandler.java | 2 +- .../validation/ValidationMessageDetector.java | 560 --------------------- ...glineDetailCompositionValidatorServiceTest.java | 2 +- .../application/web/ObserveWebMotionRender.java | 2 +- .../ObserveWebApplicationConfigurationOption.java | 9 +- .../web/configuration/db/ObserveWebDatabase.java | 3 +- .../web/configuration/db/ObserveWebDatabases.java | 3 +- .../db/impl/ObserveWebDatabaseBean.java | 11 +- .../db/impl/ObserveWebDatabaseImmutable.java | 21 +- .../db/impl/ObserveWebDatabasesBean.java | 11 +- .../db/impl/ObserveWebDatabasesImmutable.java | 21 +- .../web/configuration/user/ObserveWebUser.java | 3 +- .../web/configuration/user/ObserveWebUsers.java | 3 +- .../configuration/user/ObserveWebUsersHelper.java | 4 +- .../user/impl/ObserveWebUserBean.java | 11 +- .../user/impl/ObserveWebUserImmutable.java | 21 +- .../user/impl/ObserveWebUsersBean.java | 11 +- .../user/impl/ObserveWebUsersImmutable.java | 21 +- .../controller/v1/DataSourceServiceController.java | 2 +- .../web/converter/ObserveDtoConverter.java | 2 +- .../application/web/injector/DateInjector.java | 2 +- .../web/injector/ObserveDtoInjector.java | 2 +- .../web/request/ObserveWebRequestContext.java | 12 +- .../ObserveWebSecurityApplicationContext.java | 2 +- ...ObserveWebSecurityAuthenticationTokenCache.java | 11 +- .../db/ObserveWebDatabasesHelperTest.java | 4 +- .../user/ObserveWebUsersHelperTest.java | 2 +- .../fr/ird/observe/ObserveApplicationContext.java | 2 +- .../java/fr/ird/observe/ObserveServiceHelper.java | 2 +- .../java/fr/ird/observe/db/impl/PGDataSource.java | 2 +- .../fr/ird/observe/db/impl/PGDataSourceConfig.java | 2 +- .../java/fr/ird/observe/entities/Entities.java | 16 +- .../constants/TripMapPointTypePersist.java | 2 +- .../NonTargetCatchComputedValueSourcePersist.java | 2 +- .../entities/constants/seine/OwnershipPersist.java | 2 +- .../constants/seine/SchoolTypePersist.java | 2 +- .../TypeTransmittingBuoyOperationPersist.java | 2 +- .../entities/longline/ActivityLonglines.java | 15 +- .../entities/longline/TripLonglineTopiaDao.java | 4 +- .../migration/AbstractDataSourceMigration.java | 2 +- .../AbstractObserveMigrationCallBack.java | 21 +- .../entities/migration/H2DataSourceMigration.java | 194 ++++--- ...ObserveMigrationCallBackForVersionResolver.java | 2 +- .../entities/migration/PGDataSourceMigration.java | 317 ++++++------ .../DataSourceMigrationForVersion_3_16.java | 38 +- .../DataSourceMigrationForVersion_3_5.java | 2 +- .../DataSourceMigrationForVersion_4_0_1.java | 68 ++- .../DataSourceMigrationForVersion_4_0_RC2.java | 38 +- .../DataSourceMigrationForVersion_4_0_RC3.java | 24 +- .../referentiel/ObserveReferentialEntities.java | 20 +- .../ird/observe/entities/referentiel/Persons.java | 21 +- .../ird/observe/entities/referentiel/Programs.java | 9 +- .../ird/observe/entities/referentiel/Species2.java | 16 +- .../observe/entities/seine/ActivitySeineImpl.java | 3 +- .../ird/observe/entities/seine/ActivitySeines.java | 17 +- .../observe/entities/seine/NonTargetCatchImpl.java | 2 +- .../observe/entities/seine/NonTargetCatchs.java | 7 +- .../observe/entities/seine/NonTargetLenghts.java | 7 +- .../ird/observe/entities/seine/RouteTopiaDao.java | 40 +- .../java/fr/ird/observe/entities/seine/Routes.java | 15 +- .../fr/ird/observe/entities/seine/SetSeines.java | 9 +- .../ird/observe/entities/seine/TargetCatchs.java | 18 +- .../ird/observe/entities/seine/TargetLenghts.java | 10 +- .../observe/entities/seine/TripSeineTopiaDao.java | 4 +- .../ObserveTopiaApplicationContextTest.java | 2 +- .../services/ObserveServiceInitializer.java | 6 +- .../service/actions/report/ReportBuilder.java | 2 +- .../actions/validate/ValidateResultForDtoType.java | 8 +- .../actions/validate/ValidateResultForDtos.java | 30 +- .../actions/validate/ValidationMessage.java | 6 +- .../service/actions/validate/ValidatorDtos.java | 15 +- .../ObserveDataSourceConfigurationRest.java | 4 +- .../observe/services/dto/AbstractReference.java | 26 +- .../fr/ird/observe/services/dto/DataReference.java | 28 +- .../java/fr/ird/observe/services/dto/IdDtos.java | 26 +- .../observe/services/dto/ObserveDbUserDtos.java | 2 +- .../services/dto/actions/report/Report.java | 8 +- .../dto/actions/report/ReportOperation.java | 2 +- .../dto/actions/report/ReportVariable.java | 6 +- .../services/dto/constants/ObserveDbRole.java | 2 +- .../services/dto/constants/ReferenceStatus.java | 2 +- .../services/dto/constants/TripMapPointType.java | 4 +- .../seine/NonTargetCatchComputedValueSource.java | 2 +- .../services/dto/constants/seine/SchoolType.java | 2 +- .../seine/TypeTransmittingBuoyOperation.java | 4 +- .../services/dto/gson/ObserveDtoGsonSupplier.java | 8 +- .../services/dto/longline/SectionWithTemplate.java | 4 - .../dto/longline/SectionWithTemplates.java | 11 +- .../services/dto/referential/PersonDtos.java | 30 +- .../services/dto/referential/ReferentialDtos.java | 2 +- .../dto/referential/ReferentialReferences.java | 21 +- .../services/http/ObserveRequestBuilder.java | 2 +- .../ird/observe/services/http/ObserveResponse.java | 6 +- .../services/http/ObserveResponseBuilder.java | 4 +- .../services/service/AbstractServiceRestTest.java | 2 +- .../service/ReferenceValuesSetServiceRestTest.java | 4 +- .../report/AbstractReportServiceRestTest.java | 5 - .../report/ReportAccessoryCatchRestTest.java | 2 +- .../actions/validate/ValidateServiceRestTest.java | 251 +++++---- .../validators/AbstractSpeciesFieldValidator.java | 4 +- ...erve-services-topia-validation_en_GB.properties | 2 +- ...erve-services-topia-validation_es_ES.properties | 2 +- ...erve-services-topia-validation_fr_FR.properties | 2 +- .../validation/BeanValidatorDetectorTest.java | 2 +- .../observe/services/ObserveSecurityHelper.java | 11 +- .../ird/observe/services/ObserveServiceTopia.java | 4 +- .../ObserveTopiaApplicationContextFactory.java | 4 +- .../ird/observe/services/binder/BinderEngine.java | 12 +- .../ird/observe/services/binder/BinderSupport.java | 104 +--- .../observe/services/entity/EntitiesExtractor.java | 12 +- .../services/entity/EntitiesSetFactory.java | 12 +- .../entity/SpeciesListEntitiesExtractor.java | 2 +- .../entity/SpeciesListOceanEntitiesExtractor.java | 7 +- .../observe/services/entity/TripMapDtoFactory.java | 21 +- .../services/service/DataSourceServiceTopia.java | 2 +- .../services/service/ReferentialServiceTopia.java | 4 +- .../service/SqlScriptProducerServiceTopia.java | 4 +- .../ConsolidateActivitySeineDataResultBuilder.java | 12 +- .../consolidate/ConsolidateDataServiceTopia.java | 4 +- .../service/actions/report/ReportServiceTopia.java | 4 +- ...alReferentialSynchronizeRemoteServiceTopia.java | 5 +- .../validate/ValidationMessageDetector.java | 9 +- .../longline/ActivityLonglineServiceTopia.java | 2 +- .../service/seine/ActivitySeineServiceTopia.java | 2 +- .../services/service/seine/RouteServiceTopia.java | 10 +- .../referentiel/LengthWeightParemetersTest.java | 2 +- .../services/binder/BinderEngineMetadataTest.java | 2 +- .../observe/services/binder/BinderEngineTest.java | 9 +- .../service/DataSourceServiceTopiaTest.java | 2 +- .../services/service/MigrateTestsDatabases.java | 2 +- .../report/AbstractReportServiceTopiaTest.java | 5 +- .../actions/report/ReportAccessoryCatch2Test.java | 2 +- .../report/ReportAccessoryCatchByGroup2Test.java | 2 +- .../report/ReportAccessoryCatchByGroupTest.java | 2 +- .../actions/report/ReportAccessoryCatchTest.java | 2 +- .../report/ReportActivityWithCommentTest.java | 2 +- .../actions/report/ReportAllActivitysTest.java | 2 +- .../actions/report/ReportDailySetAndCatchTest.java | 2 +- .../service/actions/report/ReportDcpUsageTest.java | 2 +- .../actions/report/ReportSetByAssociationTest.java | 2 +- .../report/ReportTargetCatchByAssociationTest.java | 2 +- .../ReportTargetDiscardedByAssociationTest.java | 2 +- .../actions/validate/ValidateServiceTopiaTest.java | 202 +++++--- .../sql/batch/actions/AbstractSqlAction.java | 26 +- .../sql/batch/actions/AbstractTablesAction.java | 2 +- .../sql/batch/actions/DeleteTablesAction.java | 6 +- .../sql/batch/actions/ReplicateTablesAction.java | 2 +- .../sql/batch/actions/UpdateTablesAction.java | 2 +- .../service/sql/batch/tables/TopiaSqlTables.java | 2 +- 275 files changed, 1215 insertions(+), 2201 deletions(-) diff --git a/observe-application-swing-validation/src/main/java/fr/ird/observe/application/swing/validation/validators/AbstractSpeciesFieldDtoValidator.java b/observe-application-swing-validation/src/main/java/fr/ird/observe/application/swing/validation/validators/AbstractSpeciesFieldDtoValidator.java index 338993f..2a3c124 100644 --- a/observe-application-swing-validation/src/main/java/fr/ird/observe/application/swing/validation/validators/AbstractSpeciesFieldDtoValidator.java +++ b/observe-application-swing-validation/src/main/java/fr/ird/observe/application/swing/validation/validators/AbstractSpeciesFieldDtoValidator.java @@ -63,9 +63,9 @@ public abstract class AbstractSpeciesFieldDtoValidator extends FieldValidatorSup public static class Bound { - private Float min; + private final Float min; - private Float max; + private final Float max; Bound(Float min, Float max) { this.min = min; diff --git a/observe-application-swing-validation/src/test/java/fr/ird/observe/application/swing/validation/BeanValidatorDetectorTest.java b/observe-application-swing-validation/src/test/java/fr/ird/observe/application/swing/validation/BeanValidatorDetectorTest.java index 6280341..549e499 100644 --- a/observe-application-swing-validation/src/test/java/fr/ird/observe/application/swing/validation/BeanValidatorDetectorTest.java +++ b/observe-application-swing-validation/src/test/java/fr/ird/observe/application/swing/validation/BeanValidatorDetectorTest.java @@ -138,7 +138,7 @@ public class BeanValidatorDetectorTest extends AbstractValidatorDetectorTest { static Class<?>[] ALL_TYPES; @BeforeClass - public static void setUpClass() throws Exception { + public static void setUpClass() { ALL_TYPES = new Class[]{ ActivityLonglineDto.class, ActivityLonglineEncounterDto.class, diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ObserveAdminCLI.java b/observe-application-swing/src/main/java/fr/ird/observe/ObserveAdminCLI.java index 2796005..e474a4b 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ObserveAdminCLI.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ObserveAdminCLI.java @@ -36,7 +36,7 @@ import java.util.Date; public class ObserveAdminCLI extends ObserveRunner { /** Logger */ - private static Log log = LogFactory.getLog(ObserveAdminCLI.class); + private static final Log log = LogFactory.getLog(ObserveAdminCLI.class); @Override public String getRunnerName() { diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ObserveCLAction.java b/observe-application-swing/src/main/java/fr/ird/observe/ObserveCLAction.java index 4e9afd1..e11a47c 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ObserveCLAction.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ObserveCLAction.java @@ -54,7 +54,7 @@ import static org.nuiton.i18n.I18n.t; public class ObserveCLAction { /** Logger */ - static private Log log = LogFactory.getLog(ObserveCLAction.class); + private static final Log log = LogFactory.getLog(ObserveCLAction.class); /** * Les actions appellables en ligne de commande. @@ -136,13 +136,13 @@ public class ObserveCLAction { "--create-id"); - public String description; + public final String description; - public String action; + public final String action; - public String[] aliases; + public final String[] aliases; - public boolean admin; + public final boolean admin; ActionDefinition(boolean admin, String description, String action, String... aliases) { this.description = description; @@ -320,7 +320,7 @@ public class ObserveCLAction { disableMainUI(); - Class<?> klazz = null; +// Class<?> klazz = null; //FIXME // List<ObserveEntityEnum> enums = Lists.newArrayList(Entities.ALL_ENTITIES); diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ObserveResourceManager.java b/observe-application-swing/src/main/java/fr/ird/observe/ObserveResourceManager.java index 0a141a4..c176f2b 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ObserveResourceManager.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ObserveResourceManager.java @@ -63,7 +63,7 @@ public class ObserveResourceManager { public static final String OBSERVE_LOG_CONFIGURATION_FILE_PROPERTIES = "/observe-log4j.properties"; /** Logger */ - static private Log log = LogFactory.getLog(ObserveResourceManager.class); + private static final Log log = LogFactory.getLog(ObserveResourceManager.class); public enum Resource { diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ObserveRunner.java b/observe-application-swing/src/main/java/fr/ird/observe/ObserveRunner.java index df46160..455d1d2 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ObserveRunner.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ObserveRunner.java @@ -525,7 +525,7 @@ public abstract class ObserveRunner extends ApplicationRunner { } - protected void detectLocalDataBase(ObserveSwingApplicationConfig config) throws IOException { + protected void detectLocalDataBase(ObserveSwingApplicationConfig config) { boolean hasLocalStorage = new File(config.getLocalDBDirectory(), ObserveSwingApplicationConfig.DB_NAME).exists(); config.setLocalStorageExist(hasLocalStorage); if (!hasLocalStorage) { @@ -579,7 +579,7 @@ public abstract class ObserveRunner extends ApplicationRunner { } } - protected void initUIConfiguration(ObserveSwingApplicationConfig config) throws IOException { + protected void initUIConfiguration(ObserveSwingApplicationConfig config) { // prepare ui look&feel and load ui properties try { @@ -647,7 +647,7 @@ public abstract class ObserveRunner extends ApplicationRunner { * @return le context applicatif * @throws IllegalStateException si un contexte applicatif a déja été positionné. */ - public ObserveSwingApplicationContext initContext(ObserveSwingApplicationConfig config) throws Exception { + public ObserveSwingApplicationContext initContext(ObserveSwingApplicationConfig config) { ObserveSwingApplicationContext.checkIsNotInit(); diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ObserveSwingApplicationContext.java b/observe-application-swing/src/main/java/fr/ird/observe/ObserveSwingApplicationContext.java index 38157a5..daad9ff 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ObserveSwingApplicationContext.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ObserveSwingApplicationContext.java @@ -122,7 +122,7 @@ import static org.nuiton.i18n.I18n.t; public class ObserveSwingApplicationContext extends DefaultApplicationContext implements Closeable { /** Logger */ - static private Log log = LogFactory.getLog(ObserveSwingApplicationContext.class); + private static final Log log = LogFactory.getLog(ObserveSwingApplicationContext.class); /** Un drapeau pour savoir quand l'application est en cours de fermeture. */ protected static boolean closed; diff --git a/observe-application-swing/src/main/java/fr/ird/observe/configuration/ObserveSwingApplicationConfig.java b/observe-application-swing/src/main/java/fr/ird/observe/configuration/ObserveSwingApplicationConfig.java index cd81de9..e482d6e 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/configuration/ObserveSwingApplicationConfig.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/configuration/ObserveSwingApplicationConfig.java @@ -222,7 +222,7 @@ public class ObserveSwingApplicationConfig extends ApplicationConfig { public static final String PROPERTY_TREE_OPEN_NODES = "treeOpenNodes"; /** Logger */ - static private Log log = LogFactory.getLog(ObserveSwingApplicationConfig.class); + private static final Log log = LogFactory.getLog(ObserveSwingApplicationConfig.class); protected static final String DEFAULT_OBSERVE_SWING_CONFIGURATION_FILENAME = "observeSwing.conf"; @@ -1018,7 +1018,7 @@ public class ObserveSwingApplicationConfig extends ApplicationConfig { setServerUrl(config.getServerUrl()); setServerLogin(config.getLogin()); setServerPassword(config.getPassword()); - setServerDataBaseName(config.getOptionalDatabaseName().orNull()); + setServerDataBaseName(config.getOptionalDatabaseName().orElse(null)); saveForUser(); } diff --git a/observe-application-swing/src/main/java/fr/ird/observe/configuration/ObserveSwingApplicationConfigOption.java b/observe-application-swing/src/main/java/fr/ird/observe/configuration/ObserveSwingApplicationConfigOption.java index ba3fdc8..c062d94 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/configuration/ObserveSwingApplicationConfigOption.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/configuration/ObserveSwingApplicationConfigOption.java @@ -814,7 +814,7 @@ public enum ObserveSwingApplicationConfigOption implements ConfigOptionDef { false ); - public static List<ObserveSwingApplicationConfigOption> MAP_LAYERS = ImmutableList.of(MAP_LAYER_1, MAP_LAYER_2, MAP_LAYER_3, + public static final List<ObserveSwingApplicationConfigOption> MAP_LAYERS = ImmutableList.of(MAP_LAYER_1, MAP_LAYER_2, MAP_LAYER_3, MAP_LAYER_4, MAP_LAYER_5, MAP_LAYER_6, MAP_LAYER_7, MAP_LAYER_8, MAP_LAYER_9, MAP_LAYER_10); /** diff --git a/observe-application-swing/src/main/java/fr/ird/observe/db/ObserveSwingDataSource.java b/observe-application-swing/src/main/java/fr/ird/observe/db/ObserveSwingDataSource.java index 7989bcb..4da3d56 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/db/ObserveSwingDataSource.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/db/ObserveSwingDataSource.java @@ -161,7 +161,7 @@ public class ObserveSwingDataSource extends AbstractSerializableBean implements canWriteData(), getVersion(), getVersion(), - ImmutableList.<Version>of()); + ImmutableList.of()); } public void open() throws DatabaseConnexionNotAuthorizedException, DatabaseNotFoundException, BabModelVersionException { @@ -265,7 +265,7 @@ public class ObserveSwingDataSource extends AbstractSerializableBean implements dataSourceService.applySecurity(getConfiguration(), users); } - public void migrateData(ObserveDataSourceInformation dataSourceInformation, Version targetVersion) throws DatabaseConnexionNotAuthorizedException, DatabaseNotFoundException { + public void migrateData(ObserveDataSourceInformation dataSourceInformation, Version targetVersion) { checkIsNotOpen(); diff --git a/observe-application-swing/src/main/java/fr/ird/observe/entities/tripMap/TripMapPointType.java b/observe-application-swing/src/main/java/fr/ird/observe/entities/tripMap/TripMapPointType.java index 4dac356..4833ca7 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/entities/tripMap/TripMapPointType.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/entities/tripMap/TripMapPointType.java @@ -46,7 +46,7 @@ public enum TripMapPointType { LONGLINE_ACTIVITY_WITH_INTERACTION(n("observe.map.longLine.activity.interaction")), LONGLINE_ACTIVITY_WITH_STATION(n("observe.map.longLine.activity.station")); - String label; + private final String label; TripMapPointType(String label) { this.label = label; diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/ObserveMainUIHandler.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/ObserveMainUIHandler.java index 3c06af7..b9a3ba7 100755 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/ObserveMainUIHandler.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/ObserveMainUIHandler.java @@ -74,7 +74,7 @@ import static org.nuiton.i18n.I18n.t; public class ObserveMainUIHandler { /** Logger */ - static private Log log = LogFactory.getLog(ObserveMainUIHandler.class); + private static final Log log = LogFactory.getLog(ObserveMainUIHandler.class); public static final String H2_SERVER = "server"; diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/UIHelper.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/UIHelper.java index d510064..eb4ea0a 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/UIHelper.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/UIHelper.java @@ -314,7 +314,7 @@ public class UIHelper extends SwingUtil { DecoratorService decoratorService = ObserveSwingApplicationContext.get().getDecoratorService(); Decorator<E> decorator = decoratorService.getDecoratorByType(beanClass); String beanStr; - String messageDelete = null; + String messageDelete; String type = DecoratorService.getEntityLabel(beanClass); type = t(type); @@ -469,11 +469,7 @@ public class UIHelper extends SwingUtil { u.getProtocol().equalsIgnoreCase("file")) { Desktop.getDesktop().browse(u.toURI()); } - } catch (IOException e) { - if (log.isErrorEnabled()) { - log.error("Error while opening link", e); - } - } catch (URISyntaxException e) { + } catch (IOException | URISyntaxException e) { if (log.isErrorEnabled()) { log.error("Error while opening link", e); } diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/actions/ChangeDbLanguageAction.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/actions/ChangeDbLanguageAction.java index f8f52ac..81393a0 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/actions/ChangeDbLanguageAction.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/actions/ChangeDbLanguageAction.java @@ -22,11 +22,11 @@ package fr.ird.observe.ui.actions; * #L% */ +import fr.ird.observe.ObserveSwingApplicationContext; import fr.ird.observe.configuration.ObserveSwingApplicationConfig; import fr.ird.observe.configuration.ObserveSwingApplicationConfigOption; -import fr.ird.observe.ObserveSwingApplicationContext; import fr.ird.observe.services.dto.constants.ReferentialLocale; -import fr.ird.observe.ui.*; +import fr.ird.observe.ui.ObserveMainUI; import fr.ird.observe.ui.ObserveUICallback; import jaxx.runtime.SwingUtil; import org.apache.commons.logging.Log; diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/actions/ShowAboutAction.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/actions/ShowAboutAction.java index a2b63f3..7c760ea 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/actions/ShowAboutAction.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/actions/ShowAboutAction.java @@ -115,7 +115,7 @@ public class ShowAboutAction extends AbstractAction { } translateArea.setText(translateText); translatePane.getViewport().add(translateArea); - translateArea.addHyperlinkListener(e -> UIHelper.openLink(e)); + translateArea.addHyperlinkListener(UIHelper::openLink); about.getTabs().add(t("observe.about.translate.title"), translatePane); diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/actions/ShowConfigAction.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/actions/ShowConfigAction.java index a43774d..b2e0970 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/actions/ShowConfigAction.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/actions/ShowConfigAction.java @@ -139,7 +139,7 @@ public class ShowConfigAction extends AbstractAction { helper.setFinalizer(new MainCallBackFinalizer(ObserveUICallback.application.name())); - helper.setCloseAction(() -> ObserveMainUIHandler.restartEdit()); + helper.setCloseAction(ObserveMainUIHandler::restartEdit); // categorie repertoires addDirectoriesOptions(helper); diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/actions/StopH2WebServerAction.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/actions/StopH2WebServerAction.java index f405b8b..457d3da 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/actions/StopH2WebServerAction.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/actions/StopH2WebServerAction.java @@ -23,7 +23,6 @@ package fr.ird.observe.ui.actions; */ import fr.ird.observe.ui.ObserveMainUI; -import fr.ird.observe.ui.ObserveMainUIHandler; import jaxx.runtime.SwingUtil; import org.apache.commons.logging.Log; import org.apache.commons.logging.LogFactory; diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/actions/StopServerModeAction.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/actions/StopServerModeAction.java index aa0311b..9142228 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/actions/StopServerModeAction.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/actions/StopServerModeAction.java @@ -23,7 +23,6 @@ package fr.ird.observe.ui.actions; */ import fr.ird.observe.ui.ObserveMainUI; -import fr.ird.observe.ui.ObserveMainUIHandler; import fr.ird.observe.ui.ObserveUIMode; import jaxx.runtime.SwingUtil; import org.apache.commons.logging.Log; diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/actions/shared/MoveTripsUIAction.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/actions/shared/MoveTripsUIAction.java index b4e3eff..e5ac87a 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/actions/shared/MoveTripsUIAction.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/actions/shared/MoveTripsUIAction.java @@ -27,7 +27,6 @@ import fr.ird.observe.ObserveSwingApplicationContext; import fr.ird.observe.services.dto.DataDto; import fr.ird.observe.services.dto.DataReference; import fr.ird.observe.services.dto.constants.GearType; -import fr.ird.observe.services.dto.referential.ProgramDto; import fr.ird.observe.ui.ObserveMainUI; import fr.ird.observe.ui.content.ContentUI; import fr.ird.observe.ui.content.list.ContentListUIModel; @@ -35,7 +34,6 @@ import fr.ird.observe.ui.tree.ObserveNode; import fr.ird.observe.ui.tree.ObserveTreeHelper; import fr.ird.observe.ui.tree.menu.MoveTripNodeMenuPopulator; import fr.ird.observe.ui.util.DecoratedNodeEntity; -import fr.ird.observe.application.swing.decoration.decorators.ReferentialReferenceDecorator; import org.apache.commons.logging.Log; import org.apache.commons.logging.LogFactory; @@ -85,7 +83,7 @@ public abstract class MoveTripsUIAction<T extends DataDto> extends AbstractUIAct if (ui == null) { throw new IllegalStateException( "could not find client property " + - "ui on component" + c); + "ui on component" + c); } checkUIClass(ui); @@ -124,8 +122,6 @@ public abstract class MoveTripsUIAction<T extends DataDto> extends AbstractUIAct // racine ObserveNode rootNode = treeHelper.getRootNode(); - ReferentialReferenceDecorator<ProgramDto> decorator = applicationContext.getDecoratorService().getReferentialReferenceDecorator(ProgramDto.class); - //on crée un tableau avec un programme en moins car on ne propose pas le programme actuel List<DecoratedNodeEntity> decoratedProgramList = new ArrayList<>(); diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/admin/AdminActionWorker.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/admin/AdminActionWorker.java index 250ad41..67b6af4 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/admin/AdminActionWorker.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/admin/AdminActionWorker.java @@ -34,7 +34,7 @@ import java.util.concurrent.Callable; */ public class AdminActionWorker extends ActionWorker<WizardState, String> { - protected AdminTabUIHandler handler; + protected final AdminTabUIHandler handler; protected AdminActionWorker(AdminTabUIHandler handler, String actionLabel) { diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/admin/AdminUIModel.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/admin/AdminUIModel.java index 4f474a1..ac8553b 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/admin/AdminUIModel.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/admin/AdminUIModel.java @@ -107,10 +107,10 @@ public class AdminUIModel extends WizardExtModel<AdminStep> { protected ObserveSwingDataSource tmpSource; /** la configuration de la base source */ - protected StorageUIModel localSourceModel; + protected final StorageUIModel localSourceModel; /** la configuration de la base central */ - protected StorageUIModel centralSourceModel; + protected final StorageUIModel centralSourceModel; /** le controleur pour configurer les sources */ protected StorageUIHandler storageHandler; @@ -119,10 +119,10 @@ public class AdminUIModel extends WizardExtModel<AdminStep> { protected ObserveSwingApplicationConfig config; /** selection des donnees a valider */ - protected DataSelectionModel selectionDataModel; + protected final DataSelectionModel selectionDataModel; /** la liste des modes disponibles en entrée */ - protected EnumSet<DbMode> availableIncomingModes; + protected final EnumSet<DbMode> availableIncomingModes; private final PropertyChangeListener listenStepChanged; diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/admin/consolidate/ConsolidateUIHandler.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/admin/consolidate/ConsolidateUIHandler.java index bc5ad7c..15c0546 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/admin/consolidate/ConsolidateUIHandler.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/admin/consolidate/ConsolidateUIHandler.java @@ -102,7 +102,7 @@ public class ConsolidateUIHandler extends AdminTabUIHandler { public void startAction() { - addAdminWorker(((ConsolidateUI) ui).getStartButton().getToolTipText(), () -> doAction()); + addAdminWorker(((ConsolidateUI) ui).getStartButton().getToolTipText(), this::doAction); } public WizardState doAction() throws Exception { diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/admin/export/TripToExportTableModel.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/admin/export/TripToExportTableModel.java index 385d870..7b39e6b 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/admin/export/TripToExportTableModel.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/admin/export/TripToExportTableModel.java @@ -49,7 +49,7 @@ public class TripToExportTableModel extends AbstractTableModel { protected TripEntry[] data; - protected Set<Integer> selected; + protected final Set<Integer> selected; protected boolean selectAll; diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/admin/report/ReportModel.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/admin/report/ReportModel.java index b25ad6b..7e3b30b 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/admin/report/ReportModel.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/admin/report/ReportModel.java @@ -77,7 +77,7 @@ public class ReportModel extends AdminActionModel { protected Report selectedReport; /** les variables utilisées pour le report. */ - protected Map<String, Object> variables; + protected final Map<String, Object> variables; /** le résultat du report actuellement sélectionné */ protected ResultTableModel resultModel; diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/admin/report/ReportUIHandler.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/admin/report/ReportUIHandler.java index 704b093..d69f170 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/admin/report/ReportUIHandler.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/admin/report/ReportUIHandler.java @@ -94,8 +94,8 @@ public class ReportUIHandler extends AdminTabUIHandler { if (log.isDebugEnabled()) { log.debug(" specialized for [" + tabUI.getStep() + - "] for main ui " + ui.getClass().getName() + - "@" + System.identityHashCode(ui)); + "] for main ui " + ui.getClass().getName() + + "@" + System.identityHashCode(ui)); } UIHelper.setLayerUI(tabUI.getContent(), ui.getConfigBlockLayerUI()); @@ -132,6 +132,7 @@ public class ReportUIHandler extends AdminTabUIHandler { }); tabUI.getReportSelector().setRenderer(new DefaultListCellRenderer() { + private static final long serialVersionUID = 1L; @Override public Component getListCellRendererComponent(JList list, Object value, int index, boolean isSelected, boolean cellHasFocus) { @@ -148,7 +149,7 @@ public class ReportUIHandler extends AdminTabUIHandler { // ajout du renderer sur le tableau DefaultTableCellRenderer renderer = new DefaultTableCellRenderer() { - + private static final long serialVersionUID = 1L; Font defaultFont; Font headerFont; @@ -272,7 +273,7 @@ public class ReportUIHandler extends AdminTabUIHandler { if (log.isDebugEnabled()) { log.debug("Will copy result of report " + report.getName()); log.debug("Result dimension : [" + model.getRowCount() + "," + - model.getColumnCount() + "]"); + model.getColumnCount() + "]"); } String content = model.getClipbordContent(copyRowHeaders, copyColumnHeaders); UIHelper.copyToClipBoard(content); diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/admin/save/SaveLocalUIHandler.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/admin/save/SaveLocalUIHandler.java index 5f51ece..8d3bd23 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/admin/save/SaveLocalUIHandler.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/admin/save/SaveLocalUIHandler.java @@ -175,7 +175,7 @@ public class SaveLocalUIHandler extends AdminTabUIHandler { return WizardState.SUCCESSED; } - public void saveUnidirectionalSynchronizeReferential() throws Exception { + public void saveUnidirectionalSynchronizeReferential() { SynchronizeModel stepModel = getModel().getSynchronizeReferentielModel(); diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/admin/validate/ValidateEntityListCellRenderer.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/admin/validate/ValidateEntityListCellRenderer.java index ef137f5..190fcde 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/admin/validate/ValidateEntityListCellRenderer.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/admin/validate/ValidateEntityListCellRenderer.java @@ -22,11 +22,11 @@ package fr.ird.observe.ui.admin.validate; import fr.ird.observe.ObserveSwingApplicationContext; +import fr.ird.observe.application.swing.decoration.DecoratorService; import fr.ird.observe.services.dto.AbstractReference; import fr.ird.observe.services.dto.referential.ReferentialReference; import fr.ird.observe.services.service.actions.validate.ValidateResultForDto; import fr.ird.observe.services.service.actions.validate.ValidateResultForDtos; -import fr.ird.observe.application.swing.decoration.DecoratorService; import org.apache.commons.logging.Log; import org.apache.commons.logging.LogFactory; import org.nuiton.decorator.Decorator; @@ -67,12 +67,11 @@ public class ValidateEntityListCellRenderer extends DefaultListCellRenderer impl @Override public void propertyChange(PropertyChangeEvent evt) { - DecoratorService decoratorService = getService(); Map<?, ?> value = (Map<?, ?>) evt.getNewValue(); if (log.isDebugEnabled()) { log.debug("messages changed : " + - (value == null ? 0 : value.size()) + - ", rebuild render cache"); + (value == null ? 0 : value.size()) + + ", rebuild render cache"); } synchronized (renderCache) { renderCache.clear(); diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/admin/validate/ValidateUIHandler.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/admin/validate/ValidateUIHandler.java index a8818f4..0984941 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/admin/validate/ValidateUIHandler.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/admin/validate/ValidateUIHandler.java @@ -72,7 +72,7 @@ import javax.swing.RowSorter; import javax.swing.SortOrder; import java.io.File; import java.io.IOException; -import java.util.Arrays; +import java.util.Collections; import java.util.Date; import java.util.EnumSet; import java.util.List; @@ -122,7 +122,7 @@ public class ValidateUIHandler extends AdminTabUIHandler { messageTable.setDefaultRenderer(Object.class, new ObserveValidationMessageTableRenderer()); messageTable.getRowSorter().setSortKeys( - Arrays.asList(new RowSorter.SortKey(0, SortOrder.ASCENDING))); + Collections.singletonList(new RowSorter.SortKey(0, SortOrder.ASCENDING))); SwingUtil.setI18nTableHeaderRenderer( messageTable, n("validator.scope.header"), @@ -575,7 +575,7 @@ public class ValidateUIHandler extends AdminTabUIHandler { } public boolean isObjectOperationSelected(Set<AdminStep> objectOperations, JCheckBox checkBox) { - AdminStep scope = getObjectOperation(checkBox); +// AdminStep scope = getObjectOperation(checkBox); return objectOperations.contains(getObjectOperation(checkBox)); } diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/admin/validate/ValidationMessageTableModel.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/admin/validate/ValidationMessageTableModel.java index 26c9e47..2ebbe31 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/admin/validate/ValidationMessageTableModel.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/admin/validate/ValidationMessageTableModel.java @@ -36,13 +36,15 @@ import java.util.List; */ public class ValidationMessageTableModel extends AbstractTableModel { + private static final long serialVersionUID = 1L; + public static final String[] columnNames = {"validator.scope", "validator.field", "validator.message"}; public static final Class<?>[] columnClasses = {NuitonValidatorScope.class, String.class, String.class}; - protected List<ValidationMessage> messages = Lists.newArrayList(); + protected final List<ValidationMessage> messages = Lists.newArrayList(); @Override public int getRowCount() { @@ -88,6 +90,7 @@ public class ValidationMessageTableModel extends AbstractTableModel { break; case 2: value = message.getMessage(); + break; default: value = null; } diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/ContentUI.jaxx b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/ContentUI.jaxx index c2ff287..bfcbbb5 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/ContentUI.jaxx +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/ContentUI.jaxx @@ -91,15 +91,15 @@ public Object getSelectedBean(JList list) { return list.getSelectedValue(); } -public void init() throws Exception { +public void init() { getHandler().initUI(); } -public void open() throws Exception { +public void open() { getHandler().openUI(); } -public boolean close() throws Exception { +public boolean close() { return getHandler().closeUI(); } diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/ContentUIHandler.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/ContentUIHandler.java index 3c657ee..6cbca35 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/ContentUIHandler.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/ContentUIHandler.java @@ -107,7 +107,7 @@ public abstract class ContentUIHandler<E extends IdDto> { private final Icon errorIcon; /** l'interface graphique que le controleur utilise */ - protected ObserveContentUI<E> ui; + protected final ObserveContentUI<E> ui; public static <E extends IdDto> ContentUIHandler<E> newHandler(ObserveContentUI<E> ui) { @@ -283,7 +283,7 @@ public abstract class ContentUIHandler<E extends IdDto> { return result; } - public void initUI() throws Exception { + public void initUI() { final ContentUIInitializer<E, ObserveContentUI<E>> uiInitializer = new ContentUIInitializer<>(ui); uiInitializer.initUI(); @@ -292,7 +292,7 @@ public abstract class ContentUIHandler<E extends IdDto> { } - public void openUI() throws Exception { + public void openUI() { boolean canWrite = computeCanWrite(getDataSource()); @@ -436,7 +436,7 @@ public abstract class ContentUIHandler<E extends IdDto> { } } - public final boolean closeUI() throws Exception { + public final boolean closeUI() { boolean b = checkEdit(ui); if (log.isDebugEnabled()) { log.debug("Can close " + ui.getClass() + " : " + b); @@ -654,7 +654,7 @@ public abstract class ContentUIHandler<E extends IdDto> { } - protected boolean doDelete(E bean) throws Exception { + protected boolean doDelete(E bean) { return false; } @@ -871,7 +871,6 @@ public abstract class ContentUIHandler<E extends IdDto> { updateDataFilterableDoubleList(dtoClass, filterableDoubleList); } - continue; } } diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/ContentUIInitializer.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/ContentUIInitializer.java index 55f23bc..ce76f29 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/ContentUIInitializer.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/ContentUIInitializer.java @@ -195,7 +195,7 @@ public class ContentUIInitializer<E extends IdDto, UI extends ObserveContentUI<E return ui.getModel().getForm(); } - public void initUI() throws Exception { + public void initUI() { if (log.isDebugEnabled()) { log.debug("ui " + getClass()); @@ -290,7 +290,6 @@ public class ContentUIInitializer<E extends IdDto, UI extends ObserveContentUI<E if (o instanceof JTextArea) { init((JTextArea) o); - continue; } } @@ -614,7 +613,7 @@ public class ContentUIInitializer<E extends IdDto, UI extends ObserveContentUI<E ListCellRenderer<? super AbstractReference<D>> renderer = selectedList.getCellRenderer(); selectedList.setCellRenderer(new ReferentielListCellRenderer<>(renderer)); - list.getUniverseList().setCellRenderer(new ReferentielListCellRenderer<>(renderer)); + list.getUniverseList().setCellRenderer(new ReferentielListCellRenderer<>((ListCellRenderer<? super AbstractReference<IdDto>>) renderer)); } @@ -640,7 +639,7 @@ public class ContentUIInitializer<E extends IdDto, UI extends ObserveContentUI<E ListCellRenderer<? super AbstractReference<D>> renderer = selectedList.getCellRenderer(); selectedList.setCellRenderer(new ReferentielListCellRenderer<>(renderer)); - list.getUniverseList().setCellRenderer(new ReferentielListCellRenderer<>(renderer)); + list.getUniverseList().setCellRenderer(new ReferentielListCellRenderer<>((ListCellRenderer<? super AbstractReference<IdDto>>) renderer)); } @@ -660,7 +659,7 @@ public class ContentUIInitializer<E extends IdDto, UI extends ObserveContentUI<E list.putClientProperty("decorator", decorator); - list.init(decorator, Collections.<DataReference<D>>emptyList()); + list.init(decorator, Collections.emptyList()); JList<AbstractReference<D>> list1 = list.getList(); ListCellRenderer<? super AbstractReference<D>> renderer = list1.getCellRenderer(); @@ -684,7 +683,7 @@ public class ContentUIInitializer<E extends IdDto, UI extends ObserveContentUI<E list.putClientProperty("decorator", decorator); - list.init(decorator, Collections.<ReferentialReference<D>>emptyList()); + list.init(decorator, Collections.emptyList()); JList<AbstractReference<D>> list1 = list.getList(); ListCellRenderer<? super AbstractReference<D>> renderer = list1.getCellRenderer(); @@ -702,7 +701,7 @@ public class ContentUIInitializer<E extends IdDto, UI extends ObserveContentUI<E DataReferenceDecorator<D> decorator = decoratorService.getDataReferenceDecorator(dtoClass); - comboBox.init(decorator, Collections.<DataReference<D>>emptyList()); + comboBox.init(decorator, Collections.emptyList()); JComboBox<DataReference<D>> combobox = comboBox.getCombobox(); @@ -724,7 +723,7 @@ public class ContentUIInitializer<E extends IdDto, UI extends ObserveContentUI<E ReferentialReferenceDecorator<D> decorator = decoratorService.getReferentialReferenceDecorator(dtoClass); - comboBox.init(decorator, Collections.<ReferentialReference<D>>emptyList()); + comboBox.init(decorator, Collections.emptyList()); JComboBox<ReferentialReference<D>> combobox = comboBox.getCombobox(); diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/ObserveContentUI.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/ObserveContentUI.java index 4d8cbe6..cd56aea 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/ObserveContentUI.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/ObserveContentUI.java @@ -23,7 +23,6 @@ package fr.ird.observe.ui.content; */ import fr.ird.observe.db.DataContext; - import fr.ird.observe.db.ObserveSwingDataSource; import fr.ird.observe.services.dto.IdDto; import jaxx.runtime.JAXXObject; @@ -57,11 +56,11 @@ public interface ObserveContentUI<E extends IdDto> extends JAXXObject { void setContentIcon(Icon icon); - void init() throws Exception; + void init(); - void open() throws Exception; + void open(); - boolean close() throws Exception; + boolean close(); void stopEdit(); diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/impl/longline/BranchlineUIHandler.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/impl/longline/BranchlineUIHandler.java index b695eb1..309d844 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/impl/longline/BranchlineUIHandler.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/impl/longline/BranchlineUIHandler.java @@ -53,7 +53,7 @@ import java.util.Set; public class BranchlineUIHandler extends ContentUIHandler<BranchlineDto> { /** Logger */ - static private Log log = LogFactory.getLog(BranchlineUIHandler.class); + private static final Log log = LogFactory.getLog(BranchlineUIHandler.class); // Compute valid state of tab from the error table protected final TableModelListener computeTabValidStateListener; @@ -141,7 +141,7 @@ public class BranchlineUIHandler extends ContentUIHandler<BranchlineDto> { } @Override - public void initUI() throws Exception { + public void initUI() { branchlineDecorator = getDecoratorService().getDecoratorByType(BranchlineDto.class); super.initUI(); @@ -149,7 +149,7 @@ public class BranchlineUIHandler extends ContentUIHandler<BranchlineDto> { } @Override - public void openUI() throws Exception { + public void openUI() { if (log.isInfoEnabled()) { log.info("OpenUI: " + getModel()); diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/impl/longline/LonglineDetailCompositionUIHandler.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/impl/longline/LonglineDetailCompositionUIHandler.java index b422328..6cefcfa 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/impl/longline/LonglineDetailCompositionUIHandler.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/impl/longline/LonglineDetailCompositionUIHandler.java @@ -23,7 +23,6 @@ package fr.ird.observe.ui.content.impl.longline; */ import com.google.common.collect.Lists; -import com.google.common.collect.Sets; import fr.ird.observe.ObserveSwingApplicationContext; import fr.ird.observe.db.DataContext; import fr.ird.observe.db.ObserveSwingDataSource; @@ -63,6 +62,7 @@ import java.util.LinkedList; import java.util.List; import java.util.stream.Collectors; +import static com.google.common.collect.Lists.newArrayList; import static org.nuiton.i18n.I18n.t; /** @@ -76,7 +76,7 @@ public class LonglineDetailCompositionUIHandler extends ContentUIHandler<SetLong static final String SECTION_TEMPLATES_EDITOR = "sectionTemplatesEditor"; /** Logger */ - static private Log log = LogFactory.getLog(LonglineDetailCompositionUIHandler.class); + private static final Log log = LogFactory.getLog(LonglineDetailCompositionUIHandler.class); private final PropertyChangeListener sectionTemplatesTableModelModified; @@ -144,7 +144,7 @@ public class LonglineDetailCompositionUIHandler extends ContentUIHandler<SetLong */ private boolean onOpen; - private JVetoableTabbedPane.ChangeSelectedIndex tabbedPaneWillChanged; + private final JVetoableTabbedPane.ChangeSelectedIndex tabbedPaneWillChanged; public LonglineDetailCompositionUIHandler(LonglineDetailCompositionUI ui) { super(ui, DataContextType.ActivityLongline, DataContextType.SetLongline); @@ -270,7 +270,7 @@ public class LonglineDetailCompositionUIHandler extends ContentUIHandler<SetLong } @Override - public void initUI() throws Exception { + public void initUI() { this.sectionDecorator = getDecoratorService().getDecoratorByType(SectionDto.class); this.basketDecorator = getDecoratorService().getDecoratorByType(BasketDto.class); @@ -332,7 +332,7 @@ public class LonglineDetailCompositionUIHandler extends ContentUIHandler<SetLong } @Override - public void openUI() throws Exception { + public void openUI() { UIHelper.stopEditing(getUi().getSectionTemplatesTable()); UIHelper.stopEditing(getUi().getSectionsTable()); @@ -383,7 +383,7 @@ public class LonglineDetailCompositionUIHandler extends ContentUIHandler<SetLong getModel().setCanGenerate(bean.isSectionEmpty()); // TODO Use a cache of templates on setLongline (session scope) - getSectionTemplatesTableModel().setData(Lists.<SectionTemplate>newArrayList()); + getSectionTemplatesTableModel().setData(new ArrayList<>()); BranchlineUI branchlineDetailUI = getUi().getBranchlineDetailUI(); branchlineDetailUI.edit(null); @@ -564,8 +564,8 @@ public class LonglineDetailCompositionUIHandler extends ContentUIHandler<SetLong sectionsTableModel.setData(sections); List<SectionDto> sectionDtos = sections.stream() - .map(SectionWithTemplate::getDelegate) - .collect(Collectors.toList()); + .map(SectionWithTemplate::getDelegate) + .collect(Collectors.toList()); getBean().addAllSection(sectionDtos); @@ -611,7 +611,7 @@ public class LonglineDetailCompositionUIHandler extends ContentUIHandler<SetLong t("observe.sections.delete.message"), JOptionPane.WARNING_MESSAGE, new Object[]{t("observe.choice.confirm.delete"), - t("observe.choice.cancel")}, + t("observe.choice.cancel")}, 1); if (response != 0) { @@ -628,7 +628,7 @@ public class LonglineDetailCompositionUIHandler extends ContentUIHandler<SetLong try { - getSectionsTableModel().setData(Lists.<SectionWithTemplate>newArrayList()); + getSectionsTableModel().setData(new ArrayList<>()); getBean().getSection().clear(); getModel().setModified(true); @@ -660,7 +660,7 @@ public class LonglineDetailCompositionUIHandler extends ContentUIHandler<SetLong t("observe.sectionTemplate.delete.message"), JOptionPane.WARNING_MESSAGE, new Object[]{t("observe.choice.confirm.delete"), - t("observe.choice.cancel")}, + t("observe.choice.cancel")}, 1); if (response != 0) { @@ -737,7 +737,7 @@ public class LonglineDetailCompositionUIHandler extends ContentUIHandler<SetLong SectionWithTemplate newSectionWithTemplate = tableModel.getSelectedRow(); int selectedRowIndex = tableModel.getSelectedRowIndex(); - List<SectionDto> sections = Lists.newArrayList(getBean().getSection()); + List<SectionDto> sections = newArrayList(getBean().getSection()); sections.add(selectedRowIndex, newSectionWithTemplate.getDelegate()); getBean().getSection().clear(); getBean().addAllSection(sections); @@ -762,7 +762,7 @@ public class LonglineDetailCompositionUIHandler extends ContentUIHandler<SetLong SectionWithTemplate newSectionWithTemplate = tableModel.getSelectedRow(); int selectedRowIndex = tableModel.getSelectedRowIndex(); - List<SectionDto> sections = Lists.newArrayList(getBean().getSection()); + List<SectionDto> sections = newArrayList(getBean().getSection()); sections.add(selectedRowIndex, newSectionWithTemplate.getDelegate()); getBean().getSection().clear(); getBean().addAllSection(sections); @@ -842,9 +842,9 @@ public class LonglineDetailCompositionUIHandler extends ContentUIHandler<SetLong int selectedRowIndex = tableModel.getSelectedRowIndex(); SectionWithTemplate selectedSection = getSectionsTableModel().getSelectedRow(); if (selectedSection.isBasketEmpty()) { - selectedSection.setBasket(Sets.<BasketDto>newLinkedHashSet()); + selectedSection.setBasket(new LinkedHashSet<>()); } - List<BasketDto> baskets = Lists.newArrayList(selectedSection.getBasket()); + List<BasketDto> baskets = newArrayList(selectedSection.getBasket()); baskets.add(selectedRowIndex, newBasket); selectedSection.getBasket().clear(); selectedSection.addAllBasket(baskets); @@ -871,9 +871,9 @@ public class LonglineDetailCompositionUIHandler extends ContentUIHandler<SetLong int selectedRowIndex = tableModel.getSelectedRowIndex(); SectionWithTemplate selectedSection = getSectionsTableModel().getSelectedRow(); if (selectedSection.isBasketEmpty()) { - selectedSection.setBasket(Sets.<BasketDto>newLinkedHashSet()); + selectedSection.setBasket(new LinkedHashSet<>()); } - List<BasketDto> baskets = Lists.newArrayList(selectedSection.getBasket()); + List<BasketDto> baskets = newArrayList(selectedSection.getBasket()); baskets.add(selectedRowIndex, newBasket); selectedSection.getBasket().clear(); selectedSection.addAllBasket(baskets); @@ -951,10 +951,10 @@ public class LonglineDetailCompositionUIHandler extends ContentUIHandler<SetLong int selectedRowIndex = tableModel.getSelectedRowIndex(); BasketDto selectedBasket = getBasketsTableModel().getSelectedRow(); if (selectedBasket.isBranchlineEmpty()) { - selectedBasket.setBranchline(Sets.<BranchlineDto>newLinkedHashSet()); + selectedBasket.setBranchline(new LinkedHashSet<>()); } - List<BranchlineDto> branchlines = Lists.newArrayList(selectedBasket.getBranchline()); + List<BranchlineDto> branchlines = newArrayList(selectedBasket.getBranchline()); branchlines.add(selectedRowIndex, newBranchline); selectedBasket.getBranchline().clear(); selectedBasket.addAllBranchline(branchlines); @@ -981,9 +981,9 @@ public class LonglineDetailCompositionUIHandler extends ContentUIHandler<SetLong int selectedRowIndex = tableModel.getSelectedRowIndex(); BasketDto selectedBasket = getBasketsTableModel().getSelectedRow(); if (selectedBasket.isBranchlineEmpty()) { - selectedBasket.setBranchline(Sets.<BranchlineDto>newLinkedHashSet()); + selectedBasket.setBranchline(new LinkedHashSet<>()); } - List<BranchlineDto> branchlines = Lists.newArrayList(selectedBasket.getBranchline()); + List<BranchlineDto> branchlines = newArrayList(selectedBasket.getBranchline()); branchlines.add(selectedRowIndex, newBranchline); selectedBasket.getBranchline().clear(); selectedBasket.addAllBranchline(branchlines); @@ -1059,7 +1059,7 @@ public class LonglineDetailCompositionUIHandler extends ContentUIHandler<SetLong } - List<BasketDto> baskets = newSection == null ? Lists.<BasketDto>newArrayList() : Lists.newArrayList(newSection.getBasket()); + List<BasketDto> baskets = newSection == null ? new ArrayList<>() : newArrayList(newSection.getBasket()); getBasketsTableModel().setData(baskets); } finally { diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/impl/longline/LonglineDetailCompositionUIInitializer.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/impl/longline/LonglineDetailCompositionUIInitializer.java index 92d185e..25cf484 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/impl/longline/LonglineDetailCompositionUIInitializer.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/impl/longline/LonglineDetailCompositionUIInitializer.java @@ -57,7 +57,7 @@ public class LonglineDetailCompositionUIInitializer extends ContentUIInitializer } @Override - public void initUI() throws Exception { + public void initUI() { super.initUI(); LonglineDetailCompositionUIModel model = ui.getModel(); @@ -107,7 +107,7 @@ public class LonglineDetailCompositionUIInitializer extends ContentUIInitializer Decorator<SectionTemplate> sectionTemplateDecorator = decoratorService.getDecoratorByType(SectionTemplate.class); JComboBox comboBox = new JComboBox(); table.putClientProperty(LonglineDetailCompositionUIHandler.SECTION_TEMPLATES_EDITOR, comboBox); - ComboBoxCellEditor editor = newDataColumnEditor(comboBox, Collections.<SectionTemplate>emptyList(), sectionTemplateDecorator); + ComboBoxCellEditor editor = newDataColumnEditor(comboBox, Collections.emptyList(), sectionTemplateDecorator); UIHelper.setTableColumnEditor(table, 2, editor); SectionsTableModel tableModel = model.getSectionsTableModel(); diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/impl/longline/LonglineDetailCompositionUIValidationHelper.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/impl/longline/LonglineDetailCompositionUIValidationHelper.java index ef26032..1c2061d 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/impl/longline/LonglineDetailCompositionUIValidationHelper.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/impl/longline/LonglineDetailCompositionUIValidationHelper.java @@ -382,7 +382,7 @@ public class LonglineDetailCompositionUIValidationHelper { public void addMessage(SwingValidator validator, NuitonValidatorScope scope, String field, String messageToAdd) { - String propertyLabel = decoratorService.getPropertyLabel(field); + String propertyLabel = DecoratorService.getPropertyLabel(field); SwingValidatorMessage message = new SwingValidatorMessage( validator, contextLabel + " - " + t(propertyLabel), diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/impl/longline/LonglineGlobalCompositionUIHandler.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/impl/longline/LonglineGlobalCompositionUIHandler.java index 41f46fd..1eb5212 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/impl/longline/LonglineGlobalCompositionUIHandler.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/impl/longline/LonglineGlobalCompositionUIHandler.java @@ -57,7 +57,7 @@ import static org.nuiton.i18n.I18n.t; public class LonglineGlobalCompositionUIHandler extends ContentUIHandler<SetLonglineGlobalCompositionDto> { /** Logger */ - static private Log log = LogFactory.getLog(LonglineGlobalCompositionUIHandler.class); + private static final Log log = LogFactory.getLog(LonglineGlobalCompositionUIHandler.class); public LonglineGlobalCompositionUIHandler(LonglineGlobalCompositionUI ui) { super(ui, DataContextType.ActivityLongline, DataContextType.SetLongline); @@ -93,7 +93,7 @@ public class LonglineGlobalCompositionUIHandler extends ContentUIHandler<SetLong } @Override - public void initUI() throws Exception { + public void initUI() { super.initUI(); { // init floatlinesComposition tab @@ -130,7 +130,7 @@ public class LonglineGlobalCompositionUIHandler extends ContentUIHandler<SetLong } @Override - public void openUI() throws Exception { + public void openUI() { super.openUI(); String activityId = getSelectedParentId(); diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/impl/longline/SetLonglineUIHandler.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/impl/longline/SetLonglineUIHandler.java index dc8d10a..62b3347 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/impl/longline/SetLonglineUIHandler.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/impl/longline/SetLonglineUIHandler.java @@ -64,7 +64,7 @@ import static org.nuiton.i18n.I18n.t; public class SetLonglineUIHandler extends ContentUIHandler<SetLonglineDto> { /** Logger */ - static private Log log = LogFactory.getLog(SetLonglineUIHandler.class); + private static final Log log = LogFactory.getLog(SetLonglineUIHandler.class); // Compute valid state of tab from the error table protected final TableModelListener computeTabValidStateListener; @@ -154,7 +154,7 @@ public class SetLonglineUIHandler extends ContentUIHandler<SetLonglineDto> { } @Override - public void initUI() throws Exception { + public void initUI() { super.initUI(); @@ -174,7 +174,7 @@ public class SetLonglineUIHandler extends ContentUIHandler<SetLonglineDto> { @Override - public void openUI() throws Exception { + public void openUI() { getUi().getSettingStartCoordinates().resetModel(); getUi().getSettingEndCoordinates().resetModel(); @@ -372,7 +372,7 @@ public class SetLonglineUIHandler extends ContentUIHandler<SetLonglineDto> { } @Override - protected boolean doDelete(SetLonglineDto bean) throws Exception { + protected boolean doDelete(SetLonglineDto bean) { if (askToDelete(bean)) { return false; diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/impl/seine/ActivitySeineObservedSystemUIHandler.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/impl/seine/ActivitySeineObservedSystemUIHandler.java index 4c0f636..a4d2e79 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/impl/seine/ActivitySeineObservedSystemUIHandler.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/impl/seine/ActivitySeineObservedSystemUIHandler.java @@ -44,7 +44,7 @@ import static org.nuiton.i18n.I18n.t; public class ActivitySeineObservedSystemUIHandler extends ContentUIHandler<ActivitySeineObservedSystemDto> { /** Logger */ - static private Log log = LogFactory.getLog(ActivitySeineObservedSystemUIHandler.class); + private static final Log log = LogFactory.getLog(ActivitySeineObservedSystemUIHandler.class); public ActivitySeineObservedSystemUIHandler(ActivitySeineObservedSystemUI ui) { super(ui, DataContextType.ActivitySeine, null); @@ -76,7 +76,7 @@ public class ActivitySeineObservedSystemUIHandler extends ContentUIHandler<Activ } @Override - public void openUI() throws Exception { + public void openUI() { super.openUI(); String activityId = getSelectedParentId(); diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/impl/seine/ActivitySeineObservedSystemUIModel.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/impl/seine/ActivitySeineObservedSystemUIModel.java index 1cf900c..6f10c45 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/impl/seine/ActivitySeineObservedSystemUIModel.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/impl/seine/ActivitySeineObservedSystemUIModel.java @@ -22,10 +22,8 @@ package fr.ird.observe.ui.content.impl.seine; * #L% */ -import fr.ird.observe.ObserveSwingBinderService; import fr.ird.observe.services.dto.seine.ActivitySeineObservedSystemDto; import fr.ird.observe.ui.content.ContentUIModel; -import org.nuiton.util.beans.BinderModelBuilder; /** * Created on 9/28/14. diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/impl/seine/FloatingObjectTransmittingBuoyOperationUIHandler.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/impl/seine/FloatingObjectTransmittingBuoyOperationUIHandler.java index f6bfced..618ef5f 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/impl/seine/FloatingObjectTransmittingBuoyOperationUIHandler.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/impl/seine/FloatingObjectTransmittingBuoyOperationUIHandler.java @@ -61,7 +61,7 @@ import static org.nuiton.i18n.I18n.t; public class FloatingObjectTransmittingBuoyOperationUIHandler extends ContentUIHandler<FloatingObjectTransmittingBuoyDto> { /** Logger */ - static private Log log = LogFactory.getLog(FloatingObjectTransmittingBuoyOperationUIHandler.class); + private static final Log log = LogFactory.getLog(FloatingObjectTransmittingBuoyOperationUIHandler.class); public FloatingObjectTransmittingBuoyOperationUIHandler(FloatingObjectTransmittingBuoyOperationUI ui) { super(ui, DataContextType.FloatingObject, null); @@ -101,7 +101,7 @@ public class FloatingObjectTransmittingBuoyOperationUIHandler extends ContentUIH } @Override - public void openUI() throws Exception { + public void openUI() { super.openUI(); ContentMode mode = computeContentMode(); @@ -347,7 +347,7 @@ public class FloatingObjectTransmittingBuoyOperationUIHandler extends ContentUIH FloatingObjectTransmittingBuoyDto bean = getBean(); if (bean.getTransmittingBuoy() == null) { - bean.setTransmittingBuoy(Lists.<TransmittingBuoyDto>newArrayList()); + bean.setTransmittingBuoy(Lists.newArrayList()); } bean.getTransmittingBuoy().add(editBean); } diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/impl/seine/FloatingObjectUIHandler.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/impl/seine/FloatingObjectUIHandler.java index 425303c..9e51cbc 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/impl/seine/FloatingObjectUIHandler.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/impl/seine/FloatingObjectUIHandler.java @@ -50,7 +50,7 @@ import static org.nuiton.i18n.I18n.t; public class FloatingObjectUIHandler extends ContentUIHandler<FloatingObjectDto> { /** Logger */ - static private Log log = LogFactory.getLog(FloatingObjectUIHandler.class); + private static final Log log = LogFactory.getLog(FloatingObjectUIHandler.class); public FloatingObjectUIHandler(FloatingObjectUI ui) { super(ui, DataContextType.ActivitySeine, DataContextType.FloatingObject); @@ -96,7 +96,7 @@ public class FloatingObjectUIHandler extends ContentUIHandler<FloatingObjectDto> } @Override - public void openUI() throws Exception { + public void openUI() { super.openUI(); String activityId = getSelectedParentId(); @@ -205,7 +205,7 @@ public class FloatingObjectUIHandler extends ContentUIHandler<FloatingObjectDto> } @Override - protected boolean doDelete(FloatingObjectDto bean) throws Exception { + protected boolean doDelete(FloatingObjectDto bean) { if (askToDelete(bean)) { return false; diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/impl/seine/SetSeineUIHandler.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/impl/seine/SetSeineUIHandler.java index 4611e2c..bf32e9a 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/impl/seine/SetSeineUIHandler.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/impl/seine/SetSeineUIHandler.java @@ -65,7 +65,7 @@ import static org.nuiton.i18n.I18n.t; public class SetSeineUIHandler extends ContentUIHandler<SetSeineDto> { /** Logger */ - static private Log log = LogFactory.getLog(SetSeineUIHandler.class); + private static final Log log = LogFactory.getLog(SetSeineUIHandler.class); // Compute valid state of tab from the error table protected final TableModelListener computeTabValidStateListener; @@ -132,7 +132,7 @@ public class SetSeineUIHandler extends ContentUIHandler<SetSeineDto> { } @Override - public void initUI() throws Exception { + public void initUI() { super.initUI(); @@ -148,7 +148,7 @@ public class SetSeineUIHandler extends ContentUIHandler<SetSeineDto> { } @Override - public void openUI() throws Exception { + public void openUI() { super.openUI(); String activityId = getSelectedParentId(); @@ -280,7 +280,7 @@ public class SetSeineUIHandler extends ContentUIHandler<SetSeineDto> { } } - protected boolean doDelete(SetSeineDto bean) throws Exception { + protected boolean doDelete(SetSeineDto bean) { if (askToDelete(bean)) { return false; diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/list/ContentListUIHandler.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/list/ContentListUIHandler.java index 6581a0e..24184b0 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/list/ContentListUIHandler.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/list/ContentListUIHandler.java @@ -57,7 +57,7 @@ import static org.nuiton.i18n.I18n.t; public abstract class ContentListUIHandler<E extends IdDto, C extends DataDto> extends ContentUIHandler<E> { /** Logger */ - static private Log log = LogFactory.getLog(ContentListUIHandler.class); + private static final Log log = LogFactory.getLog(ContentListUIHandler.class); public ContentListUIHandler(ContentListUI<E, C> ui, DataContextType parentType, @@ -90,7 +90,7 @@ public abstract class ContentListUIHandler<E extends IdDto, C extends DataDto> e } @Override - public void initUI() throws Exception { + public void initUI() { super.initUI(); // on installe un renderer sur la liste pour afficher les couleurs + @@ -98,14 +98,13 @@ public abstract class ContentListUIHandler<E extends IdDto, C extends DataDto> e ListCellRenderer renderer = getUi().getList().getCellRenderer(); ObserveTreeHelper treeHelper = getTreeHelper(getUi()); - ListCellRenderer renderer2 = - new EntityListCellRenderer(renderer, treeHelper); + ListCellRenderer renderer2 = new EntityListCellRenderer(renderer, treeHelper); getUi().getList().setCellRenderer(renderer2); } @Override - public final void openUI() throws Exception { + public final void openUI() { super.openUI(); @@ -205,11 +204,11 @@ public abstract class ContentListUIHandler<E extends IdDto, C extends DataDto> e private static final long serialVersionUID = 1L; - protected ListCellRenderer delegate; + protected final transient ListCellRenderer delegate; - protected ObserveTreeHelper treeHelper; + protected final transient ObserveTreeHelper treeHelper; - protected AbstractObserveTreeCellRenderer treeRenderer; + protected final AbstractObserveTreeCellRenderer treeRenderer; protected ObserveNode containerNode; @@ -217,7 +216,7 @@ public abstract class ContentListUIHandler<E extends IdDto, C extends DataDto> e ObserveTreeHelper treeHelper) { this.delegate = delegate; this.treeHelper = treeHelper; - treeRenderer = treeHelper.getTreeCellRenderer(); + this.treeRenderer = treeHelper.getTreeCellRenderer(); } public void init() { diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/list/impl/longline/ActivityLonglinesUIHandler.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/list/impl/longline/ActivityLonglinesUIHandler.java index 11e6a09..5ed8f08 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/list/impl/longline/ActivityLonglinesUIHandler.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/list/impl/longline/ActivityLonglinesUIHandler.java @@ -49,7 +49,7 @@ import static org.nuiton.i18n.I18n.n; public class ActivityLonglinesUIHandler extends ContentListUIHandler<TripLonglineDto, ActivityLonglineDto> { /** Logger */ - static private Log log = LogFactory.getLog(ActivityLonglinesUIHandler.class); + private static final Log log = LogFactory.getLog(ActivityLonglinesUIHandler.class); public ActivityLonglinesUIHandler(ActivityLonglinesUI ui) { super(ui, DataContextType.TripLongline, DataContextType.ActivityLongline); diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/list/impl/seine/ActivitySeinesUIHandler.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/list/impl/seine/ActivitySeinesUIHandler.java index 36c54fe..d1b9adb 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/list/impl/seine/ActivitySeinesUIHandler.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/list/impl/seine/ActivitySeinesUIHandler.java @@ -46,7 +46,7 @@ import static org.nuiton.i18n.I18n.n; public class ActivitySeinesUIHandler extends ContentListUIHandler<RouteDto, ActivitySeineDto> { /** Logger */ - static private Log log = LogFactory.getLog(ActivitySeinesUIHandler.class); + private static final Log log = LogFactory.getLog(ActivitySeinesUIHandler.class); public ActivitySeinesUIHandler(ActivitySeinesUI ui) { super(ui, DataContextType.Route, DataContextType.ActivitySeine); diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/list/impl/seine/RoutesUIHandler.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/list/impl/seine/RoutesUIHandler.java index f68f479..852a727 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/list/impl/seine/RoutesUIHandler.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/list/impl/seine/RoutesUIHandler.java @@ -46,7 +46,7 @@ import static org.nuiton.i18n.I18n.n; public class RoutesUIHandler extends ContentListUIHandler<TripSeineDto, RouteDto> { /** Logger */ - static private Log log = LogFactory.getLog(RoutesUIHandler.class); + private static final Log log = LogFactory.getLog(RoutesUIHandler.class); public RoutesUIHandler(RoutesUI ui) { super(ui, DataContextType.TripSeine, DataContextType.Route); diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/open/impl/longline/ActivityLonglineUIHandler.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/open/impl/longline/ActivityLonglineUIHandler.java index c4aba45..6f3f2d3 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/open/impl/longline/ActivityLonglineUIHandler.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/open/impl/longline/ActivityLonglineUIHandler.java @@ -52,7 +52,7 @@ import static org.nuiton.i18n.I18n.t; public class ActivityLonglineUIHandler extends ContentOpenableUIHandler<ActivityLonglineDto> { /** Logger */ - static private Log log = LogFactory.getLog(ActivityLonglineUIHandler.class); + private static final Log log = LogFactory.getLog(ActivityLonglineUIHandler.class); static { @@ -142,14 +142,14 @@ public class ActivityLonglineUIHandler extends ContentOpenableUIHandler<Activity } // @Override -// public void initUI() throws Exception { +// public void initUI() { // super.initUI(); // getBean().removePropertyChangeListener(logCoordinatesChanges); // getBean().addPropertyChangeListener(logCoordinatesChanges); // } @Override - public void openUI() throws Exception { + public void openUI() { super.openUI(); getUi().getCoordinatesEditor().resetModel(); @@ -280,7 +280,7 @@ public class ActivityLonglineUIHandler extends ContentOpenableUIHandler<Activity } @Override - protected boolean doDelete(ActivityLonglineDto bean) throws Exception { + protected boolean doDelete(ActivityLonglineDto bean) { if (askToDelete(bean)) { return false; diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/open/impl/longline/TripLonglineUIHandler.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/open/impl/longline/TripLonglineUIHandler.java index 113daa5..ed4a126 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/open/impl/longline/TripLonglineUIHandler.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/open/impl/longline/TripLonglineUIHandler.java @@ -89,7 +89,7 @@ public class TripLonglineUIHandler extends ContentOpenableUIHandler<TripLongline } @Override - public void initUI() throws Exception { + public void initUI() { super.initUI(); TripLonglineUI ui = getUi(); @@ -126,7 +126,7 @@ public class TripLonglineUIHandler extends ContentOpenableUIHandler<TripLongline } @Override - public void openUI() throws Exception { + public void openUI() { super.openUI(); ContentMode mode = computeContentMode(); @@ -297,7 +297,7 @@ public class TripLonglineUIHandler extends ContentOpenableUIHandler<TripLongline } @Override - protected boolean doDelete(TripLonglineDto bean) throws Exception { + protected boolean doDelete(TripLonglineDto bean) { if (askToDelete(bean)) { return false; diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/open/impl/seine/ActivitySeineUIHandler.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/open/impl/seine/ActivitySeineUIHandler.java index 4e52fbd..822d36c 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/open/impl/seine/ActivitySeineUIHandler.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/open/impl/seine/ActivitySeineUIHandler.java @@ -56,7 +56,7 @@ import static org.nuiton.i18n.I18n.t; public class ActivitySeineUIHandler extends ContentOpenableUIHandler<ActivitySeineDto> { /** Logger */ - static private Log log = LogFactory.getLog(ActivitySeineUIHandler.class); + private static final Log log = LogFactory.getLog(ActivitySeineUIHandler.class); // Compute valid state of tab from the error table protected final TableModelListener computeTabValidStateListener; @@ -157,7 +157,7 @@ public class ActivitySeineUIHandler extends ContentOpenableUIHandler<ActivitySei } @Override - public void initUI() throws Exception { + public void initUI() { super.initUI(); @@ -171,7 +171,7 @@ public class ActivitySeineUIHandler extends ContentOpenableUIHandler<ActivitySei } @Override - public void openUI() throws Exception { + public void openUI() { super.openUI(); getUi().getCoordinatesEditor().resetModel(); @@ -308,7 +308,7 @@ public class ActivitySeineUIHandler extends ContentOpenableUIHandler<ActivitySei } @Override - protected boolean doDelete(ActivitySeineDto bean) throws Exception { + protected boolean doDelete(ActivitySeineDto bean) { if (askToDelete(bean)) { return false; diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/open/impl/seine/RouteUIHandler.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/open/impl/seine/RouteUIHandler.java index fa3fa38..f57e9ea 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/open/impl/seine/RouteUIHandler.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/open/impl/seine/RouteUIHandler.java @@ -58,7 +58,7 @@ public class RouteUIHandler extends ContentOpenableUIHandler<RouteDto> { public static final String UPDATE_MAREE_NODE = "updateTripNode"; /** Logger */ - static private Log log = LogFactory.getLog(RouteUIHandler.class); + private static final Log log = LogFactory.getLog(RouteUIHandler.class); public RouteUIHandler(RouteUI ui) { super(ui, @@ -110,7 +110,7 @@ public class RouteUIHandler extends ContentOpenableUIHandler<RouteDto> { } @Override - public void openUI() throws Exception { + public void openUI() { super.openUI(); @@ -243,7 +243,7 @@ public class RouteUIHandler extends ContentOpenableUIHandler<RouteDto> { } @Override - protected boolean doDelete(RouteDto bean) throws Exception { + protected boolean doDelete(RouteDto bean) { if (askToDelete(bean)) { return false; diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/open/impl/seine/TripSeineUIHandler.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/open/impl/seine/TripSeineUIHandler.java index b466d5b..1a15566 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/open/impl/seine/TripSeineUIHandler.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/open/impl/seine/TripSeineUIHandler.java @@ -87,7 +87,7 @@ public class TripSeineUIHandler extends ContentOpenableUIHandler<TripSeineDto> { } @Override - public void initUI() throws Exception { + public void initUI() { super.initUI(); TripSeineUI ui = getUi(); @@ -124,7 +124,7 @@ public class TripSeineUIHandler extends ContentOpenableUIHandler<TripSeineDto> { } @Override - public void openUI() throws Exception { + public void openUI() { super.openUI(); ContentMode mode = computeContentMode(); @@ -295,7 +295,7 @@ public class TripSeineUIHandler extends ContentOpenableUIHandler<TripSeineDto> { } @Override - protected boolean doDelete(TripSeineDto bean) throws Exception { + protected boolean doDelete(TripSeineDto bean) { if (askToDelete(bean)) { return false; diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/ref/ContentReferenceUIHandler.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/ref/ContentReferenceUIHandler.java index f8d412d..e837fef 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/ref/ContentReferenceUIHandler.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/ref/ContentReferenceUIHandler.java @@ -415,7 +415,7 @@ public class ContentReferenceUIHandler<E extends ReferentialDto> extends Content } @Override - public void initUI() throws Exception { + public void initUI() { uiInitializer.initUI(); @@ -428,7 +428,7 @@ public class ContentReferenceUIHandler<E extends ReferentialDto> extends Content } @Override - public void openUI() throws Exception { + public void openUI() { super.openUI(); ContentReferenceUIModel<E> model = getModel(); @@ -732,7 +732,7 @@ public class ContentReferenceUIHandler<E extends ReferentialDto> extends Content } @Override - protected boolean doDelete(E bean) throws Exception { + protected boolean doDelete(E bean) { ContentReferenceUI<E> ui = getUi(); ContentReferenceUIModel<E> model = getModel(); diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/ref/UniqueKeyTableModel.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/ref/UniqueKeyTableModel.java index adfa54d..8775dd5 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/ref/UniqueKeyTableModel.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/ref/UniqueKeyTableModel.java @@ -40,9 +40,9 @@ public class UniqueKeyTableModel extends AbstractTableModel { private static final long serialVersionUID = 1L; - protected String[] columns; + protected final String[] columns; - protected List<Object[]> datas; + protected final List<Object[]> datas; protected transient DecoratorService decoratorService; @@ -82,6 +82,6 @@ public class UniqueKeyTableModel extends AbstractTableModel { @Override public String getColumnName(int column) { String property = columns[column]; - return t(getDecoratorService().getPropertyLabel(property)); + return t(DecoratorService.getPropertyLabel(property)); } } diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/ref/impl/GearUIHandler.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/ref/impl/GearUIHandler.java index 1670939..599803b 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/ref/impl/GearUIHandler.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/ref/impl/GearUIHandler.java @@ -56,7 +56,7 @@ public class GearUIHandler extends ContentReferenceUIHandler<GearDto> { } @Override - public void initUI() throws Exception { + public void initUI() { super.initUI(); diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/ref/impl/LengthWeightParameterUIHandler.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/ref/impl/LengthWeightParameterUIHandler.java index 02321e3..f3cb36c 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/ref/impl/LengthWeightParameterUIHandler.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/ref/impl/LengthWeightParameterUIHandler.java @@ -56,7 +56,7 @@ public class LengthWeightParameterUIHandler extends ContentReferenceUIHandler<Le } @Override - public void initUI() throws Exception { + public void initUI() { super.initUI(); diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/ref/impl/ProgramUIHandler.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/ref/impl/ProgramUIHandler.java index 8b66371..d45819b 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/ref/impl/ProgramUIHandler.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/ref/impl/ProgramUIHandler.java @@ -56,7 +56,7 @@ public class ProgramUIHandler extends ContentReferenceUIHandler<ProgramDto> { } @Override - public void initUI() throws Exception { + public void initUI() { super.initUI(); diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/ref/impl/SpeciesListUIHandler.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/ref/impl/SpeciesListUIHandler.java index a2e36e9..2951983 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/ref/impl/SpeciesListUIHandler.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/ref/impl/SpeciesListUIHandler.java @@ -56,7 +56,7 @@ public class SpeciesListUIHandler extends ContentReferenceUIHandler<SpeciesListD } @Override - public void initUI() throws Exception { + public void initUI() { super.initUI(); diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/ref/impl/SpeciesUIHandler.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/ref/impl/SpeciesUIHandler.java index 5e33dbc..1928b3a 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/ref/impl/SpeciesUIHandler.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/ref/impl/SpeciesUIHandler.java @@ -56,7 +56,7 @@ public class SpeciesUIHandler extends ContentReferenceUIHandler<SpeciesDto> { } @Override - public void initUI() throws Exception { + public void initUI() { super.initUI(); diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/ref/impl/VesselUIHandler.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/ref/impl/VesselUIHandler.java index 593d502..f00cb0e 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/ref/impl/VesselUIHandler.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/ref/impl/VesselUIHandler.java @@ -56,7 +56,7 @@ public class VesselUIHandler extends ContentReferenceUIHandler<VesselDto> { } @Override - public void initUI() throws Exception { + public void initUI() { super.initUI(); diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/ContentTableMeta.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/ContentTableMeta.java index 100bb68..0dcdecd 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/ContentTableMeta.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/ContentTableMeta.java @@ -25,6 +25,8 @@ import com.google.common.base.Preconditions; import com.google.common.base.Predicate; import com.google.common.base.Predicates; import com.google.common.collect.Iterables; +import org.apache.commons.logging.Log; +import org.apache.commons.logging.LogFactory; import org.nuiton.util.ObjectUtil; import org.nuiton.util.beans.BeanUtil; @@ -42,20 +44,23 @@ import java.util.Set; */ public class ContentTableMeta<B> implements Serializable { + /** Logger. */ + private static final Log log = LogFactory.getLog(ContentTableMeta.class); + private static final long serialVersionUID = 1L; /** le lastName de la meta (c'est le nom de la colonne) */ - protected String name; + protected final String name; /** le type de la meta (c'estle type de la colonne) */ - protected Class<B> klass; + protected final Class<B> klass; /** * un drapeau pour savoir si on peut modifier cette méta lorsque l'objet * encapsulé existe déjà en base (pour pouvoir gérer les clefs métiers non * mutable) */ - protected boolean unmodiableWhenExisting; + protected final boolean unmodiableWhenExisting; /** * le descripteur de la méta (pour pouvoir récupérer et modifier la @@ -69,9 +74,8 @@ public class ContentTableMeta<B> implements Serializable { this.name = name; this.klass = klass; this.unmodiableWhenExisting = unmodiableWhenExisting; - if (ContentTableModel.log.isDebugEnabled()) { - ContentTableModel.log.debug(this + " : " + name + " : " + - getType().getName()); + if (log.isDebugEnabled()) { + log.debug(this + " : " + name + " : " + getType().getName()); } } diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/ContentTableModel.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/ContentTableModel.java index 3a18e97..5a41382 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/ContentTableModel.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/ContentTableModel.java @@ -92,7 +92,7 @@ public abstract class ContentTableModel<P extends IdDto, B extends IdDto> extend private static final long serialVersionUID = 1L; /** Logger */ - protected static Log log = LogFactory.getLog(ContentTableModel.class); + private static final Log log = LogFactory.getLog(ContentTableModel.class); /** la liste des métas du modèle */ protected final List<ContentTableMeta<B>> metas; diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/ContentTableUIHandler.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/ContentTableUIHandler.java index 86764d1..c582d6c 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/ContentTableUIHandler.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/ContentTableUIHandler.java @@ -69,7 +69,7 @@ import static org.nuiton.i18n.I18n.t; public abstract class ContentTableUIHandler<E extends IdDto, D extends IdDto> extends ContentUIHandler<E> { /** Logger */ - private static Log log = LogFactory.getLog(ContentTableUIHandler.class); + private static final Log log = LogFactory.getLog(ContentTableUIHandler.class); protected ContentTableUIHandler(ObserveContentTableUI<E, D> ui, DataContextType dataContextType) { super(ui, dataContextType, null); @@ -244,7 +244,7 @@ public abstract class ContentTableUIHandler<E extends IdDto, D extends IdDto> ex // } @Override - public void initUI() throws Exception { + public void initUI() { final ContentTableUIInitializer<E, D, ObserveContentTableUI<E, D>> uiInitializer = new ContentTableUIInitializer<>(getUi()); @@ -255,7 +255,7 @@ public abstract class ContentTableUIHandler<E extends IdDto, D extends IdDto> ex } @Override - public void openUI() throws Exception { + public void openUI() { super.openUI(); diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/ContentTableUIInitializer.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/ContentTableUIInitializer.java index 4b3cf1a..1e47a6d 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/ContentTableUIInitializer.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/ContentTableUIInitializer.java @@ -76,7 +76,7 @@ public class ContentTableUIInitializer<E extends IdDto, D extends IdDto, UI exte } @Override - public void initUI() throws Exception { + public void initUI() { super.initUI(); diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/ContentTableUIModel.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/ContentTableUIModel.java index ea1a42c..778a655 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/ContentTableUIModel.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/ContentTableUIModel.java @@ -53,7 +53,7 @@ public abstract class ContentTableUIModel<E extends IdDto, D extends IdDto> exte private static final long serialVersionUID = 1L; /** Logger */ - private static Log log = LogFactory.getLog(ContentTableUIModel.class); + private static final Log log = LogFactory.getLog(ContentTableUIModel.class); protected final Class<D> childType; @@ -61,7 +61,7 @@ public abstract class ContentTableUIModel<E extends IdDto, D extends IdDto> exte protected final String[] childProperties; - private final ListSelectionModel selectionModel; + private final transient ListSelectionModel selectionModel; protected D tableEditBean; @@ -157,15 +157,14 @@ public abstract class ContentTableUIModel<E extends IdDto, D extends IdDto> exte } public final D newTableEditBean() { - D result = null; try { - result = getChildType().getConstructor().newInstance(); + + D result = getChildType().getConstructor().newInstance(); + return result; } catch (Exception ex) { throw new RuntimeException(ex); - } finally { - return result; } } diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/longline/BaitsCompositionUIHandler.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/longline/BaitsCompositionUIHandler.java index 01ba8a9..d1aa5c4 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/longline/BaitsCompositionUIHandler.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/longline/BaitsCompositionUIHandler.java @@ -46,7 +46,7 @@ import static org.nuiton.i18n.I18n.n; public class BaitsCompositionUIHandler extends ContentTableUIHandler<SetLonglineGlobalCompositionDto, BaitsCompositionDto> { /** Logger */ - static private Log log = LogFactory.getLog(BaitsCompositionUIHandler.class); + private static final Log log = LogFactory.getLog(BaitsCompositionUIHandler.class); public BaitsCompositionUIHandler(BaitsCompositionUI ui) { super(ui, DataContextType.SetLongline); diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/longline/BaitsCompositionUIModel.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/longline/BaitsCompositionUIModel.java index 0e9797e..c83b88b 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/longline/BaitsCompositionUIModel.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/longline/BaitsCompositionUIModel.java @@ -73,6 +73,8 @@ public class BaitsCompositionUIModel extends ContentTableUIModel<SetLonglineGlob List<ContentTableMeta<BaitsCompositionDto>> contentTableMetas) { return new ContentTableModel<SetLonglineGlobalCompositionDto, BaitsCompositionDto>(ui, contentTableMetas) { + private static final long serialVersionUID = 1L; + @Override protected Collection<BaitsCompositionDto> getChilds(SetLonglineGlobalCompositionDto bean) { return bean.getBaitsComposition(); diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/longline/BranchlinesCompositionUIHandler.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/longline/BranchlinesCompositionUIHandler.java index ff6c9bf..cde391e 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/longline/BranchlinesCompositionUIHandler.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/longline/BranchlinesCompositionUIHandler.java @@ -46,7 +46,7 @@ import static org.nuiton.i18n.I18n.n; public class BranchlinesCompositionUIHandler extends ContentTableUIHandler<SetLonglineGlobalCompositionDto, BranchlinesCompositionDto> { /** Logger */ - static private Log log = LogFactory.getLog(BranchlinesCompositionUIHandler.class); + private static final Log log = LogFactory.getLog(BranchlinesCompositionUIHandler.class); public BranchlinesCompositionUIHandler(BranchlinesCompositionUI ui) { super(ui, DataContextType.SetLongline); diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/longline/BranchlinesCompositionUIModel.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/longline/BranchlinesCompositionUIModel.java index 94e0f0a..7520cd5 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/longline/BranchlinesCompositionUIModel.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/longline/BranchlinesCompositionUIModel.java @@ -72,6 +72,8 @@ public class BranchlinesCompositionUIModel extends ContentTableUIModel<SetLongli List<ContentTableMeta<BranchlinesCompositionDto>> contentTableMetas) { return new ContentTableModel<SetLonglineGlobalCompositionDto, BranchlinesCompositionDto>(ui, contentTableMetas) { + private static final long serialVersionUID = 1L; + @Override protected Collection<BranchlinesCompositionDto> getChilds(SetLonglineGlobalCompositionDto bean) { return bean.getBranchlinesComposition(); diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/longline/CatchAcquisitionModeEnum.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/longline/CatchAcquisitionModeEnum.java index 01ff486..2292198 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/longline/CatchAcquisitionModeEnum.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/longline/CatchAcquisitionModeEnum.java @@ -37,7 +37,7 @@ public enum CatchAcquisitionModeEnum { GROUPED(n("observe.catchAcquisitionModeEnum.GROUPED")); - private String i18nKey; + private final String i18nKey; CatchAcquisitionModeEnum(String i18nKey) { this.i18nKey = i18nKey; diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/longline/CatchLonglineTableModel.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/longline/CatchLonglineTableModel.java index b400b17..f2a0b06 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/longline/CatchLonglineTableModel.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/longline/CatchLonglineTableModel.java @@ -30,6 +30,8 @@ import fr.ird.observe.services.dto.longline.WeightMeasureDto; import fr.ird.observe.ui.content.table.ContentTableMeta; import fr.ird.observe.ui.content.table.ContentTableModel; import fr.ird.observe.ui.content.table.ObserveContentTableUI; +import org.apache.commons.logging.Log; +import org.apache.commons.logging.LogFactory; import java.util.Collection; import java.util.List; @@ -43,6 +45,9 @@ import java.util.stream.Collectors; */ public class CatchLonglineTableModel extends ContentTableModel<SetLonglineCatchDto, CatchLonglineDto> { + /** Logger. */ + private static final Log log = LogFactory.getLog(CatchLonglineTableModel.class); + private static final long serialVersionUID = 1L; public CatchLonglineTableModel(ObserveContentTableUI<SetLonglineCatchDto, CatchLonglineDto> context, diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/longline/CatchLonglineUIHandler.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/longline/CatchLonglineUIHandler.java index c22d055..a012593 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/longline/CatchLonglineUIHandler.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/longline/CatchLonglineUIHandler.java @@ -90,7 +90,7 @@ import static org.nuiton.i18n.I18n.t; public class CatchLonglineUIHandler extends ContentTableUIHandler<SetLonglineCatchDto, CatchLonglineDto> { /** Logger */ - static private Log log = LogFactory.getLog(CatchLonglineUIHandler.class); + private static final Log log = LogFactory.getLog(CatchLonglineUIHandler.class); // Compute valid state of tab from the error table protected final TableModelListener computeTabValidStateListener; @@ -105,7 +105,7 @@ public class CatchLonglineUIHandler extends ContentTableUIHandler<SetLonglineCat private final PropertyChangeListener weightTableModelModified; - JAXXContextEntryDef<LonglinePositionHelper<CatchLonglineDto>> POSITION_HELPER_ENTRY = + private final JAXXContextEntryDef<LonglinePositionHelper<CatchLonglineDto>> POSITION_HELPER_ENTRY = UIHelper.newContextEntryDef("CatchLonglineUI-positionHelper", LonglinePositionHelper.class); public CatchLonglineUIHandler(CatchLonglineUI ui) { @@ -134,7 +134,7 @@ public class CatchLonglineUIHandler extends ContentTableUIHandler<SetLonglineCat } @Override - public void initUI() throws Exception { + public void initUI() { final CatchLonglineContentTableUIInitializer uiInitializer = new CatchLonglineContentTableUIInitializer(getUi()); uiInitializer.initUI(); @@ -164,7 +164,7 @@ public class CatchLonglineUIHandler extends ContentTableUIHandler<SetLonglineCat } @Override - public void openUI() throws Exception { + public void openUI() { if (log.isInfoEnabled()) { log.info("OpenUI: " + getModel()); @@ -303,7 +303,7 @@ public class CatchLonglineUIHandler extends ContentTableUIHandler<SetLonglineCat // load size measures SizeMeasuresTableModel sizeMeasuresTableModel = model.getSizeMeasuresTableModel(); - List<SizeMeasureDto> sizes = emptySelection ? Collections.<SizeMeasureDto>emptyList() : sizeMeasuresTableModel.getCacheForRow(editingRow); + List<SizeMeasureDto> sizes = emptySelection ? Collections.emptyList() : sizeMeasuresTableModel.getCacheForRow(editingRow); if (sizes == null) { if (log.isInfoEnabled()) { @@ -345,7 +345,7 @@ public class CatchLonglineUIHandler extends ContentTableUIHandler<SetLonglineCat // load weight measures WeightMeasuresTableModel weightMeasuresTableModel = model.getWeightMeasuresTableModel(); - List<WeightMeasureDto> weights = emptySelection ? Collections.<WeightMeasureDto>emptyList() : weightMeasuresTableModel.getCacheForRow(editingRow); + List<WeightMeasureDto> weights = emptySelection ? Collections.emptyList() : weightMeasuresTableModel.getCacheForRow(editingRow); if (weights == null) { diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/longline/EncounterUIHandler.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/longline/EncounterUIHandler.java index 7cfb8f7..97e6b00 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/longline/EncounterUIHandler.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/longline/EncounterUIHandler.java @@ -59,7 +59,7 @@ import static org.nuiton.i18n.I18n.n; public class EncounterUIHandler extends ContentTableUIHandler<ActivityLonglineEncounterDto, EncounterDto> { /** Logger */ - static private Log log = LogFactory.getLog(EncounterUIHandler.class); + private static final Log log = LogFactory.getLog(EncounterUIHandler.class); public EncounterUIHandler(EncounterUI ui) { super(ui, DataContextType.ActivityLongline); diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/longline/EncounterUIModel.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/longline/EncounterUIModel.java index 3ae0187..5fbdf08 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/longline/EncounterUIModel.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/longline/EncounterUIModel.java @@ -71,6 +71,8 @@ public class EncounterUIModel extends ContentTableUIModel<ActivityLonglineEncoun ObserveContentTableUI<ActivityLonglineEncounterDto, EncounterDto> ui, List<ContentTableMeta<EncounterDto>> contentTableMetas) { return new ContentTableModel<ActivityLonglineEncounterDto, EncounterDto>(ui, contentTableMetas) { + private static final long serialVersionUID = 1L; + @Override protected Collection<EncounterDto> getChilds(ActivityLonglineEncounterDto bean) { return bean.getEncounter(); diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/longline/FloatlinesCompositionUIHandler.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/longline/FloatlinesCompositionUIHandler.java index db19fbd..e146c41 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/longline/FloatlinesCompositionUIHandler.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/longline/FloatlinesCompositionUIHandler.java @@ -45,7 +45,7 @@ import static org.nuiton.i18n.I18n.n; public class FloatlinesCompositionUIHandler extends ContentTableUIHandler<SetLonglineGlobalCompositionDto, FloatlinesCompositionDto> { /** Logger */ - static private Log log = LogFactory.getLog(FloatlinesCompositionUIHandler.class); + private static final Log log = LogFactory.getLog(FloatlinesCompositionUIHandler.class); public FloatlinesCompositionUIHandler(FloatlinesCompositionUI ui) { super(ui, DataContextType.SetLongline); diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/longline/FloatlinesCompositionUIModel.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/longline/FloatlinesCompositionUIModel.java index 0a2f9ed..ac88c62 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/longline/FloatlinesCompositionUIModel.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/longline/FloatlinesCompositionUIModel.java @@ -70,6 +70,7 @@ public class FloatlinesCompositionUIModel extends ContentTableUIModel<SetLonglin List<ContentTableMeta<FloatlinesCompositionDto>> contentTableMetas) { return new ContentTableModel<SetLonglineGlobalCompositionDto, FloatlinesCompositionDto>(ui, contentTableMetas) { + private static final long serialVersionUID = 1L; @Override protected Collection<FloatlinesCompositionDto> getChilds(SetLonglineGlobalCompositionDto bean) { return bean.getFloatlinesComposition(); diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/longline/GearUseFeaturesLonglineTableModel.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/longline/GearUseFeaturesLonglineTableModel.java index bc2c615..ae3ba85 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/longline/GearUseFeaturesLonglineTableModel.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/longline/GearUseFeaturesLonglineTableModel.java @@ -33,6 +33,8 @@ import fr.ird.observe.ui.content.table.ContentTableMeta; import fr.ird.observe.ui.content.table.ContentTableModel; import fr.ird.observe.ui.content.table.ObserveContentTableUI; import org.apache.commons.collections4.CollectionUtils; +import org.apache.commons.logging.Log; +import org.apache.commons.logging.LogFactory; import java.util.Collection; import java.util.List; @@ -45,9 +47,12 @@ import java.util.List; */ public class GearUseFeaturesLonglineTableModel extends ContentTableModel<TripLonglineGearUseDto, GearUseFeaturesLonglineDto> { + /** Logger. */ + private static final Log log = LogFactory.getLog(GearUseFeaturesLonglineTableModel.class); + private static final long serialVersionUID = 1L; - private GearUseFeaturesLonglineUIHandler gearUseFeaturesLonglineUIHandler; + private transient GearUseFeaturesLonglineUIHandler gearUseFeaturesLonglineUIHandler; public GearUseFeaturesLonglineTableModel(ObserveContentTableUI<TripLonglineGearUseDto, GearUseFeaturesLonglineDto> context, List<ContentTableMeta<GearUseFeaturesLonglineDto>> contentTableMetas) { diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/longline/GearUseFeaturesLonglineUIHandler.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/longline/GearUseFeaturesLonglineUIHandler.java index 0ecce5e..99ebe34 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/longline/GearUseFeaturesLonglineUIHandler.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/longline/GearUseFeaturesLonglineUIHandler.java @@ -80,7 +80,7 @@ import static org.nuiton.i18n.I18n.t; public class GearUseFeaturesLonglineUIHandler extends ContentTableUIHandler<TripLonglineGearUseDto, GearUseFeaturesLonglineDto> { /** Logger */ - static private Log log = LogFactory.getLog(GearUseFeaturesLonglineUIHandler.class); + private static final Log log = LogFactory.getLog(GearUseFeaturesLonglineUIHandler.class); // Compute valid state of tab from the error table protected final TableModelListener computeTabValidStateListener; @@ -109,7 +109,7 @@ public class GearUseFeaturesLonglineUIHandler extends ContentTableUIHandler<Trip } @Override - public void initUI() throws Exception { + public void initUI() { super.initUI(); @@ -125,7 +125,7 @@ public class GearUseFeaturesLonglineUIHandler extends ContentTableUIHandler<Trip } @Override - public void openUI() throws Exception { + public void openUI() { if (log.isInfoEnabled()) { log.info("OpenUI: " + getModel()); @@ -236,7 +236,7 @@ public class GearUseFeaturesLonglineUIHandler extends ContentTableUIHandler<Trip // load size measures GearUseFeaturesMeasurementLonglinesTableModel measurementsTableModel = model.getMeasurementsTableModel(); - List<GearUseFeaturesMeasurementLonglineDto> measurements = emptySelection ? Collections.<GearUseFeaturesMeasurementLonglineDto>emptyList() : measurementsTableModel.getCacheForRow(editingRow); + List<GearUseFeaturesMeasurementLonglineDto> measurements = emptySelection ? Collections.emptyList() : measurementsTableModel.getCacheForRow(editingRow); if (measurements == null) { if (log.isInfoEnabled()) { diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/longline/HooksCompositionUIHandler.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/longline/HooksCompositionUIHandler.java index cf8ea37..18f576e 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/longline/HooksCompositionUIHandler.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/longline/HooksCompositionUIHandler.java @@ -46,7 +46,7 @@ import static org.nuiton.i18n.I18n.n; public class HooksCompositionUIHandler extends ContentTableUIHandler<SetLonglineGlobalCompositionDto, HooksCompositionDto> { /** Logger */ - static private Log log = LogFactory.getLog(HooksCompositionUIHandler.class); + private static final Log log = LogFactory.getLog(HooksCompositionUIHandler.class); public HooksCompositionUIHandler(HooksCompositionUI ui) { super(ui, DataContextType.SetLongline); diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/longline/HooksCompositionUIModel.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/longline/HooksCompositionUIModel.java index e14ca52..cc29463 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/longline/HooksCompositionUIModel.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/longline/HooksCompositionUIModel.java @@ -72,6 +72,7 @@ public class HooksCompositionUIModel extends ContentTableUIModel<SetLonglineGlob List<ContentTableMeta<HooksCompositionDto>> contentTableMetas) { return new ContentTableModel<SetLonglineGlobalCompositionDto, HooksCompositionDto>(ui, contentTableMetas) { + private static final long serialVersionUID = 1L; @Override protected Collection<HooksCompositionDto> getChilds(SetLonglineGlobalCompositionDto bean) { return bean.getHooksComposition(); diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/longline/LonglinePositionHelper.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/longline/LonglinePositionHelper.java index d1ef627..3f8ffc8 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/longline/LonglinePositionHelper.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/longline/LonglinePositionHelper.java @@ -188,10 +188,10 @@ public class LonglinePositionHelper<D extends LonglinePositionAwareDto> { dto.setBranchline(null); // on vide l'ensemble des paniers - uiBasket.setData(Collections.<DataReference<BasketDto>>emptyList()); + uiBasket.setData(Collections.emptyList()); // on vide l'ensemble des avançons - uiBranchline.setData(Collections.<DataReference<BranchlineDto>>emptyList()); + uiBranchline.setData(Collections.emptyList()); if (newValue != null) { @@ -239,7 +239,7 @@ public class LonglinePositionHelper<D extends LonglinePositionAwareDto> { dto.setBranchline(null); // on vide l'ensemble des avançons - uiBranchline.setData(Collections.<DataReference<BranchlineDto>>emptyList()); + uiBranchline.setData(Collections.emptyList()); if (newValue != null) { diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/longline/SensorUsedUIHandler.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/longline/SensorUsedUIHandler.java index 4aa271e..1096aa5 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/longline/SensorUsedUIHandler.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/longline/SensorUsedUIHandler.java @@ -62,7 +62,7 @@ import static org.nuiton.i18n.I18n.t; public class SensorUsedUIHandler extends ContentTableUIHandler<ActivityLonglineSensorUsedDto, SensorUsedDto> { /** Logger */ - static private Log log = LogFactory.getLog(SensorUsedUIHandler.class); + private static final Log log = LogFactory.getLog(SensorUsedUIHandler.class); public SensorUsedUIHandler(SensorUsedUI ui) { super(ui, DataContextType.ActivityLongline); diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/longline/SensorUsedUIModel.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/longline/SensorUsedUIModel.java index d133125..ebcd761 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/longline/SensorUsedUIModel.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/longline/SensorUsedUIModel.java @@ -76,6 +76,7 @@ public class SensorUsedUIModel extends ContentTableUIModel<ActivityLonglineSenso List<ContentTableMeta<SensorUsedDto>> contentTableMetas) { return new ContentTableModel<ActivityLonglineSensorUsedDto, SensorUsedDto>(ui, contentTableMetas) { + private static final long serialVersionUID = 1L; @Override protected Collection<SensorUsedDto> getChilds(ActivityLonglineSensorUsedDto bean) { return bean.getSensorUsed(); diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/longline/TdrUIHandler.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/longline/TdrUIHandler.java index 159cc0f..6c72d8c 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/longline/TdrUIHandler.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/longline/TdrUIHandler.java @@ -80,7 +80,7 @@ import static org.nuiton.i18n.I18n.t; public class TdrUIHandler extends ContentTableUIHandler<SetLonglineTdrDto, TdrDto> { /** Logger */ - static private Log log = LogFactory.getLog(TdrUIHandler.class); + private static final Log log = LogFactory.getLog(TdrUIHandler.class); // Compute valid state of tab from the error table protected final TableModelListener computeTabValidStateListener; @@ -90,7 +90,7 @@ public class TdrUIHandler extends ContentTableUIHandler<SetLonglineTdrDto, TdrDt protected boolean toogleTimeEditorSliderIsChanging; - JAXXContextEntryDef<LonglinePositionHelper<TdrDto>> POSITION_HELPER_ENTRY = + private static final JAXXContextEntryDef<LonglinePositionHelper<TdrDto>> POSITION_HELPER_ENTRY = UIHelper.newContextEntryDef("TdrUI-positionHelper", LonglinePositionHelper.class); public TdrUIHandler(TdrUI ui) { @@ -190,7 +190,7 @@ public class TdrUIHandler extends ContentTableUIHandler<SetLonglineTdrDto, TdrDt } @Override - public void initUI() throws Exception { + public void initUI() { super.initUI(); @@ -210,7 +210,7 @@ public class TdrUIHandler extends ContentTableUIHandler<SetLonglineTdrDto, TdrDt } @Override - public void openUI() throws Exception { + public void openUI() { if (log.isInfoEnabled()) { log.info("OpenUI: " + getModel()); diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/longline/TdrUIModel.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/longline/TdrUIModel.java index f2f7724..fdc86e5 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/longline/TdrUIModel.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/longline/TdrUIModel.java @@ -162,6 +162,7 @@ public class TdrUIModel extends ContentTableUIModel<SetLonglineTdrDto, TdrDto> { ObserveContentTableUI<SetLonglineTdrDto, TdrDto> ui, List<ContentTableMeta<TdrDto>> contentTableMetas) { return new ContentTableModel<SetLonglineTdrDto, TdrDto>(ui, contentTableMetas) { + private static final long serialVersionUID = 1L; @Override protected Collection<TdrDto> getChilds(SetLonglineTdrDto bean) { return bean.getTdr(); diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/seine/GearUseFeatureMeasurementCellEditor.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/seine/GearUseFeatureMeasurementCellEditor.java index 05c5217..94d73b8 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/seine/GearUseFeatureMeasurementCellEditor.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/seine/GearUseFeatureMeasurementCellEditor.java @@ -46,9 +46,7 @@ import java.util.TreeMap; */ public class GearUseFeatureMeasurementCellEditor implements TableCellEditor { - private static final long serialVersionUID = 1L; - - protected int caracteristicColumn; + protected final int caracteristicColumn; protected TableCellEditor editor; diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/seine/GearUseFeaturesSeineTableModel.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/seine/GearUseFeaturesSeineTableModel.java index a585b3e..7bcfb7c 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/seine/GearUseFeaturesSeineTableModel.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/seine/GearUseFeaturesSeineTableModel.java @@ -33,6 +33,8 @@ import fr.ird.observe.ui.content.table.ContentTableMeta; import fr.ird.observe.ui.content.table.ContentTableModel; import fr.ird.observe.ui.content.table.ObserveContentTableUI; import org.apache.commons.collections4.CollectionUtils; +import org.apache.commons.logging.Log; +import org.apache.commons.logging.LogFactory; import java.util.Collection; import java.util.List; @@ -45,9 +47,12 @@ import java.util.List; */ public class GearUseFeaturesSeineTableModel extends ContentTableModel<TripSeineGearUseDto, GearUseFeaturesSeineDto> { + /** Logger. */ + private static final Log log = LogFactory.getLog(GearUseFeaturesSeineTableModel.class); + private static final long serialVersionUID = 1L; - private GearUseFeaturesSeineUIHandler gearUseFeaturesSeineUIHandler; + private transient GearUseFeaturesSeineUIHandler gearUseFeaturesSeineUIHandler; public GearUseFeaturesSeineTableModel(ObserveContentTableUI<TripSeineGearUseDto, GearUseFeaturesSeineDto> context, List<ContentTableMeta<GearUseFeaturesSeineDto>> contentTableMetas) { diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/seine/GearUseFeaturesSeineUIHandler.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/seine/GearUseFeaturesSeineUIHandler.java index c0f8b43..f3c55b3 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/seine/GearUseFeaturesSeineUIHandler.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/seine/GearUseFeaturesSeineUIHandler.java @@ -78,7 +78,7 @@ import static org.nuiton.i18n.I18n.t; public class GearUseFeaturesSeineUIHandler extends ContentTableUIHandler<TripSeineGearUseDto, GearUseFeaturesSeineDto> { /** Logger */ - static private Log log = LogFactory.getLog(GearUseFeaturesSeineUIHandler.class); + private static final Log log = LogFactory.getLog(GearUseFeaturesSeineUIHandler.class); // Compute valid state of tab from the error table protected final TableModelListener computeTabValidStateListener; @@ -107,7 +107,7 @@ public class GearUseFeaturesSeineUIHandler extends ContentTableUIHandler<TripSei } @Override - public void initUI() throws Exception { + public void initUI() { super.initUI(); @@ -123,7 +123,7 @@ public class GearUseFeaturesSeineUIHandler extends ContentTableUIHandler<TripSei } @Override - public void openUI() throws Exception { + public void openUI() { if (log.isInfoEnabled()) { log.info("OpenUI: " + getModel()); @@ -235,7 +235,7 @@ public class GearUseFeaturesSeineUIHandler extends ContentTableUIHandler<TripSei // load size measures GearUseFeaturesMeasurementSeinesTableModel measurementsTableModel = model.getMeasurementsTableModel(); - List<GearUseFeaturesMeasurementSeineDto> measurements = emptySelection ? Collections.<GearUseFeaturesMeasurementSeineDto>emptyList() : measurementsTableModel.getCacheForRow(editingRow); + List<GearUseFeaturesMeasurementSeineDto> measurements = emptySelection ? Collections.emptyList() : measurementsTableModel.getCacheForRow(editingRow); if (measurements == null) { if (log.isInfoEnabled()) { diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/seine/ModeSaisieEchantillonEnum.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/seine/ModeSaisieEchantillonEnum.java index 068f3aa..3239ca3 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/seine/ModeSaisieEchantillonEnum.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/seine/ModeSaisieEchantillonEnum.java @@ -47,7 +47,7 @@ public enum ModeSaisieEchantillonEnum { */ byIndividu(n("observe.modeSaisieEchantillonEnum.byIndividu")); - private String i18nKey; + private final String i18nKey; ModeSaisieEchantillonEnum(String i18nKey) { this.i18nKey = i18nKey; diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/seine/NonTargetCatchUIHandler.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/seine/NonTargetCatchUIHandler.java index 025a509..2207293 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/seine/NonTargetCatchUIHandler.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/seine/NonTargetCatchUIHandler.java @@ -69,7 +69,7 @@ import static org.nuiton.i18n.I18n.t; public class NonTargetCatchUIHandler extends ContentTableUIHandler<SetSeineNonTargetCatchDto, NonTargetCatchDto> { /** Logger */ - static private Log log = LogFactory.getLog(NonTargetCatchUIHandler.class); + private static final Log log = LogFactory.getLog(NonTargetCatchUIHandler.class); /** * Ecoute les modifications de la propriété {@link NonTargetCatchDto#getTotalCount()}, diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/seine/NonTargetCatchUIModel.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/seine/NonTargetCatchUIModel.java index 3f6f79c..d02baf1 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/seine/NonTargetCatchUIModel.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/seine/NonTargetCatchUIModel.java @@ -84,6 +84,7 @@ public class NonTargetCatchUIModel extends ContentTableUIModel<SetSeineNonTarget List<ContentTableMeta<NonTargetCatchDto>> contentTableMetas) { return new ContentTableModel<SetSeineNonTargetCatchDto, NonTargetCatchDto>(ui, contentTableMetas) { + private static final long serialVersionUID = 1L; @Override protected Collection<NonTargetCatchDto> getChilds(SetSeineNonTargetCatchDto bean) { diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/seine/NonTargetSampleUIHandler.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/seine/NonTargetSampleUIHandler.java index 869a802..1e25c13 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/seine/NonTargetSampleUIHandler.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/seine/NonTargetSampleUIHandler.java @@ -63,7 +63,7 @@ import static org.nuiton.i18n.I18n.t; public class NonTargetSampleUIHandler extends ContentTableUIHandler<NonTargetSampleDto, NonTargetLengthDto> { /** Logger */ - static private Log log = LogFactory.getLog(NonTargetSampleUIHandler.class); + private static final Log log = LogFactory.getLog(NonTargetSampleUIHandler.class); /** * Ecoute les modifications de la propriété {@link NonTargetLengthDto#getWeight()}, diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/seine/NonTargetSampleUIModel.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/seine/NonTargetSampleUIModel.java index 5219102..9aa7bd6 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/seine/NonTargetSampleUIModel.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/seine/NonTargetSampleUIModel.java @@ -86,6 +86,7 @@ public class NonTargetSampleUIModel extends ContentTableUIModel<NonTargetSampleD @Override protected ContentTableModel<NonTargetSampleDto, NonTargetLengthDto> createTableModel(ObserveContentTableUI<NonTargetSampleDto, NonTargetLengthDto> ui, List<ContentTableMeta<NonTargetLengthDto>> contentTableMetas) { return new ContentTableModel<NonTargetSampleDto, NonTargetLengthDto>(ui, contentTableMetas) { + private static final long serialVersionUID = 1L; @Override protected Collection<NonTargetLengthDto> getChilds(NonTargetSampleDto bean) { return bean.getNonTargetLength(); diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/seine/ObjectObservedSpeciesUIHandler.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/seine/ObjectObservedSpeciesUIHandler.java index e43f56f..ade5863 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/seine/ObjectObservedSpeciesUIHandler.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/seine/ObjectObservedSpeciesUIHandler.java @@ -57,8 +57,7 @@ import static org.nuiton.i18n.I18n.n; public class ObjectObservedSpeciesUIHandler extends ContentTableUIHandler<FloatingObjectObservedSpeciesDto, ObjectObservedSpeciesDto> { /** Logger */ - static private Log log = - LogFactory.getLog(ObjectObservedSpeciesUIHandler.class); + private static final Log log = LogFactory.getLog(ObjectObservedSpeciesUIHandler.class); public ObjectObservedSpeciesUIHandler(ObjectObservedSpeciesUI ui) { super(ui, DataContextType.SetSeine); diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/seine/ObjectObservedSpeciesUIModel.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/seine/ObjectObservedSpeciesUIModel.java index 023ae0d..7e802f3 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/seine/ObjectObservedSpeciesUIModel.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/seine/ObjectObservedSpeciesUIModel.java @@ -72,6 +72,7 @@ public class ObjectObservedSpeciesUIModel extends ContentTableUIModel<FloatingOb List<ContentTableMeta<ObjectObservedSpeciesDto>> contentTableMetas) { return new ContentTableModel<FloatingObjectObservedSpeciesDto, ObjectObservedSpeciesDto>(ui, contentTableMetas) { + private static final long serialVersionUID = 1L; @Override protected Collection<ObjectObservedSpeciesDto> getChilds(FloatingObjectObservedSpeciesDto bean) { return bean.getObjectObservedSpecies(); diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/seine/ObjectSchoolEstimateUIHandler.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/seine/ObjectSchoolEstimateUIHandler.java index c99d39e..72d0d89 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/seine/ObjectSchoolEstimateUIHandler.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/seine/ObjectSchoolEstimateUIHandler.java @@ -56,7 +56,7 @@ public class ObjectSchoolEstimateUIHandler extends ContentTableUIHandler<Floatin /** Logger */ - static private Log log = LogFactory.getLog(ObjectSchoolEstimateUIHandler.class); + private static final Log log = LogFactory.getLog(ObjectSchoolEstimateUIHandler.class); public ObjectSchoolEstimateUIHandler(ObjectSchoolEstimateUI ui) { super(ui, DataContextType.SetSeine); diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/seine/ObjectSchoolEstimateUIModel.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/seine/ObjectSchoolEstimateUIModel.java index dd6d814..5456579 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/seine/ObjectSchoolEstimateUIModel.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/seine/ObjectSchoolEstimateUIModel.java @@ -70,6 +70,7 @@ public class ObjectSchoolEstimateUIModel extends ContentTableUIModel<FloatingObj List<ContentTableMeta<ObjectSchoolEstimateDto>> contentTableMetas) { return new ContentTableModel<FloatingObjectSchoolEstimateDto, ObjectSchoolEstimateDto>(ui, contentTableMetas) { + private static final long serialVersionUID = 1L; @Override protected Collection<ObjectSchoolEstimateDto> getChilds(FloatingObjectSchoolEstimateDto bean) { return bean.getObjectSchoolEstimate(); diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/seine/SchoolEstimateUIHandler.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/seine/SchoolEstimateUIHandler.java index 4987006..4a2a299 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/seine/SchoolEstimateUIHandler.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/seine/SchoolEstimateUIHandler.java @@ -60,7 +60,7 @@ import static org.nuiton.i18n.I18n.n; public class SchoolEstimateUIHandler extends ContentTableUIHandler<SetSeineSchoolEstimateDto, SchoolEstimateDto> { /** Logger */ - static private Log log = LogFactory.getLog(SchoolEstimateUIHandler.class); + private static final Log log = LogFactory.getLog(SchoolEstimateUIHandler.class); public SchoolEstimateUIHandler(SchoolEstimateUI ui) { super(ui, DataContextType.SetSeine); diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/seine/SchoolEstimateUIModel.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/seine/SchoolEstimateUIModel.java index c210868..286062a 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/seine/SchoolEstimateUIModel.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/seine/SchoolEstimateUIModel.java @@ -72,6 +72,7 @@ public class SchoolEstimateUIModel extends ContentTableUIModel<SetSeineSchoolEst List<ContentTableMeta<SchoolEstimateDto>> contentTableMetas) { return new ContentTableModel<SetSeineSchoolEstimateDto, SchoolEstimateDto>(ui, contentTableMetas) { + private static final long serialVersionUID = 1L; @Override protected Collection<SchoolEstimateDto> getChilds(SetSeineSchoolEstimateDto bean) { return bean.getSchoolEstimate(); diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/seine/TargetCatchUIHandler.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/seine/TargetCatchUIHandler.java index 05427ed..f23dbd2 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/seine/TargetCatchUIHandler.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/seine/TargetCatchUIHandler.java @@ -80,7 +80,7 @@ public class TargetCatchUIHandler extends ContentTableUIHandler<SetSeineTargetCa } @Override - public void initUI() throws Exception { + public void initUI() { super.initUI(); // lors de la modification d'une species (sur une entree non sauvee) diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/seine/TargetCatchUIModel.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/seine/TargetCatchUIModel.java index e5c3262..976ccce 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/seine/TargetCatchUIModel.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/seine/TargetCatchUIModel.java @@ -78,6 +78,7 @@ public class TargetCatchUIModel extends ContentTableUIModel<SetSeineTargetCatchD ObserveContentTableUI<SetSeineTargetCatchDto, TargetCatchDto> ui, List<ContentTableMeta<TargetCatchDto>> contentTableMetas) { return new ContentTableModel<SetSeineTargetCatchDto, TargetCatchDto>(ui, contentTableMetas) { + private static final long serialVersionUID = 1L; @Override protected Collection<TargetCatchDto> getChilds(SetSeineTargetCatchDto bean) { return bean.getTargetCatch(); diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/seine/TargetDiscardCatchUIHandler.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/seine/TargetDiscardCatchUIHandler.java index e11f990..f50a7ef 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/seine/TargetDiscardCatchUIHandler.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/seine/TargetDiscardCatchUIHandler.java @@ -71,7 +71,7 @@ import static org.nuiton.i18n.I18n.t; public class TargetDiscardCatchUIHandler extends ContentTableUIHandler<SetSeineTargetCatchDto, TargetCatchDto> { /** Logger */ - static private Log log = LogFactory.getLog(TargetDiscardCatchUIHandler.class); + private static final Log log = LogFactory.getLog(TargetDiscardCatchUIHandler.class); public TargetDiscardCatchUIHandler(TargetDiscardCatchUI ui) { super(ui, DataContextType.SetSeine); @@ -108,7 +108,7 @@ public class TargetDiscardCatchUIHandler extends ContentTableUIHandler<SetSeineT } @Override - public void initUI() throws Exception { + public void initUI() { super.initUI(); diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/seine/TargetDiscardCatchUIModel.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/seine/TargetDiscardCatchUIModel.java index 7115cb9..1c22ad0 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/seine/TargetDiscardCatchUIModel.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/seine/TargetDiscardCatchUIModel.java @@ -78,6 +78,7 @@ public class TargetDiscardCatchUIModel extends ContentTableUIModel<SetSeineTarge List<ContentTableMeta<TargetCatchDto>> contentTableMetas) { return new ContentTableModel<SetSeineTargetCatchDto, TargetCatchDto>(ui, contentTableMetas) { + private static final long serialVersionUID = 1L; @Override protected Collection<TargetCatchDto> getChilds(SetSeineTargetCatchDto bean) { return bean.getTargetCatch(); diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/seine/TargetSampleUIHandler.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/seine/TargetSampleUIHandler.java index 990af33..3b3ef8f 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/seine/TargetSampleUIHandler.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/seine/TargetSampleUIHandler.java @@ -61,7 +61,7 @@ import static org.nuiton.i18n.I18n.t; public class TargetSampleUIHandler extends ContentTableUIHandler<TargetSampleDto, TargetLengthDto> { /** Logger */ - static private Log log = LogFactory.getLog(TargetSampleUIHandler.class); + private static final Log log = LogFactory.getLog(TargetSampleUIHandler.class); /** * Pour différencier positionner l'invariant de l'écran diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/seine/TargetSampleUIModel.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/seine/TargetSampleUIModel.java index f116c8e..73d392a 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/seine/TargetSampleUIModel.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/content/table/impl/seine/TargetSampleUIModel.java @@ -79,6 +79,7 @@ public class TargetSampleUIModel extends ContentTableUIModel<TargetSampleDto, Ta ObserveContentTableUI<TargetSampleDto, TargetLengthDto> ui, List<ContentTableMeta<TargetLengthDto>> contentTableMetas) { return new ContentTableModel<TargetSampleDto, TargetLengthDto>(ui, contentTableMetas) { + private static final long serialVersionUID = 1L; @Override protected Collection<TargetLengthDto> getChilds(TargetSampleDto bean) { return bean.getTargetLength(); diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/storage/ObstunaAdminAction.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/storage/ObstunaAdminAction.java index 964f01f..6c2fd97 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/storage/ObstunaAdminAction.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/storage/ObstunaAdminAction.java @@ -188,7 +188,7 @@ public enum ObstunaAdminAction { } @Override - protected void applySecurity() throws Exception { + protected void applySecurity() { if (log.isInfoEnabled()) { log.info("Apply security..."); } @@ -249,7 +249,7 @@ public enum ObstunaAdminAction { } @Override - protected void applySecurity() throws Exception { + protected void applySecurity() { if (log.isInfoEnabled()) { log.info("Apply security..."); } @@ -299,7 +299,7 @@ public enum ObstunaAdminAction { } @Override - protected void applySecurity() throws Exception { + protected void applySecurity() { if (log.isInfoEnabled()) { log.info("Apply security..."); } @@ -310,7 +310,7 @@ public enum ObstunaAdminAction { }; /** Logger */ - static private Log log = LogFactory.getLog(ObstunaAdminAction.class); + private static final Log log = LogFactory.getLog(ObstunaAdminAction.class); private final String label; diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/storage/RemoteUILauncher.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/storage/RemoteUILauncher.java index de1e08d..86ead38 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/storage/RemoteUILauncher.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/storage/RemoteUILauncher.java @@ -42,7 +42,7 @@ import java.util.List; public abstract class RemoteUILauncher extends StorageUILauncher { /** Logger */ - static private Log log = LogFactory.getLog(RemoteUILauncher.class); + private static final Log log = LogFactory.getLog(RemoteUILauncher.class); protected ObstunaAdminAction action; @@ -137,6 +137,6 @@ public abstract class RemoteUILauncher extends StorageUILauncher { protected void execute() throws Exception { } - protected void applySecurity() throws Exception { + protected void applySecurity() { } } diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/storage/StorageBackupUILauncher.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/storage/StorageBackupUILauncher.java index 074cbbf..abbddfe 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/storage/StorageBackupUILauncher.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/storage/StorageBackupUILauncher.java @@ -46,7 +46,7 @@ public class StorageBackupUILauncher extends StorageUILauncher { /** * Logger */ - static private Log log = LogFactory.getLog(StorageBackupUILauncher.class); + private static final Log log = LogFactory.getLog(StorageBackupUILauncher.class); public StorageBackupUILauncher(JAXXContext context, Window frame, diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/storage/StorageUIHandler.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/storage/StorageUIHandler.java index 1c29079..6096c18 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/storage/StorageUIHandler.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/storage/StorageUIHandler.java @@ -111,8 +111,6 @@ public class StorageUIHandler { @Override public void onOpened(ObserveSwingDataSourceEvent event) { - ObserveSwingDataSource source = event.getSource(); - ObserveSwingApplicationContext context = ObserveSwingApplicationContext.get(); // la base locale existe desormais context.getConfig().setLocalStorageExist(true); diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/storage/StorageUILauncher.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/storage/StorageUILauncher.java index c6be8a2..12584be 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/storage/StorageUILauncher.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/storage/StorageUILauncher.java @@ -53,7 +53,7 @@ public class StorageUILauncher extends WizardUILancher<StorageStep, StorageUIMod /** Logger */ private static final Log log = LogFactory.getLog(StorageUILauncher.class); - protected String title; + protected final String title; public StorageUILauncher(JAXXContext context, Window frame, diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/storage/StorageUIModel.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/storage/StorageUIModel.java index 8fda354..eddc5d8 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/storage/StorageUIModel.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/storage/StorageUIModel.java @@ -1245,7 +1245,7 @@ public class StorageUIModel extends WizardModel<StorageStep> { setRemoteLogin(restConfig.getLogin()); setRemoteUrl(restConfig.getServerUrl() == null ? "" : restConfig.getServerUrl().toString()); setRemotePassword(restConfig.getPassword()); - setServerDatabase(restConfig.getOptionalDatabaseName().orNull()); + setServerDatabase(restConfig.getOptionalDatabaseName().orElse(null)); } } @@ -1430,7 +1430,7 @@ public class StorageUIModel extends WizardModel<StorageStep> { } public String getServerDatabase() { - return restConfig.getOptionalDatabaseName().orNull(); + return restConfig.getOptionalDatabaseName().orElse(null); } public ConnexionStatus getConnexionStatus() { @@ -1455,7 +1455,7 @@ public class StorageUIModel extends WizardModel<StorageStep> { public void setRemoteLogin(String remoteLogin) { - String oldValue = getRemoteLogin(); +// String oldValue = getRemoteLogin(); if (isEditRemoteConfig()) { @@ -1471,7 +1471,7 @@ public class StorageUIModel extends WizardModel<StorageStep> { } public void setRemotePassword(char[] remotePassword) { - char[] oldValue = getRemotePassword(); +// char[] oldValue = getRemotePassword(); if (isEditRemoteConfig()) { @@ -1655,7 +1655,7 @@ public class StorageUIModel extends WizardModel<StorageStep> { restConfig.getServerUrl(), restConfig.getLogin(), restConfig.getPassword(), - restConfig.getOptionalDatabaseName().orNull(), + restConfig.getOptionalDatabaseName().orElse(null), restConfig.getModelVersion() ); return result; diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/storage/tabs/DataSelectionModel.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/storage/tabs/DataSelectionModel.java index 2fd9b00..c4bc8e5 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/storage/tabs/DataSelectionModel.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/storage/tabs/DataSelectionModel.java @@ -38,7 +38,6 @@ import fr.ird.observe.services.dto.referential.ReferentialDto; import fr.ird.observe.services.dto.referential.ReferentialDtos; import fr.ird.observe.services.dto.referential.ReferentialReference; import fr.ird.observe.services.dto.seine.TripSeineDto; -import fr.ird.observe.services.service.ReferentialService; import fr.ird.observe.services.service.longline.TripLonglineService; import fr.ird.observe.services.service.seine.TripSeineService; import org.apache.commons.collections4.CollectionUtils; @@ -63,14 +62,12 @@ import java.util.stream.Collectors; */ public class DataSelectionModel implements Serializable { - public static void populate(DataSelectionModel model, - ObserveSwingDataSource source) throws Exception { + public static void populate(DataSelectionModel model, ObserveSwingDataSource source) { Preconditions.checkState(source.isOpen()); Map<ReferentialReference<ProgramDto>, List<DataReference>> datas = Maps.newHashMap(); - ReferentialService referentialService = source.newService(ReferentialService.class); TripSeineService tripSeineService = source.newService(TripSeineService.class); TripLonglineService tripLonglineService = source.newService(TripLonglineService.class); @@ -162,7 +159,7 @@ public class DataSelectionModel implements Serializable { protected final PropertyChangeSupport pcs; - public void populate() throws Exception { + public void populate() { throw new UnsupportedOperationException(); } @@ -217,7 +214,7 @@ public class DataSelectionModel implements Serializable { } public int selectDataSize() { - return selectedData == null ? 0 :selectedData.size(); + return selectedData == null ? 0 : selectedData.size(); } public Set<Class<? extends ReferentialDto>> getSelectedReferentiel() { @@ -289,8 +286,8 @@ public class DataSelectionModel implements Serializable { } List<DataReference> result = datas.get(program).stream() - .filter(trip -> selectedData.contains(trip)) - .collect(Collectors.toList()); + .filter(trip -> selectedData.contains(trip)) + .collect(Collectors.toList()); return result; } @@ -504,7 +501,7 @@ public class DataSelectionModel implements Serializable { if (!referentiel.contains(type)) { throw new IllegalArgumentException( "given <" + type + "> is not in referentiel universe : " + - referentiel); + referentiel); } } @@ -524,7 +521,7 @@ public class DataSelectionModel implements Serializable { } public List<DataReference> getDatas(String programId) { - Optional<ReferentialReference<ProgramDto>> programRefOptional = Iterables.tryFind(getDatas().keySet(), ReferentialReference.newIdPredicate(programId)); + Optional<ReferentialReference<ProgramDto>> programRefOptional = Iterables.tryFind(getDatas().keySet(), ReferentialReference.newIdPredicate(programId)::apply); List<DataReference> result; diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/storage/tabs/SecurityModel.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/storage/tabs/SecurityModel.java index 96b3fa0..ab4b170 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/storage/tabs/SecurityModel.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/storage/tabs/SecurityModel.java @@ -21,7 +21,6 @@ */ package fr.ird.observe.ui.storage.tabs; -import com.google.common.base.Function; import com.google.common.base.Predicates; import com.google.common.collect.Iterables; import com.google.common.collect.Lists; @@ -53,18 +52,11 @@ public class SecurityModel implements Serializable { private static final long serialVersionUID = 1L; - public static final Function<String, String> ESCAPE_STRING = new Function<String, String>() { - @Override - public String apply(String input) { - return "\"" + input + "\""; - } - }; - protected ObserveDbUserDto administrateur; - protected Set<ObserveDbUserDto> users; + protected final Set<ObserveDbUserDto> users; - protected PropertyChangeSupport pcs = new PropertyChangeSupport(this); + protected final PropertyChangeSupport pcs = new PropertyChangeSupport(this); public SecurityModel() { users = Sets.newHashSet(); diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/tree/DataSelectionTreeSelectionModel.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/tree/DataSelectionTreeSelectionModel.java index ef2df02..c2c3f30 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/tree/DataSelectionTreeSelectionModel.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/tree/DataSelectionTreeSelectionModel.java @@ -79,7 +79,7 @@ public class DataSelectionTreeSelectionModel implements TreeSelectionModel, Prop protected TreePath[] selection; /** Event listener list. */ - protected EventListenerList listenerList = new EventListenerList(); + protected final EventListenerList listenerList = new EventListenerList(); /** Last path that was added. */ protected TreePath leadPath; @@ -641,7 +641,7 @@ public class DataSelectionTreeSelectionModel implements TreeSelectionModel, Prop // recalcule de la selection List<TreePath> oldSelection = isSelectionEmpty() ? - Collections.<TreePath>emptyList() : + Collections.emptyList() : Arrays.asList(selection); List<TreePath> newSelection = new ArrayList<>(); diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/tree/ObserveTreeBridge.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/tree/ObserveTreeBridge.java index a6139de..72f53df 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/tree/ObserveTreeBridge.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/tree/ObserveTreeBridge.java @@ -46,7 +46,7 @@ public class ObserveTreeBridge extends NavTreeBridge<ObserveNode> { protected JTree ui; - protected List<String> pathToSelect; + protected final List<String> pathToSelect; public ObserveTreeBridge() { pathToSelect = new ArrayList<>(); diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/tree/ObserveTreeHelper.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/tree/ObserveTreeHelper.java index e0b5e52..6da0450 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/tree/ObserveTreeHelper.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/tree/ObserveTreeHelper.java @@ -501,7 +501,7 @@ public class ObserveTreeHelper extends NavTreeHelper<ObserveNode> { return result; } - public ObserveNode addProgram(ReferentialReference<ProgramDto> bean) throws Exception { + public ObserveNode addProgram(ReferentialReference<ProgramDto> bean) { Set<ReferentialReference<ProgramDto>> programs = getDataProvider().getDataSource().getReferentialReferences(ProgramDto.class); List data = Lists.newArrayList(programs); diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/tree/loadors/RootNodeChildLoador.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/tree/loadors/RootNodeChildLoador.java index 2630d0b..7259ef5 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/tree/loadors/RootNodeChildLoador.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/tree/loadors/RootNodeChildLoador.java @@ -22,11 +22,9 @@ package fr.ird.observe.ui.tree.loadors; import com.google.common.collect.Lists; -import fr.ird.observe.ObserveSwingApplicationContext; import fr.ird.observe.services.dto.constants.GearType; import fr.ird.observe.services.dto.referential.ProgramDto; import fr.ird.observe.services.dto.referential.ReferentialReference; -import fr.ird.observe.services.service.ReferentialService; import fr.ird.observe.ui.storage.tabs.DataSelectionModel; import fr.ird.observe.ui.tree.ObserveNode; import fr.ird.observe.ui.tree.ObserveTreeHelper; @@ -85,7 +83,6 @@ public class RootNodeChildLoador extends AbstractNodeChildLoador<ReferentialRefe if (selectionModel != null) { data = Lists.newArrayList(selectionModel.getDatas().keySet()); } else { - ReferentialService service = ObserveSwingApplicationContext.get().newService(ReferentialService.class); Set<ReferentialReference<ProgramDto>> referentialReferenceSet = getDataSource(dataProvider).getReferentialReferences(ProgramDto.class); data = new ArrayList<>(referentialReferenceSet); } diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/util/ObserveSwingValidatorMessageTableModel.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/util/ObserveSwingValidatorMessageTableModel.java index 8b91b0b..f5e3410 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/util/ObserveSwingValidatorMessageTableModel.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/util/ObserveSwingValidatorMessageTableModel.java @@ -22,7 +22,6 @@ package fr.ird.observe.ui.util; * #L% */ -import com.google.common.base.Predicate; import jaxx.runtime.validator.swing.SwingValidatorMessage; import jaxx.runtime.validator.swing.SwingValidatorMessageTableModel; import org.nuiton.validator.NuitonValidatorScope; @@ -30,6 +29,7 @@ import org.nuiton.validator.NuitonValidatorScope; import javax.swing.JComponent; import java.util.Collection; import java.util.Collections; +import java.util.function.Predicate; /** * Created on 3/18/15. @@ -61,7 +61,7 @@ public class ObserveSwingValidatorMessageTableModel extends SwingValidatorMessag for (int i = getRowCount() - 1; i > -1; i--) { SwingValidatorMessage error = data.get(i); - if (predicate.apply(error)) { + if (predicate.test(error)) { // remove the message data.remove(i); fireTableRowsDeleted(i, i); diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/util/table/AbstractSelectTableAction.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/util/table/AbstractSelectTableAction.java index f31f952..7959d50 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/util/table/AbstractSelectTableAction.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/util/table/AbstractSelectTableAction.java @@ -28,7 +28,6 @@ import org.apache.commons.logging.LogFactory; import javax.swing.AbstractAction; import javax.swing.JTable; -import java.io.Serializable; /** * Abstract action to select a cell in a table. @@ -81,7 +80,7 @@ public abstract class AbstractSelectTableAction<M extends EditableTableModelSupp protected boolean isCellEditable(int rowIndex, int columnIndex) { boolean result = rowIndex > -1 && columnIndex > -1 && - table.isCellEditable(rowIndex, columnIndex); + table.isCellEditable(rowIndex, columnIndex); return result; } diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/util/table/EditableList.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/util/table/EditableList.java index 19b2c35..5b7dad3 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/util/table/EditableList.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/util/table/EditableList.java @@ -60,6 +60,6 @@ public class EditableList<E extends Serializable> implements Serializable { } public void reset() { - setData(Collections.<E>emptyList()); + setData(Collections.emptyList()); } } diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/util/table/EditableTableModelSupport.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/util/table/EditableTableModelSupport.java index d9ed766..bd416fd 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/util/table/EditableTableModelSupport.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/util/table/EditableTableModelSupport.java @@ -90,7 +90,7 @@ public abstract class EditableTableModelSupport<E extends Serializable> extends protected int selectedRowIndex = -1; /* -1 = pas de selection */ /** la liste des données du modèle */ - protected List<E> data = new ArrayList<>(); + protected final List<E> data = new ArrayList<>(); private JTable table; @@ -279,7 +279,7 @@ public abstract class EditableTableModelSupport<E extends Serializable> extends public void clear() { setSelectedRowIndex(-1); - setData(Collections.<E>emptyList()); + setData(Collections.emptyList()); validate(); setModified(false); fireEmpty(); @@ -468,7 +468,7 @@ public abstract class EditableTableModelSupport<E extends Serializable> extends NumberCellEditor editor = (NumberCellEditor) cellEditor; editor.getNumberEditor().getTextField().addFocusListener(focusAdapter); } else if (cellEditor instanceof ComboBoxCellEditor) { - ComboBoxCellEditor editor = (ComboBoxCellEditor) cellEditor; +// ComboBoxCellEditor editor = (ComboBoxCellEditor) cellEditor; //FIXME should also use the focus listener here } } diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/util/table/ObserveBooleanTableCellRenderer.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/util/table/ObserveBooleanTableCellRenderer.java index fd47031..a4a04fe 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/util/table/ObserveBooleanTableCellRenderer.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/util/table/ObserveBooleanTableCellRenderer.java @@ -22,8 +22,6 @@ package fr.ird.observe.ui.util.table; * #L% */ -import com.google.common.base.Predicate; - import javax.swing.Icon; import javax.swing.JCheckBox; import javax.swing.JComponent; @@ -32,6 +30,7 @@ import javax.swing.JTable; import javax.swing.table.TableCellRenderer; import java.awt.Color; import java.awt.Component; +import java.util.function.Predicate; /** * TODO A remonter dans JAXX. @@ -49,13 +48,7 @@ public class ObserveBooleanTableCellRenderer extends JCheckBox implements TableC private final Predicate predicate; - private static final Predicate<Object> DEFAULT_PREDICATE = new Predicate<Object>() { - - @Override - public boolean apply(Object input) { - return (input != null && (Boolean) input); - } - }; + private static final Predicate<?> DEFAULT_PREDICATE = input -> (input != null && (Boolean) input); public ObserveBooleanTableCellRenderer(TableCellRenderer delegate, Predicate<?> predicate) { this(delegate, null, predicate); @@ -91,7 +84,7 @@ public class ObserveBooleanTableCellRenderer extends JCheckBox implements TableC } } - boolean selectCheckBox = predicate.apply(value); + boolean selectCheckBox = predicate.test(value); setSelected(selectCheckBox); setBorder(render.getBorder()); diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/util/tripMap/ObserveMapPane.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/util/tripMap/ObserveMapPane.java index ea0164c..3db6f45 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/util/tripMap/ObserveMapPane.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/util/tripMap/ObserveMapPane.java @@ -53,6 +53,7 @@ import static org.nuiton.i18n.I18n.t; */ public class ObserveMapPane extends JMapPane { + private static final long serialVersionUID = 1L; private static final Log log = LogFactory.getLog(ObserveMapPane.class); protected static final int MARGIN = 10; @@ -169,11 +170,11 @@ public class ObserveMapPane extends JMapPane { for (CardinalPoint cardinalPoint : CardinalPoint.values()) { - Point2D direction = cardinalPoint.getDirection(rotation, (int) (AXIS_LENGTH), center); + Point2D direction = cardinalPoint.getDirection(rotation, AXIS_LENGTH, center); - Point2D sommet1 = cardinalPoint.getDirection(rotation - Math.PI / 4, (int) (SUB_AXIS_LENGTH), center); + Point2D sommet1 = cardinalPoint.getDirection(rotation - Math.PI / 4, SUB_AXIS_LENGTH, center); - Point2D sommet2 = cardinalPoint.getDirection(rotation + Math.PI / 4, (int) (SUB_AXIS_LENGTH), center); + Point2D sommet2 = cardinalPoint.getDirection(rotation + Math.PI / 4, SUB_AXIS_LENGTH, center); Polygon polygon = new Polygon(); @@ -189,7 +190,7 @@ public class ObserveMapPane extends JMapPane { // on cherche la ditance entre le centre du text et sa bordure dans le direction donné double l = cardinalPoint.distanceCenterBorder(rotation, textArea); - Point2D textCenter = cardinalPoint.getDirection(rotation, (int) (AXIS_LENGTH + INTER_AXIS_TEXT) + l, center); + Point2D textCenter = cardinalPoint.getDirection(rotation, AXIS_LENGTH + INTER_AXIS_TEXT + l, center); graphics.drawString( cardinalPoint.getLabel(), diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/util/tripMap/ObserverMapPanLegendDrawer.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/util/tripMap/ObserverMapPanLegendDrawer.java index ff728eb..8003536 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/util/tripMap/ObserverMapPanLegendDrawer.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/util/tripMap/ObserverMapPanLegendDrawer.java @@ -22,19 +22,13 @@ package fr.ird.observe.ui.util.tripMap; * #L% */ -import com.vividsolutions.jts.geom.Coordinate; import com.vividsolutions.jts.geom.Geometry; -import com.vividsolutions.jts.geom.LineString; -import com.vividsolutions.jts.geom.LinearRing; -import com.vividsolutions.jts.geom.Point; import org.geotools.geometry.jts.LiteShape; import org.geotools.legend.Drawer; import org.geotools.styling.LineSymbolizer; -import org.geotools.styling.PointSymbolizer; import org.geotools.styling.Rule; import org.geotools.styling.SLD; import org.geotools.styling.Symbolizer; -import org.geotools.styling.TextSymbolizer; import org.opengis.feature.simple.SimpleFeature; import java.awt.BasicStroke; @@ -48,9 +42,9 @@ import java.awt.image.BufferedImage; /** * @author Sylvain Bavencoff - bavencoff@codelutin.com */ -public class ObserverMapPanLegendDrawer { +public class ObserverMapPanLegendDrawer { - protected Drawer drawer; + protected final Drawer drawer; public ObserverMapPanLegendDrawer() { @@ -58,11 +52,11 @@ public class ObserverMapPanLegendDrawer { } - public void drawDirect(BufferedImage bi, SimpleFeature feature, Rule rule){ + public void drawDirect(BufferedImage bi, SimpleFeature feature, Rule rule) { AffineTransform affineTransform = new AffineTransform(); LiteShape shape = new LiteShape(null, affineTransform, false); - for(Symbolizer symbolizer : rule.getSymbolizers()) { + for (Symbolizer symbolizer : rule.getSymbolizers()) { if (symbolizer instanceof LineSymbolizer) { LineSymbolizer lineSymbolizer = (LineSymbolizer) symbolizer; @@ -76,20 +70,20 @@ public class ObserverMapPanLegendDrawer { Color c = SLD.color(lineSymbolizer); - int w = SLD.width( lineSymbolizer ); + int w = SLD.width(lineSymbolizer); float[] lineDash = SLD.lineDash(lineSymbolizer); - if( c != null && w > 0 ){ - g.setColor( c ); + if (c != null && w > 0) { + g.setColor(c); Stroke str = new BasicStroke( w, BasicStroke.CAP_SQUARE, BasicStroke.JOIN_MITER, 10.0f, lineDash, 0.0f - ); + ); g.setStroke(str); - g.draw( shape ); + g.draw(shape); } } } else { diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/util/tripMap/TripMapContentBuilder.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/util/tripMap/TripMapContentBuilder.java index 77eaa56..2458001 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/util/tripMap/TripMapContentBuilder.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/util/tripMap/TripMapContentBuilder.java @@ -97,8 +97,8 @@ public class TripMapContentBuilder { public static final SimpleDateFormat DATE_FORMAT = new SimpleDateFormat("dd/MM"); protected StyledLayerDescriptor styledLayerDescriptor; - protected MapContent mapContent; - protected List<ObserveMapPaneLegendItem> legendItems; + protected final MapContent mapContent; + protected final List<ObserveMapPaneLegendItem> legendItems; public TripMapContentBuilder() { mapContent = new MapContent(); diff --git a/observe-application-swing/src/main/java/fr/ird/observe/ui/util/tripMap/TripMapUIHandler.java b/observe-application-swing/src/main/java/fr/ird/observe/ui/util/tripMap/TripMapUIHandler.java index 7c2319c..73e0b8f 100644 --- a/observe-application-swing/src/main/java/fr/ird/observe/ui/util/tripMap/TripMapUIHandler.java +++ b/observe-application-swing/src/main/java/fr/ird/observe/ui/util/tripMap/TripMapUIHandler.java @@ -68,7 +68,7 @@ public class TripMapUIHandler { private static final Log log = LogFactory.getLog(TripMapUIHandler.class); - protected TripMapUI view; + protected final TripMapUI view; private ObserveSwingApplicationConfig config; protected ReferencedEnvelope tripArea; diff --git a/observe-application-swing/src/main/java/fr/ird/observe/validation/ValidationMessageDetector.java b/observe-application-swing/src/main/java/fr/ird/observe/validation/ValidationMessageDetector.java deleted file mode 100644 index 0cc7206..0000000 --- a/observe-application-swing/src/main/java/fr/ird/observe/validation/ValidationMessageDetector.java +++ /dev/null @@ -1,560 +0,0 @@ -/* - * #%L - * ObServe :: Business - * %% - * Copyright (C) 2008 - 2010 IRD, Codelutin, Tony Chemit - * %% - * This program is free software: you can redistribute it and/or modify - * it under the terms of the GNU General Public License as - * published by the Free Software Foundation, either version 3 of the - * License, or (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public - * License along with this program. If not, see - * <http://www.gnu.org/licenses/gpl-3.0.html>. - * #L% - */ -package fr.ird.observe.validation; - -import fr.ird.observe.ObserveSwingApplicationContext; -import fr.ird.observe.db.DataContext; -import fr.ird.observe.services.dto.IdDto; -import org.apache.commons.logging.Log; -import org.apache.commons.logging.LogFactory; -import org.nuiton.validator.bean.simple.SimpleBeanValidator; -import org.nuiton.validator.bean.simple.SimpleBeanValidatorEvent; -import org.nuiton.validator.bean.simple.SimpleBeanValidatorListener; -import org.nuiton.validator.bean.simple.SimpleBeanValidatorMessage; - -import java.util.Collection; -import java.util.Deque; -import java.util.HashSet; -import java.util.LinkedList; -import java.util.Set; - -/** - * Le detecteur de messages de validation. - * - * @author Tony Chemit - chemit@codelutin.com - * @since 1.3 - */ -public class ValidationMessageDetector implements SimpleBeanValidatorListener { - - /** Logger */ - private static final Log log = - LogFactory.getLog(ValidationMessageDetector.class); - - public static final String SEPARATOR = "/"; - - /** le path courant depuis le depart */ - protected Deque<IdDto> path; - - /** le dictionnaire des paths d'entites detectees */ -// protected SortedMap<TopiaEntityRef, List<SimpleBeanValidatorMessage<?>>> refs; - - protected StringBuilder accessorExpression; - - protected IdDto root; - -// protected TopiaEntityRef currentRef; - - protected Set<IdDto> explored; - - /** le dictionnaire des validateurs utilisables */ - protected final ValidatorsMap validators; - - protected ValidationContext context; - - public ValidationContext getContext() { - if (context == null) { - ObserveSwingApplicationContext applicationContext = ObserveSwingApplicationContext.get(); - context = applicationContext.getValidationContext(); - } - return context; - } - - public ValidationMessageDetector(ValidatorsMap validators) { - this.validators = validators; - path = new LinkedList<>(); - explored = new HashSet<>(); - //FIXME -// refs = new TreeMap<TopiaEntityRef, List<SimpleBeanValidatorMessage<?>>>(); - accessorExpression = new StringBuilder(); - for (SimpleBeanValidator<?> v : validators.values()) { - v.setBean(null); - } - } - - public void detectMessages(IdDto... entities) { -// try { - // on reinitialise tous les validateurs -// for (BeanValidator<?> v : validators.values()) { -// v.setBean(null); -//// v.setContextName(contextName); -// } - for (IdDto e : entities) { - if (log.isDebugEnabled()) { - log.debug("start for entity " + e.getId()); - } - // détection sur l'entité e - //FIXME -// try { -// e.accept(this); -// } catch (TopiaException e1) { -// throw new RuntimeException("could not vist entity " + e.getTopiaId(), e1); -// } - } - } - -// @Override - public void start(IdDto e) { - if (root == null) { - // start come in start method since - // last clear method invocation - root = e; - addPath(e, "$root", -1); - } - explored.add(e); - SimpleBeanValidator<IdDto> validator = getValidator(e); - if (log.isDebugEnabled()) { - log.debug("with entity " + e.getId() + " : " + accessorExpression); - } - if (validator != null) { - validator.addSimpleBeanValidatorListener(this); - addEntityInContext(e); - //FIXME -// try { -// currentRef = new TopiaEntityRef( -// root, -// e, -// accessorExpression.toString(), -// path.toArray(new TopiaEntity[path.size()])); -// validator.setBean(e); -// } finally { -// validator.removeSimpleBeanValidatorListener(this); -// validator.setBean(null); -// } - } - } - -// @Override - public void end(IdDto e) { - if (root != null && root.equals(e)) { - // global visit is done - root = null; - removePath(); - } - removeEntityFromContext(e); - } - - private void addEntityInContext(IdDto e) { - - DataContext context = getContext().getDataContext(); - - //FIXME -// ObserveEntityEnum anEnum = ObserveEntityEnum.valueOf(e); -// switch (anEnum) { -// case Route: -// context.setSelectedRouteId(e.getTopiaId()); -// break; -// case TripSeine: { -// context.setSelectedTripId(e.getTopiaId()); -// Program program = ((TripSeine) e).getProgram(); -// if (program != null) { -// context.setSelectedProgramId(program.getTopiaId()); -// } else { -// context.setSelectedProgramId(null); -// } -// } -// break; -// case ActivitySeine: -// context.setSelectedActivityId(e.getTopiaId()); -// break; -// case SetSeine: -// context.setSelectedSetId(e.getTopiaId()); -// break; -// case TripLongline: { -// context.setSelectedTripId(e.getTopiaId()); -// Program program = ((TripLongline) e).getProgram(); -// if (program != null) { -// context.setSelectedProgramId(program.getTopiaId()); -// } else { -// context.setSelectedProgramId(null); -// } -// } -// break; -// case ActivityLongline: -// context.setSelectedActivityId(e.getTopiaId()); -// break; -// case SetLongline: -// context.setSelectedSetId(e.getTopiaId()); -// break; -// case FloatingObject: -// context.setSelectedFloatingObjectId(e.getTopiaId()); -// break; -// case NonTargetLength: -// break; -// case TargetLength: -// break; -// case TransmittingBuoy: -// break; -// case NonTargetCatch: -// break; -// case TargetCatch: -// break; -// case NonTargetSample: -// break; -// case TargetSample: -// break; -// case ObjectObservedSpecies: -// break; -// case SchoolEstimate: -// break; -// case ObjectSchoolEstimate: -// break; -// case VesselActivitySeine: -// break; -// case SurroundingActivity: -// break; -// case Vessel: -// break; -// case VesselSizeCategory: -// break; -// case WeightCategory: -// break; -// case ReasonForNullSet: -// break; -// case ReasonForNoFishing: -// break; -// case SpeciesFate: -// break; -// case ObjectFate: -// break; -// case Species: -// break; -// case SpeciesGroup: -// break; -// case DetectionMode: -// break; -// case Person: -// break; -// case Ocean: -// break; -// case TransmittingBuoyOperation: -// break; -// case ObjectOperation: -// break; -// case Organism: -// break; -// case LengthWeightParameter: -// break; -// case Country: -// break; -// case Program: -// break; -// case ReasonForDiscard: -// break; -// case SpeciesStatus: -// break; -// case ObservedSystem: -// break; -// case TransmittingBuoyType: -// break; -// case VesselType: -// break; -// case ObjectType: -// break; -// case Wind: -// break; -// } - } - - private void removeEntityFromContext(IdDto e) { - - DataContext context = getContext().getDataContext(); - - //FIXME -// ObserveEntityEnum anEnum = ObserveEntityEnum.valueOf(e); -// switch (anEnum) { -// case Route: -// context.setSelectedRouteId(null); -// break; -// case TripSeine: -// context.setSelectedTripId(null); -// context.setSelectedProgramId(null); -// break; -// case ActivitySeine: -// context.setSelectedActivityId(null); -// break; -// case SetSeine: -// context.setSelectedSetId(null); -// break; -// case TripLongline: -// context.setSelectedTripId(null); -// context.setSelectedProgramId(null); -// break; -// case ActivityLongline: -// context.setSelectedActivityId(null); -// break; -// case SetLongline: -// context.setSelectedSetId(null); -// break; -// case FloatingObject: -// context.setSelectedFloatingObjectId(null); -// break; -// case NonTargetLength: -// break; -// case TargetLength: -// break; -// case TransmittingBuoy: -// break; -// case NonTargetCatch: -// break; -// case TargetCatch: -// break; -// case NonTargetSample: -// break; -// case TargetSample: -// break; -// case ObjectObservedSpecies: -// break; -// case SchoolEstimate: -// break; -// case ObjectSchoolEstimate: -// break; -// case VesselActivitySeine: -// break; -// case SurroundingActivity: -// break; -// case Vessel: -// break; -// case VesselSizeCategory: -// break; -// case WeightCategory: -// break; -// case ReasonForNullSet: -// break; -// case ReasonForNoFishing: -// break; -// case SpeciesFate: -// break; -// case ObjectFate: -// break; -// case Species: -// break; -// case SpeciesGroup: -// break; -// case DetectionMode: -// break; -// case Person: -// break; -// case Ocean: -// break; -// case TransmittingBuoyOperation: -// break; -// case ObjectOperation: -// break; -// case Organism: -// break; -// case LengthWeightParameter: -// break; -// case Country: -// break; -// case Program: -// break; -// case ReasonForDiscard: -// break; -// case SpeciesStatus: -// break; -// case ObservedSystem: -// break; -// case TransmittingBuoyType: -// break; -// case VesselType: -// break; -// case ObjectType: -// break; -// case Wind: -// break; -// } - } - -// @Override - public void visit(IdDto e, - String name, - Class<?> type, - Object value) { - IdDto e1 = getTopiaValue(value); - if (e1 != null) { - addPath(e1, name, -1); - try { - //FIXME -// try { -// e1.accept(this); -// } catch (TopiaException ex) { -// if (log.isErrorEnabled()) { -// log.error(ex.getMessage(), ex); -// } -// } - } finally { - removePath(); - } - } - } - -// @Override - public void visit(IdDto e, - String name, - Class<?> collectionType, - Class<?> type, - int index, - Object value) { - IdDto e1 = getTopiaValue(value); - if (e1 != null) { - addPath(e1, name, index); - try { - //FIXME -// try { -// e1.accept(this); -// } catch (TopiaException ex) { -// if (log.isErrorEnabled()) { -// log.error(ex.getMessage(), ex); -// } -// } - } finally { - removePath(); - } - } - } - -// @Override - public void visit(IdDto e, - String name, - Class<?> collectionType, - Class<?> type, - Object value) { - Collection<?> cValue = (Collection<?>) value; - if (IdDto.class.isAssignableFrom(type) && - cValue != null && !cValue.isEmpty()) { - int i = 0; - for (Object currentValue : cValue) { - visit(e, name, collectionType, type, i++, currentValue); - } - } - } - - //FIXME -// public SortedMap<TopiaEntityRef, List<SimpleBeanValidatorMessage<?>>> getRefs() { -// // on renvoie toujours une copie -// // pour pouvoir au plus tôt nettoyer le detecteur -// TreeMap<TopiaEntityRef, List<SimpleBeanValidatorMessage<?>>> result; -// result = new TreeMap<TopiaEntityRef, List<SimpleBeanValidatorMessage<?>>>(refs); -// return result; -// } - - //FIXME -// @Override - public void clear() { - path.clear(); -// refs.clear(); - root = null; - explored.clear(); - accessorExpression.setLength(0); - } - - protected IdDto getTopiaValue(Object value) { - IdDto topiaEntity = (IdDto) (value != null && - value instanceof IdDto ? value : null); - if (topiaEntity != null && explored.contains(topiaEntity)) { - // entite deja visitee - topiaEntity = null; - } - return topiaEntity; - } - - protected <T extends IdDto> SimpleBeanValidator<T> getValidator(T e) { - Class<T> contractClass; - //FIXME -// contractClass = (Class<T>) ObserveDAOHelper.getContractClass(e.getClass()); -// return validators.getValidator(contractClass); - return null; - } - - protected void addPath(IdDto e, String name, int index) { - path.add(e); - if (accessorExpression.length() > 0) { - accessorExpression.append(SEPARATOR); - } - accessorExpression.append(name); - if (index > -1) { - //FIXME - accessorExpression.append("[@topiaId=\""); - accessorExpression.append(e.getId()); - accessorExpression.append("\"]"); - } - if (log.isTraceEnabled()) { - log.trace("add to stack : " + e.getId() + ", new size : " + - path.size() + ", path : " + accessorExpression); - } - } - - protected void removePath() { - IdDto e = path.removeLast(); - if (path.isEmpty()) { - accessorExpression.setLength(0); - } else { - int index = accessorExpression.lastIndexOf(SEPARATOR); - if (index > -1) { - accessorExpression.delete(index, - accessorExpression.length()); - } - } - if (log.isTraceEnabled()) { - log.trace("remove from stack : " + e.getId() + - ", new size : " + path.size() + ", path : " + - accessorExpression); - } - } - - @Override - public void onFieldChanged(SimpleBeanValidatorEvent event) { - SimpleBeanValidator<?> validator = event.getSource(); - - // on ne traite que les messages a ajouter - String[] messagesToAdd = event.getMessagesToAdd(); - - if (messagesToAdd == null || messagesToAdd.length == 0) { - return; - } - - //FIXME -// if (log.isDebugEnabled()) { -// log.debug("will add " + Arrays.toString(messagesToAdd) + -// " for " + currentRef.getAccessorExpression()); -// } -// List<SimpleBeanValidatorMessage<?>> list = refs.get(currentRef); -// if (list == null) { -// // first time for this entity -// list = new ArrayList<SimpleBeanValidatorMessage<?>>(); -// refs.put(currentRef, list); -// } - for (String m : messagesToAdd) { - SimpleBeanValidatorMessage<?> message; - message = new SimpleBeanValidatorMessage( - validator, - event.getField(), - m, - event.getScope()); - if (log.isDebugEnabled()) { - log.debug("add message " + message); - } - //FIXME -// list.add(message); - } - } -} diff --git a/observe-application-swing/src/test/java/fr/ird/observe/ui/content/impl/longline/LonglineDetailCompositionValidatorServiceTest.java b/observe-application-swing/src/test/java/fr/ird/observe/ui/content/impl/longline/LonglineDetailCompositionValidatorServiceTest.java index f84dbf2..4bedf20 100644 --- a/observe-application-swing/src/test/java/fr/ird/observe/ui/content/impl/longline/LonglineDetailCompositionValidatorServiceTest.java +++ b/observe-application-swing/src/test/java/fr/ird/observe/ui/content/impl/longline/LonglineDetailCompositionValidatorServiceTest.java @@ -59,7 +59,7 @@ public class LonglineDetailCompositionValidatorServiceTest { protected LonglineDetailCompositionUIValidationHelper.LonglineDetailCompositionValidatorService service; @Before - public void setUp() throws Exception { + public void setUp() { if (ObserveSwingApplicationContext.isInit()) { diff --git a/observe-application-web/src/main/java/fr/ird/observe/application/web/ObserveWebMotionRender.java b/observe-application-web/src/main/java/fr/ird/observe/application/web/ObserveWebMotionRender.java index 07905fb..106e90a 100644 --- a/observe-application-web/src/main/java/fr/ird/observe/application/web/ObserveWebMotionRender.java +++ b/observe-application-web/src/main/java/fr/ird/observe/application/web/ObserveWebMotionRender.java @@ -40,7 +40,7 @@ import java.io.PrintWriter; */ public class ObserveWebMotionRender<T> extends Render { - protected T model; + protected final T model; public ObserveWebMotionRender(T model) { this.model = model; diff --git a/observe-application-web/src/main/java/fr/ird/observe/application/web/configuration/ObserveWebApplicationConfigurationOption.java b/observe-application-web/src/main/java/fr/ird/observe/application/web/configuration/ObserveWebApplicationConfigurationOption.java index 2776124..817d5d9 100644 --- a/observe-application-web/src/main/java/fr/ird/observe/application/web/configuration/ObserveWebApplicationConfigurationOption.java +++ b/observe-application-web/src/main/java/fr/ird/observe/application/web/configuration/ObserveWebApplicationConfigurationOption.java @@ -31,7 +31,6 @@ import org.nuiton.version.Version; import java.io.File; import java.net.URL; import java.util.Collections; -import java.util.Comparator; import java.util.List; import static org.nuiton.i18n.I18n.n; @@ -125,13 +124,7 @@ public enum ObserveWebApplicationConfigurationOption implements ConfigOptionDef public static ImmutableList<ObserveWebApplicationConfigurationOption> orderedByNameValues() { List<ObserveWebApplicationConfigurationOption> values = Lists.newArrayList(values()); - Collections.sort(values, new Comparator<ObserveWebApplicationConfigurationOption>() { - - @Override - public int compare(ObserveWebApplicationConfigurationOption o1, ObserveWebApplicationConfigurationOption o2) { - return o1.getKey().compareTo(o2.getKey()); - } - }); + Collections.sort(values, (o1, o2) -> o1.getKey().compareTo(o2.getKey())); return ImmutableList.copyOf(values); } diff --git a/observe-application-web/src/main/java/fr/ird/observe/application/web/configuration/db/ObserveWebDatabase.java b/observe-application-web/src/main/java/fr/ird/observe/application/web/configuration/db/ObserveWebDatabase.java index 5c5d22a..1003be9 100644 --- a/observe-application-web/src/main/java/fr/ird/observe/application/web/configuration/db/ObserveWebDatabase.java +++ b/observe-application-web/src/main/java/fr/ird/observe/application/web/configuration/db/ObserveWebDatabase.java @@ -22,9 +22,8 @@ package fr.ird.observe.application.web.configuration.db; * #L% */ -import com.google.common.base.Optional; - import java.util.Collection; +import java.util.Optional; /** * Created on 30/08/15. diff --git a/observe-application-web/src/main/java/fr/ird/observe/application/web/configuration/db/ObserveWebDatabases.java b/observe-application-web/src/main/java/fr/ird/observe/application/web/configuration/db/ObserveWebDatabases.java index 9f9072c..16930fb 100644 --- a/observe-application-web/src/main/java/fr/ird/observe/application/web/configuration/db/ObserveWebDatabases.java +++ b/observe-application-web/src/main/java/fr/ird/observe/application/web/configuration/db/ObserveWebDatabases.java @@ -22,9 +22,8 @@ package fr.ird.observe.application.web.configuration.db; * #L% */ -import com.google.common.base.Optional; - import java.util.Collection; +import java.util.Optional; /** * Created on 30/08/15. diff --git a/observe-application-web/src/main/java/fr/ird/observe/application/web/configuration/db/impl/ObserveWebDatabaseBean.java b/observe-application-web/src/main/java/fr/ird/observe/application/web/configuration/db/impl/ObserveWebDatabaseBean.java index 16d9dbd..5fcb4dc 100644 --- a/observe-application-web/src/main/java/fr/ird/observe/application/web/configuration/db/impl/ObserveWebDatabaseBean.java +++ b/observe-application-web/src/main/java/fr/ird/observe/application/web/configuration/db/impl/ObserveWebDatabaseBean.java @@ -22,12 +22,11 @@ package fr.ird.observe.application.web.configuration.db.impl; * #L% */ -import com.google.common.base.Function; -import com.google.common.base.Optional; import com.google.common.collect.Iterables; import fr.ird.observe.application.web.configuration.db.ObserveWebDatabase; import java.util.LinkedHashSet; +import java.util.Optional; /** * Created on 30/08/15. @@ -85,12 +84,6 @@ public class ObserveWebDatabaseBean implements ObserveWebDatabase<ObserveWebData } public ObserveWebDatabaseImmutable toImmutable() { - return new ObserveWebDatabaseImmutable(name, defaultDatabase, url, Iterables.transform(roles, new Function<ObserveWebDatabaseRoleBean, ObserveWebDatabaseRoleImmutable>() { - - @Override - public ObserveWebDatabaseRoleImmutable apply(ObserveWebDatabaseRoleBean input) { - return input.toImmutable(); - } - })); + return new ObserveWebDatabaseImmutable(name, defaultDatabase, url, Iterables.transform(roles, ObserveWebDatabaseRoleBean::toImmutable)); } } diff --git a/observe-application-web/src/main/java/fr/ird/observe/application/web/configuration/db/impl/ObserveWebDatabaseImmutable.java b/observe-application-web/src/main/java/fr/ird/observe/application/web/configuration/db/impl/ObserveWebDatabaseImmutable.java index 5a0df27..9409318 100644 --- a/observe-application-web/src/main/java/fr/ird/observe/application/web/configuration/db/impl/ObserveWebDatabaseImmutable.java +++ b/observe-application-web/src/main/java/fr/ird/observe/application/web/configuration/db/impl/ObserveWebDatabaseImmutable.java @@ -22,8 +22,6 @@ package fr.ird.observe.application.web.configuration.db.impl; * #L% */ -import com.google.common.base.Function; -import com.google.common.base.Optional; import com.google.common.collect.ImmutableMap; import com.google.common.collect.Iterables; import com.google.common.collect.Maps; @@ -31,6 +29,7 @@ import com.google.common.collect.Sets; import fr.ird.observe.application.web.configuration.db.ObserveWebDatabase; import java.util.Collection; +import java.util.Optional; /** * Created on 30/08/15. @@ -54,13 +53,7 @@ public class ObserveWebDatabaseImmutable implements ObserveWebDatabase<ObserveWe this.name = name; this.defaultDatabase = defaultDatabase; this.url = url; - this.roles = Maps.uniqueIndex(roles, new Function<ObserveWebDatabaseRoleImmutable, String>() { - - @Override - public String apply(ObserveWebDatabaseRoleImmutable input) { - return input.getLogin(); - } - }); + this.roles = Maps.uniqueIndex(roles, input -> input.getLogin()); } @Override @@ -86,7 +79,7 @@ public class ObserveWebDatabaseImmutable implements ObserveWebDatabase<ObserveWe @Override public Optional<ObserveWebDatabaseRoleImmutable> getDatabaseRoleByLogin(String login) { ObserveWebDatabaseRoleImmutable observeWebDatabaseRole = roles.get(login); - return Optional.fromNullable(observeWebDatabaseRole); + return Optional.ofNullable(observeWebDatabaseRole); } public ObserveWebDatabaseBean toBean() { @@ -94,13 +87,7 @@ public class ObserveWebDatabaseImmutable implements ObserveWebDatabase<ObserveWe observeWebDatabaseBean.setDefaultDatabase(defaultDatabase); observeWebDatabaseBean.setName(name); observeWebDatabaseBean.setUrl(url); - observeWebDatabaseBean.setRoles(Sets.newLinkedHashSet(Iterables.transform(getRoles(), new Function<ObserveWebDatabaseRoleImmutable, ObserveWebDatabaseRoleBean>() { - - @Override - public ObserveWebDatabaseRoleBean apply(ObserveWebDatabaseRoleImmutable input) { - return input.toBean(); - } - }))); + observeWebDatabaseBean.setRoles(Sets.newLinkedHashSet(Iterables.transform(getRoles(), ObserveWebDatabaseRoleImmutable::toBean))); return observeWebDatabaseBean; } diff --git a/observe-application-web/src/main/java/fr/ird/observe/application/web/configuration/db/impl/ObserveWebDatabasesBean.java b/observe-application-web/src/main/java/fr/ird/observe/application/web/configuration/db/impl/ObserveWebDatabasesBean.java index efd3385..d70c074 100644 --- a/observe-application-web/src/main/java/fr/ird/observe/application/web/configuration/db/impl/ObserveWebDatabasesBean.java +++ b/observe-application-web/src/main/java/fr/ird/observe/application/web/configuration/db/impl/ObserveWebDatabasesBean.java @@ -22,12 +22,11 @@ package fr.ird.observe.application.web.configuration.db.impl; * #L% */ -import com.google.common.base.Function; -import com.google.common.base.Optional; import com.google.common.collect.Iterables; import fr.ird.observe.application.web.configuration.db.ObserveWebDatabases; import java.util.LinkedHashSet; +import java.util.Optional; /** * Created on 30/08/15. @@ -60,13 +59,7 @@ public class ObserveWebDatabasesBean implements ObserveWebDatabases<ObserveWebDa public ObserveWebDatabasesImmutable toImmutable() { - return new ObserveWebDatabasesImmutable(Iterables.transform(databases, new Function<ObserveWebDatabaseBean, ObserveWebDatabaseImmutable>() { - - @Override - public ObserveWebDatabaseImmutable apply(ObserveWebDatabaseBean input) { - return input.toImmutable(); - } - })); + return new ObserveWebDatabasesImmutable(Iterables.transform(databases, input -> input.toImmutable())); } public void setDatabases(LinkedHashSet<ObserveWebDatabaseBean> databases) { diff --git a/observe-application-web/src/main/java/fr/ird/observe/application/web/configuration/db/impl/ObserveWebDatabasesImmutable.java b/observe-application-web/src/main/java/fr/ird/observe/application/web/configuration/db/impl/ObserveWebDatabasesImmutable.java index 98840af..160be2c 100644 --- a/observe-application-web/src/main/java/fr/ird/observe/application/web/configuration/db/impl/ObserveWebDatabasesImmutable.java +++ b/observe-application-web/src/main/java/fr/ird/observe/application/web/configuration/db/impl/ObserveWebDatabasesImmutable.java @@ -22,8 +22,6 @@ package fr.ird.observe.application.web.configuration.db.impl; * #L% */ -import com.google.common.base.Function; -import com.google.common.base.Optional; import com.google.common.collect.ImmutableMap; import com.google.common.collect.Iterables; import com.google.common.collect.Maps; @@ -31,6 +29,7 @@ import com.google.common.collect.Sets; import fr.ird.observe.application.web.configuration.db.ObserveWebDatabases; import java.util.Collection; +import java.util.Optional; /** * Created on 30/08/15. @@ -44,13 +43,7 @@ public class ObserveWebDatabasesImmutable implements ObserveWebDatabases<Observe private final ObserveWebDatabaseImmutable defaultDatabase; public ObserveWebDatabasesImmutable(Iterable<ObserveWebDatabaseImmutable> databases) { - this.databases = Maps.uniqueIndex(databases, new Function<ObserveWebDatabaseImmutable, String>() { - - @Override - public String apply(ObserveWebDatabaseImmutable input) { - return input.getName(); - } - }); + this.databases = Maps.uniqueIndex(databases, input -> input.getName()); ObserveWebDatabaseImmutable defaultDb = null; for (ObserveWebDatabaseImmutable database : databases) { @@ -81,18 +74,12 @@ public class ObserveWebDatabasesImmutable implements ObserveWebDatabases<Observe @Override public Optional<ObserveWebDatabaseImmutable> getDatabaseByName(String databaseName) { ObserveWebDatabaseImmutable database = databases.get(databaseName); - return Optional.fromNullable(database); + return Optional.ofNullable(database); } public ObserveWebDatabasesBean toBean() { ObserveWebDatabasesBean observeWebDatabasesBean = new ObserveWebDatabasesBean(); - observeWebDatabasesBean.setDatabases(Sets.newLinkedHashSet(Iterables.transform(getDatabases(), new Function<ObserveWebDatabaseImmutable, ObserveWebDatabaseBean>() { - - @Override - public ObserveWebDatabaseBean apply(ObserveWebDatabaseImmutable input) { - return input.toBean(); - } - }))); + observeWebDatabasesBean.setDatabases(Sets.newLinkedHashSet(Iterables.transform(getDatabases(), input -> input.toBean()))); return observeWebDatabasesBean; } diff --git a/observe-application-web/src/main/java/fr/ird/observe/application/web/configuration/user/ObserveWebUser.java b/observe-application-web/src/main/java/fr/ird/observe/application/web/configuration/user/ObserveWebUser.java index 90c4377..6f073a9 100644 --- a/observe-application-web/src/main/java/fr/ird/observe/application/web/configuration/user/ObserveWebUser.java +++ b/observe-application-web/src/main/java/fr/ird/observe/application/web/configuration/user/ObserveWebUser.java @@ -22,9 +22,8 @@ package fr.ird.observe.application.web.configuration.user; * #L% */ -import com.google.common.base.Optional; - import java.util.Collection; +import java.util.Optional; /** * Created on 30/08/15. diff --git a/observe-application-web/src/main/java/fr/ird/observe/application/web/configuration/user/ObserveWebUsers.java b/observe-application-web/src/main/java/fr/ird/observe/application/web/configuration/user/ObserveWebUsers.java index 665db68..a9dbbe3 100644 --- a/observe-application-web/src/main/java/fr/ird/observe/application/web/configuration/user/ObserveWebUsers.java +++ b/observe-application-web/src/main/java/fr/ird/observe/application/web/configuration/user/ObserveWebUsers.java @@ -22,9 +22,8 @@ package fr.ird.observe.application.web.configuration.user; * #L% */ -import com.google.common.base.Optional; - import java.util.Collection; +import java.util.Optional; /** * Created on 30/08/15. diff --git a/observe-application-web/src/main/java/fr/ird/observe/application/web/configuration/user/ObserveWebUsersHelper.java b/observe-application-web/src/main/java/fr/ird/observe/application/web/configuration/user/ObserveWebUsersHelper.java index acab15b..b0175eb 100644 --- a/observe-application-web/src/main/java/fr/ird/observe/application/web/configuration/user/ObserveWebUsersHelper.java +++ b/observe-application-web/src/main/java/fr/ird/observe/application/web/configuration/user/ObserveWebUsersHelper.java @@ -27,7 +27,6 @@ import com.esotericsoftware.yamlbeans.YamlException; import com.esotericsoftware.yamlbeans.YamlReader; import com.esotericsoftware.yamlbeans.YamlWriter; import com.google.common.base.Charsets; -import com.google.common.base.Optional; import com.google.common.io.Files; import fr.ird.observe.application.web.configuration.db.ObserveWebDatabase; import fr.ird.observe.application.web.configuration.db.ObserveWebDatabaseRole; @@ -46,6 +45,7 @@ import java.io.File; import java.io.Reader; import java.io.Writer; import java.util.LinkedHashSet; +import java.util.Optional; import java.util.Set; /** @@ -81,7 +81,7 @@ public class ObserveWebUsersHelper { return result; } - public void validateObserveWebUsersBean(ObserveWebDatabases databases, ObserveWebUsersBean observeWebUsersBean) throws InvalidObserveWebUsersException, InvalidObserveWebUserException, InvalidObserveWebUserPermissionException { + public void validateObserveWebUsersBean(ObserveWebDatabases databases, ObserveWebUsersBean observeWebUsersBean) throws InvalidObserveWebUserException, InvalidObserveWebUserPermissionException { if (CollectionUtils.isEmpty(observeWebUsersBean.getUsers())) { throw new InvalidObserveWebUserException("No user defined"); diff --git a/observe-application-web/src/main/java/fr/ird/observe/application/web/configuration/user/impl/ObserveWebUserBean.java b/observe-application-web/src/main/java/fr/ird/observe/application/web/configuration/user/impl/ObserveWebUserBean.java index d141460..84d4354 100644 --- a/observe-application-web/src/main/java/fr/ird/observe/application/web/configuration/user/impl/ObserveWebUserBean.java +++ b/observe-application-web/src/main/java/fr/ird/observe/application/web/configuration/user/impl/ObserveWebUserBean.java @@ -22,12 +22,11 @@ package fr.ird.observe.application.web.configuration.user.impl; * #L% */ -import com.google.common.base.Function; -import com.google.common.base.Optional; import com.google.common.collect.Iterables; import fr.ird.observe.application.web.configuration.user.ObserveWebUser; import java.util.LinkedHashSet; +import java.util.Optional; /** * Created on 30/08/15. @@ -75,13 +74,7 @@ public class ObserveWebUserBean implements ObserveWebUser<ObserveWebUserPermissi } public ObserveWebUserImmutable toImmutable() { - return new ObserveWebUserImmutable(login, password, Iterables.transform(roles, new Function<ObserveWebUserPermissionBean, ObserveWebUserPermissionImmutable>() { - - @Override - public ObserveWebUserPermissionImmutable apply(ObserveWebUserPermissionBean input) { - return input.toImmutable(); - } - })); + return new ObserveWebUserImmutable(login, password, Iterables.transform(roles, ObserveWebUserPermissionBean::toImmutable)); } } diff --git a/observe-application-web/src/main/java/fr/ird/observe/application/web/configuration/user/impl/ObserveWebUserImmutable.java b/observe-application-web/src/main/java/fr/ird/observe/application/web/configuration/user/impl/ObserveWebUserImmutable.java index d9aaf9b..de23bce 100644 --- a/observe-application-web/src/main/java/fr/ird/observe/application/web/configuration/user/impl/ObserveWebUserImmutable.java +++ b/observe-application-web/src/main/java/fr/ird/observe/application/web/configuration/user/impl/ObserveWebUserImmutable.java @@ -22,8 +22,6 @@ package fr.ird.observe.application.web.configuration.user.impl; * #L% */ -import com.google.common.base.Function; -import com.google.common.base.Optional; import com.google.common.collect.ImmutableMap; import com.google.common.collect.Iterables; import com.google.common.collect.Maps; @@ -31,6 +29,7 @@ import com.google.common.collect.Sets; import fr.ird.observe.application.web.configuration.user.ObserveWebUser; import java.util.Collection; +import java.util.Optional; /** * Created on 30/08/15. @@ -49,13 +48,7 @@ public class ObserveWebUserImmutable implements ObserveWebUser<ObserveWebUserPer this.login = login; this.password = password; - this.permissions = Maps.uniqueIndex(permissions, new Function<ObserveWebUserPermissionImmutable, String>() { - - @Override - public String apply(ObserveWebUserPermissionImmutable input) { - return input.getDatabase(); - } - }); + this.permissions = Maps.uniqueIndex(permissions, ObserveWebUserPermissionImmutable::getDatabase); } @@ -76,20 +69,14 @@ public class ObserveWebUserImmutable implements ObserveWebUser<ObserveWebUserPer @Override public Optional<ObserveWebUserPermissionImmutable> getPermissionByDatabaseName(String databaseName) { - return Optional.fromNullable(permissions.get(databaseName)); + return Optional.ofNullable(permissions.get(databaseName)); } public ObserveWebUserBean toBean() { ObserveWebUserBean observeWebUserBean = new ObserveWebUserBean(); observeWebUserBean.setLogin(login); observeWebUserBean.setPassword(password); - observeWebUserBean.setPermissions(Sets.newLinkedHashSet(Iterables.transform(getPermissions(), new Function<ObserveWebUserPermissionImmutable, ObserveWebUserPermissionBean>() { - - @Override - public ObserveWebUserPermissionBean apply(ObserveWebUserPermissionImmutable input) { - return input.toBean(); - } - }))); + observeWebUserBean.setPermissions(Sets.newLinkedHashSet(Iterables.transform(getPermissions(), ObserveWebUserPermissionImmutable::toBean))); return observeWebUserBean; } diff --git a/observe-application-web/src/main/java/fr/ird/observe/application/web/configuration/user/impl/ObserveWebUsersBean.java b/observe-application-web/src/main/java/fr/ird/observe/application/web/configuration/user/impl/ObserveWebUsersBean.java index 1bdc870..e18a763 100644 --- a/observe-application-web/src/main/java/fr/ird/observe/application/web/configuration/user/impl/ObserveWebUsersBean.java +++ b/observe-application-web/src/main/java/fr/ird/observe/application/web/configuration/user/impl/ObserveWebUsersBean.java @@ -22,12 +22,11 @@ package fr.ird.observe.application.web.configuration.user.impl; * #L% */ -import com.google.common.base.Function; -import com.google.common.base.Optional; import com.google.common.collect.Iterables; import fr.ird.observe.application.web.configuration.user.ObserveWebUsers; import java.util.LinkedHashSet; +import java.util.Optional; /** * Created on 30/08/15. @@ -53,13 +52,7 @@ public class ObserveWebUsersBean implements ObserveWebUsers<ObserveWebUserBean> } public ObserveWebUsersImmutable toImmutable() { - return new ObserveWebUsersImmutable(Iterables.transform(users, new Function<ObserveWebUserBean, ObserveWebUserImmutable>() { - - @Override - public ObserveWebUserImmutable apply(ObserveWebUserBean input) { - return input.toImmutable(); - } - })); + return new ObserveWebUsersImmutable(Iterables.transform(users, ObserveWebUserBean::toImmutable)); } } diff --git a/observe-application-web/src/main/java/fr/ird/observe/application/web/configuration/user/impl/ObserveWebUsersImmutable.java b/observe-application-web/src/main/java/fr/ird/observe/application/web/configuration/user/impl/ObserveWebUsersImmutable.java index 3510b4e..7f4fe68 100644 --- a/observe-application-web/src/main/java/fr/ird/observe/application/web/configuration/user/impl/ObserveWebUsersImmutable.java +++ b/observe-application-web/src/main/java/fr/ird/observe/application/web/configuration/user/impl/ObserveWebUsersImmutable.java @@ -22,8 +22,6 @@ package fr.ird.observe.application.web.configuration.user.impl; * #L% */ -import com.google.common.base.Function; -import com.google.common.base.Optional; import com.google.common.collect.ImmutableMap; import com.google.common.collect.Iterables; import com.google.common.collect.Maps; @@ -31,6 +29,7 @@ import com.google.common.collect.Sets; import fr.ird.observe.application.web.configuration.user.ObserveWebUsers; import java.util.Collection; +import java.util.Optional; /** * Created on 30/08/15. @@ -42,13 +41,7 @@ public class ObserveWebUsersImmutable implements ObserveWebUsers<ObserveWebUserI private final ImmutableMap<String, ObserveWebUserImmutable> users; public ObserveWebUsersImmutable(Iterable<ObserveWebUserImmutable> users) { - this.users = Maps.uniqueIndex(users, new Function<ObserveWebUserImmutable, String>() { - - @Override - public String apply(ObserveWebUserImmutable input) { - return input.getLogin(); - } - }); + this.users = Maps.uniqueIndex(users, ObserveWebUserImmutable::getLogin); } @Override @@ -58,18 +51,12 @@ public class ObserveWebUsersImmutable implements ObserveWebUsers<ObserveWebUserI @Override public Optional<ObserveWebUserImmutable> getUserByLogin(String login) { - return Optional.fromNullable(users.get(login)); + return Optional.ofNullable(users.get(login)); } public ObserveWebUsersBean toBean() { ObserveWebUsersBean observeWebUsersBean = new ObserveWebUsersBean(); - observeWebUsersBean.setUsers(Sets.newLinkedHashSet(Iterables.transform(getUsers(), new Function<ObserveWebUserImmutable, ObserveWebUserBean>() { - - @Override - public ObserveWebUserBean apply(ObserveWebUserImmutable input) { - return input.toBean(); - } - }))); + observeWebUsersBean.setUsers(Sets.newLinkedHashSet(Iterables.transform(getUsers(), ObserveWebUserImmutable::toBean))); return observeWebUsersBean; } } diff --git a/observe-application-web/src/main/java/fr/ird/observe/application/web/controller/v1/DataSourceServiceController.java b/observe-application-web/src/main/java/fr/ird/observe/application/web/controller/v1/DataSourceServiceController.java index c95c772..a4d2513 100644 --- a/observe-application-web/src/main/java/fr/ird/observe/application/web/controller/v1/DataSourceServiceController.java +++ b/observe-application-web/src/main/java/fr/ird/observe/application/web/controller/v1/DataSourceServiceController.java @@ -22,7 +22,6 @@ package fr.ird.observe.application.web.controller.v1; * #L% */ -import com.google.common.base.Optional; import com.google.common.base.Preconditions; import fr.ird.observe.application.web.request.ObserveWebRequestContext; import fr.ird.observe.application.web.security.ObserveWebSecurityApplicationContext; @@ -44,6 +43,7 @@ import fr.ird.observe.services.service.DatabaseNotFoundException; import org.apache.commons.logging.Log; import org.apache.commons.logging.LogFactory; +import java.util.Optional; import java.util.Set; /** diff --git a/observe-application-web/src/main/java/fr/ird/observe/application/web/converter/ObserveDtoConverter.java b/observe-application-web/src/main/java/fr/ird/observe/application/web/converter/ObserveDtoConverter.java index a892019..1d85b3d 100644 --- a/observe-application-web/src/main/java/fr/ird/observe/application/web/converter/ObserveDtoConverter.java +++ b/observe-application-web/src/main/java/fr/ird/observe/application/web/converter/ObserveDtoConverter.java @@ -47,7 +47,7 @@ public class ObserveDtoConverter extends AbstractConverter { @Override protected <T> T convertToType(Class<T> type, Object value) throws Throwable { - T observeDto = null; + T observeDto; if (ObserveDto.class.isAssignableFrom(type)) { diff --git a/observe-application-web/src/main/java/fr/ird/observe/application/web/injector/DateInjector.java b/observe-application-web/src/main/java/fr/ird/observe/application/web/injector/DateInjector.java index ad28bac..8f14c73 100644 --- a/observe-application-web/src/main/java/fr/ird/observe/application/web/injector/DateInjector.java +++ b/observe-application-web/src/main/java/fr/ird/observe/application/web/injector/DateInjector.java @@ -41,7 +41,7 @@ public class DateInjector implements ExecutorParametersInjectorHandler.Injector{ private static final Log log = LogFactory.getLog(DateInjector.class); - protected String datePattern; + protected final String datePattern; public DateInjector(String datePattern) { this.datePattern = datePattern; diff --git a/observe-application-web/src/main/java/fr/ird/observe/application/web/injector/ObserveDtoInjector.java b/observe-application-web/src/main/java/fr/ird/observe/application/web/injector/ObserveDtoInjector.java index 29891c5..368402b 100644 --- a/observe-application-web/src/main/java/fr/ird/observe/application/web/injector/ObserveDtoInjector.java +++ b/observe-application-web/src/main/java/fr/ird/observe/application/web/injector/ObserveDtoInjector.java @@ -100,7 +100,7 @@ public class ObserveDtoInjector extends AbstractConverter implements ExecutorPar @Override protected <T> T convertToType(Class<T> type, Object value) throws Throwable { - T observeDto = null; + T observeDto; if (ObserveDto.class.isAssignableFrom(type)) { diff --git a/observe-application-web/src/main/java/fr/ird/observe/application/web/request/ObserveWebRequestContext.java b/observe-application-web/src/main/java/fr/ird/observe/application/web/request/ObserveWebRequestContext.java index b68e7ab..a65c905 100644 --- a/observe-application-web/src/main/java/fr/ird/observe/application/web/request/ObserveWebRequestContext.java +++ b/observe-application-web/src/main/java/fr/ird/observe/application/web/request/ObserveWebRequestContext.java @@ -22,20 +22,20 @@ package fr.ird.observe.application.web.request; * #L% */ -import com.google.common.base.Optional; import fr.ird.observe.application.web.ObserveWebApplicationContext; -import fr.ird.observe.services.security.AdminApiKeyNotFoundException; -import fr.ird.observe.services.security.AuthenticationTokenNotFoundException; -import fr.ird.observe.services.security.InvalidAdminKeyApiException; import fr.ird.observe.services.ObserveService; import fr.ird.observe.services.ObserveServiceInitializer; import fr.ird.observe.services.ObserveSpeciesListConfiguration; import fr.ird.observe.services.configuration.ObserveDataSourceConfiguration; import fr.ird.observe.services.configuration.ObserveDataSourceConfigurationAndConnection; import fr.ird.observe.services.dto.constants.ReferentialLocale; +import fr.ird.observe.services.security.AdminApiKeyNotFoundException; +import fr.ird.observe.services.security.AuthenticationTokenNotFoundException; +import fr.ird.observe.services.security.InvalidAdminKeyApiException; import org.debux.webmotion.server.call.HttpContext; import java.util.Locale; +import java.util.Optional; /** * Created on 4/25/14. @@ -80,8 +80,8 @@ public class ObserveWebRequestContext { this.applicationLocale = applicationLocale; this.referentialLocale = referentialLocale; this.speciesListConfiguration = speciesListConfiguration; - this.optionalAdminApiKey = Optional.fromNullable(adminApiKey); - this.optionalAuthenticationToken = Optional.fromNullable(authenticationToken); + this.optionalAdminApiKey = Optional.ofNullable(adminApiKey); + this.optionalAuthenticationToken = Optional.ofNullable(authenticationToken); } public ObserveWebApplicationContext getApplicationContext() { diff --git a/observe-application-web/src/main/java/fr/ird/observe/application/web/security/ObserveWebSecurityApplicationContext.java b/observe-application-web/src/main/java/fr/ird/observe/application/web/security/ObserveWebSecurityApplicationContext.java index 10bd677..9a7d63e 100644 --- a/observe-application-web/src/main/java/fr/ird/observe/application/web/security/ObserveWebSecurityApplicationContext.java +++ b/observe-application-web/src/main/java/fr/ird/observe/application/web/security/ObserveWebSecurityApplicationContext.java @@ -22,7 +22,6 @@ package fr.ird.observe.application.web.security; * #L% */ -import com.google.common.base.Optional; import com.google.common.base.Preconditions; import com.google.common.base.Strings; import com.google.common.collect.ImmutableMap; @@ -48,6 +47,7 @@ import org.nuiton.version.Version; import java.io.Closeable; import java.util.Objects; +import java.util.Optional; /** * Pour conserver les données applicatives liée à la sécurité (principale le cache des utilisateurs connectés). diff --git a/observe-application-web/src/main/java/fr/ird/observe/application/web/security/ObserveWebSecurityAuthenticationTokenCache.java b/observe-application-web/src/main/java/fr/ird/observe/application/web/security/ObserveWebSecurityAuthenticationTokenCache.java index 8f744b7..26196fd 100644 --- a/observe-application-web/src/main/java/fr/ird/observe/application/web/security/ObserveWebSecurityAuthenticationTokenCache.java +++ b/observe-application-web/src/main/java/fr/ird/observe/application/web/security/ObserveWebSecurityAuthenticationTokenCache.java @@ -25,7 +25,6 @@ package fr.ird.observe.application.web.security; import com.google.common.cache.Cache; import com.google.common.cache.CacheBuilder; import com.google.common.cache.RemovalListener; -import com.google.common.cache.RemovalNotification; import fr.ird.observe.services.configuration.ObserveDataSourceConfigurationAndConnection; import org.apache.commons.logging.Log; import org.apache.commons.logging.LogFactory; @@ -56,13 +55,9 @@ public class ObserveWebSecurityAuthenticationTokenCache implements Closeable { .maximumSize(maximumSize) .expireAfterWrite(expireDelay, TimeUnit.MINUTES) .expireAfterAccess(expireDelay, TimeUnit.MINUTES) - .removalListener(new RemovalListener<String, ObserveDataSourceConfigurationAndConnection>() { - - @Override - public void onRemoval(RemovalNotification<String, ObserveDataSourceConfigurationAndConnection> notification) { - if (log.isInfoEnabled()) { - log.info(String.format("Remove authentication token: %s - %s", notification.getKey(), notification.getValue())); - } + .removalListener((RemovalListener<String, ObserveDataSourceConfigurationAndConnection>) notification -> { + if (log.isInfoEnabled()) { + log.info(String.format("Remove authentication token: %s - %s", notification.getKey(), notification.getValue())); } }) .build(); diff --git a/observe-application-web/src/test/java/fr/ird/observe/application/web/configuration/db/ObserveWebDatabasesHelperTest.java b/observe-application-web/src/test/java/fr/ird/observe/application/web/configuration/db/ObserveWebDatabasesHelperTest.java index d67ab46..4e57dcd 100644 --- a/observe-application-web/src/test/java/fr/ird/observe/application/web/configuration/db/ObserveWebDatabasesHelperTest.java +++ b/observe-application-web/src/test/java/fr/ird/observe/application/web/configuration/db/ObserveWebDatabasesHelperTest.java @@ -23,7 +23,6 @@ package fr.ird.observe.application.web.configuration.db; */ import com.google.common.base.Charsets; -import com.google.common.base.Optional; import com.google.common.collect.Iterables; import com.google.common.io.Files; import fr.ird.observe.application.web.configuration.ObserveWebApplicationConfiguration; @@ -41,6 +40,7 @@ import java.io.File; import java.io.IOException; import java.util.Collection; import java.util.LinkedHashSet; +import java.util.Optional; import java.util.Set; /** @@ -88,7 +88,7 @@ public class ObserveWebDatabasesHelperTest { } @Before - public void setUp() throws IOException { + public void setUp() { configuration = new ObserveWebApplicationConfiguration("observeweb-test.conf"); configuration.init(); observeWebDatabasesHelper = new ObserveWebDatabasesHelper(); diff --git a/observe-application-web/src/test/java/fr/ird/observe/application/web/configuration/user/ObserveWebUsersHelperTest.java b/observe-application-web/src/test/java/fr/ird/observe/application/web/configuration/user/ObserveWebUsersHelperTest.java index e82bb24..45d7e0d 100644 --- a/observe-application-web/src/test/java/fr/ird/observe/application/web/configuration/user/ObserveWebUsersHelperTest.java +++ b/observe-application-web/src/test/java/fr/ird/observe/application/web/configuration/user/ObserveWebUsersHelperTest.java @@ -23,7 +23,6 @@ package fr.ird.observe.application.web.configuration.user; */ import com.google.common.base.Charsets; -import com.google.common.base.Optional; import com.google.common.collect.Iterables; import com.google.common.io.Files; import fr.ird.observe.application.web.configuration.ObserveWebApplicationConfiguration; @@ -43,6 +42,7 @@ import org.junit.Test; import java.io.File; import java.util.Collection; import java.util.LinkedHashSet; +import java.util.Optional; import java.util.Set; /** diff --git a/observe-business/src/main/java/fr/ird/observe/ObserveApplicationContext.java b/observe-business/src/main/java/fr/ird/observe/ObserveApplicationContext.java index a921cec..d3a1a18 100644 --- a/observe-business/src/main/java/fr/ird/observe/ObserveApplicationContext.java +++ b/observe-business/src/main/java/fr/ird/observe/ObserveApplicationContext.java @@ -48,7 +48,7 @@ import java.util.Locale; public class ObserveApplicationContext extends DefaultApplicationContext { /** Logger */ - static private Log log = LogFactory.getLog(ObserveApplicationContext.class); + private static final Log log = LogFactory.getLog(ObserveApplicationContext.class); /** the jaxx context entry to store the config */ public static final JAXXContextEntryDef<IObserveConfig> CONFIG_ENTRY_DEF = diff --git a/observe-business/src/main/java/fr/ird/observe/ObserveServiceHelper.java b/observe-business/src/main/java/fr/ird/observe/ObserveServiceHelper.java index e2b57d5..efb22d1 100644 --- a/observe-business/src/main/java/fr/ird/observe/ObserveServiceHelper.java +++ b/observe-business/src/main/java/fr/ird/observe/ObserveServiceHelper.java @@ -44,7 +44,7 @@ import static org.nuiton.i18n.I18n.n; public class ObserveServiceHelper { /** Logger. */ - private static Log log = LogFactory.getLog(ObserveServiceHelper.class); + private static final Log log = LogFactory.getLog(ObserveServiceHelper.class); /** Le context applicatif. */ public static ObserveApplicationContext context; diff --git a/observe-business/src/main/java/fr/ird/observe/db/impl/PGDataSource.java b/observe-business/src/main/java/fr/ird/observe/db/impl/PGDataSource.java index d282922..efe81cd 100644 --- a/observe-business/src/main/java/fr/ird/observe/db/impl/PGDataSource.java +++ b/observe-business/src/main/java/fr/ird/observe/db/impl/PGDataSource.java @@ -44,7 +44,7 @@ import java.util.Set; public class PGDataSource extends AbstractDataSource { /** Logger */ - static private Log log = LogFactory.getLog(PGDataSource.class); + private static final Log log = LogFactory.getLog(PGDataSource.class); public PGDataSource(PGDataSourceConfig config) { super(config); diff --git a/observe-business/src/main/java/fr/ird/observe/db/impl/PGDataSourceConfig.java b/observe-business/src/main/java/fr/ird/observe/db/impl/PGDataSourceConfig.java index d065164..150ca7a 100644 --- a/observe-business/src/main/java/fr/ird/observe/db/impl/PGDataSourceConfig.java +++ b/observe-business/src/main/java/fr/ird/observe/db/impl/PGDataSourceConfig.java @@ -53,7 +53,7 @@ import static org.nuiton.i18n.I18n.t; public class PGDataSourceConfig extends AbstractDataSourceConfig { /** Logger */ - static private Log log = LogFactory.getLog(PGDataSourceConfig.class); + private static final Log log = LogFactory.getLog(PGDataSourceConfig.class); public static final String DATA_PRIVILEGES = "dataPrivileges"; diff --git a/observe-entities/src/main/java/fr/ird/observe/entities/Entities.java b/observe-entities/src/main/java/fr/ird/observe/entities/Entities.java index 2ed9d46..2c20226 100644 --- a/observe-entities/src/main/java/fr/ird/observe/entities/Entities.java +++ b/observe-entities/src/main/java/fr/ird/observe/entities/Entities.java @@ -301,18 +301,8 @@ public class Entities { }; public static final ObserveEntityEnum[] ALL_ENTITIES = ObserveEntityEnum.values(); - public static final Predicate<String> IS_SEINE_ID = new Predicate<String>() { - @Override - public boolean apply(String input) { - return Entities.isSeineId(input); - } - }; - public static final Predicate<String> IS_LONGLINE_ID = new Predicate<String>() { - @Override - public boolean apply(String input) { - return Entities.isLonglineId(input); - } - }; + public static final java.util.function.Predicate<String> IS_SEINE_ID = input -> Entities.isSeineId(input); + public static final java.util.function.Predicate<String> IS_LONGLINE_ID = input -> Entities.isLonglineId(input); /** * @param klass le type d'entite a tester @@ -365,7 +355,7 @@ public class Entities { public static <E extends ObserveEntity> Map<String, E> toIdMap(Collection<E> entities) { Map<String, E> map = CollectionUtils.isEmpty(entities) - ? Maps.<String, E>newHashMap() + ? Maps.newHashMap() : Maps.uniqueIndex(entities, TopiaEntities.getTopiaIdFunction()); return map; diff --git a/observe-entities/src/main/java/fr/ird/observe/entities/constants/TripMapPointTypePersist.java b/observe-entities/src/main/java/fr/ird/observe/entities/constants/TripMapPointTypePersist.java index 76b073d..e10d8a2 100644 --- a/observe-entities/src/main/java/fr/ird/observe/entities/constants/TripMapPointTypePersist.java +++ b/observe-entities/src/main/java/fr/ird/observe/entities/constants/TripMapPointTypePersist.java @@ -43,6 +43,6 @@ public enum TripMapPointTypePersist { longlineActivityWithHaulingStart, longlineActivityWithHaulingEnd, longlineActivityWithInteraction, - longlineActivityWithStation; + longlineActivityWithStation } diff --git a/observe-entities/src/main/java/fr/ird/observe/entities/constants/seine/NonTargetCatchComputedValueSourcePersist.java b/observe-entities/src/main/java/fr/ird/observe/entities/constants/seine/NonTargetCatchComputedValueSourcePersist.java index c34eda9..351ceb2 100644 --- a/observe-entities/src/main/java/fr/ird/observe/entities/constants/seine/NonTargetCatchComputedValueSourcePersist.java +++ b/observe-entities/src/main/java/fr/ird/observe/entities/constants/seine/NonTargetCatchComputedValueSourcePersist.java @@ -47,6 +47,6 @@ public enum NonTargetCatchComputedValueSourcePersist { * * @since 3.0 */ - fromReferentiel; + fromReferentiel } diff --git a/observe-entities/src/main/java/fr/ird/observe/entities/constants/seine/OwnershipPersist.java b/observe-entities/src/main/java/fr/ird/observe/entities/constants/seine/OwnershipPersist.java index d363869..7ffc123 100644 --- a/observe-entities/src/main/java/fr/ird/observe/entities/constants/seine/OwnershipPersist.java +++ b/observe-entities/src/main/java/fr/ird/observe/entities/constants/seine/OwnershipPersist.java @@ -35,6 +35,6 @@ public enum OwnershipPersist implements Comparable<OwnershipPersist> { ceVessel, /** appartien a un autre vessel */ - autreVessel; + autreVessel } diff --git a/observe-entities/src/main/java/fr/ird/observe/entities/constants/seine/SchoolTypePersist.java b/observe-entities/src/main/java/fr/ird/observe/entities/constants/seine/SchoolTypePersist.java index 69a6a08..a1c85b7 100644 --- a/observe-entities/src/main/java/fr/ird/observe/entities/constants/seine/SchoolTypePersist.java +++ b/observe-entities/src/main/java/fr/ird/observe/entities/constants/seine/SchoolTypePersist.java @@ -36,6 +36,6 @@ public enum SchoolTypePersist { objet, /** banc libre // was 2 before version 4.0 */ - libre; + libre } diff --git a/observe-entities/src/main/java/fr/ird/observe/entities/constants/seine/TypeTransmittingBuoyOperationPersist.java b/observe-entities/src/main/java/fr/ird/observe/entities/constants/seine/TypeTransmittingBuoyOperationPersist.java index e81bf6b..5726746 100644 --- a/observe-entities/src/main/java/fr/ird/observe/entities/constants/seine/TypeTransmittingBuoyOperationPersist.java +++ b/observe-entities/src/main/java/fr/ird/observe/entities/constants/seine/TypeTransmittingBuoyOperationPersist.java @@ -32,6 +32,6 @@ public enum TypeTransmittingBuoyOperationPersist { pose, // deux balises lues - recuperationEtRemplacement; + recuperationEtRemplacement } diff --git a/observe-entities/src/main/java/fr/ird/observe/entities/longline/ActivityLonglines.java b/observe-entities/src/main/java/fr/ird/observe/entities/longline/ActivityLonglines.java index f350769..43a0e78 100644 --- a/observe-entities/src/main/java/fr/ird/observe/entities/longline/ActivityLonglines.java +++ b/observe-entities/src/main/java/fr/ird/observe/entities/longline/ActivityLonglines.java @@ -41,24 +41,13 @@ public class ActivityLonglines { * Comparateur de {@link ActivityLongline} basé sur la propriété {@link * ActivityLongline#getTimeStamp()}. */ - public static final Comparator<ActivityLongline> ACTIVITY_LONGLINE_COMPARATOR = new Comparator<ActivityLongline>() { - - @Override - public int compare(ActivityLongline o1, ActivityLongline o2) { - return o1.getTimeStamp().compareTo(o2.getTimeStamp()); - } - }; + public static final Comparator<ActivityLongline> ACTIVITY_LONGLINE_COMPARATOR = (o1, o2) -> o1.getTimeStamp().compareTo(o2.getTimeStamp()); public static void sort(List<ActivityLongline> routes) { Collections.sort(routes, ACTIVITY_LONGLINE_COMPARATOR); } public static Predicate<ActivityLongline> newTimeStampBeforePredicate(final Date timeStamp) { - return new Predicate<ActivityLongline>() { - @Override - public boolean apply(ActivityLongline input) { - return input.getTimeStamp().before(timeStamp); - } - }; + return input -> input.getTimeStamp().before(timeStamp); } } diff --git a/observe-entities/src/main/java/fr/ird/observe/entities/longline/TripLonglineTopiaDao.java b/observe-entities/src/main/java/fr/ird/observe/entities/longline/TripLonglineTopiaDao.java index cc874ce..5714a38 100644 --- a/observe-entities/src/main/java/fr/ird/observe/entities/longline/TripLonglineTopiaDao.java +++ b/observe-entities/src/main/java/fr/ird/observe/entities/longline/TripLonglineTopiaDao.java @@ -122,7 +122,7 @@ public class TripLonglineTopiaDao extends AbstractTripLonglineTopiaDao<TripLongl private static class TripMapActivityPointQuery extends TopiaSqlQuery<List<TripMapPoint>> { - private static String SQL = "SELECT" + + private static final String SQL = "SELECT" + " a.timestamp, " + " a.latitude," + " a.longitude," + @@ -145,7 +145,7 @@ public class TripLonglineTopiaDao extends AbstractTripLonglineTopiaDao<TripLongl " WHERE a.trip = ?" + " ORDER BY a.timestamp"; - protected String tripId; + protected final String tripId; public TripMapActivityPointQuery(String tripId) { this.tripId = tripId; diff --git a/observe-entities/src/main/java/fr/ird/observe/entities/migration/AbstractDataSourceMigration.java b/observe-entities/src/main/java/fr/ird/observe/entities/migration/AbstractDataSourceMigration.java index 1599934..4bbbe28 100644 --- a/observe-entities/src/main/java/fr/ird/observe/entities/migration/AbstractDataSourceMigration.java +++ b/observe-entities/src/main/java/fr/ird/observe/entities/migration/AbstractDataSourceMigration.java @@ -42,7 +42,7 @@ public abstract class AbstractDataSourceMigration extends TopiaMigrationCallback /** * Logger */ - static private Log log = + private static final Log log = LogFactory.getLog(AbstractDataSourceMigration.class); public static final Version V_3_0 = Versions.valueOf("3.0"); diff --git a/observe-entities/src/main/java/fr/ird/observe/entities/migration/AbstractObserveMigrationCallBack.java b/observe-entities/src/main/java/fr/ird/observe/entities/migration/AbstractObserveMigrationCallBack.java index 095b8dd..a17266e 100644 --- a/observe-entities/src/main/java/fr/ird/observe/entities/migration/AbstractObserveMigrationCallBack.java +++ b/observe-entities/src/main/java/fr/ird/observe/entities/migration/AbstractObserveMigrationCallBack.java @@ -30,15 +30,12 @@ import org.apache.commons.logging.LogFactory; import org.nuiton.topia.migration.TopiaMigrationCallbackByClass; import org.nuiton.topia.persistence.TopiaException; import org.nuiton.topia.persistence.support.TopiaSqlSupport; -import org.nuiton.topia.persistence.support.TopiaSqlWork; import org.nuiton.version.Version; import java.io.IOException; import java.io.InputStream; -import java.sql.Connection; import java.sql.PreparedStatement; import java.sql.ResultSet; -import java.sql.SQLException; import java.util.HashSet; import java.util.LinkedHashSet; import java.util.List; @@ -68,17 +65,13 @@ public abstract class AbstractObserveMigrationCallBack extends TopiaMigrationCal final Set<String> result = new HashSet<>(); - topiaSqlSupport.doSqlWork(new TopiaSqlWork() { - - @Override - public void execute(Connection connection) throws SQLException { - String sql = String.format("SELECT topiaId FROM %s;", tableName); - try (PreparedStatement ps = connection.prepareStatement(sql)) { - ResultSet set = ps.executeQuery(); - while (set.next()) { - String id = set.getString(1); - result.add(id); - } + topiaSqlSupport.doSqlWork(connection -> { + String sql = String.format("SELECT topiaId FROM %s;", tableName); + try (PreparedStatement ps = connection.prepareStatement(sql)) { + ResultSet set = ps.executeQuery(); + while (set.next()) { + String id = set.getString(1); + result.add(id); } } }); diff --git a/observe-entities/src/main/java/fr/ird/observe/entities/migration/H2DataSourceMigration.java b/observe-entities/src/main/java/fr/ird/observe/entities/migration/H2DataSourceMigration.java index fc8c1fc..f494bef 100644 --- a/observe-entities/src/main/java/fr/ird/observe/entities/migration/H2DataSourceMigration.java +++ b/observe-entities/src/main/java/fr/ird/observe/entities/migration/H2DataSourceMigration.java @@ -25,9 +25,7 @@ import org.apache.commons.logging.Log; import org.apache.commons.logging.LogFactory; import org.nuiton.topia.persistence.TopiaException; import org.nuiton.topia.persistence.support.TopiaSqlSupport; -import org.nuiton.topia.persistence.support.TopiaSqlWork; -import java.sql.Connection; import java.sql.PreparedStatement; import java.sql.ResultSet; import java.sql.SQLException; @@ -59,28 +57,24 @@ public class H2DataSourceMigration extends AbstractDataSourceMigration { // recherche du nom de la constrainte final List<String> result = new ArrayList<>(); - tx.doSqlWork(new TopiaSqlWork() { - - @Override - public void execute(Connection connection) throws SQLException { - - String sql = "select CONSTRAINT_NAME from INFORMATION_SCHEMA.Constraints where CONSTRAINT_TYPE='UNIQUE' AND TABLE_NAME=? AND Column_list =?;"; - PreparedStatement ps = connection.prepareStatement(sql); - ps.setString(1, tableName.toUpperCase()); - ps.setString(2, columnName.toUpperCase()); - try { - ResultSet set = ps.executeQuery(); - if (set.next()) { - String constraintName = set.getString(1); - if (log.isDebugEnabled()) - log.debug("found constraint of type unique for table " + tableName + " and column " + columnName + ": " + constraintName); - result.add(constraintName); - } - } catch (Exception e) { - throw new SQLException("Could not obtain constraint unique for table" + tableName + " and column " + columnName, e); - } finally { - ps.close(); + tx.doSqlWork(connection -> { + + String sql = "select CONSTRAINT_NAME from INFORMATION_SCHEMA.Constraints where CONSTRAINT_TYPE='UNIQUE' AND TABLE_NAME=? AND Column_list =?;"; + PreparedStatement ps = connection.prepareStatement(sql); + ps.setString(1, tableName.toUpperCase()); + ps.setString(2, columnName.toUpperCase()); + try { + ResultSet set = ps.executeQuery(); + if (set.next()) { + String constraintName = set.getString(1); + if (log.isDebugEnabled()) + log.debug("found constraint of type unique for table " + tableName + " and column " + columnName + ": " + constraintName); + result.add(constraintName); } + } catch (Exception e) { + throw new SQLException("Could not obtain constraint unique for table" + tableName + " and column " + columnName, e); + } finally { + ps.close(); } }); @@ -98,26 +92,22 @@ public class H2DataSourceMigration extends AbstractDataSourceMigration { //(); final List<String> result = new ArrayList<>(); - tx.doSqlWork(new TopiaSqlWork() { - - @Override - public void execute(Connection connection) throws SQLException { - String sql = "select CONSTRAINT_NAME from INFORMATION_SCHEMA.Constraints where CONSTRAINT_TYPE='UNIQUE' AND TABLE_NAME=?;"; - PreparedStatement ps = connection.prepareStatement(sql); - ps.setString(1, tableName.toUpperCase()); - try { - ResultSet set = ps.executeQuery(); - if (set.next()) { - String constraintName = set.getString(1); - if (log.isDebugEnabled()) - log.debug("found constraint of type unique for table " + tableName + " : " + constraintName); - result.add(constraintName); - } - } catch (Exception e) { - throw new SQLException("Could not obtain constraint unique for table " + tableName, e); - } finally { - ps.close(); + tx.doSqlWork(connection -> { + String sql = "select CONSTRAINT_NAME from INFORMATION_SCHEMA.Constraints where CONSTRAINT_TYPE='UNIQUE' AND TABLE_NAME=?;"; + PreparedStatement ps = connection.prepareStatement(sql); + ps.setString(1, tableName.toUpperCase()); + try { + ResultSet set = ps.executeQuery(); + if (set.next()) { + String constraintName = set.getString(1); + if (log.isDebugEnabled()) + log.debug("found constraint of type unique for table " + tableName + " : " + constraintName); + result.add(constraintName); } + } catch (Exception e) { + throw new SQLException("Could not obtain constraint unique for table " + tableName, e); + } finally { + ps.close(); } }); @@ -133,23 +123,19 @@ public class H2DataSourceMigration extends AbstractDataSourceMigration { final Set<String> result = new HashSet<>(); - tx.doSqlWork(new TopiaSqlWork() { - - @Override - public void execute(Connection connection) throws SQLException { - String sql = String.format("SELECT DISTINCT constraint_name FROM INFORMATION_SCHEMA.Constraints WHERE (CONSTRAINT_TYPE='UNIQUE' OR CONSTRAINT_TYPE='REFERENTIAL') AND TABLE_NAME='%S';", tableName); - PreparedStatement ps = connection.prepareStatement(sql); - try { - ResultSet set = ps.executeQuery(); - while (set.next()) { - String constraintName = set.getString(1); - result.add(constraintName); - } - } catch (Exception e) { - throw new SQLException("Could not obtain constraints for table " + tableName, e); - } finally { - ps.close(); + tx.doSqlWork(connection -> { + String sql = String.format("SELECT DISTINCT constraint_name FROM INFORMATION_SCHEMA.Constraints WHERE (CONSTRAINT_TYPE='UNIQUE' OR CONSTRAINT_TYPE='REFERENTIAL') AND TABLE_NAME='%S';", tableName); + PreparedStatement ps = connection.prepareStatement(sql); + try { + ResultSet set = ps.executeQuery(); + while (set.next()) { + String constraintName = set.getString(1); + result.add(constraintName); } + } catch (Exception e) { + throw new SQLException("Could not obtain constraints for table " + tableName, e); + } finally { + ps.close(); } }); @@ -160,23 +146,19 @@ public class H2DataSourceMigration extends AbstractDataSourceMigration { final Set<String> result = new HashSet<>(); - tx.doSqlWork(new TopiaSqlWork() { - - @Override - public void execute(Connection connection) throws SQLException { - String sql = String.format("SELECT DISTINCT constraint_name FROM INFORMATION_SCHEMA.Constraints WHERE CONSTRAINT_TYPE='REFERENTIAL' AND TABLE_NAME='%S';", tableName); - PreparedStatement ps = connection.prepareStatement(sql); - try { - ResultSet set = ps.executeQuery(); - while (set.next()) { - String constraintName = set.getString(1); - result.add(constraintName); - } - } catch (Exception e) { - throw new SQLException("Could not obtain constraints for table " + tableName, e); - } finally { - ps.close(); + tx.doSqlWork(connection -> { + String sql = String.format("SELECT DISTINCT constraint_name FROM INFORMATION_SCHEMA.Constraints WHERE CONSTRAINT_TYPE='REFERENTIAL' AND TABLE_NAME='%S';", tableName); + PreparedStatement ps = connection.prepareStatement(sql); + try { + ResultSet set = ps.executeQuery(); + while (set.next()) { + String constraintName = set.getString(1); + result.add(constraintName); } + } catch (Exception e) { + throw new SQLException("Could not obtain constraints for table " + tableName, e); + } finally { + ps.close(); } }); @@ -187,27 +169,23 @@ public class H2DataSourceMigration extends AbstractDataSourceMigration { final List<String> result = new ArrayList<>(); - tx.doSqlWork(new TopiaSqlWork() { - - @Override - public void execute(Connection connection) throws SQLException { - String sql = String.format("SELECT DISTINCT constraint_name FROM INFORMATION_SCHEMA.Constraints " + - "WHERE CONSTRAINT_TYPE='REFERENTIAL' " + - "AND CONSTRAINT_SCHEMA='%S' " + - "AND TABLE_NAME='%S' " + - "AND COLUMN_LIST='%S';", schemaName, tableName, columnName); - PreparedStatement ps = connection.prepareStatement(sql); - try { - ResultSet set = ps.executeQuery(); - while (set.next()) { - String constraintName = set.getString(1); - result.add(constraintName); - } - } catch (Exception e) { - throw new SQLException("Could not obtain constraints for table " + tableName, e); - } finally { - ps.close(); + tx.doSqlWork(connection -> { + String sql = String.format("SELECT DISTINCT constraint_name FROM INFORMATION_SCHEMA.Constraints " + + "WHERE CONSTRAINT_TYPE='REFERENTIAL' " + + "AND CONSTRAINT_SCHEMA='%S' " + + "AND TABLE_NAME='%S' " + + "AND COLUMN_LIST='%S';", schemaName, tableName, columnName); + PreparedStatement ps = connection.prepareStatement(sql); + try { + ResultSet set = ps.executeQuery(); + while (set.next()) { + String constraintName = set.getString(1); + result.add(constraintName); } + } catch (Exception e) { + throw new SQLException("Could not obtain constraints for table " + tableName, e); + } finally { + ps.close(); } }); @@ -236,23 +214,19 @@ public class H2DataSourceMigration extends AbstractDataSourceMigration { final Set<String> result = new HashSet<>(); - tx.doSqlWork(new TopiaSqlWork() { - - @Override - public void execute(Connection connection) throws SQLException { - String sql = String.format("SELECT DISTINCT constraint_name FROM INFORMATION_SCHEMA.Constraints WHERE CONSTRAINT_TYPE='UNIQUE' AND TABLE_NAME='%S';", tableName); - PreparedStatement ps = connection.prepareStatement(sql); - try { - ResultSet set = ps.executeQuery(); - while (set.next()) { - String constraintName = set.getString(1); - result.add(constraintName); - } - } catch (Exception e) { - throw new SQLException("Could not obtain constraints for table " + tableName, e); - } finally { - ps.close(); + tx.doSqlWork(connection -> { + String sql = String.format("SELECT DISTINCT constraint_name FROM INFORMATION_SCHEMA.Constraints WHERE CONSTRAINT_TYPE='UNIQUE' AND TABLE_NAME='%S';", tableName); + PreparedStatement ps = connection.prepareStatement(sql); + try { + ResultSet set = ps.executeQuery(); + while (set.next()) { + String constraintName = set.getString(1); + result.add(constraintName); } + } catch (Exception e) { + throw new SQLException("Could not obtain constraints for table " + tableName, e); + } finally { + ps.close(); } }); diff --git a/observe-entities/src/main/java/fr/ird/observe/entities/migration/ObserveMigrationCallBackForVersionResolver.java b/observe-entities/src/main/java/fr/ird/observe/entities/migration/ObserveMigrationCallBackForVersionResolver.java index 634a220..10ee36b 100644 --- a/observe-entities/src/main/java/fr/ird/observe/entities/migration/ObserveMigrationCallBackForVersionResolver.java +++ b/observe-entities/src/main/java/fr/ird/observe/entities/migration/ObserveMigrationCallBackForVersionResolver.java @@ -38,7 +38,7 @@ import java.lang.reflect.Modifier; class ObserveMigrationCallBackForVersionResolver implements TopiaMigrationCallbackByClass.MigrationCallBackForVersionResolver { /** Logger */ - static private Log log = + private static final Log log = LogFactory.getLog(ObserveMigrationCallBackForVersionResolver.class); protected final String prefix; diff --git a/observe-entities/src/main/java/fr/ird/observe/entities/migration/PGDataSourceMigration.java b/observe-entities/src/main/java/fr/ird/observe/entities/migration/PGDataSourceMigration.java index 63f6cea..0d9ee4e4 100644 --- a/observe-entities/src/main/java/fr/ird/observe/entities/migration/PGDataSourceMigration.java +++ b/observe-entities/src/main/java/fr/ird/observe/entities/migration/PGDataSourceMigration.java @@ -25,9 +25,7 @@ import org.apache.commons.logging.Log; import org.apache.commons.logging.LogFactory; import org.nuiton.topia.persistence.TopiaException; import org.nuiton.topia.persistence.support.TopiaSqlSupport; -import org.nuiton.topia.persistence.support.TopiaSqlWork; -import java.sql.Connection; import java.sql.PreparedStatement; import java.sql.ResultSet; import java.sql.SQLException; @@ -59,72 +57,68 @@ public class PGDataSourceMigration extends AbstractDataSourceMigration { // recherche du nom de la constrainte final List<String> result = new ArrayList<>(); - tx.doSqlWork(new TopiaSqlWork() { - - @Override - public void execute(Connection connection) throws SQLException { - - // get table oid - String oid = null; - - String sqlOid = "select oid from pg_class where relname=?;"; - { - PreparedStatement ps = connection.prepareStatement(sqlOid); - ps.setString(1, tableName.toLowerCase()); - try { - ResultSet set = ps.executeQuery(); - if (set.next()) { - oid = set.getString(1); - if (log.isDebugEnabled()) - log.debug("found table oid " + tableName + ": " + oid); - } - } catch (Exception e) { - throw new SQLException("Could not obtain oid for table" + tableName, e); - } finally { - ps.close(); - } - } + tx.doSqlWork(connection -> { + + // get table oid + String oid = null; - // get attribute num - String attNumSql = "select attnum from pg_attribute where attrelid=? AND attname =?"; - String attNum = null; - { - PreparedStatement ps = connection.prepareStatement(attNumSql); - ps.setInt(1, Integer.valueOf(oid)); - ps.setString(2, columnName.toLowerCase()); - try { - ResultSet set = ps.executeQuery(); - if (set.next()) { - attNum = set.getString(1); - if (log.isDebugEnabled()) - log.debug("found attribute " + columnName + " attNum : " + attNum); - } - } catch (Exception e) { - throw new SQLException("Could not obtain attNum for column" + columnName, e); - } finally { - ps.close(); + String sqlOid = "select oid from pg_class where relname=?;"; + { + PreparedStatement ps = connection.prepareStatement(sqlOid); + ps.setString(1, tableName.toLowerCase()); + try { + ResultSet set = ps.executeQuery(); + if (set.next()) { + oid = set.getString(1); + if (log.isDebugEnabled()) + log.debug("found table oid " + tableName + ": " + oid); } + } catch (Exception e) { + throw new SQLException("Could not obtain oid for table" + tableName, e); + } finally { + ps.close(); } + } - String sql = "SELECT conname FROM pg_constraint where contype='u' and conrelid= ? and conkey = '{" + attNum + "}';"; - - PreparedStatement ps = connection.prepareStatement(sql); + // get attribute num + String attNumSql = "select attnum from pg_attribute where attrelid=? AND attname =?"; + String attNum = null; + { + PreparedStatement ps = connection.prepareStatement(attNumSql); ps.setInt(1, Integer.valueOf(oid)); + ps.setString(2, columnName.toLowerCase()); try { ResultSet set = ps.executeQuery(); - if (set.next()) { - String constraintName = set.getString(1); + attNum = set.getString(1); if (log.isDebugEnabled()) - log.debug("found constraint of type unique for table " + tableName + " and column " + columnName + ": " + constraintName); - result.add(constraintName); + log.debug("found attribute " + columnName + " attNum : " + attNum); } } catch (Exception e) { - throw new SQLException("Could not obtain constraint unique for table" + tableName + " and column " + columnName, e); + throw new SQLException("Could not obtain attNum for column" + columnName, e); } finally { ps.close(); } } + + String sql = "SELECT conname FROM pg_constraint where contype='u' and conrelid= ? and conkey = '{" + attNum + "}';"; + + PreparedStatement ps = connection.prepareStatement(sql); + ps.setInt(1, Integer.valueOf(oid)); + try { + ResultSet set = ps.executeQuery(); + + if (set.next()) { + String constraintName = set.getString(1); + if (log.isDebugEnabled()) + log.debug("found constraint of type unique for table " + tableName + " and column " + columnName + ": " + constraintName); + result.add(constraintName); + } + } catch (Exception e) { + throw new SQLException("Could not obtain constraint unique for table" + tableName + " and column " + columnName, e); + } finally { + ps.close(); + } }); if (result.isEmpty()) { @@ -141,26 +135,22 @@ public class PGDataSourceMigration extends AbstractDataSourceMigration { //(); final List<String> result = new ArrayList<>(); - tx.doSqlWork(new TopiaSqlWork() { - - @Override - public void execute(Connection connection) throws SQLException { - String sql = "SELECT conname FROM pg_constraint where contype='u' and conrelid= (select oid from pg_class where relname=?);"; - PreparedStatement ps = connection.prepareStatement(sql); - ps.setString(1, tableName.toLowerCase()); - try { - ResultSet set = ps.executeQuery(); - if (set.next()) { - String constraintName = set.getString(1); - if (log.isDebugEnabled()) - log.debug("found constraint of type unique for table " + tableName + " : " + constraintName); - result.add(constraintName); - } - } catch (Exception e) { - throw new SQLException("Could not obtain constraint unique for table " + tableName, e); - } finally { - ps.close(); + tx.doSqlWork(connection -> { + String sql = "SELECT conname FROM pg_constraint where contype='u' and conrelid= (select oid from pg_class where relname=?);"; + PreparedStatement ps = connection.prepareStatement(sql); + ps.setString(1, tableName.toLowerCase()); + try { + ResultSet set = ps.executeQuery(); + if (set.next()) { + String constraintName = set.getString(1); + if (log.isDebugEnabled()) + log.debug("found constraint of type unique for table " + tableName + " : " + constraintName); + result.add(constraintName); } + } catch (Exception e) { + throw new SQLException("Could not obtain constraint unique for table " + tableName, e); + } finally { + ps.close(); } }); @@ -176,23 +166,19 @@ public class PGDataSourceMigration extends AbstractDataSourceMigration { final Set<String> result = new HashSet<>(); - tx.doSqlWork(new TopiaSqlWork() { - - @Override - public void execute(Connection connection) throws SQLException { - String sql = String.format("SELECT DISTINCT conname FROM pg_constraint WHERE ( contype='u' OR contype='f' ) AND conrelid = (SELECT oid FROM pg_class WHERE relname='%s');", tableName.toLowerCase()); - PreparedStatement ps = connection.prepareStatement(sql); - try { - ResultSet set = ps.executeQuery(); - while (set.next()) { - String constraintName = set.getString(1); - result.add(constraintName); - } - } catch (Exception e) { - throw new SQLException("Could not obtain constraints for table " + tableName, e); - } finally { - ps.close(); + tx.doSqlWork(connection -> { + String sql = String.format("SELECT DISTINCT conname FROM pg_constraint WHERE ( contype='u' OR contype='f' ) AND conrelid = (SELECT oid FROM pg_class WHERE relname='%s');", tableName.toLowerCase()); + PreparedStatement ps = connection.prepareStatement(sql); + try { + ResultSet set = ps.executeQuery(); + while (set.next()) { + String constraintName = set.getString(1); + result.add(constraintName); } + } catch (Exception e) { + throw new SQLException("Could not obtain constraints for table " + tableName, e); + } finally { + ps.close(); } }); @@ -203,23 +189,19 @@ public class PGDataSourceMigration extends AbstractDataSourceMigration { final Set<String> result = new HashSet<>(); - tx.doSqlWork(new TopiaSqlWork() { - - @Override - public void execute(Connection connection) throws SQLException { - String sql = String.format("SELECT DISTINCT conname FROM pg_constraint WHERE ( contype='f' ) AND conrelid = (SELECT oid FROM pg_class WHERE relname='%s');", tableName.toLowerCase()); - PreparedStatement ps = connection.prepareStatement(sql); - try { - ResultSet set = ps.executeQuery(); - while (set.next()) { - String constraintName = set.getString(1); - result.add(constraintName); - } - } catch (Exception e) { - throw new SQLException("Could not obtain constraints for table " + tableName, e); - } finally { - ps.close(); + tx.doSqlWork(connection -> { + String sql = String.format("SELECT DISTINCT conname FROM pg_constraint WHERE ( contype='f' ) AND conrelid = (SELECT oid FROM pg_class WHERE relname='%s');", tableName.toLowerCase()); + PreparedStatement ps = connection.prepareStatement(sql); + try { + ResultSet set = ps.executeQuery(); + while (set.next()) { + String constraintName = set.getString(1); + result.add(constraintName); } + } catch (Exception e) { + throw new SQLException("Could not obtain constraints for table " + tableName, e); + } finally { + ps.close(); } }); @@ -231,70 +213,67 @@ public class PGDataSourceMigration extends AbstractDataSourceMigration { final List<String> result = new ArrayList<>(); - tx.doSqlWork(new TopiaSqlWork() { - - public void execute(Connection connection) throws SQLException { - - - // get table oid - String oid = null; - - String sqlOid = "select oid from pg_class where relnamespace = (select oid from pg_catalog.pg_namespace where nspname=?) AND relname=?;"; - { - PreparedStatement ps = connection.prepareStatement(sqlOid); - ps.setString(1, schemaName.toLowerCase()); - ps.setString(2, tableName.toLowerCase()); - try { - ResultSet set = ps.executeQuery(); - if (set.next()) { - oid = set.getString(1); - if (log.isDebugEnabled()) - log.debug("found table oid " + tableName + ": " + oid); - } - } catch (Exception e) { - throw new SQLException("Could not obtain oid for table" + tableName, e); - } finally { - ps.close(); - } - } + tx.doSqlWork(connection -> { + - // get attribute num - String attNumSql = "select attnum from pg_attribute where attrelid=? AND attname =?"; - String attNum = null; - { - PreparedStatement ps = connection.prepareStatement(attNumSql); - ps.setInt(1, Integer.valueOf(oid)); - ps.setString(2, columnName.toLowerCase()); - try { - ResultSet set = ps.executeQuery(); - if (set.next()) { - attNum = set.getString(1); - if (log.isDebugEnabled()) - log.debug("found attribute " + columnName + " attNum : " + attNum); - } - } catch (Exception e) { - throw new SQLException("Could not obtain attNum for column" + columnName, e); - } finally { - ps.close(); + // get table oid + String oid = null; + + String sqlOid = "select oid from pg_class where relnamespace = (select oid from pg_catalog.pg_namespace where nspname=?) AND relname=?;"; + { + PreparedStatement ps = connection.prepareStatement(sqlOid); + ps.setString(1, schemaName.toLowerCase()); + ps.setString(2, tableName.toLowerCase()); + try { + ResultSet set = ps.executeQuery(); + if (set.next()) { + oid = set.getString(1); + if (log.isDebugEnabled()) + log.debug("found table oid " + tableName + ": " + oid); } + } catch (Exception e) { + throw new SQLException("Could not obtain oid for table" + tableName, e); + } finally { + ps.close(); } + } - String sql = "SELECT DISTINCT conname FROM pg_constraint WHERE contype='f' AND conrelid = ? AND conkey = '{" + attNum + "}';"; - PreparedStatement ps = connection.prepareStatement(sql); + // get attribute num + String attNumSql = "select attnum from pg_attribute where attrelid=? AND attname =?"; + String attNum = null; + { + PreparedStatement ps = connection.prepareStatement(attNumSql); ps.setInt(1, Integer.valueOf(oid)); - + ps.setString(2, columnName.toLowerCase()); try { ResultSet set = ps.executeQuery(); - while (set.next()) { - String constraintName = set.getString(1); - result.add(constraintName); + if (set.next()) { + attNum = set.getString(1); + if (log.isDebugEnabled()) + log.debug("found attribute " + columnName + " attNum : " + attNum); } } catch (Exception e) { - throw new SQLException("Could not obtain constraints for table " + tableName, e); + throw new SQLException("Could not obtain attNum for column" + columnName, e); } finally { ps.close(); } } + + String sql = "SELECT DISTINCT conname FROM pg_constraint WHERE contype='f' AND conrelid = ? AND conkey = '{" + attNum + "}';"; + PreparedStatement ps = connection.prepareStatement(sql); + ps.setInt(1, Integer.valueOf(oid)); + + try { + ResultSet set = ps.executeQuery(); + while (set.next()) { + String constraintName = set.getString(1); + result.add(constraintName); + } + } catch (Exception e) { + throw new SQLException("Could not obtain constraints for table " + tableName, e); + } finally { + ps.close(); + } }); String constraintName; @@ -321,23 +300,19 @@ public class PGDataSourceMigration extends AbstractDataSourceMigration { final Set<String> result = new HashSet<>(); - tx.doSqlWork(new TopiaSqlWork() { - - @Override - public void execute(Connection connection) throws SQLException { - String sql = String.format("SELECT DISTINCT conname FROM pg_constraint WHERE ( contype='u' ) AND conrelid = (SELECT oid FROM pg_class WHERE relname='%s');", tableName.toLowerCase()); - PreparedStatement ps = connection.prepareStatement(sql); - try { - ResultSet set = ps.executeQuery(); - while (set.next()) { - String constraintName = set.getString(1); - result.add(constraintName); - } - } catch (Exception e) { - throw new SQLException("Could not obtain constraints for table " + tableName, e); - } finally { - ps.close(); + tx.doSqlWork(connection -> { + String sql = String.format("SELECT DISTINCT conname FROM pg_constraint WHERE ( contype='u' ) AND conrelid = (SELECT oid FROM pg_class WHERE relname='%s');", tableName.toLowerCase()); + PreparedStatement ps = connection.prepareStatement(sql); + try { + ResultSet set = ps.executeQuery(); + while (set.next()) { + String constraintName = set.getString(1); + result.add(constraintName); } + } catch (Exception e) { + throw new SQLException("Could not obtain constraints for table " + tableName, e); + } finally { + ps.close(); } }); diff --git a/observe-entities/src/main/java/fr/ird/observe/entities/migration/versions/DataSourceMigrationForVersion_3_16.java b/observe-entities/src/main/java/fr/ird/observe/entities/migration/versions/DataSourceMigrationForVersion_3_16.java index a4d0113..d30c97a 100644 --- a/observe-entities/src/main/java/fr/ird/observe/entities/migration/versions/DataSourceMigrationForVersion_3_16.java +++ b/observe-entities/src/main/java/fr/ird/observe/entities/migration/versions/DataSourceMigrationForVersion_3_16.java @@ -29,9 +29,7 @@ import fr.ird.observe.entities.migration.PGDataSourceMigration; import org.apache.commons.logging.Log; import org.apache.commons.logging.LogFactory; import org.nuiton.topia.persistence.support.TopiaSqlSupport; -import org.nuiton.topia.persistence.support.TopiaSqlWork; -import java.sql.Connection; import java.sql.PreparedStatement; import java.sql.ResultSet; import java.sql.SQLException; @@ -103,27 +101,23 @@ public class DataSourceMigrationForVersion_3_16 extends AbstractObserveMigration final Set<SenneData> result = new HashSet<>(); - tx.doSqlWork(new TopiaSqlWork() { - - @Override - public void execute(Connection connection) throws SQLException { - String sql = "SELECT topiaId, seineCircumference, seineDepth, seineBallastWeight FROM OBSERVE_SEINE.TRIP WHERE seineDepth IS NOT NULL OR seineDepth IS NOT NULL OR seineBallastWeight IS NOT NULL;"; - PreparedStatement ps = connection.prepareStatement(sql); - try { - ResultSet set = ps.executeQuery(); - while (set.next()) { - SenneData senneData = new SenneData(); - senneData.tripId = set.getString(1); - senneData.seineCircumference = set.getInt(2); - senneData.seineDepth = set.getInt(3); - senneData.seineBallastWeight = set.getInt(4); - result.add(senneData); - } - } catch (Exception e) { - throw new SQLException("Could not obtain trip senne data", e); - } finally { - ps.close(); + tx.doSqlWork(connection -> { + String sql = "SELECT topiaId, seineCircumference, seineDepth, seineBallastWeight FROM OBSERVE_SEINE.TRIP WHERE seineDepth IS NOT NULL OR seineDepth IS NOT NULL OR seineBallastWeight IS NOT NULL;"; + PreparedStatement ps = connection.prepareStatement(sql); + try { + ResultSet set = ps.executeQuery(); + while (set.next()) { + SenneData senneData = new SenneData(); + senneData.tripId = set.getString(1); + senneData.seineCircumference = set.getInt(2); + senneData.seineDepth = set.getInt(3); + senneData.seineBallastWeight = set.getInt(4); + result.add(senneData); } + } catch (Exception e) { + throw new SQLException("Could not obtain trip senne data", e); + } finally { + ps.close(); } }); diff --git a/observe-entities/src/main/java/fr/ird/observe/entities/migration/versions/DataSourceMigrationForVersion_3_5.java b/observe-entities/src/main/java/fr/ird/observe/entities/migration/versions/DataSourceMigrationForVersion_3_5.java index fbece2e..ea5102f 100644 --- a/observe-entities/src/main/java/fr/ird/observe/entities/migration/versions/DataSourceMigrationForVersion_3_5.java +++ b/observe-entities/src/main/java/fr/ird/observe/entities/migration/versions/DataSourceMigrationForVersion_3_5.java @@ -40,7 +40,7 @@ import java.util.Set; */ public abstract class DataSourceMigrationForVersion_3_5 extends AbstractObserveMigrationCallBack { - protected String[] TABLES = new String[]{ + protected static final String[] TABLES = new String[]{ "ParametrageTaillePoidsFaune", "ParametrageTaillePoidsThon", "ActiviteEnvironnante", diff --git a/observe-entities/src/main/java/fr/ird/observe/entities/migration/versions/DataSourceMigrationForVersion_4_0_1.java b/observe-entities/src/main/java/fr/ird/observe/entities/migration/versions/DataSourceMigrationForVersion_4_0_1.java index 1391806..6c47bfd 100644 --- a/observe-entities/src/main/java/fr/ird/observe/entities/migration/versions/DataSourceMigrationForVersion_4_0_1.java +++ b/observe-entities/src/main/java/fr/ird/observe/entities/migration/versions/DataSourceMigrationForVersion_4_0_1.java @@ -33,9 +33,7 @@ import fr.ird.observe.entities.seine.GearUseFeaturesMeasurementSeine; import fr.ird.observe.entities.seine.GearUseFeaturesSeine; import org.nuiton.topia.persistence.TopiaException; import org.nuiton.topia.persistence.support.TopiaSqlSupport; -import org.nuiton.topia.persistence.support.TopiaSqlWork; -import java.sql.Connection; import java.sql.PreparedStatement; import java.sql.ResultSet; import java.sql.SQLException; @@ -92,27 +90,23 @@ public abstract class DataSourceMigrationForVersion_4_0_1 extends AbstractObserv // L'ensemble des opérations de pêche où l'on doit regénerer les générer les haulingIds final Set<SetData> setIds = new LinkedHashSet<>(); - tx.doSqlWork(new TopiaSqlWork() { - - @Override - public void execute(Connection connection) throws SQLException { - String sql = "SELECT topiaId, totalSectionsCount, basketsPerSectionCount, branchlinesPerBasketCount FROM OBSERVE_LONGLINE.SET WHERE HAULINGBREAKS = 0 AND haulingDirectionSameAsSetting IS FALSE;"; - PreparedStatement ps = connection.prepareStatement(sql); - try { - ResultSet set = ps.executeQuery(); - while (set.next()) { - SetData setData = new SetData(); - setData.id = set.getString(1); - setData.totalSectionsCount = set.getInt(2); - setData.basketsPerSectionCount = set.getInt(3); - setData.branchlinesPerBasketCount = set.getInt(4); - setIds.add(setData); - } - } catch (Exception e) { - throw new SQLException("Could not obtain SET data", e); - } finally { - ps.close(); + tx.doSqlWork(connection -> { + String sql = "SELECT topiaId, totalSectionsCount, basketsPerSectionCount, branchlinesPerBasketCount FROM OBSERVE_LONGLINE.SET WHERE HAULINGBREAKS = 0 AND haulingDirectionSameAsSetting IS FALSE;"; + PreparedStatement ps = connection.prepareStatement(sql); + try { + ResultSet set = ps.executeQuery(); + while (set.next()) { + SetData setData = new SetData(); + setData.id = set.getString(1); + setData.totalSectionsCount = set.getInt(2); + setData.basketsPerSectionCount = set.getInt(3); + setData.branchlinesPerBasketCount = set.getInt(4); + setIds.add(setData); } + } catch (Exception e) { + throw new SQLException("Could not obtain SET data", e); + } finally { + ps.close(); } }); @@ -128,24 +122,20 @@ public abstract class DataSourceMigrationForVersion_4_0_1 extends AbstractObserv protected void migrateGearUseFeaturesSeineMeasurementIds(TopiaSqlSupport tx, List<String> queries) { final Multimap<String, String> gearUseFeaturesSeineAndMeasurementIds = LinkedHashMultimap.create(); - tx.doSqlWork(new TopiaSqlWork() { - - @Override - public void execute(Connection connection) throws SQLException { - String sql = "SELECT GEARUSEFEATURES, topiaId FROM OBSERVE_SEINE.GEARUSEFEATURESMEASUREMENT;"; - PreparedStatement ps = connection.prepareStatement(sql); - try { - ResultSet set = ps.executeQuery(); - while (set.next()) { - String gearUseFeaturesSeineId = set.getString(1); - String gearUseFeaturesMeasurementSeineId = set.getString(2); - gearUseFeaturesSeineAndMeasurementIds.put(gearUseFeaturesSeineId, gearUseFeaturesMeasurementSeineId); - } - } catch (Exception e) { - throw new SQLException("Could not obtain GEARUSEFEATURESMEASUREMENT ids", e); - } finally { - ps.close(); + tx.doSqlWork(connection -> { + String sql = "SELECT GEARUSEFEATURES, topiaId FROM OBSERVE_SEINE.GEARUSEFEATURESMEASUREMENT;"; + PreparedStatement ps = connection.prepareStatement(sql); + try { + ResultSet set = ps.executeQuery(); + while (set.next()) { + String gearUseFeaturesSeineId = set.getString(1); + String gearUseFeaturesMeasurementSeineId = set.getString(2); + gearUseFeaturesSeineAndMeasurementIds.put(gearUseFeaturesSeineId, gearUseFeaturesMeasurementSeineId); } + } catch (Exception e) { + throw new SQLException("Could not obtain GEARUSEFEATURESMEASUREMENT ids", e); + } finally { + ps.close(); } }); diff --git a/observe-entities/src/main/java/fr/ird/observe/entities/migration/versions/DataSourceMigrationForVersion_4_0_RC2.java b/observe-entities/src/main/java/fr/ird/observe/entities/migration/versions/DataSourceMigrationForVersion_4_0_RC2.java index eb1ce64..527f753 100644 --- a/observe-entities/src/main/java/fr/ird/observe/entities/migration/versions/DataSourceMigrationForVersion_4_0_RC2.java +++ b/observe-entities/src/main/java/fr/ird/observe/entities/migration/versions/DataSourceMigrationForVersion_4_0_RC2.java @@ -27,9 +27,7 @@ import fr.ird.observe.entities.migration.AbstractObserveMigrationCallBack; import fr.ird.observe.entities.migration.H2DataSourceMigration; import fr.ird.observe.entities.migration.PGDataSourceMigration; import org.nuiton.topia.persistence.support.TopiaSqlSupport; -import org.nuiton.topia.persistence.support.TopiaSqlWork; -import java.sql.Connection; import java.sql.PreparedStatement; import java.sql.ResultSet; import java.sql.SQLException; @@ -59,29 +57,25 @@ public class DataSourceMigrationForVersion_4_0_RC2 extends AbstractObserveMigrat // recherche du nom de la constrainte final Set<String> result = new HashSet<>(); - topiaSqlSupport.doSqlWork(new TopiaSqlWork() { - - @Override - public void execute(Connection connection) throws SQLException { - - String sql = "select distinct (geartype||'') from observe_common.program"; - { - PreparedStatement ps = connection.prepareStatement(sql); - try { - ResultSet set = ps.executeQuery(); - while (set.next()) { - String gearType = set.getString(1); - result.add(gearType); - } - - } catch (Exception e) { - throw new SQLException("Could not obtain program gear types", e); - } finally { - ps.close(); + topiaSqlSupport.doSqlWork(connection -> { + + String sql = "select distinct (geartype||'') from observe_common.program"; + { + PreparedStatement ps = connection.prepareStatement(sql); + try { + ResultSet set = ps.executeQuery(); + while (set.next()) { + String gearType = set.getString(1); + result.add(gearType); } - } + } catch (Exception e) { + throw new SQLException("Could not obtain program gear types", e); + } finally { + ps.close(); + } } + }); if (result.contains("seine")) { diff --git a/observe-entities/src/main/java/fr/ird/observe/entities/migration/versions/DataSourceMigrationForVersion_4_0_RC3.java b/observe-entities/src/main/java/fr/ird/observe/entities/migration/versions/DataSourceMigrationForVersion_4_0_RC3.java index 9a02b27..2f92da3 100644 --- a/observe-entities/src/main/java/fr/ird/observe/entities/migration/versions/DataSourceMigrationForVersion_4_0_RC3.java +++ b/observe-entities/src/main/java/fr/ird/observe/entities/migration/versions/DataSourceMigrationForVersion_4_0_RC3.java @@ -30,7 +30,6 @@ import org.apache.commons.logging.Log; import org.apache.commons.logging.LogFactory; import org.nuiton.topia.persistence.TopiaException; import org.nuiton.topia.persistence.support.TopiaSqlSupport; -import org.nuiton.topia.persistence.support.TopiaSqlWork; import java.sql.Connection; import java.sql.PreparedStatement; @@ -152,25 +151,20 @@ public abstract class DataSourceMigrationForVersion_4_0_RC3 extends AbstractObse private void removeForeignKeyIndex(TopiaSqlSupport tx, final List<String> queries, final String schemaName, final String tableName, final String columnName) { - tx.doSqlWork(new TopiaSqlWork() { + tx.doSqlWork(connection -> { - @Override - public void execute(Connection connection) throws SQLException { + // get table oid + int oid = getTableOid(connection, schemaName, tableName); - // get table oid - int oid = getTableOid(connection, schemaName, tableName); + // get attribute num + int attNum = getAttributeNum(connection, oid, columnName); - // get attribute num - int attNum = getAttributeNum(connection, oid, columnName); + Set<Integer> indexIds = getIndexId(connection, oid, attNum); - Set<Integer> indexIds = getIndexId(connection, oid, attNum); + for (Integer indexId : indexIds) { - for (Integer indexId : indexIds) { - - String indexName = getIndexName(connection, indexId); - queries.add("DROP INDEX " + schemaName + "." + indexName + ";"); - - } + String indexName = getIndexName(connection, indexId); + queries.add("DROP INDEX " + schemaName + "." + indexName + ";"); } diff --git a/observe-entities/src/main/java/fr/ird/observe/entities/referentiel/ObserveReferentialEntities.java b/observe-entities/src/main/java/fr/ird/observe/entities/referentiel/ObserveReferentialEntities.java index a444709..00db79c 100644 --- a/observe-entities/src/main/java/fr/ird/observe/entities/referentiel/ObserveReferentialEntities.java +++ b/observe-entities/src/main/java/fr/ird/observe/entities/referentiel/ObserveReferentialEntities.java @@ -41,13 +41,7 @@ import java.util.List; */ public class ObserveReferentialEntities { - public static final Predicate<? extends ObserveReferentialEntity> IS_ACTIF_PREDICATE = new Predicate<ObserveReferentialEntity>() { - - @Override - public boolean apply(ObserveReferentialEntity input) { - return ReferenceStatusPersist.disabled != input.getStatus(); - } - }; + public static final Predicate<? extends ObserveReferentialEntity> IS_ACTIF_PREDICATE = (Predicate<ObserveReferentialEntity>) input -> ReferenceStatusPersist.disabled != input.getStatus(); /** Logger. */ private static final Log log = LogFactory.getLog(ObserveReferentialEntities.class); @@ -57,11 +51,11 @@ public class ObserveReferentialEntities { * entités qui ne sont pas actives {@link ObserveReferentialEntity#getStatus()} * * @param list la liste des entitées à filtrer - * @param <E> le type des entites du référentiel + * @param <E> le type des entites du référentiel */ public static <E extends ObserveReferentialEntity> void filterReferentielListByStatus( List<E> list) { - filterReferentielList(list, ObserveReferentialEntities.<E>newEnablePredicate()); + filterReferentielList(list, ObserveReferentialEntities.newEnablePredicate()::apply); } @@ -71,15 +65,15 @@ public class ObserveReferentialEntities { * * @param list la liste des entitées à filtrer * @param predicate le prédicate à appliquer pour conserver les valeurs - * @param <E> le type des entites du référentiel + * @param <E> le type des entites du référentiel */ public static <E extends ObserveReferentialEntity> void filterReferentielList( List<E> list, - Predicate<E> predicate) { + java.util.function.Predicate<E> predicate) { Iterator<E> itr = list.iterator(); while (itr.hasNext()) { E e = itr.next(); - if (!predicate.apply(e)) { + if (!predicate.test(e)) { // l'entite n'est pas retenue, on ne l'affiche pas @@ -121,7 +115,7 @@ public class ObserveReferentialEntities { public interface ReferentielWalker { - <E extends TopiaEntity> void walk(Class<E> beanClass) throws Exception; + <E extends TopiaEntity> void walk(Class<E> beanClass); } } diff --git a/observe-entities/src/main/java/fr/ird/observe/entities/referentiel/Persons.java b/observe-entities/src/main/java/fr/ird/observe/entities/referentiel/Persons.java index 6be30b4..53fa5b2 100644 --- a/observe-entities/src/main/java/fr/ird/observe/entities/referentiel/Persons.java +++ b/observe-entities/src/main/java/fr/ird/observe/entities/referentiel/Persons.java @@ -33,29 +33,14 @@ import com.google.common.base.Predicate; public class Persons { public static Predicate<Person> newObserverPredicate() { - return new Predicate<Person>() { - @Override - public boolean apply(Person input) { - return input.isObserver(); - } - }; + return Person::isObserver; } public static Predicate<Person> newCaptainPredicate() { - return new Predicate<Person>() { - @Override - public boolean apply(Person input) { - return input.isCaptain(); - } - }; + return Person::isCaptain; } public static Predicate<Person> newDataEntryOperatorPredicate() { - return new Predicate<Person>() { - @Override - public boolean apply(Person input) { - return input.isDataEntryOperator(); - } - }; + return Person::isDataEntryOperator; } } diff --git a/observe-entities/src/main/java/fr/ird/observe/entities/referentiel/Programs.java b/observe-entities/src/main/java/fr/ird/observe/entities/referentiel/Programs.java index 8645ba9..637ad67 100644 --- a/observe-entities/src/main/java/fr/ird/observe/entities/referentiel/Programs.java +++ b/observe-entities/src/main/java/fr/ird/observe/entities/referentiel/Programs.java @@ -43,14 +43,7 @@ public class Programs { * FIXME-TC-20100205 : il faudrait que le comparateur soit sur le bon * libelle selon la langue de base choisie... */ - public static Comparator<Program> PROGRAMME_COMPARATOR = - new Comparator<Program>() { - - @Override - public int compare(Program o1, Program o2) { - return o1.getLabel2().compareTo(o2.getLabel2()); - } - }; + public static final Comparator<Program> PROGRAMME_COMPARATOR = (o1, o2) -> o1.getLabel2().compareTo(o2.getLabel2()); public static void sort(List<Program> programs) { //FIXME-TC20100207 : make possible sort on different libelles coming diff --git a/observe-entities/src/main/java/fr/ird/observe/entities/referentiel/Species2.java b/observe-entities/src/main/java/fr/ird/observe/entities/referentiel/Species2.java index db7d1ab..b37330e 100644 --- a/observe-entities/src/main/java/fr/ird/observe/entities/referentiel/Species2.java +++ b/observe-entities/src/main/java/fr/ird/observe/entities/referentiel/Species2.java @@ -66,25 +66,13 @@ public class Species2 { public static List<WeightCategory> filterWeightCategoryBySpeciesIds(Collection<WeightCategory> speciess, final Set<String> speciesIds) { - return Lists.newArrayList(Iterables.filter(speciess, new Predicate<WeightCategory>() { - - @Override - public boolean apply(WeightCategory input) { - return speciesIds.contains(input.getSpecies().getTopiaId()); - } - })); + return Lists.newArrayList(Iterables.filter(speciess, input -> speciesIds.contains(input.getSpecies().getTopiaId()))); } public static List<WeightCategory> filterWeightCategoryByOcean(Collection<WeightCategory> speciess, final Ocean ocean) { - return Lists.newArrayList(Iterables.filter(speciess, new Predicate<WeightCategory>() { - - @Override - public boolean apply(WeightCategory input) { - return input.getSpecies().getOcean().contains(ocean); - } - })); + return Lists.newArrayList(Iterables.filter(speciess, input -> input.getSpecies().getOcean().contains(ocean))); } public static String decorate(Locale locale, Species species) { diff --git a/observe-entities/src/main/java/fr/ird/observe/entities/seine/ActivitySeineImpl.java b/observe-entities/src/main/java/fr/ird/observe/entities/seine/ActivitySeineImpl.java index 8627cea..5a771ab 100644 --- a/observe-entities/src/main/java/fr/ird/observe/entities/seine/ActivitySeineImpl.java +++ b/observe-entities/src/main/java/fr/ird/observe/entities/seine/ActivitySeineImpl.java @@ -31,6 +31,7 @@ import org.apache.commons.logging.LogFactory; import org.nuiton.util.NumberUtil; import java.util.Arrays; +import java.util.Collections; import java.util.List; import java.util.Objects; @@ -50,7 +51,7 @@ public class ActivitySeineImpl extends ActivitySeineAbstract { public static final String ACTIVITY_CHANGED_ZONE = "21"; - private static final List<String> CALEE_OPERATIONS = Arrays.asList(ACTIVITY_FIN_DE_PECHE); + private static final List<String> CALEE_OPERATIONS = Collections.singletonList(ACTIVITY_FIN_DE_PECHE); private static final List<String> DCP_OPERATIONS = Arrays.asList("13", "14", "15"); diff --git a/observe-entities/src/main/java/fr/ird/observe/entities/seine/ActivitySeines.java b/observe-entities/src/main/java/fr/ird/observe/entities/seine/ActivitySeines.java index 4273546..07a4a2a 100644 --- a/observe-entities/src/main/java/fr/ird/observe/entities/seine/ActivitySeines.java +++ b/observe-entities/src/main/java/fr/ird/observe/entities/seine/ActivitySeines.java @@ -50,14 +50,8 @@ public class ActivitySeines { * ActivitySeine#getTime()}. */ public static final Comparator<ActivitySeine> ACTIVITE_COMPARATOR = - new Comparator<ActivitySeine>() { - - @Override - public int compare(ActivitySeine o1, ActivitySeine o2) { - return o1.getTime().compareTo( - o2.getTime()); - } - }; + (o1, o2) -> o1.getTime().compareTo( + o2.getTime()); /** Logger. */ private static final Log log = LogFactory.getLog(ActivitySeines.class); @@ -304,11 +298,6 @@ public class ActivitySeines { } public static Predicate<ActivitySeine> newDateBeforePredicate(final Date time) { - return new Predicate<ActivitySeine>() { - @Override - public boolean apply(ActivitySeine input) { - return input.getTime().before(time); - } - }; + return input -> input.getTime().before(time); } } diff --git a/observe-entities/src/main/java/fr/ird/observe/entities/seine/NonTargetCatchImpl.java b/observe-entities/src/main/java/fr/ird/observe/entities/seine/NonTargetCatchImpl.java index 1bcd84b..af34ed3 100644 --- a/observe-entities/src/main/java/fr/ird/observe/entities/seine/NonTargetCatchImpl.java +++ b/observe-entities/src/main/java/fr/ird/observe/entities/seine/NonTargetCatchImpl.java @@ -43,7 +43,7 @@ public class NonTargetCatchImpl extends NonTargetCatchAbstract { /** Logger */ - static private Log log = LogFactory.getLog(NonTargetCatchImpl.class); + private static final Log log = LogFactory.getLog(NonTargetCatchImpl.class); private static final long serialVersionUID = 1L; diff --git a/observe-entities/src/main/java/fr/ird/observe/entities/seine/NonTargetCatchs.java b/observe-entities/src/main/java/fr/ird/observe/entities/seine/NonTargetCatchs.java index c64b276..b81226b 100644 --- a/observe-entities/src/main/java/fr/ird/observe/entities/seine/NonTargetCatchs.java +++ b/observe-entities/src/main/java/fr/ird/observe/entities/seine/NonTargetCatchs.java @@ -31,12 +31,7 @@ import fr.ird.observe.entities.referentiel.Species; public class NonTargetCatchs { public static Function<NonTargetCatch, Species> getSpeciesFunction() { - return new Function<NonTargetCatch, Species>() { - @Override - public Species apply(NonTargetCatch input) { - return input.getSpecies(); - } - }; + return NonTargetCatch::getSpecies; } } diff --git a/observe-entities/src/main/java/fr/ird/observe/entities/seine/NonTargetLenghts.java b/observe-entities/src/main/java/fr/ird/observe/entities/seine/NonTargetLenghts.java index e6416e4..abdbd0e 100644 --- a/observe-entities/src/main/java/fr/ird/observe/entities/seine/NonTargetLenghts.java +++ b/observe-entities/src/main/java/fr/ird/observe/entities/seine/NonTargetLenghts.java @@ -31,12 +31,7 @@ import fr.ird.observe.entities.referentiel.Species; public class NonTargetLenghts { public static Function<NonTargetLength, Species> getSpeciesFunction() { - return new Function<NonTargetLength, Species>() { - @Override - public Species apply(NonTargetLength input) { - return input.getSpecies(); - } - }; + return NonTargetLength::getSpecies; } } diff --git a/observe-entities/src/main/java/fr/ird/observe/entities/seine/RouteTopiaDao.java b/observe-entities/src/main/java/fr/ird/observe/entities/seine/RouteTopiaDao.java index a3c9bc4..500bbce 100644 --- a/observe-entities/src/main/java/fr/ird/observe/entities/seine/RouteTopiaDao.java +++ b/observe-entities/src/main/java/fr/ird/observe/entities/seine/RouteTopiaDao.java @@ -126,28 +126,24 @@ public class RouteTopiaDao extends AbstractRouteTopiaDao<Route> { final Date date = new Date(route.getDate().getTime()); - topiaSqlSupport.doSqlWork(new TopiaSqlWork() { - - @Override - public void execute(Connection connection) throws SQLException { - - String sql = "UPDATE observe_seine.SET" + - " SET ENDPURSINGTIMESTAMP = (? || ' ' || ENDPURSINGTIMESTAMP::time)::timestamp," + - " ENDSETTIMESTAMP = (? || ' ' || ENDSETTIMESTAMP::time)::timestamp" + - " WHERE TOPIAID IN " + - " (" + - " SELECT s.TOPIAID" + - " FROM observe_seine.ACTIVITY a, observe_seine.SET s" + - " WHERE a.ROUTE = ? AND a.SET = s.TOPIAID" + - " );"; - - PreparedStatement ps = connection.prepareStatement(sql); - ps.setDate(1, date); - ps.setDate(2, date); - ps.setString(3, routeId); - ps.executeUpdate(); - - } + topiaSqlSupport.doSqlWork(connection -> { + + String sql = "UPDATE observe_seine.SET" + + " SET ENDPURSINGTIMESTAMP = (? || ' ' || ENDPURSINGTIMESTAMP::time)::timestamp," + + " ENDSETTIMESTAMP = (? || ' ' || ENDSETTIMESTAMP::time)::timestamp" + + " WHERE TOPIAID IN " + + " (" + + " SELECT s.TOPIAID" + + " FROM observe_seine.ACTIVITY a, observe_seine.SET s" + + " WHERE a.ROUTE = ? AND a.SET = s.TOPIAID" + + " );"; + + PreparedStatement ps = connection.prepareStatement(sql); + ps.setDate(1, date); + ps.setDate(2, date); + ps.setString(3, routeId); + ps.executeUpdate(); + }); } diff --git a/observe-entities/src/main/java/fr/ird/observe/entities/seine/Routes.java b/observe-entities/src/main/java/fr/ird/observe/entities/seine/Routes.java index d49e279..10a2004 100644 --- a/observe-entities/src/main/java/fr/ird/observe/entities/seine/Routes.java +++ b/observe-entities/src/main/java/fr/ird/observe/entities/seine/Routes.java @@ -46,13 +46,7 @@ public class Routes { * Comparateur de {@link Route} basé sur la propriété {@link * Route#getDate()}. */ - public static final Comparator<Route> ROUTE_COMPARATOR = new Comparator<Route>() { - - @Override - public int compare(Route o1, Route o2) { - return o1.getDate().compareTo(o2.getDate()); - } - }; + public static final Comparator<Route> ROUTE_COMPARATOR = (o1, o2) -> o1.getDate().compareTo(o2.getDate()); public static void sort(List<Route> routes) { Collections.sort(routes, ROUTE_COMPARATOR); @@ -94,11 +88,6 @@ public class Routes { } public static Predicate<Route> newDateBeforePredicate(final Date date) { - return new Predicate<Route>() { - @Override - public boolean apply(Route input) { - return input.getDate().before(date); - } - }; + return input -> input.getDate().before(date); } } diff --git a/observe-entities/src/main/java/fr/ird/observe/entities/seine/SetSeines.java b/observe-entities/src/main/java/fr/ird/observe/entities/seine/SetSeines.java index 167975e..a65035e 100644 --- a/observe-entities/src/main/java/fr/ird/observe/entities/seine/SetSeines.java +++ b/observe-entities/src/main/java/fr/ird/observe/entities/seine/SetSeines.java @@ -22,7 +22,6 @@ package fr.ird.observe.entities.seine; * #L% */ -import com.google.common.base.Predicate; import com.google.common.collect.Collections2; import fr.ird.observe.entities.referentiel.Species; @@ -40,13 +39,7 @@ public class SetSeines { Collection<NonTargetLength> nonTargetLengths = null; if (!setSeine.isNonTargetSampleEmpty()) { - nonTargetLengths = Collections2.filter(setSeine.getNonTargetSample().iterator().next().getNonTargetLength(), new Predicate<NonTargetLength>() { - - @Override - public boolean apply(NonTargetLength input) { - return species.equals(input.getSpecies()); - } - }); + nonTargetLengths = Collections2.filter(setSeine.getNonTargetSample().iterator().next().getNonTargetLength(), input -> species.equals(input.getSpecies())); } return nonTargetLengths; diff --git a/observe-entities/src/main/java/fr/ird/observe/entities/seine/TargetCatchs.java b/observe-entities/src/main/java/fr/ird/observe/entities/seine/TargetCatchs.java index 658e692..d42a288 100644 --- a/observe-entities/src/main/java/fr/ird/observe/entities/seine/TargetCatchs.java +++ b/observe-entities/src/main/java/fr/ird/observe/entities/seine/TargetCatchs.java @@ -22,12 +22,12 @@ package fr.ird.observe.entities.seine; * #L% */ -import com.google.common.base.Function; -import com.google.common.base.Predicate; import fr.ird.observe.entities.referentiel.Species; import java.util.Collection; import java.util.List; +import java.util.function.Function; +import java.util.function.Predicate; import java.util.stream.Collectors; /** @@ -43,21 +43,11 @@ public class TargetCatchs { } public static Function<TargetCatch, Species> getSpeciesFunction() { - return new Function<TargetCatch, Species>() { - @Override - public Species apply(TargetCatch input) { - return input.getSpecies(); - } - }; + return TargetCatch::getSpecies; } public static Predicate<TargetCatch> newDiscardedPredicate(final boolean discarded) { - return new Predicate<TargetCatch>() { - @Override - public boolean apply(TargetCatch input) { - return discarded == input.isDiscarded(); - } - }; + return input -> discarded == input.isDiscarded(); } } diff --git a/observe-entities/src/main/java/fr/ird/observe/entities/seine/TargetLenghts.java b/observe-entities/src/main/java/fr/ird/observe/entities/seine/TargetLenghts.java index 118a9c1..7ecb115 100644 --- a/observe-entities/src/main/java/fr/ird/observe/entities/seine/TargetLenghts.java +++ b/observe-entities/src/main/java/fr/ird/observe/entities/seine/TargetLenghts.java @@ -22,21 +22,17 @@ package fr.ird.observe.entities.seine; * #L% */ -import com.google.common.base.Function; import fr.ird.observe.entities.referentiel.Species; +import java.util.function.Function; + /** * @author Sylvain Bavencoff - bavencoff@codelutin.com */ public class TargetLenghts { public static Function<TargetLength, Species> getSpeciesFunction() { - return new Function<TargetLength, Species>() { - @Override - public Species apply(TargetLength input) { - return input.getSpecies(); - } - }; + return input -> input.getSpecies(); } } diff --git a/observe-entities/src/main/java/fr/ird/observe/entities/seine/TripSeineTopiaDao.java b/observe-entities/src/main/java/fr/ird/observe/entities/seine/TripSeineTopiaDao.java index 1f35c35..8c944ac 100644 --- a/observe-entities/src/main/java/fr/ird/observe/entities/seine/TripSeineTopiaDao.java +++ b/observe-entities/src/main/java/fr/ird/observe/entities/seine/TripSeineTopiaDao.java @@ -118,7 +118,7 @@ public class TripSeineTopiaDao extends AbstractTripSeineTopiaDao<TripSeine> { private static class TripMapActivityPointQuery extends TopiaSqlQuery<TripMapPoint> { - private static String SQL = "SELECT" + + private static final String SQL = "SELECT" + " r.date, " + " a.time, " + " a.latitude," + @@ -133,7 +133,7 @@ public class TripSeineTopiaDao extends AbstractTripSeineTopiaDao<TripSeine> { " WHERE r.trip = ?" + " ORDER BY r.date, a.time"; - protected String tripId; + protected final String tripId; public TripMapActivityPointQuery(String tripId) { this.tripId = tripId; diff --git a/observe-entities/src/test/java/fr/ird/observe/ObserveTopiaApplicationContextTest.java b/observe-entities/src/test/java/fr/ird/observe/ObserveTopiaApplicationContextTest.java index f3a47b7..fded7d4 100644 --- a/observe-entities/src/test/java/fr/ird/observe/ObserveTopiaApplicationContextTest.java +++ b/observe-entities/src/test/java/fr/ird/observe/ObserveTopiaApplicationContextTest.java @@ -57,7 +57,7 @@ public class ObserveTopiaApplicationContextTest { } @Before - public void setUp() throws Exception { + public void setUp() { testDirectory = TestHelper.newFile(testName.getMethodName()); } diff --git a/observe-services-api/src/main/java/fr/ird/observe/services/ObserveServiceInitializer.java b/observe-services-api/src/main/java/fr/ird/observe/services/ObserveServiceInitializer.java index 70d033e..fe7e14f 100644 --- a/observe-services-api/src/main/java/fr/ird/observe/services/ObserveServiceInitializer.java +++ b/observe-services-api/src/main/java/fr/ird/observe/services/ObserveServiceInitializer.java @@ -22,7 +22,6 @@ package fr.ird.observe.services; * #L% */ -import com.google.common.base.Optional; import fr.ird.observe.services.configuration.ObserveDataSourceConfiguration; import fr.ird.observe.services.configuration.ObserveDataSourceConfigurationAndConnection; import fr.ird.observe.services.configuration.ObserveDataSourceConnection; @@ -30,6 +29,7 @@ import fr.ird.observe.services.dto.constants.ReferentialLocale; import java.io.File; import java.util.Locale; +import java.util.Optional; /** * Objet contentant les informations nécessaire pour créer un nouveau service. @@ -190,11 +190,11 @@ public class ObserveServiceInitializer { } protected void setDataSourceConnection(ObserveDataSourceConnection dataSourceConnection) { - this.dataSourceConnection = Optional.fromNullable(dataSourceConnection); + this.dataSourceConnection = Optional.ofNullable(dataSourceConnection); } protected void setDataSourceConfiguration(ObserveDataSourceConfiguration dataSourceConfiguration) { - this.dataSourceConfiguration = Optional.fromNullable(dataSourceConfiguration); + this.dataSourceConfiguration = Optional.ofNullable(dataSourceConfiguration); } protected void setTemporaryDirectoryRoot(File temporaryDirectoryRoot) { diff --git a/observe-services-api/src/main/java/fr/ird/observe/services/service/actions/report/ReportBuilder.java b/observe-services-api/src/main/java/fr/ird/observe/services/service/actions/report/ReportBuilder.java index c196fdd..a12eb2d 100644 --- a/observe-services-api/src/main/java/fr/ird/observe/services/service/actions/report/ReportBuilder.java +++ b/observe-services-api/src/main/java/fr/ird/observe/services/service/actions/report/ReportBuilder.java @@ -365,7 +365,7 @@ public class ReportBuilder { } String typeStr = parts[0].trim(); String request = parts[1].trim(); - Class<?> type = null; + Class<?> type; try { type = Class.forName(typeStr); } catch (ClassNotFoundException eee) { diff --git a/observe-services-api/src/main/java/fr/ird/observe/services/service/actions/validate/ValidateResultForDtoType.java b/observe-services-api/src/main/java/fr/ird/observe/services/service/actions/validate/ValidateResultForDtoType.java index 21b8d49..1518ea5 100644 --- a/observe-services-api/src/main/java/fr/ird/observe/services/service/actions/validate/ValidateResultForDtoType.java +++ b/observe-services-api/src/main/java/fr/ird/observe/services/service/actions/validate/ValidateResultForDtoType.java @@ -23,7 +23,6 @@ package fr.ird.observe.services.service.actions.validate; */ import com.google.common.base.Optional; -import com.google.common.base.Predicate; import com.google.common.collect.ImmutableSet; import com.google.common.collect.Iterables; import fr.ird.observe.services.dto.AbstractReference; @@ -53,12 +52,7 @@ public class ValidateResultForDtoType<D extends IdDto> implements ObserveDto { } public ValidateResultForDto<D> getValidateResult(final AbstractReference<D> referenceDto) { - Optional<ValidateResultForDto<D>> resultForDtoOptional = Iterables.tryFind(validateResultForDto, new Predicate<ValidateResultForDto<D>>() { - @Override - public boolean apply(ValidateResultForDto<D> input) { - return referenceDto.equals(input.getDto()); - } - }); + Optional<ValidateResultForDto<D>> resultForDtoOptional = Iterables.tryFind(validateResultForDto, input -> referenceDto.equals(input.getDto())); return resultForDtoOptional.orNull(); } diff --git a/observe-services-api/src/main/java/fr/ird/observe/services/service/actions/validate/ValidateResultForDtos.java b/observe-services-api/src/main/java/fr/ird/observe/services/service/actions/validate/ValidateResultForDtos.java index 932aadd..d86c49f 100644 --- a/observe-services-api/src/main/java/fr/ird/observe/services/service/actions/validate/ValidateResultForDtos.java +++ b/observe-services-api/src/main/java/fr/ird/observe/services/service/actions/validate/ValidateResultForDtos.java @@ -22,8 +22,6 @@ package fr.ird.observe.services.service.actions.validate; * #L% */ -import com.google.common.base.Function; -import com.google.common.base.Predicate; import com.google.common.collect.ImmutableSet; import com.google.common.collect.Iterables; import com.google.common.collect.Lists; @@ -34,14 +32,14 @@ import org.nuiton.validator.NuitonValidatorScope; import java.util.EnumMap; import java.util.EnumSet; import java.util.List; +import java.util.stream.Collectors; /** * @author Sylvain Bavencoff - bavencoff@codelutin.com */ public class ValidateResultForDtos { - public static EnumMap<NuitonValidatorScope, Integer> getScopesCount( - ValidateResultForDto validateResultForDto) { + public static EnumMap<NuitonValidatorScope, Integer> getScopesCount(ValidateResultForDto<?> validateResultForDto) { EnumMap<NuitonValidatorScope, Integer> result = Maps.newEnumMap(NuitonValidatorScope.class); @@ -71,30 +69,16 @@ public class ValidateResultForDtos { return result; } - public static EnumSet<NuitonValidatorScope> getScopes( - ValidateResultForDto validateResultForDto) { + public static EnumSet<NuitonValidatorScope> getScopes(ValidateResultForDto<?> validateResultForDto) { - EnumSet<NuitonValidatorScope> result = Sets.newEnumSet(Iterables.transform(validateResultForDto.getMessages(), new Function<ValidationMessage, NuitonValidatorScope>() { - @Override - public NuitonValidatorScope apply(ValidationMessage input) { - return input.getScope(); - } - }), NuitonValidatorScope.class); + EnumSet<NuitonValidatorScope> result = Sets.newEnumSet(Iterables.transform(validateResultForDto.getMessages(), ValidationMessage::getScope), NuitonValidatorScope.class); return result; } - public static List<ValidationMessage> scopeMessageFilter(final NuitonValidatorScope scope, ValidateResultForDto validateResultForDto) { - - List<ValidationMessage> result = Lists.newLinkedList(Iterables.filter( - validateResultForDto.getMessages(), - new Predicate<ValidationMessage>() { - @Override - public boolean apply(ValidationMessage input) { - return scope.equals(input.getScope()); - } - } - )); + public static List<ValidationMessage> scopeMessageFilter(final NuitonValidatorScope scope, ValidateResultForDto<?> validateResultForDto) { + + List<ValidationMessage> result = Lists.newLinkedList(validateResultForDto.getMessages().stream().filter(input -> scope.equals(input.getScope())).collect(Collectors.toList())); return result; } diff --git a/observe-services-api/src/main/java/fr/ird/observe/services/service/actions/validate/ValidationMessage.java b/observe-services-api/src/main/java/fr/ird/observe/services/service/actions/validate/ValidationMessage.java index 9719eca..de1666f 100644 --- a/observe-services-api/src/main/java/fr/ird/observe/services/service/actions/validate/ValidationMessage.java +++ b/observe-services-api/src/main/java/fr/ird/observe/services/service/actions/validate/ValidationMessage.java @@ -26,12 +26,16 @@ import com.google.common.base.MoreObjects; import fr.ird.observe.services.dto.ObserveDto; import org.nuiton.validator.NuitonValidatorScope; +import java.io.Serializable; + /** * Représente un message de validation. * * @author Sylvain Bavencoff - bavencoff@codelutin.com */ -public class ValidationMessage implements ObserveDto { +public class ValidationMessage implements ObserveDto, Serializable { + + private static final long serialVersionUID = 1L; protected final NuitonValidatorScope scope; diff --git a/observe-services-api/src/main/java/fr/ird/observe/services/service/actions/validate/ValidatorDtos.java b/observe-services-api/src/main/java/fr/ird/observe/services/service/actions/validate/ValidatorDtos.java index b2e6db5..a8a2e52 100644 --- a/observe-services-api/src/main/java/fr/ird/observe/services/service/actions/validate/ValidatorDtos.java +++ b/observe-services-api/src/main/java/fr/ird/observe/services/service/actions/validate/ValidatorDtos.java @@ -22,7 +22,6 @@ package fr.ird.observe.services.service.actions.validate; * #L% */ -import com.google.common.base.Predicate; import com.google.common.collect.Iterables; import com.google.common.collect.Sets; import fr.ird.observe.services.dto.referential.ReferentialDto; @@ -42,16 +41,10 @@ public class ValidatorDtos { final EnumSet<NuitonValidatorScope> scopes, final String context) { - return Sets.newHashSet(Iterables.filter(validators, new Predicate<ValidatorDto>() { - @Override - public boolean apply(ValidatorDto input) { - return - (validateData && ! ReferentialDto.class.isAssignableFrom(input.getDtoType()) - || validateReferential && ReferentialDto.class.isAssignableFrom(input.getDtoType())) - && scopes.contains(input.getScope()) - && context.equals(input.getContext()); - } - })); + return Sets.newHashSet(Iterables.filter(validators, input -> (validateData && ! ReferentialDto.class.isAssignableFrom(input.getDtoType()) + || validateReferential && ReferentialDto.class.isAssignableFrom(input.getDtoType())) + && scopes.contains(input.getScope()) + && context.equals(input.getContext()))); } diff --git a/observe-services-configuration-rest/src/main/java/fr/ird/observe/services/configuration/ObserveDataSourceConfigurationRest.java b/observe-services-configuration-rest/src/main/java/fr/ird/observe/services/configuration/ObserveDataSourceConfigurationRest.java index 2cfb98c..de5ac57 100644 --- a/observe-services-configuration-rest/src/main/java/fr/ird/observe/services/configuration/ObserveDataSourceConfigurationRest.java +++ b/observe-services-configuration-rest/src/main/java/fr/ird/observe/services/configuration/ObserveDataSourceConfigurationRest.java @@ -23,10 +23,10 @@ package fr.ird.observe.services.configuration; */ import com.google.common.base.MoreObjects; -import com.google.common.base.Optional; import org.nuiton.version.Version; import java.net.URL; +import java.util.Optional; /** * Configuration d'une source de données Rest non connectée. @@ -113,7 +113,7 @@ public class ObserveDataSourceConfigurationRest implements ObserveDataSourceConf } public Optional<String> getOptionalDatabaseName() { - return Optional.fromNullable(optionalDatabaseName); + return Optional.ofNullable(optionalDatabaseName); } public void setOptionalDatabaseName(String optionalDatabaseName) { diff --git a/observe-services-model/src/main/java/fr/ird/observe/services/dto/AbstractReference.java b/observe-services-model/src/main/java/fr/ird/observe/services/dto/AbstractReference.java index fe7674f..74ca603 100644 --- a/observe-services-model/src/main/java/fr/ird/observe/services/dto/AbstractReference.java +++ b/observe-services-model/src/main/java/fr/ird/observe/services/dto/AbstractReference.java @@ -81,25 +81,11 @@ public abstract class AbstractReference<D extends IdDto> implements ObserveDto, //FIXME Use java Predicate API public static <BeanType extends AbstractReference> Predicate<BeanType> newIdPredicate(String id) { - final String $tmp = id; - return new Predicate<BeanType>() { - - @Override - public boolean apply(BeanType input) { - return Objects.equals($tmp, input.getId()); - } - }; - + return input -> Objects.equals(id, input.getId()); } public static <BeanType extends AbstractReference> Predicate<BeanType> newIdsPredicate(final Collection<String> ids) { - return new Predicate<BeanType>() { - - @Override - public boolean apply(BeanType input) { - return ids.contains(input.getId()); - } - }; + return input -> ids.contains(input.getId()); } public static Function<AbstractReference, String> getIdFunction() { @@ -107,13 +93,7 @@ public abstract class AbstractReference<D extends IdDto> implements ObserveDto, } public static <BeanType extends AbstractReference> Function<BeanType, String> newIdFunction() { - return new Function<BeanType, String>() { - - @Override - public String apply(BeanType input) { - return input.getId(); - } - }; + return input -> input.getId(); } diff --git a/observe-services-model/src/main/java/fr/ird/observe/services/dto/DataReference.java b/observe-services-model/src/main/java/fr/ird/observe/services/dto/DataReference.java index ea7d862..0e66d04 100644 --- a/observe-services-model/src/main/java/fr/ird/observe/services/dto/DataReference.java +++ b/observe-services-model/src/main/java/fr/ird/observe/services/dto/DataReference.java @@ -43,34 +43,16 @@ public class DataReference<D extends DataDto> extends AbstractReference<D> { private static final Log log = LogFactory.getLog(DataReference.class); public static Predicate<? super DataReference> newLabelValuePredicate(final String propertyName, final Serializable propertyValue) { - return new Predicate<DataReference>() { - - @Override - public boolean apply(DataReference input) { - return input.getPropertyNames().contains(propertyName) - && propertyValue.equals(input.getPropertyValue(propertyName)); - } - }; + return (Predicate<DataReference>) input -> input.getPropertyNames().contains(propertyName) + && propertyValue.equals(input.getPropertyValue(propertyName)); } public static Predicate<DataReference> newTripSeinePredicate() { - return new Predicate<DataReference>() { - - @Override - public boolean apply(DataReference input) { - return IdDtos.isTripSeineId(input.getId()); - } - }; + return input -> IdDtos.isTripSeineId(input.getId()); } - public static <BeanType extends IdDto> Predicate<BeanType> newTripLonglinePredicate() { - return new Predicate<BeanType>() { - - @Override - public boolean apply(BeanType input) { - return IdDtos.isTripLonglineId(input.getId()); - } - }; + public static <BeanType extends IdDto> java.util.function.Predicate<BeanType> newTripLonglinePredicate() { + return input -> IdDtos.isTripLonglineId(input.getId()); } @Override diff --git a/observe-services-model/src/main/java/fr/ird/observe/services/dto/IdDtos.java b/observe-services-model/src/main/java/fr/ird/observe/services/dto/IdDtos.java index 6ae9d56..57ace7b 100644 --- a/observe-services-model/src/main/java/fr/ird/observe/services/dto/IdDtos.java +++ b/observe-services-model/src/main/java/fr/ird/observe/services/dto/IdDtos.java @@ -22,7 +22,6 @@ package fr.ird.observe.services.dto; * #L% */ -import com.google.common.base.Predicate; import com.google.common.collect.Iterables; import com.google.common.collect.Maps; import fr.ird.observe.services.dto.longline.ActivityLonglineDto; @@ -34,6 +33,7 @@ import fr.ird.observe.services.dto.seine.TripSeineDto; import java.util.Collection; import java.util.Map; +import java.util.function.Predicate; public class IdDtos extends AbstractIdDtos { @@ -42,23 +42,11 @@ public class IdDtos extends AbstractIdDtos { } public static <BeanType extends IdDto> Predicate<BeanType> newTripSeinePredicate() { - return new Predicate<BeanType>() { - - @Override - public boolean apply(BeanType input) { - return isTripSeineId(input.getId()) ; - } - }; + return input -> isTripSeineId(input.getId()); } public static <BeanType extends IdDto> Predicate<BeanType> newTripLonglinePredicate() { - return new Predicate<BeanType>() { - - @Override - public boolean apply(BeanType input) { - return isTripLonglineId(input.getId()) ; - } - }; + return input -> isTripLonglineId(input.getId()); } public static <BeanType extends IdDto> boolean exists(Iterable<BeanType> source, String id) { @@ -166,13 +154,7 @@ public class IdDtos extends AbstractIdDtos { } public static <BeanType extends IdDto> Predicate<BeanType> newIdsPredicate(final Collection<String> ids) { - return new Predicate<BeanType>() { - - @Override - public boolean apply(BeanType input) { - return ids.contains(input.getId()) ; - } - }; + return input -> ids.contains(input.getId()); } public static <BeanType extends IdDto> Map<String, BeanType> splitById(Collection<BeanType> dtos) { diff --git a/observe-services-model/src/main/java/fr/ird/observe/services/dto/ObserveDbUserDtos.java b/observe-services-model/src/main/java/fr/ird/observe/services/dto/ObserveDbUserDtos.java index 3a316d0..9890489 100644 --- a/observe-services-model/src/main/java/fr/ird/observe/services/dto/ObserveDbUserDtos.java +++ b/observe-services-model/src/main/java/fr/ird/observe/services/dto/ObserveDbUserDtos.java @@ -26,7 +26,7 @@ import java.util.Comparator; public class ObserveDbUserDtos extends AbstractObserveDbUserDtos { - protected static UserDtoComparator USER_DTO_COMPARATOR = new UserDtoComparator(); + protected static final UserDtoComparator USER_DTO_COMPARATOR = new UserDtoComparator(); public static UserDtoComparator getUserDtoComparator() { return USER_DTO_COMPARATOR; diff --git a/observe-services-model/src/main/java/fr/ird/observe/services/dto/actions/report/Report.java b/observe-services-model/src/main/java/fr/ird/observe/services/dto/actions/report/Report.java index cf53d6f..338a1b2 100644 --- a/observe-services-model/src/main/java/fr/ird/observe/services/dto/actions/report/Report.java +++ b/observe-services-model/src/main/java/fr/ird/observe/services/dto/actions/report/Report.java @@ -21,7 +21,6 @@ */ package fr.ird.observe.services.dto.actions.report; -import com.google.common.base.Predicate; import com.google.common.collect.Iterables; import com.google.common.collect.Lists; import fr.ird.observe.services.dto.ObserveDto; @@ -148,12 +147,7 @@ public class Report implements Serializable, ObserveDto { } public ReportVariable getRepeatVariable(final String name) { - return Iterables.find(Lists.newArrayList(repeatVariables), new Predicate<ReportVariable>() { - @Override - public boolean apply(ReportVariable reportVariable) { - return name.equals(reportVariable.getName()); - } - }); + return Iterables.find(Lists.newArrayList(repeatVariables), reportVariable -> name.equals(reportVariable.getName())); } public boolean canExecute() { diff --git a/observe-services-model/src/main/java/fr/ird/observe/services/dto/actions/report/ReportOperation.java b/observe-services-model/src/main/java/fr/ird/observe/services/dto/actions/report/ReportOperation.java index 87a6499..ca9c1da 100644 --- a/observe-services-model/src/main/java/fr/ird/observe/services/dto/actions/report/ReportOperation.java +++ b/observe-services-model/src/main/java/fr/ird/observe/services/dto/actions/report/ReportOperation.java @@ -36,6 +36,6 @@ public enum ReportOperation implements ObserveDto { SumColumn, SumIntColumn, SumIntRow, - SumRow; + SumRow } diff --git a/observe-services-model/src/main/java/fr/ird/observe/services/dto/actions/report/ReportVariable.java b/observe-services-model/src/main/java/fr/ird/observe/services/dto/actions/report/ReportVariable.java index 47747cd..e062779 100644 --- a/observe-services-model/src/main/java/fr/ird/observe/services/dto/actions/report/ReportVariable.java +++ b/observe-services-model/src/main/java/fr/ird/observe/services/dto/actions/report/ReportVariable.java @@ -46,11 +46,11 @@ public class ReportVariable<V> implements Serializable, ObserveDto { private static final long serialVersionUID = 1L; - protected String name; + protected final String name; - protected Class<V> type; + protected final Class<V> type; - protected String request; + protected final String request; protected Set<V> values; diff --git a/observe-services-model/src/main/java/fr/ird/observe/services/dto/constants/ObserveDbRole.java b/observe-services-model/src/main/java/fr/ird/observe/services/dto/constants/ObserveDbRole.java index 936dfd8..4fb9127 100644 --- a/observe-services-model/src/main/java/fr/ird/observe/services/dto/constants/ObserveDbRole.java +++ b/observe-services-model/src/main/java/fr/ird/observe/services/dto/constants/ObserveDbRole.java @@ -31,6 +31,6 @@ public enum ObserveDbRole { REFERENTIAL, USER, TECHNICAL, - ADMINISTRATOR; + ADMINISTRATOR } diff --git a/observe-services-model/src/main/java/fr/ird/observe/services/dto/constants/ReferenceStatus.java b/observe-services-model/src/main/java/fr/ird/observe/services/dto/constants/ReferenceStatus.java index dbc6eef..ef3aecf 100644 --- a/observe-services-model/src/main/java/fr/ird/observe/services/dto/constants/ReferenceStatus.java +++ b/observe-services-model/src/main/java/fr/ird/observe/services/dto/constants/ReferenceStatus.java @@ -35,6 +35,6 @@ public enum ReferenceStatus { disabled, /** status active */ - enabled; + enabled } diff --git a/observe-services-model/src/main/java/fr/ird/observe/services/dto/constants/TripMapPointType.java b/observe-services-model/src/main/java/fr/ird/observe/services/dto/constants/TripMapPointType.java index 4af4528..8daeb12 100644 --- a/observe-services-model/src/main/java/fr/ird/observe/services/dto/constants/TripMapPointType.java +++ b/observe-services-model/src/main/java/fr/ird/observe/services/dto/constants/TripMapPointType.java @@ -43,6 +43,6 @@ public enum TripMapPointType { longlineActivityWithHaulingStart, longlineActivityWithHaulingEnd, longlineActivityWithInteraction, - longlineActivityWithStation; - + longlineActivityWithStation + } diff --git a/observe-services-model/src/main/java/fr/ird/observe/services/dto/constants/seine/NonTargetCatchComputedValueSource.java b/observe-services-model/src/main/java/fr/ird/observe/services/dto/constants/seine/NonTargetCatchComputedValueSource.java index 6e5ab78..3be588e 100644 --- a/observe-services-model/src/main/java/fr/ird/observe/services/dto/constants/seine/NonTargetCatchComputedValueSource.java +++ b/observe-services-model/src/main/java/fr/ird/observe/services/dto/constants/seine/NonTargetCatchComputedValueSource.java @@ -47,6 +47,6 @@ public enum NonTargetCatchComputedValueSource { * * @since 3.0 */ - fromReferentiel; + fromReferentiel } diff --git a/observe-services-model/src/main/java/fr/ird/observe/services/dto/constants/seine/SchoolType.java b/observe-services-model/src/main/java/fr/ird/observe/services/dto/constants/seine/SchoolType.java index ab341df..5454c94 100644 --- a/observe-services-model/src/main/java/fr/ird/observe/services/dto/constants/seine/SchoolType.java +++ b/observe-services-model/src/main/java/fr/ird/observe/services/dto/constants/seine/SchoolType.java @@ -36,6 +36,6 @@ public enum SchoolType { objet, /** banc libre // was 2 before version 4.0 */ - libre; + libre } diff --git a/observe-services-model/src/main/java/fr/ird/observe/services/dto/constants/seine/TypeTransmittingBuoyOperation.java b/observe-services-model/src/main/java/fr/ird/observe/services/dto/constants/seine/TypeTransmittingBuoyOperation.java index ef57b3c..b4db646 100644 --- a/observe-services-model/src/main/java/fr/ird/observe/services/dto/constants/seine/TypeTransmittingBuoyOperation.java +++ b/observe-services-model/src/main/java/fr/ird/observe/services/dto/constants/seine/TypeTransmittingBuoyOperation.java @@ -35,10 +35,10 @@ public enum TypeTransmittingBuoyOperation { recuperationEtRemplacement("2", "3"); /** les codes des opérations sur balise */ - private String[] codeOperation; + private final String[] codeOperation; /** le count de balises lues */ - private int nbBalises; + private final int nbBalises; TypeTransmittingBuoyOperation(String... codeOperation) { this.codeOperation = codeOperation; diff --git a/observe-services-model/src/main/java/fr/ird/observe/services/dto/gson/ObserveDtoGsonSupplier.java b/observe-services-model/src/main/java/fr/ird/observe/services/dto/gson/ObserveDtoGsonSupplier.java index 3c71fd4..6b055db 100644 --- a/observe-services-model/src/main/java/fr/ird/observe/services/dto/gson/ObserveDtoGsonSupplier.java +++ b/observe-services-model/src/main/java/fr/ird/observe/services/dto/gson/ObserveDtoGsonSupplier.java @@ -49,13 +49,7 @@ import java.util.Date; */ public class ObserveDtoGsonSupplier implements Supplier<Gson> { - public static final Supplier<Gson> DEFAULT_GSON_SUPPLIER = new Supplier<Gson>() { - - @Override - public Gson get() { - return new ObserveDtoGsonSupplier().get(); - } - }; + public static final Supplier<Gson> DEFAULT_GSON_SUPPLIER = () -> new ObserveDtoGsonSupplier().get(); protected final boolean prettyPrint; diff --git a/observe-services-model/src/main/java/fr/ird/observe/services/dto/longline/SectionWithTemplate.java b/observe-services-model/src/main/java/fr/ird/observe/services/dto/longline/SectionWithTemplate.java index 42a3390..3b79565 100644 --- a/observe-services-model/src/main/java/fr/ird/observe/services/dto/longline/SectionWithTemplate.java +++ b/observe-services-model/src/main/java/fr/ird/observe/services/dto/longline/SectionWithTemplate.java @@ -22,10 +22,6 @@ package fr.ird.observe.services.dto.longline; * #L% */ -import fr.ird.observe.services.dto.longline.BasketDto; -import fr.ird.observe.services.dto.longline.SectionDto; -import fr.ird.observe.services.dto.longline.SectionTemplate; - import java.util.Collection; import java.util.LinkedHashSet; diff --git a/observe-services-model/src/main/java/fr/ird/observe/services/dto/longline/SectionWithTemplates.java b/observe-services-model/src/main/java/fr/ird/observe/services/dto/longline/SectionWithTemplates.java index 56ccf82..ccb3512 100644 --- a/observe-services-model/src/main/java/fr/ird/observe/services/dto/longline/SectionWithTemplates.java +++ b/observe-services-model/src/main/java/fr/ird/observe/services/dto/longline/SectionWithTemplates.java @@ -22,7 +22,6 @@ package fr.ird.observe.services.dto.longline; * #L% */ -import com.google.common.base.Function; import com.google.common.collect.Iterables; import com.google.common.collect.Sets; @@ -39,14 +38,6 @@ import java.util.List; */ public class SectionWithTemplates { - protected static Function<SectionWithTemplate, SectionDto> GET_DELEGATE_FUNCTION = new Function<SectionWithTemplate, SectionDto>() { - @Override - public SectionDto apply(SectionWithTemplate input) { - return input.getDelegate(); - } - }; - - public static List<SectionWithTemplate> getSectionTemplates(Collection<SectionDto> sections) { List<SectionWithTemplate> sectionTemplates = new ArrayList<>(); @@ -64,6 +55,6 @@ public class SectionWithTemplates { } public static LinkedHashSet<SectionDto> getSections(List<SectionWithTemplate> data) { - return Sets.newLinkedHashSet(Iterables.transform(data, GET_DELEGATE_FUNCTION)); + return Sets.newLinkedHashSet(Iterables.transform(data, SectionWithTemplate::getDelegate)); } } diff --git a/observe-services-model/src/main/java/fr/ird/observe/services/dto/referential/PersonDtos.java b/observe-services-model/src/main/java/fr/ird/observe/services/dto/referential/PersonDtos.java index c3050f4..256ebf7 100644 --- a/observe-services-model/src/main/java/fr/ird/observe/services/dto/referential/PersonDtos.java +++ b/observe-services-model/src/main/java/fr/ird/observe/services/dto/referential/PersonDtos.java @@ -44,38 +44,20 @@ public class PersonDtos extends AbstractPersonDtos { } public static Predicate<ReferentialReference<PersonDto>> newCaptainReferencePredicate() { - return new Predicate<ReferentialReference<PersonDto>>() { - - @Override - public boolean test(ReferentialReference<PersonDto> input) { - return input.getPropertyNames().contains(PersonDto.PROPERTY_CAPTAIN) - && Objects.equals(true, input.getPropertyValue(PersonDto.PROPERTY_CAPTAIN)); - } - }; + return input -> input.getPropertyNames().contains(PersonDto.PROPERTY_CAPTAIN) + && Objects.equals(true, input.getPropertyValue(PersonDto.PROPERTY_CAPTAIN)); } public static Predicate<ReferentialReference<PersonDto>> newDataEntryOperatorReferencePredicate() { - return new Predicate<ReferentialReference<PersonDto>>() { - - @Override - public boolean test(ReferentialReference<PersonDto> input) { - return input.getPropertyNames().contains(PersonDto.PROPERTY_DATA_ENTRY_OPERATOR) - && Objects.equals(true, input.getPropertyValue(PersonDto.PROPERTY_DATA_ENTRY_OPERATOR)); - } - }; + return input -> input.getPropertyNames().contains(PersonDto.PROPERTY_DATA_ENTRY_OPERATOR) + && Objects.equals(true, input.getPropertyValue(PersonDto.PROPERTY_DATA_ENTRY_OPERATOR)); } public static Predicate<ReferentialReference<PersonDto>> newObserverReferencePredicate() { - return new Predicate<ReferentialReference<PersonDto>>() { - - @Override - public boolean test(ReferentialReference<PersonDto> input) { - return input.getPropertyNames().contains(PersonDto.PROPERTY_OBSERVER) - && Objects.equals(true, input.getPropertyValue(PersonDto.PROPERTY_OBSERVER)); - } - }; + return input -> input.getPropertyNames().contains(PersonDto.PROPERTY_OBSERVER) + && Objects.equals(true, input.getPropertyValue(PersonDto.PROPERTY_OBSERVER)); } diff --git a/observe-services-model/src/main/java/fr/ird/observe/services/dto/referential/ReferentialDtos.java b/observe-services-model/src/main/java/fr/ird/observe/services/dto/referential/ReferentialDtos.java index 29c86f8..4b8b631 100644 --- a/observe-services-model/src/main/java/fr/ird/observe/services/dto/referential/ReferentialDtos.java +++ b/observe-services-model/src/main/java/fr/ird/observe/services/dto/referential/ReferentialDtos.java @@ -87,7 +87,7 @@ public class ReferentialDtos extends AbstractReferentialDtos { GearCaracteristicDto.class, GearDto.class); - public static final ImmutableSet<Class<? extends ReferentialDto>> REFERENCE_SEINE_DTOS = ImmutableSet.<Class<? extends ReferentialDto>>of( + public static final ImmutableSet<Class<? extends ReferentialDto>> REFERENCE_SEINE_DTOS = ImmutableSet.of( VesselActivitySeineDto.class, SurroundingActivityDto.class, ReasonForNullSetDto.class, diff --git a/observe-services-model/src/main/java/fr/ird/observe/services/dto/referential/ReferentialReferences.java b/observe-services-model/src/main/java/fr/ird/observe/services/dto/referential/ReferentialReferences.java index 25935c1..75a38b8 100644 --- a/observe-services-model/src/main/java/fr/ird/observe/services/dto/referential/ReferentialReferences.java +++ b/observe-services-model/src/main/java/fr/ird/observe/services/dto/referential/ReferentialReferences.java @@ -22,12 +22,13 @@ package fr.ird.observe.services.dto.referential; * #L% */ -import com.google.common.base.Function; -import com.google.common.base.Predicate; +import fr.ird.observe.services.dto.AbstractReference; import java.util.Collection; import java.util.List; import java.util.Set; +import java.util.function.Function; +import java.util.function.Predicate; import java.util.stream.Collectors; /** @@ -37,21 +38,9 @@ import java.util.stream.Collectors; */ public class ReferentialReferences { - protected static final Function<ReferentialReference, String> ID_FUNCTION = new Function<ReferentialReference, String>() { + protected static final Function<ReferentialReference, String> ID_FUNCTION = AbstractReference::getId; - @Override - public String apply(ReferentialReference input) { - return input.getId(); - } - }; - - protected static final Predicate<ReferentialReference> IS_ENABLE_PREDICATE = new Predicate<ReferentialReference>() { - - @Override - public boolean apply(ReferentialReference input) { - return input.isEnabled(); - } - }; + protected static final Predicate<ReferentialReference> IS_ENABLE_PREDICATE = ReferentialReference::isEnabled; public static <D extends ReferentialDto> List<ReferentialReference<D>> filterEnabled(Collection<ReferentialReference<D>> references) { diff --git a/observe-services-rest/src/main/java/fr/ird/observe/services/http/ObserveRequestBuilder.java b/observe-services-rest/src/main/java/fr/ird/observe/services/http/ObserveRequestBuilder.java index 3f0c124..73888f4 100644 --- a/observe-services-rest/src/main/java/fr/ird/observe/services/http/ObserveRequestBuilder.java +++ b/observe-services-rest/src/main/java/fr/ird/observe/services/http/ObserveRequestBuilder.java @@ -103,7 +103,7 @@ public class ObserveRequestBuilder { return this; } - public ObserveRequestBuilder addParameter(String parameterName, Object toJson) throws IOException { + public ObserveRequestBuilder addParameter(String parameterName, Object toJson) { String json = gson.toJson(toJson); return addParameter(parameterName, json); } diff --git a/observe-services-rest/src/main/java/fr/ird/observe/services/http/ObserveResponse.java b/observe-services-rest/src/main/java/fr/ird/observe/services/http/ObserveResponse.java index 730d7aa..419f966 100644 --- a/observe-services-rest/src/main/java/fr/ird/observe/services/http/ObserveResponse.java +++ b/observe-services-rest/src/main/java/fr/ird/observe/services/http/ObserveResponse.java @@ -26,8 +26,6 @@ import org.apache.commons.logging.Log; import org.apache.commons.logging.LogFactory; import org.apache.http.Header; -import java.io.IOException; - /** * @author Arnaud Thimel - thimel@codelutin.com */ @@ -44,7 +42,7 @@ public class ObserveResponse<T> { protected final T resultObject; - protected ObserveResponse(int statusCode, Header[] headers, String responseAsString, T resultObject) throws IOException { + protected ObserveResponse(int statusCode, Header[] headers, String responseAsString, T resultObject) { this.statusCode = statusCode; this.headers = headers; this.resultObject = resultObject; @@ -82,7 +80,7 @@ public class ObserveResponse<T> { throw new IllegalArgumentException(key + " key is not found in header"); } - public String getResponse() throws IOException { + public String getResponse() { return responseAsString; } diff --git a/observe-services-rest/src/main/java/fr/ird/observe/services/http/ObserveResponseBuilder.java b/observe-services-rest/src/main/java/fr/ird/observe/services/http/ObserveResponseBuilder.java index fe1d17e..229d726 100644 --- a/observe-services-rest/src/main/java/fr/ird/observe/services/http/ObserveResponseBuilder.java +++ b/observe-services-rest/src/main/java/fr/ird/observe/services/http/ObserveResponseBuilder.java @@ -361,7 +361,7 @@ public class ObserveResponseBuilder { } } - protected <M extends HttpEntityEnclosingRequestBase> void addParameters(M method, String contentType, List<? extends NameValuePair> parameters) throws UnsupportedEncodingException { + protected <M extends HttpEntityEnclosingRequestBase> void addParameters(M method, String contentType, List<? extends NameValuePair> parameters) { UrlEncodedFormEntity encodedFormEntity = new UrlEncodedFormEntity(parameters, Charsets.UTF_8); if (StringUtils.isNotBlank(contentType)) { encodedFormEntity.setContentType(contentType); @@ -379,7 +379,7 @@ public class ObserveResponseBuilder { } } - public <T> T convertJson(String json, Type type) throws IOException { + public <T> T convertJson(String json, Type type) { Preconditions.checkNotNull(json); Preconditions.checkNotNull(gson); diff --git a/observe-services-rest/src/test/java/fr/ird/observe/services/service/AbstractServiceRestTest.java b/observe-services-rest/src/test/java/fr/ird/observe/services/service/AbstractServiceRestTest.java index 85aa99d..c43c2ab 100644 --- a/observe-services-rest/src/test/java/fr/ird/observe/services/service/AbstractServiceRestTest.java +++ b/observe-services-rest/src/test/java/fr/ird/observe/services/service/AbstractServiceRestTest.java @@ -66,7 +66,7 @@ public abstract class AbstractServiceRestTest { } @After - public void tearDown() throws Exception { + public void tearDown() { if (dataSourceConnection != null) { dataSourceService.close(); diff --git a/observe-services-rest/src/test/java/fr/ird/observe/services/service/ReferenceValuesSetServiceRestTest.java b/observe-services-rest/src/test/java/fr/ird/observe/services/service/ReferenceValuesSetServiceRestTest.java index dc5ab55..3453f17 100644 --- a/observe-services-rest/src/test/java/fr/ird/observe/services/service/ReferenceValuesSetServiceRestTest.java +++ b/observe-services-rest/src/test/java/fr/ird/observe/services/service/ReferenceValuesSetServiceRestTest.java @@ -36,8 +36,6 @@ import org.junit.ClassRule; import org.junit.Rule; import org.junit.Test; -import java.util.Date; - /** * Created on 13/11/15. * @@ -74,7 +72,7 @@ public class ReferenceValuesSetServiceRestTest { //FIXME ReferenceSetsRequest request = new ReferenceSetsRequest(); request.setRequestName(requestName); - request.setLastUpdateDates(ImmutableMap.<Class<?>, Date>of()); + request.setLastUpdateDates(ImmutableMap.of()); ImmutableSet<ReferentialReferenceSet<?>> referenceSetResult = service.getReferentialReferenceSets(request); Assert.assertNotNull(referenceSetResult); diff --git a/observe-services-rest/src/test/java/fr/ird/observe/services/service/actions/report/AbstractReportServiceRestTest.java b/observe-services-rest/src/test/java/fr/ird/observe/services/service/actions/report/AbstractReportServiceRestTest.java index 3fc0424..052158a 100644 --- a/observe-services-rest/src/test/java/fr/ird/observe/services/service/actions/report/AbstractReportServiceRestTest.java +++ b/observe-services-rest/src/test/java/fr/ird/observe/services/service/actions/report/AbstractReportServiceRestTest.java @@ -37,9 +37,7 @@ import org.junit.Test; import java.io.IOException; import java.net.URL; -import java.util.HashMap; import java.util.List; -import java.util.Map; /** * Classe abstraite de test d'un report. @@ -102,9 +100,6 @@ public abstract class AbstractReportServiceRestTest extends AbstractServiceRestT // creation de l'executeur de report report = service.populateVariables(report, TRIP_SEINE_ID_1); - // les variables a utiliser (par defaut, pas de variable) - Map<String, Object> variables = new HashMap<>(); - // preparation des variables prepareVariables(); diff --git a/observe-services-rest/src/test/java/fr/ird/observe/services/service/actions/report/ReportAccessoryCatchRestTest.java b/observe-services-rest/src/test/java/fr/ird/observe/services/service/actions/report/ReportAccessoryCatchRestTest.java index 971a311..f384c3e 100644 --- a/observe-services-rest/src/test/java/fr/ird/observe/services/service/actions/report/ReportAccessoryCatchRestTest.java +++ b/observe-services-rest/src/test/java/fr/ird/observe/services/service/actions/report/ReportAccessoryCatchRestTest.java @@ -148,7 +148,7 @@ public class ReportAccessoryCatchRestTest extends AbstractReportServiceRestTest assertResultRow(result, row++, "[FAO]SPL [sc]Sphyrna lewini [fr]Requin marteau halicorne", "-", "-"); assertResultRow(result, row++, "[FAO]SPK [sc]Sphyrna mokarran [fr]Grand requin marteau", "-", "-"); assertResultRow(result, row++, "[FAO]SPZ [sc]Sphyrna zygaena [fr]Requin marteau commun", "-", "-"); - assertResultRow(result, row++, "[FAO]TOD [sc]Torpedinidae [fr]Torpilles, raies électriq. nca ", "-", "-"); + assertResultRow(result, row, "[FAO]TOD [sc]Torpedinidae [fr]Torpilles, raies électriq. nca ", "-", "-"); } diff --git a/observe-services-rest/src/test/java/fr/ird/observe/services/service/actions/validate/ValidateServiceRestTest.java b/observe-services-rest/src/test/java/fr/ird/observe/services/service/actions/validate/ValidateServiceRestTest.java index 542ba18..660f484 100644 --- a/observe-services-rest/src/test/java/fr/ird/observe/services/service/actions/validate/ValidateServiceRestTest.java +++ b/observe-services-rest/src/test/java/fr/ird/observe/services/service/actions/validate/ValidateServiceRestTest.java @@ -25,7 +25,74 @@ package fr.ird.observe.services.service.actions.validate; import com.google.common.collect.ImmutableMap; import com.google.common.collect.ImmutableSet; import fr.ird.observe.services.dto.IdDto; +import fr.ird.observe.services.dto.referential.CountryDto; +import fr.ird.observe.services.dto.referential.FpaZoneDto; +import fr.ird.observe.services.dto.referential.GearCaracteristicDto; +import fr.ird.observe.services.dto.referential.GearCaracteristicTypeDto; +import fr.ird.observe.services.dto.referential.GearDto; +import fr.ird.observe.services.dto.referential.HarbourDto; +import fr.ird.observe.services.dto.referential.LengthWeightParameterDto; +import fr.ird.observe.services.dto.referential.OceanDto; +import fr.ird.observe.services.dto.referential.OrganismDto; +import fr.ird.observe.services.dto.referential.PersonDto; +import fr.ird.observe.services.dto.referential.ProgramDto; import fr.ird.observe.services.dto.referential.ReferentialDto; +import fr.ird.observe.services.dto.referential.SexDto; +import fr.ird.observe.services.dto.referential.SpeciesDto; +import fr.ird.observe.services.dto.referential.SpeciesGroupDto; +import fr.ird.observe.services.dto.referential.SpeciesListDto; +import fr.ird.observe.services.dto.referential.VesselDto; +import fr.ird.observe.services.dto.referential.VesselSizeCategoryDto; +import fr.ird.observe.services.dto.referential.VesselTypeDto; +import fr.ird.observe.services.dto.referential.longline.BaitHaulingStatusDto; +import fr.ird.observe.services.dto.referential.longline.BaitSettingStatusDto; +import fr.ird.observe.services.dto.referential.longline.BaitTypeDto; +import fr.ird.observe.services.dto.referential.longline.CatchFateLonglineDto; +import fr.ird.observe.services.dto.referential.longline.EncounterTypeDto; +import fr.ird.observe.services.dto.referential.longline.HealthnessDto; +import fr.ird.observe.services.dto.referential.longline.HookPositionDto; +import fr.ird.observe.services.dto.referential.longline.HookSizeDto; +import fr.ird.observe.services.dto.referential.longline.HookTypeDto; +import fr.ird.observe.services.dto.referential.longline.ItemHorizontalPositionDto; +import fr.ird.observe.services.dto.referential.longline.ItemVerticalPositionDto; +import fr.ird.observe.services.dto.referential.longline.LightsticksColorDto; +import fr.ird.observe.services.dto.referential.longline.LightsticksTypeDto; +import fr.ird.observe.services.dto.referential.longline.LineTypeDto; +import fr.ird.observe.services.dto.referential.longline.MaturityStatusDto; +import fr.ird.observe.services.dto.referential.longline.MitigationTypeDto; +import fr.ird.observe.services.dto.referential.longline.SensorBrandDto; +import fr.ird.observe.services.dto.referential.longline.SensorDataFormatDto; +import fr.ird.observe.services.dto.referential.longline.SensorTypeDto; +import fr.ird.observe.services.dto.referential.longline.SettingShapeDto; +import fr.ird.observe.services.dto.referential.longline.SizeMeasureTypeDto; +import fr.ird.observe.services.dto.referential.longline.StomacFullnessDto; +import fr.ird.observe.services.dto.referential.longline.TripTypeDto; +import fr.ird.observe.services.dto.referential.longline.VesselActivityLonglineDto; +import fr.ird.observe.services.dto.referential.longline.WeightMeasureTypeDto; +import fr.ird.observe.services.dto.referential.seine.DetectionModeDto; +import fr.ird.observe.services.dto.referential.seine.ObjectFateDto; +import fr.ird.observe.services.dto.referential.seine.ObjectOperationDto; +import fr.ird.observe.services.dto.referential.seine.ObjectTypeDto; +import fr.ird.observe.services.dto.referential.seine.ObservedSystemDto; +import fr.ird.observe.services.dto.referential.seine.ReasonForDiscardDto; +import fr.ird.observe.services.dto.referential.seine.ReasonForNoFishingDto; +import fr.ird.observe.services.dto.referential.seine.ReasonForNullSetDto; +import fr.ird.observe.services.dto.referential.seine.SpeciesFateDto; +import fr.ird.observe.services.dto.referential.seine.SpeciesStatusDto; +import fr.ird.observe.services.dto.referential.seine.SurroundingActivityDto; +import fr.ird.observe.services.dto.referential.seine.TransmittingBuoyOperationDto; +import fr.ird.observe.services.dto.referential.seine.TransmittingBuoyTypeDto; +import fr.ird.observe.services.dto.referential.seine.VesselActivitySeineDto; +import fr.ird.observe.services.dto.referential.seine.WeightCategoryDto; +import fr.ird.observe.services.dto.referential.seine.WindDto; +import fr.ird.observe.services.dto.seine.ActivitySeineDto; +import fr.ird.observe.services.dto.seine.FloatingObjectDto; +import fr.ird.observe.services.dto.seine.NonTargetCatchDto; +import fr.ird.observe.services.dto.seine.RouteDto; +import fr.ird.observe.services.dto.seine.SchoolEstimateDto; +import fr.ird.observe.services.dto.seine.SetSeineDto; +import fr.ird.observe.services.dto.seine.TransmittingBuoyDto; +import fr.ird.observe.services.dto.seine.TripSeineDto; import fr.ird.observe.services.service.AbstractServiceRestTest; import org.junit.Assert; import org.junit.Test; @@ -37,24 +104,24 @@ import org.nuiton.validator.NuitonValidatorScope; public class ValidateServiceRestTest extends AbstractServiceRestTest { protected static final ImmutableSet<Class<? extends ReferentialDto>> REFERENTIAL_DTO_TYPES = ImmutableSet.of( - fr.ird.observe.services.dto.referential.CountryDto.class, - fr.ird.observe.services.dto.referential.FpaZoneDto.class, - fr.ird.observe.services.dto.referential.GearCaracteristicDto.class, - fr.ird.observe.services.dto.referential.GearCaracteristicTypeDto.class, - fr.ird.observe.services.dto.referential.GearDto.class, - fr.ird.observe.services.dto.referential.HarbourDto.class, - fr.ird.observe.services.dto.referential.LengthWeightParameterDto.class, - fr.ird.observe.services.dto.referential.OceanDto.class, - fr.ird.observe.services.dto.referential.OrganismDto.class, - fr.ird.observe.services.dto.referential.PersonDto.class, - fr.ird.observe.services.dto.referential.ProgramDto.class, - fr.ird.observe.services.dto.referential.SexDto.class, - fr.ird.observe.services.dto.referential.SpeciesDto.class, - fr.ird.observe.services.dto.referential.SpeciesGroupDto.class, - fr.ird.observe.services.dto.referential.SpeciesListDto.class, - fr.ird.observe.services.dto.referential.VesselDto.class, - fr.ird.observe.services.dto.referential.VesselSizeCategoryDto.class, - fr.ird.observe.services.dto.referential.VesselTypeDto.class + CountryDto.class, + FpaZoneDto.class, + GearCaracteristicDto.class, + GearCaracteristicTypeDto.class, + GearDto.class, + HarbourDto.class, + LengthWeightParameterDto.class, + OceanDto.class, + OrganismDto.class, + PersonDto.class, + ProgramDto.class, + SexDto.class, + SpeciesDto.class, + SpeciesGroupDto.class, + SpeciesListDto.class, + VesselDto.class, + VesselSizeCategoryDto.class, + VesselTypeDto.class ); protected ValidateService service; @@ -82,67 +149,67 @@ public class ValidateServiceRestTest extends AbstractServiceRestTest { Assert.assertNotNull(resultByType); Assert.assertEquals(59, resultByType.size()); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.CountryDto.class, 53); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.FpaZoneDto.class, 41); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.GearCaracteristicDto.class, 22); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.GearCaracteristicTypeDto.class, 6); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.GearDto.class, 26); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.HarbourDto.class, 74); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.LengthWeightParameterDto.class, 352); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.OceanDto.class, 3); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.OrganismDto.class, 8); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.PersonDto.class, 390); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.ProgramDto.class, 27); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.SexDto.class, 5); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.SpeciesDto.class, 275); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.SpeciesGroupDto.class, 8); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.SpeciesListDto.class, 5); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.VesselDto.class, 977); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.VesselSizeCategoryDto.class, 13); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.VesselTypeDto.class, 14); - - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.longline.BaitHaulingStatusDto.class, 5); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.longline.BaitSettingStatusDto.class, 5); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.longline.BaitTypeDto.class, 16); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.longline.CatchFateLonglineDto.class, 5); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.longline.EncounterTypeDto.class, 12); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.longline.HealthnessDto.class, 6); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.longline.HookPositionDto.class, 13); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.longline.HookSizeDto.class, 22); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.longline.HookTypeDto.class, 13); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.longline.ItemHorizontalPositionDto.class, 3); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.longline.ItemVerticalPositionDto.class, 3); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.longline.LightsticksColorDto.class, 7); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.longline.LightsticksTypeDto.class, 2); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.longline.LineTypeDto.class, 8); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.longline.MaturityStatusDto.class, 12); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.longline.MitigationTypeDto.class, 15); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.longline.SensorBrandDto.class, 4); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.longline.SensorDataFormatDto.class, 2); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.longline.SensorTypeDto.class, 4); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.longline.SettingShapeDto.class, 6); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.longline.SizeMeasureTypeDto.class, 17); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.longline.StomacFullnessDto.class, 7); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.longline.TripTypeDto.class, 3); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.longline.VesselActivityLonglineDto.class, 5); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.longline.WeightMeasureTypeDto.class, 3); - - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.seine.DetectionModeDto.class, 10); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.seine.ObjectFateDto.class, 9); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.seine.ObjectOperationDto.class, 4); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.seine.ObjectTypeDto.class, 23); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.seine.ObservedSystemDto.class, 21); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.seine.ReasonForDiscardDto.class, 5); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.seine.ReasonForNoFishingDto.class, 13); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.seine.ReasonForNullSetDto.class, 10); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.seine.SpeciesFateDto.class, 9); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.seine.SpeciesStatusDto.class, 3); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.seine.SurroundingActivityDto.class, 8); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.seine.TransmittingBuoyOperationDto.class, 3); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.seine.TransmittingBuoyTypeDto.class, 12); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.seine.VesselActivitySeineDto.class, 23); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.seine.WeightCategoryDto.class, 101); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.seine.WindDto.class, 13); + assertValidateResultForReferentialDtoType(resultByType, CountryDto.class, 53); + assertValidateResultForReferentialDtoType(resultByType, FpaZoneDto.class, 41); + assertValidateResultForReferentialDtoType(resultByType, GearCaracteristicDto.class, 22); + assertValidateResultForReferentialDtoType(resultByType, GearCaracteristicTypeDto.class, 6); + assertValidateResultForReferentialDtoType(resultByType, GearDto.class, 26); + assertValidateResultForReferentialDtoType(resultByType, HarbourDto.class, 74); + assertValidateResultForReferentialDtoType(resultByType, LengthWeightParameterDto.class, 352); + assertValidateResultForReferentialDtoType(resultByType, OceanDto.class, 3); + assertValidateResultForReferentialDtoType(resultByType, OrganismDto.class, 8); + assertValidateResultForReferentialDtoType(resultByType, PersonDto.class, 390); + assertValidateResultForReferentialDtoType(resultByType, ProgramDto.class, 27); + assertValidateResultForReferentialDtoType(resultByType, SexDto.class, 5); + assertValidateResultForReferentialDtoType(resultByType, SpeciesDto.class, 275); + assertValidateResultForReferentialDtoType(resultByType, SpeciesGroupDto.class, 8); + assertValidateResultForReferentialDtoType(resultByType, SpeciesListDto.class, 5); + assertValidateResultForReferentialDtoType(resultByType, VesselDto.class, 977); + assertValidateResultForReferentialDtoType(resultByType, VesselSizeCategoryDto.class, 13); + assertValidateResultForReferentialDtoType(resultByType, VesselTypeDto.class, 14); + + assertValidateResultForReferentialDtoType(resultByType, BaitHaulingStatusDto.class, 5); + assertValidateResultForReferentialDtoType(resultByType, BaitSettingStatusDto.class, 5); + assertValidateResultForReferentialDtoType(resultByType, BaitTypeDto.class, 16); + assertValidateResultForReferentialDtoType(resultByType, CatchFateLonglineDto.class, 5); + assertValidateResultForReferentialDtoType(resultByType, EncounterTypeDto.class, 12); + assertValidateResultForReferentialDtoType(resultByType, HealthnessDto.class, 6); + assertValidateResultForReferentialDtoType(resultByType, HookPositionDto.class, 13); + assertValidateResultForReferentialDtoType(resultByType, HookSizeDto.class, 22); + assertValidateResultForReferentialDtoType(resultByType, HookTypeDto.class, 13); + assertValidateResultForReferentialDtoType(resultByType, ItemHorizontalPositionDto.class, 3); + assertValidateResultForReferentialDtoType(resultByType, ItemVerticalPositionDto.class, 3); + assertValidateResultForReferentialDtoType(resultByType, LightsticksColorDto.class, 7); + assertValidateResultForReferentialDtoType(resultByType, LightsticksTypeDto.class, 2); + assertValidateResultForReferentialDtoType(resultByType, LineTypeDto.class, 8); + assertValidateResultForReferentialDtoType(resultByType, MaturityStatusDto.class, 12); + assertValidateResultForReferentialDtoType(resultByType, MitigationTypeDto.class, 15); + assertValidateResultForReferentialDtoType(resultByType, SensorBrandDto.class, 4); + assertValidateResultForReferentialDtoType(resultByType, SensorDataFormatDto.class, 2); + assertValidateResultForReferentialDtoType(resultByType, SensorTypeDto.class, 4); + assertValidateResultForReferentialDtoType(resultByType, SettingShapeDto.class, 6); + assertValidateResultForReferentialDtoType(resultByType, SizeMeasureTypeDto.class, 17); + assertValidateResultForReferentialDtoType(resultByType, StomacFullnessDto.class, 7); + assertValidateResultForReferentialDtoType(resultByType, TripTypeDto.class, 3); + assertValidateResultForReferentialDtoType(resultByType, VesselActivityLonglineDto.class, 5); + assertValidateResultForReferentialDtoType(resultByType, WeightMeasureTypeDto.class, 3); + + assertValidateResultForReferentialDtoType(resultByType, DetectionModeDto.class, 10); + assertValidateResultForReferentialDtoType(resultByType, ObjectFateDto.class, 9); + assertValidateResultForReferentialDtoType(resultByType, ObjectOperationDto.class, 4); + assertValidateResultForReferentialDtoType(resultByType, ObjectTypeDto.class, 23); + assertValidateResultForReferentialDtoType(resultByType, ObservedSystemDto.class, 21); + assertValidateResultForReferentialDtoType(resultByType, ReasonForDiscardDto.class, 5); + assertValidateResultForReferentialDtoType(resultByType, ReasonForNoFishingDto.class, 13); + assertValidateResultForReferentialDtoType(resultByType, ReasonForNullSetDto.class, 10); + assertValidateResultForReferentialDtoType(resultByType, SpeciesFateDto.class, 9); + assertValidateResultForReferentialDtoType(resultByType, SpeciesStatusDto.class, 3); + assertValidateResultForReferentialDtoType(resultByType, SurroundingActivityDto.class, 8); + assertValidateResultForReferentialDtoType(resultByType, TransmittingBuoyOperationDto.class, 3); + assertValidateResultForReferentialDtoType(resultByType, TransmittingBuoyTypeDto.class, 12); + assertValidateResultForReferentialDtoType(resultByType, VesselActivitySeineDto.class, 23); + assertValidateResultForReferentialDtoType(resultByType, WeightCategoryDto.class, 101); + assertValidateResultForReferentialDtoType(resultByType, WindDto.class, 13); } @@ -161,11 +228,11 @@ public class ValidateServiceRestTest extends AbstractServiceRestTest { Assert.assertNotNull(resultByType); Assert.assertEquals(5, resultByType.size()); - assertValidateResultForDtoType(resultByType, fr.ird.observe.services.dto.seine.TripSeineDto.class, 2); - assertValidateResultForDtoType(resultByType, fr.ird.observe.services.dto.seine.RouteDto.class, 80); - assertValidateResultForDtoType(resultByType, fr.ird.observe.services.dto.seine.ActivitySeineDto.class, 1519); - assertValidateResultForDtoType(resultByType, fr.ird.observe.services.dto.seine.FloatingObjectDto.class, 99); - assertValidateResultForDtoType(resultByType, fr.ird.observe.services.dto.seine.SetSeineDto.class, 77); + assertValidateResultForDtoType(resultByType, TripSeineDto.class, 2); + assertValidateResultForDtoType(resultByType, RouteDto.class, 80); + assertValidateResultForDtoType(resultByType, ActivitySeineDto.class, 1519); + assertValidateResultForDtoType(resultByType, FloatingObjectDto.class, 99); + assertValidateResultForDtoType(resultByType, SetSeineDto.class, 77); } @@ -185,14 +252,14 @@ public class ValidateServiceRestTest extends AbstractServiceRestTest { Assert.assertNotNull(resultByType); Assert.assertEquals(8, resultByType.size()); - assertValidateResultForDtoType(resultByType, fr.ird.observe.services.dto.seine.TripSeineDto.class, 2); - assertValidateResultForDtoType(resultByType, fr.ird.observe.services.dto.seine.RouteDto.class, 80); - assertValidateResultForDtoType(resultByType, fr.ird.observe.services.dto.seine.ActivitySeineDto.class, 1519); - assertValidateResultForDtoType(resultByType, fr.ird.observe.services.dto.seine.FloatingObjectDto.class, 99); - assertValidateResultForDtoType(resultByType, fr.ird.observe.services.dto.seine.TransmittingBuoyDto.class, 42); - assertValidateResultForDtoType(resultByType, fr.ird.observe.services.dto.seine.SetSeineDto.class, 77); - assertValidateResultForDtoType(resultByType, fr.ird.observe.services.dto.seine.NonTargetCatchDto.class, 3); - assertValidateResultForDtoType(resultByType, fr.ird.observe.services.dto.seine.SchoolEstimateDto.class, 27); + assertValidateResultForDtoType(resultByType, TripSeineDto.class, 2); + assertValidateResultForDtoType(resultByType, RouteDto.class, 80); + assertValidateResultForDtoType(resultByType, ActivitySeineDto.class, 1519); + assertValidateResultForDtoType(resultByType, FloatingObjectDto.class, 99); + assertValidateResultForDtoType(resultByType, TransmittingBuoyDto.class, 42); + assertValidateResultForDtoType(resultByType, SetSeineDto.class, 77); + assertValidateResultForDtoType(resultByType, NonTargetCatchDto.class, 3); + assertValidateResultForDtoType(resultByType, SchoolEstimateDto.class, 27); } diff --git a/observe-services-topia-validation/src/main/java/fr/ird/observe/services/topia/validation/validators/AbstractSpeciesFieldValidator.java b/observe-services-topia-validation/src/main/java/fr/ird/observe/services/topia/validation/validators/AbstractSpeciesFieldValidator.java index 350652d..a827a66 100644 --- a/observe-services-topia-validation/src/main/java/fr/ird/observe/services/topia/validation/validators/AbstractSpeciesFieldValidator.java +++ b/observe-services-topia-validation/src/main/java/fr/ird/observe/services/topia/validation/validators/AbstractSpeciesFieldValidator.java @@ -63,9 +63,9 @@ public abstract class AbstractSpeciesFieldValidator extends FieldValidatorSuppor public static class Bound { - private Float min; + private final Float min; - private Float max; + private final Float max; Bound(Float min, Float max) { this.min = min; diff --git a/observe-services-topia-validation/src/main/resources/i18n/observe-services-topia-validation_en_GB.properties b/observe-services-topia-validation/src/main/resources/i18n/observe-services-topia-validation_en_GB.properties index e2fccda..1419895 100644 --- a/observe-services-topia-validation/src/main/resources/i18n/observe-services-topia-validation_en_GB.properties +++ b/observe-services-topia-validation/src/main/resources/i18n/observe-services-topia-validation_en_GB.properties @@ -320,6 +320,7 @@ validator.service.targetCatch.required.weight= validator.service.targetCatch.required.weightCategory= validator.service.targetCatch.required.well= validator.service.targetCatch.uniqueKey= +validator.service.targetDiscarded.bound.weight= validator.service.targetDiscarded.comment.tobig= validator.service.targetDiscarded.desactivated.reasonForDiscard= validator.service.targetDiscarded.desactivated.species= @@ -399,4 +400,3 @@ validator.service.vesselSizeCategory.required.capacityLabel= validator.service.vesselSizeCategory.required.gaugeLabel= validator.service.wind.required.speedRange= validator.service.wind.required.waveHeight= -validator.service.targetDiscarded.bound.weight= diff --git a/observe-services-topia-validation/src/main/resources/i18n/observe-services-topia-validation_es_ES.properties b/observe-services-topia-validation/src/main/resources/i18n/observe-services-topia-validation_es_ES.properties index fc25bdf..40d4b91 100644 --- a/observe-services-topia-validation/src/main/resources/i18n/observe-services-topia-validation_es_ES.properties +++ b/observe-services-topia-validation/src/main/resources/i18n/observe-services-topia-validation_es_ES.properties @@ -320,6 +320,7 @@ validator.service.targetCatch.required.weight=No se ha introducido el peso. validator.service.targetCatch.required.weightCategory=Se debe seleccionar una categoría de peso. validator.service.targetCatch.required.well=No se ha introducido la cuba. validator.service.targetCatch.uniqueKey=El par (categoría de peso - cuba) debe ser única. +validator.service.targetDiscarded.bound.weight= validator.service.targetDiscarded.comment.tobig=La longitud del campo de comentarios está limitada a 1024 caracteres. validator.service.targetDiscarded.desactivated.reasonForDiscard=La causa del descarte seleccionada está desactivada. validator.service.targetDiscarded.desactivated.species=La especie seleccionada está desactivada. @@ -399,4 +400,3 @@ validator.service.vesselSizeCategory.required.capacityLabel=La etiqueta «Capaci validator.service.vesselSizeCategory.required.gaugeLabel=La etiqueta «Capacidad00BB no se ha establecido. validator.service.wind.required.speedRange=Etiqueta para la velocidad del viento no especificada. validator.service.wind.required.waveHeight=Etiqueta descriptiva para la altura media de las olas no especificada. -validator.service.targetDiscarded.bound.weight= diff --git a/observe-services-topia-validation/src/main/resources/i18n/observe-services-topia-validation_fr_FR.properties b/observe-services-topia-validation/src/main/resources/i18n/observe-services-topia-validation_fr_FR.properties index cbc3b01..f326125 100644 --- a/observe-services-topia-validation/src/main/resources/i18n/observe-services-topia-validation_fr_FR.properties +++ b/observe-services-topia-validation/src/main/resources/i18n/observe-services-topia-validation_fr_FR.properties @@ -320,6 +320,7 @@ validator.service.targetCatch.required.weight=Le poids n'est pas renseigné. validator.service.targetCatch.required.weightCategory=La sélection d'une catégorie poids est obligatoire. validator.service.targetCatch.required.well=La cuve n'est pas renseignée. validator.service.targetCatch.uniqueKey=Le couple (catégorie poids - well) doit être unique. +validator.service.targetDiscarded.bound.weight= validator.service.targetDiscarded.comment.tobig=La taille du commentaire est limitée à 1024 caractères. validator.service.targetDiscarded.desactivated.reasonForDiscard=La raison rejet sélectionnée est désactivée. validator.service.targetDiscarded.desactivated.species=L'espèce sélectionnée est désactivée. @@ -399,4 +400,3 @@ validator.service.vesselSizeCategory.required.capacityLabel=Le libellé Capacit validator.service.vesselSizeCategory.required.gaugeLabel=Le libellé Jauge n'est pas renseigné. validator.service.wind.required.speedRange=Libellé vitesse vent non renseigné. validator.service.wind.required.waveHeight=Libellé descriptif hauteur moyenne vagues non renseigné. -validator.service.targetDiscarded.bound.weight= diff --git a/observe-services-topia-validation/src/test/java/fr/ird/observe/services/topia/validation/BeanValidatorDetectorTest.java b/observe-services-topia-validation/src/test/java/fr/ird/observe/services/topia/validation/BeanValidatorDetectorTest.java index 4bc32cd..1dcba07 100644 --- a/observe-services-topia-validation/src/test/java/fr/ird/observe/services/topia/validation/BeanValidatorDetectorTest.java +++ b/observe-services-topia-validation/src/test/java/fr/ird/observe/services/topia/validation/BeanValidatorDetectorTest.java @@ -141,7 +141,7 @@ public class BeanValidatorDetectorTest extends AbstractValidatorDetectorTest { static Class<?>[] ALL_TYPES; @BeforeClass - public static void setUpClass() throws Exception { + public static void setUpClass() { ALL_TYPES = ObserveEntityEnum.getContractClasses(); } diff --git a/observe-services-topia/src/main/java/fr/ird/observe/services/ObserveSecurityHelper.java b/observe-services-topia/src/main/java/fr/ird/observe/services/ObserveSecurityHelper.java index 061a147..46c7461 100644 --- a/observe-services-topia/src/main/java/fr/ird/observe/services/ObserveSecurityHelper.java +++ b/observe-services-topia/src/main/java/fr/ird/observe/services/ObserveSecurityHelper.java @@ -22,7 +22,6 @@ package fr.ird.observe.services; * #L% */ -import com.google.common.base.Function; import com.google.common.collect.Iterables; import com.google.common.collect.Sets; import fr.ird.observe.entities.Entities; @@ -45,6 +44,7 @@ import java.util.HashSet; import java.util.LinkedHashSet; import java.util.List; import java.util.Set; +import java.util.function.Function; /** * FIXME Ca sert à quoi? @@ -100,12 +100,7 @@ public class ObserveSecurityHelper { OBSERVE_SEINE_SCHEMA_NAME, OBSERVE_LONGLINE_SCHEMA_NAME); - public static final Function<String, String> ESCAPE_STRING = new Function<String, String>() { - @Override - public String apply(String input) { - return "\"" + input + "\""; - } - }; + public static final Function<String, String> ESCAPE_STRING = input -> "\"" + input + "\""; protected final ObserveJdbcHelper jdbcHelper; @@ -236,7 +231,7 @@ public class ObserveSecurityHelper { } protected Set<String> escapedNames(Iterable<String> names) { - Iterable<String> transform = Iterables.transform(names, ESCAPE_STRING); + Iterable<String> transform = Iterables.transform(names, ESCAPE_STRING::apply); return Sets.newHashSet(transform); } diff --git a/observe-services-topia/src/main/java/fr/ird/observe/services/ObserveServiceTopia.java b/observe-services-topia/src/main/java/fr/ird/observe/services/ObserveServiceTopia.java index aeb28dd..3646444 100644 --- a/observe-services-topia/src/main/java/fr/ird/observe/services/ObserveServiceTopia.java +++ b/observe-services-topia/src/main/java/fr/ird/observe/services/ObserveServiceTopia.java @@ -22,7 +22,6 @@ package fr.ird.observe.services; * #L% */ -import com.google.common.base.Optional; import com.google.common.base.Preconditions; import com.google.common.collect.ImmutableSet; import fr.ird.observe.ObserveTopiaPersistenceContext; @@ -57,6 +56,7 @@ import java.sql.SQLException; import java.util.Date; import java.util.List; import java.util.Locale; +import java.util.Optional; /** * Support pour toute implantation d'un service ToPIA. @@ -138,7 +138,7 @@ public abstract class ObserveServiceTopia implements ObserveService { ObserveTopiaPersistenceContext persistenceContext = serviceContext.getTopiaPersistenceContext(); Date lastUpdateDate = persistenceContext.getLastUpdateDate(entityType); - Optional<Date> result = Optional.fromNullable(lastUpdateDate); + Optional<Date> result = Optional.ofNullable(lastUpdateDate); return result; } diff --git a/observe-services-topia/src/main/java/fr/ird/observe/services/ObserveTopiaApplicationContextFactory.java b/observe-services-topia/src/main/java/fr/ird/observe/services/ObserveTopiaApplicationContextFactory.java index 43631a4..f5f14c6 100644 --- a/observe-services-topia/src/main/java/fr/ird/observe/services/ObserveTopiaApplicationContextFactory.java +++ b/observe-services-topia/src/main/java/fr/ird/observe/services/ObserveTopiaApplicationContextFactory.java @@ -22,7 +22,6 @@ package fr.ird.observe.services; * #L% */ -import com.google.common.base.Optional; import com.google.common.base.Preconditions; import fr.ird.observe.ObserveTopiaApplicationContext; import fr.ird.observe.ObserveTopiaConfiguration; @@ -37,6 +36,7 @@ import org.nuiton.topia.persistence.TopiaApplicationContext; import java.util.HashMap; import java.util.LinkedHashSet; import java.util.Map; +import java.util.Optional; /** * Usine de contexte applicatif ToPIA. @@ -86,7 +86,7 @@ public class ObserveTopiaApplicationContextFactory { public static Optional<ObserveTopiaApplicationContext> getTopiaApplicationContextIfPresent(ObserveDataSourceConfigurationTopiaSupport dataSourceConfiguration) { ObserveTopiaApplicationContext topiaApplicationContext = TOPIA_APPLICATION_CONTEXT_CACHE.get(dataSourceConfiguration); - return Optional.fromNullable(topiaApplicationContext); + return Optional.ofNullable(topiaApplicationContext); } diff --git a/observe-services-topia/src/main/java/fr/ird/observe/services/binder/BinderEngine.java b/observe-services-topia/src/main/java/fr/ird/observe/services/binder/BinderEngine.java index 9838a62..3542685 100644 --- a/observe-services-topia/src/main/java/fr/ird/observe/services/binder/BinderEngine.java +++ b/observe-services-topia/src/main/java/fr/ird/observe/services/binder/BinderEngine.java @@ -47,17 +47,17 @@ public class BinderEngine implements ReferenceBinderEngine { private static final BinderEngine INSTANCE = new BinderEngine(); - protected ImmutableMap<Class<? extends ReferentialDto>, BinderSupport> referentialBinders; + protected final ImmutableMap<Class<? extends ReferentialDto>, BinderSupport> referentialBinders; - protected ImmutableMap<Class<? extends DataDto>, BinderSupport> dataBinders; + protected final ImmutableMap<Class<? extends DataDto>, BinderSupport> dataBinders; - protected ImmutableMap<Class<? extends ReferentialDto>, Class<? extends ObserveReferentialEntity>> referentialDtoToEntityTypes; + protected final ImmutableMap<Class<? extends ReferentialDto>, Class<? extends ObserveReferentialEntity>> referentialDtoToEntityTypes; - protected ImmutableMap<Class<? extends DataDto>, Class<? extends ObserveDataEntity>> dataDtoToEntityTypes; + protected final ImmutableMap<Class<? extends DataDto>, Class<? extends ObserveDataEntity>> dataDtoToEntityTypes; - protected ImmutableMap<Class<? extends ObserveReferentialEntity>, Class<? extends ReferentialDto>> referentialEntityToDtoTypes; + protected final ImmutableMap<Class<? extends ObserveReferentialEntity>, Class<? extends ReferentialDto>> referentialEntityToDtoTypes; - protected ImmutableMap<Class<? extends ObserveDataEntity>, Class<? extends DataDto>> dataEntityToDtoTypes; + protected final ImmutableMap<Class<? extends ObserveDataEntity>, Class<? extends DataDto>> dataEntityToDtoTypes; public static BinderEngine get() { return INSTANCE; diff --git a/observe-services-topia/src/main/java/fr/ird/observe/services/binder/BinderSupport.java b/observe-services-topia/src/main/java/fr/ird/observe/services/binder/BinderSupport.java index e402a8f..bfc49ce 100644 --- a/observe-services-topia/src/main/java/fr/ird/observe/services/binder/BinderSupport.java +++ b/observe-services-topia/src/main/java/fr/ird/observe/services/binder/BinderSupport.java @@ -64,101 +64,29 @@ import java.util.List; */ public abstract class BinderSupport<E extends TopiaEntity, D extends IdDto> { - protected static final Function<TripMapPointType, TripMapPointTypePersist> TRIP_MAP_POINT_TO_ENTITY = new Function<TripMapPointType, TripMapPointTypePersist>() { + protected static final Function<TripMapPointType, TripMapPointTypePersist> TRIP_MAP_POINT_TO_ENTITY = input -> TripMapPointTypePersist.valueOf(input.name()); - @Override - public TripMapPointTypePersist apply(TripMapPointType input) { - return TripMapPointTypePersist.valueOf(input.name()); - } - }; - - protected static final Function<GearType, GearTypePersist> GEAR_TYPE_TO_ENTITY = new Function<GearType, GearTypePersist>() { - - @Override - public GearTypePersist apply(GearType input) { - return GearTypePersist.valueOf(input.name()); - } - }; - - protected static final Function<ReferenceStatus, ReferenceStatusPersist> REFERENCE_STATUS_TO_ENTITY = new Function<ReferenceStatus, ReferenceStatusPersist>() { - - @Override - public ReferenceStatusPersist apply(ReferenceStatus input) { - return ReferenceStatusPersist.valueOf(input.name()); - } - }; - - protected static final Function<Ownership, OwnershipPersist> OWNERSHIP_TO_ENTITY = new Function<Ownership, OwnershipPersist>() { - - @Override - public OwnershipPersist apply(Ownership input) { - return input == null ? null : OwnershipPersist.valueOf(input.name()); - } - }; - - protected static final Function<SchoolType, SchoolTypePersist> SCHOOL_TYPE_TO_ENTITY = new Function<SchoolType, SchoolTypePersist>() { - - @Override - public SchoolTypePersist apply(SchoolType input) { - return input == null ? null : SchoolTypePersist.valueOf(input.name()); - } - }; + protected static final Function<GearType, GearTypePersist> GEAR_TYPE_TO_ENTITY = input -> GearTypePersist.valueOf(input.name()); - protected static final Function<TypeTransmittingBuoyOperation, TypeTransmittingBuoyOperationPersist> TYPE_TRANSMITTING_BUOY_OPERATION_TO_ENTITY = new Function<TypeTransmittingBuoyOperation, TypeTransmittingBuoyOperationPersist>() { + protected static final Function<ReferenceStatus, ReferenceStatusPersist> REFERENCE_STATUS_TO_ENTITY = input -> ReferenceStatusPersist.valueOf(input.name()); - @Override - public TypeTransmittingBuoyOperationPersist apply(TypeTransmittingBuoyOperation input) { - return input == null ? null : TypeTransmittingBuoyOperationPersist.valueOf(input.name()); - } - }; + protected static final Function<Ownership, OwnershipPersist> OWNERSHIP_TO_ENTITY = input -> input == null ? null : OwnershipPersist.valueOf(input.name()); - protected static final Function<NonTargetCatchComputedValueSource, NonTargetCatchComputedValueSourcePersist> NON_TARGET_CATCH_COMPUTED_VALUE_SOURCE_TO_ENTITY = new Function<NonTargetCatchComputedValueSource, NonTargetCatchComputedValueSourcePersist>() { + protected static final Function<SchoolType, SchoolTypePersist> SCHOOL_TYPE_TO_ENTITY = input -> input == null ? null : SchoolTypePersist.valueOf(input.name()); - @Override - public NonTargetCatchComputedValueSourcePersist apply(NonTargetCatchComputedValueSource input) { - return input == null ? null : NonTargetCatchComputedValueSourcePersist.valueOf(input.name()); - } - }; + protected static final Function<TypeTransmittingBuoyOperation, TypeTransmittingBuoyOperationPersist> TYPE_TRANSMITTING_BUOY_OPERATION_TO_ENTITY = input -> input == null ? null : TypeTransmittingBuoyOperationPersist.valueOf(input.name()); - protected static final Function<TripMapPointTypePersist, TripMapPointType> TRIP_MAP_POINT_TO_DTO = new Function<TripMapPointTypePersist, TripMapPointType>() { + protected static final Function<NonTargetCatchComputedValueSource, NonTargetCatchComputedValueSourcePersist> NON_TARGET_CATCH_COMPUTED_VALUE_SOURCE_TO_ENTITY = input -> input == null ? null : NonTargetCatchComputedValueSourcePersist.valueOf(input.name()); - @Override - public TripMapPointType apply(TripMapPointTypePersist input) { - return TripMapPointType.valueOf(input.name()); - } - }; + protected static final Function<TripMapPointTypePersist, TripMapPointType> TRIP_MAP_POINT_TO_DTO = input -> TripMapPointType.valueOf(input.name()); - protected static final Function<GearTypePersist, GearType> GEAR_TYPE_TO_DTO = new Function<GearTypePersist, GearType>() { + protected static final Function<GearTypePersist, GearType> GEAR_TYPE_TO_DTO = input -> input == null ? null : GearType.valueOf(input.name()); - @Override - public GearType apply(GearTypePersist input) { - return input == null ? null : GearType.valueOf(input.name()); - } - }; + protected static final Function<ReferenceStatusPersist, ReferenceStatus> REFERENCE_STATUS_TO_DTO = input -> input == null ? null : ReferenceStatus.valueOf(input.name()); - protected static final Function<ReferenceStatusPersist, ReferenceStatus> REFERENCE_STATUS_TO_DTO = new Function<ReferenceStatusPersist, ReferenceStatus>() { + protected static final Function<OwnershipPersist, Ownership> OWNERSHIP_TO_DTO = input -> input == null ? null : Ownership.valueOf(input.name()); - @Override - public ReferenceStatus apply(ReferenceStatusPersist input) { - return input == null ? null : ReferenceStatus.valueOf(input.name()); - } - }; - - protected static final Function<OwnershipPersist, Ownership> OWNERSHIP_TO_DTO = new Function<OwnershipPersist, Ownership>() { - - @Override - public Ownership apply(OwnershipPersist input) { - return input == null ? null : Ownership.valueOf(input.name()); - } - }; - - protected static final Function<SchoolTypePersist, SchoolType> SCHOOL_TYPE_TO_DTO = new Function<SchoolTypePersist, SchoolType>() { - - @Override - public SchoolType apply(SchoolTypePersist input) { - return input == null ? null : SchoolType.valueOf(input.name()); - } - }; + protected static final Function<SchoolTypePersist, SchoolType> SCHOOL_TYPE_TO_DTO = input -> input == null ? null : SchoolType.valueOf(input.name()); // protected static final Function<fr.ird.observe.entities.constants.seine.TypeTransmittingBuoyOperationPersist, fr.ird.observe.services.dto.constants.seine.TypeTransmittingBuoyOperationPersist> TRANSMITTING_BUOY_OPERATION_TO_DTO = new Function<fr.ird.observe.entities.constants.seine.TypeTransmittingBuoyOperationPersist, fr.ird.observe.services.dto.constants.seine.TypeTransmittingBuoyOperationPersist>() { // @@ -168,13 +96,7 @@ public abstract class BinderSupport<E extends TopiaEntity, D extends IdDto> { // } // }; - protected static final Function<NonTargetCatchComputedValueSourcePersist, NonTargetCatchComputedValueSource> NON_TARGET_CATCH_COMPUTED_VALUE_SOURCE_TO_DTO = new Function<NonTargetCatchComputedValueSourcePersist, NonTargetCatchComputedValueSource>() { - - @Override - public NonTargetCatchComputedValueSource apply(NonTargetCatchComputedValueSourcePersist input) { - return input == null ? null : NonTargetCatchComputedValueSource.valueOf(input.name()); - } - }; + protected static final Function<NonTargetCatchComputedValueSourcePersist, NonTargetCatchComputedValueSource> NON_TARGET_CATCH_COMPUTED_VALUE_SOURCE_TO_DTO = input -> input == null ? null : NonTargetCatchComputedValueSource.valueOf(input.name()); protected final Class<E> entityType; diff --git a/observe-services-topia/src/main/java/fr/ird/observe/services/entity/EntitiesExtractor.java b/observe-services-topia/src/main/java/fr/ird/observe/services/entity/EntitiesExtractor.java index 4f52c92..3627148 100644 --- a/observe-services-topia/src/main/java/fr/ird/observe/services/entity/EntitiesExtractor.java +++ b/observe-services-topia/src/main/java/fr/ird/observe/services/entity/EntitiesExtractor.java @@ -22,7 +22,6 @@ package fr.ird.observe.services.entity; * #L% */ -import com.google.common.base.Optional; import com.google.common.base.Predicate; import com.google.common.collect.Iterables; import fr.ird.observe.ObserveTopiaPersistenceContext; @@ -30,6 +29,7 @@ import fr.ird.observe.entities.ObserveEntity; import org.nuiton.topia.persistence.TopiaDao; import java.util.Map; +import java.util.Optional; /** * Cette classe permet d'extraire dynamiquement un ensemble d'entitiées de la base de données. @@ -52,16 +52,16 @@ public class EntitiesExtractor<E extends ObserveEntity> { public Iterable<E> getEntities(ObserveTopiaPersistenceContext persistenceContext, Map<String, Object> requestContext) { Iterable<E> result = getEntitiesSetBase(persistenceContext, requestContext); - Predicate<E> filter = getFilter(requestContext); + java.util.function.Predicate<E> filter = getFilter(requestContext); if (filter != null) { - result = Iterables.filter(result, filter); + result = Iterables.filter(result, filter::test); } return result; } protected EntitiesExtractor(Class<E> entityType, Predicate<E> optionalFilter) { this.entityType = entityType; - this.optionalFilter = Optional.fromNullable(optionalFilter); + this.optionalFilter = Optional.ofNullable(optionalFilter); } protected Iterable<E> getEntitiesSetBase(ObserveTopiaPersistenceContext persistenceContext, Map<String, Object> requestContext) { @@ -69,8 +69,8 @@ public class EntitiesExtractor<E extends ObserveEntity> { return dao.findAll(); } - protected Predicate<E> getFilter(Map<String, Object> requestContext) { - return optionalFilter.orNull(); + protected java.util.function.Predicate<E> getFilter(Map<String, Object> requestContext) { + return optionalFilter.orElse(null)::apply; } } diff --git a/observe-services-topia/src/main/java/fr/ird/observe/services/entity/EntitiesSetFactory.java b/observe-services-topia/src/main/java/fr/ird/observe/services/entity/EntitiesSetFactory.java index 0fed350..ba9adad 100644 --- a/observe-services-topia/src/main/java/fr/ird/observe/services/entity/EntitiesSetFactory.java +++ b/observe-services-topia/src/main/java/fr/ird/observe/services/entity/EntitiesSetFactory.java @@ -71,17 +71,17 @@ public class EntitiesSetFactory { TripSeine.class, TripSeine.PROPERTY_CAPTAIN, Person.class, - Persons.newCaptainPredicate()); + Persons.newCaptainPredicate()); registerReferentialEntitiesExtractor(builder, TripSeine.class, TripSeine.PROPERTY_OBSERVER, Person.class, - Persons.newObserverPredicate()); + Persons.newObserverPredicate()); registerReferentialEntitiesExtractor(builder, TripSeine.class, TripSeine.PROPERTY_DATA_ENTRY_OPERATOR, Person.class, - Persons.newDataEntryOperatorPredicate()); + Persons.newDataEntryOperatorPredicate()); registerReferentialEntitiesExtractor(builder, TripSeine.class, TripSeine.PROPERTY_VESSEL, @@ -93,17 +93,17 @@ public class EntitiesSetFactory { TripLongline.class, TripLongline.PROPERTY_CAPTAIN, Person.class, - Persons.newCaptainPredicate()); + Persons.newCaptainPredicate()); registerReferentialEntitiesExtractor(builder, TripLongline.class, TripLongline.PROPERTY_OBSERVER, Person.class, - Persons.newObserverPredicate()); + Persons.newObserverPredicate()); registerReferentialEntitiesExtractor(builder, TripLongline.class, TripLongline.PROPERTY_DATA_ENTRY_OPERATOR, Person.class, - Persons.newDataEntryOperatorPredicate()); + Persons.newDataEntryOperatorPredicate()); registerReferentialEntitiesExtractor(builder, TripLongline.class, TripLongline.PROPERTY_VESSEL, diff --git a/observe-services-topia/src/main/java/fr/ird/observe/services/entity/SpeciesListEntitiesExtractor.java b/observe-services-topia/src/main/java/fr/ird/observe/services/entity/SpeciesListEntitiesExtractor.java index 3355929..1983da3 100644 --- a/observe-services-topia/src/main/java/fr/ird/observe/services/entity/SpeciesListEntitiesExtractor.java +++ b/observe-services-topia/src/main/java/fr/ird/observe/services/entity/SpeciesListEntitiesExtractor.java @@ -43,7 +43,7 @@ public class SpeciesListEntitiesExtractor extends EntitiesExtractor<Species> { protected final String speciesListId; public SpeciesListEntitiesExtractor(String speciesListId) { - super(Species.class, ObserveReferentialEntities.<Species>newEnablePredicate()); + super(Species.class, ObserveReferentialEntities.newEnablePredicate()); this.speciesListId = speciesListId; } diff --git a/observe-services-topia/src/main/java/fr/ird/observe/services/entity/SpeciesListOceanEntitiesExtractor.java b/observe-services-topia/src/main/java/fr/ird/observe/services/entity/SpeciesListOceanEntitiesExtractor.java index 6a1209a..10309ab 100644 --- a/observe-services-topia/src/main/java/fr/ird/observe/services/entity/SpeciesListOceanEntitiesExtractor.java +++ b/observe-services-topia/src/main/java/fr/ird/observe/services/entity/SpeciesListOceanEntitiesExtractor.java @@ -23,7 +23,6 @@ package fr.ird.observe.services.entity; */ import com.google.common.base.Predicate; -import com.google.common.base.Predicates; import fr.ird.observe.entities.referentiel.Ocean; import fr.ird.observe.entities.referentiel.Species; import fr.ird.observe.entities.referentiel.Species2; @@ -42,16 +41,16 @@ public class SpeciesListOceanEntitiesExtractor extends SpeciesListEntitiesExtrac } @Override - protected Predicate<Species> getFilter(Map<String, Object> requestContext) { + protected java.util.function.Predicate<Species> getFilter(Map<String, Object> requestContext) { - Predicate<Species> filter = super.getFilter(requestContext); + java.util.function.Predicate<Species> filter = super.getFilter(requestContext); Ocean ocean = (Ocean) requestContext.get(Species.PROPERTY_OCEAN); if (ocean != null) { Predicate<Species> oceanFilter = Species2.newSpeciesByOceanPredicate(ocean); - filter = Predicates.and(filter, oceanFilter); + filter = filter.and(oceanFilter::apply); } diff --git a/observe-services-topia/src/main/java/fr/ird/observe/services/entity/TripMapDtoFactory.java b/observe-services-topia/src/main/java/fr/ird/observe/services/entity/TripMapDtoFactory.java index 7a73c3c..8755efc 100644 --- a/observe-services-topia/src/main/java/fr/ird/observe/services/entity/TripMapDtoFactory.java +++ b/observe-services-topia/src/main/java/fr/ird/observe/services/entity/TripMapDtoFactory.java @@ -22,7 +22,6 @@ package fr.ird.observe.services.entity; * #L% */ -import com.google.common.base.Function; import com.google.common.collect.Iterables; import com.google.common.collect.Sets; import fr.ird.observe.entities.TripMapPoint; @@ -32,6 +31,7 @@ import fr.ird.observe.services.dto.constants.TripMapPointType; import java.util.LinkedHashSet; import java.util.Set; +import java.util.function.Function; /** * Created on 09/01/16. @@ -43,20 +43,17 @@ public class TripMapDtoFactory { public static TripMapDto newTripMapDto(String tripId, Set<TripMapPoint> points) { TripMapDto tripMapDto = new TripMapDto(); tripMapDto.setId(tripId); - LinkedHashSet<TripMapPointDto> pointDtos = Sets.newLinkedHashSet(Iterables.transform(points, TRIP_MAP_POINT_TRIP_MAP_POINT_DTO_FUNCTION)); + LinkedHashSet<TripMapPointDto> pointDtos = Sets.newLinkedHashSet(Iterables.transform(points, TRIP_MAP_POINT_TRIP_MAP_POINT_DTO_FUNCTION::apply)); tripMapDto.setPoints(pointDtos); return tripMapDto; } - protected static final Function<TripMapPoint, TripMapPointDto> TRIP_MAP_POINT_TRIP_MAP_POINT_DTO_FUNCTION = new Function<TripMapPoint, TripMapPointDto>() { - @Override - public TripMapPointDto apply(TripMapPoint tripMapPoint) { - TripMapPointDto result = new TripMapPointDto(); - result.setLatitude(tripMapPoint.getLatitude()); - result.setLongitude(tripMapPoint.getLongitude()); - result.setTime(tripMapPoint.getTime()); - result.setType(TripMapPointType.valueOf(tripMapPoint.getType().name())); - return result; - } + protected static final Function<TripMapPoint, TripMapPointDto> TRIP_MAP_POINT_TRIP_MAP_POINT_DTO_FUNCTION = tripMapPoint -> { + TripMapPointDto result = new TripMapPointDto(); + result.setLatitude(tripMapPoint.getLatitude()); + result.setLongitude(tripMapPoint.getLongitude()); + result.setTime(tripMapPoint.getTime()); + result.setType(TripMapPointType.valueOf(tripMapPoint.getType().name())); + return result; }; } diff --git a/observe-services-topia/src/main/java/fr/ird/observe/services/service/DataSourceServiceTopia.java b/observe-services-topia/src/main/java/fr/ird/observe/services/service/DataSourceServiceTopia.java index 0ab73f9..b29ff3c 100644 --- a/observe-services-topia/src/main/java/fr/ird/observe/services/service/DataSourceServiceTopia.java +++ b/observe-services-topia/src/main/java/fr/ird/observe/services/service/DataSourceServiceTopia.java @@ -23,7 +23,6 @@ package fr.ird.observe.services.service; */ import com.google.common.base.Joiner; -import com.google.common.base.Optional; import com.google.common.base.Preconditions; import com.google.common.collect.ImmutableSet; import com.google.common.collect.Iterables; @@ -56,6 +55,7 @@ import org.nuiton.version.Version; import java.io.File; import java.io.IOException; import java.nio.file.Files; +import java.util.Optional; import java.util.Set; import java.util.UUID; diff --git a/observe-services-topia/src/main/java/fr/ird/observe/services/service/ReferentialServiceTopia.java b/observe-services-topia/src/main/java/fr/ird/observe/services/service/ReferentialServiceTopia.java index 1a4ec1a..a176caa 100644 --- a/observe-services-topia/src/main/java/fr/ird/observe/services/service/ReferentialServiceTopia.java +++ b/observe-services-topia/src/main/java/fr/ird/observe/services/service/ReferentialServiceTopia.java @@ -23,7 +23,6 @@ package fr.ird.observe.services.service; */ import com.google.common.base.Joiner; -import com.google.common.base.Optional; import com.google.common.base.Preconditions; import com.google.common.collect.ImmutableMap; import com.google.common.collect.ImmutableSet; @@ -35,8 +34,8 @@ import fr.ird.observe.services.binder.BinderEngine; import fr.ird.observe.services.binder.referential.ReferentialBinderSupport; import fr.ird.observe.services.dto.DataDto; import fr.ird.observe.services.dto.DataReferenceSet; -import fr.ird.observe.services.dto.ReferenceMap; import fr.ird.observe.services.dto.Form; +import fr.ird.observe.services.dto.ReferenceMap; import fr.ird.observe.services.dto.constants.ReferenceStatus; import fr.ird.observe.services.dto.reference.ReferenceSetDefinition; import fr.ird.observe.services.dto.reference.request.ReferenceSetRequestDefinition; @@ -55,6 +54,7 @@ import java.util.Collection; import java.util.Collections; import java.util.Date; import java.util.List; +import java.util.Optional; /** * Created on 16/08/15. diff --git a/observe-services-topia/src/main/java/fr/ird/observe/services/service/SqlScriptProducerServiceTopia.java b/observe-services-topia/src/main/java/fr/ird/observe/services/service/SqlScriptProducerServiceTopia.java index fb5427c..e2c4cc9 100644 --- a/observe-services-topia/src/main/java/fr/ird/observe/services/service/SqlScriptProducerServiceTopia.java +++ b/observe-services-topia/src/main/java/fr/ird/observe/services/service/SqlScriptProducerServiceTopia.java @@ -117,7 +117,7 @@ public class SqlScriptProducerServiceTopia extends ObserveServiceTopia implement { - Set<String> tripIds1 = Sets.newHashSet(Iterables.filter(tripIds, Entities.IS_SEINE_ID)); + Set<String> tripIds1 = Sets.newHashSet(Iterables.filter(tripIds, Entities.IS_SEINE_ID::test)); if (!tripIds1.isEmpty()) { @@ -132,7 +132,7 @@ public class SqlScriptProducerServiceTopia extends ObserveServiceTopia implement { - Set<String> tripIds1 = Sets.newHashSet(Iterables.filter(tripIds, Entities.IS_LONGLINE_ID)); + Set<String> tripIds1 = Sets.newHashSet(Iterables.filter(tripIds, Entities.IS_LONGLINE_ID::test)); if (!tripIds1.isEmpty()) { diff --git a/observe-services-topia/src/main/java/fr/ird/observe/services/service/actions/consolidate/ConsolidateActivitySeineDataResultBuilder.java b/observe-services-topia/src/main/java/fr/ird/observe/services/service/actions/consolidate/ConsolidateActivitySeineDataResultBuilder.java index 1868469..05244cb 100644 --- a/observe-services-topia/src/main/java/fr/ird/observe/services/service/actions/consolidate/ConsolidateActivitySeineDataResultBuilder.java +++ b/observe-services-topia/src/main/java/fr/ird/observe/services/service/actions/consolidate/ConsolidateActivitySeineDataResultBuilder.java @@ -22,7 +22,6 @@ package fr.ird.observe.services.service.actions.consolidate; * #L% */ -import com.google.common.base.Optional; import com.google.common.collect.ImmutableSet; import fr.ird.observe.entities.constants.seine.SchoolTypePersist; import fr.ird.observe.entities.referentiel.I18nReferenceEntities; @@ -42,6 +41,7 @@ import org.apache.commons.logging.LogFactory; import java.util.Date; import java.util.Locale; +import java.util.Optional; import static fr.ird.observe.services.service.actions.consolidate.ConsolidateActivitySeineDataResult.NonTargetCatchModification; import static fr.ird.observe.services.service.actions.consolidate.ConsolidateActivitySeineDataResult.NonTargetLengthModification; @@ -74,13 +74,13 @@ public class ConsolidateActivitySeineDataResultBuilder { protected String newSchoolType; - protected ImmutableSet.Builder<String> lengthWeightParameterNotFoundBuilder = new ImmutableSet.Builder<>(); + protected final ImmutableSet.Builder<String> lengthWeightParameterNotFoundBuilder = new ImmutableSet.Builder<>(); - protected ImmutableSet.Builder<TargetLengthModification> targetLengthModificationBuilder = new ImmutableSet.Builder<>(); + protected final ImmutableSet.Builder<TargetLengthModification> targetLengthModificationBuilder = new ImmutableSet.Builder<>(); - protected ImmutableSet.Builder<NonTargetLengthModification> nonTargetLengthModificationBuilder = new ImmutableSet.Builder<>(); + protected final ImmutableSet.Builder<NonTargetLengthModification> nonTargetLengthModificationBuilder = new ImmutableSet.Builder<>(); - protected ImmutableSet.Builder<NonTargetCatchModification> nonTargetCatchModificationBuilder = new ImmutableSet.Builder<>(); + protected final ImmutableSet.Builder<NonTargetCatchModification> nonTargetCatchModificationBuilder = new ImmutableSet.Builder<>(); public void flushTargetLengthModification(TargetLength targetLength, String... propertyNamesModified) { @@ -246,7 +246,7 @@ public class ConsolidateActivitySeineDataResultBuilder { } - return Optional.fromNullable(consolidateActivitySeineDataResult); + return Optional.ofNullable(consolidateActivitySeineDataResult); } diff --git a/observe-services-topia/src/main/java/fr/ird/observe/services/service/actions/consolidate/ConsolidateDataServiceTopia.java b/observe-services-topia/src/main/java/fr/ird/observe/services/service/actions/consolidate/ConsolidateDataServiceTopia.java index 443a4dd..4a361cb 100644 --- a/observe-services-topia/src/main/java/fr/ird/observe/services/service/actions/consolidate/ConsolidateDataServiceTopia.java +++ b/observe-services-topia/src/main/java/fr/ird/observe/services/service/actions/consolidate/ConsolidateDataServiceTopia.java @@ -22,7 +22,6 @@ package fr.ird.observe.services.service.actions.consolidate; * #L% */ -import com.google.common.base.Optional; import com.google.common.collect.ImmutableSet; import fr.ird.observe.ObserveTopiaDaoSupplier; import fr.ird.observe.ObserveTopiaPersistenceContext; @@ -58,6 +57,7 @@ import org.nuiton.util.beans.BeanMonitor; import java.util.Collection; import java.util.Date; import java.util.Locale; +import java.util.Optional; /** * Created on 28/08/15. @@ -270,7 +270,7 @@ public class ConsolidateDataServiceTopia extends ObserveServiceTopia implements log.info("Found some modifications on trip: " + consolidateTripSeineDataResult.getTripSeineLabel()); } } - return Optional.fromNullable(consolidateTripSeineDataResult); + return Optional.ofNullable(consolidateTripSeineDataResult); } diff --git a/observe-services-topia/src/main/java/fr/ird/observe/services/service/actions/report/ReportServiceTopia.java b/observe-services-topia/src/main/java/fr/ird/observe/services/service/actions/report/ReportServiceTopia.java index 224f461..9cf6e3e 100644 --- a/observe-services-topia/src/main/java/fr/ird/observe/services/service/actions/report/ReportServiceTopia.java +++ b/observe-services-topia/src/main/java/fr/ird/observe/services/service/actions/report/ReportServiceTopia.java @@ -382,7 +382,7 @@ public class ReportServiceTopia extends ObserveServiceTopia implements ReportSer DataMatrix result = new DataMatrix(); - Map<String, Object> params = request.extractParams(report, tripId); + Map<String, Object> params = ReportRequest.extractParams(report, tripId); for (Object repeatValue : repeatValues.getValues()) { params.put(request.getRepeat().getVariableName(), repeatValue); @@ -423,7 +423,7 @@ public class ReportServiceTopia extends ObserveServiceTopia implements ReportSer } public DataMatrix executeReportRequest(ReportRequest request, Report report, String tripId) { - Map<String, Object> params = request.extractParams(report, tripId); + Map<String, Object> params = ReportRequest.extractParams(report, tripId); DataMatrix dataMatrix = executeReportRequest(request, params); diff --git a/observe-services-topia/src/main/java/fr/ird/observe/services/service/actions/synchro/UnidirectionalReferentialSynchronizeRemoteServiceTopia.java b/observe-services-topia/src/main/java/fr/ird/observe/services/service/actions/synchro/UnidirectionalReferentialSynchronizeRemoteServiceTopia.java index d39d373..b3cc570 100644 --- a/observe-services-topia/src/main/java/fr/ird/observe/services/service/actions/synchro/UnidirectionalReferentialSynchronizeRemoteServiceTopia.java +++ b/observe-services-topia/src/main/java/fr/ird/observe/services/service/actions/synchro/UnidirectionalReferentialSynchronizeRemoteServiceTopia.java @@ -36,7 +36,6 @@ import org.apache.commons.logging.Log; import org.apache.commons.logging.LogFactory; import org.nuiton.topia.persistence.TopiaDao; -import java.util.Collection; import java.util.LinkedHashSet; import java.util.List; import java.util.Map; @@ -92,9 +91,9 @@ public class UnidirectionalReferentialSynchronizeRemoteServiceTopia extends Obse ReferentialLocale referentialLocale = getReferentialLocale(); BinderEngine binderEngine = BinderEngine.get(); - Class<ReferentialDto> referentialDtoType = binderEngine.getReferentialDtoType(entityType); +// Class<ReferentialDto> referentialDtoType = binderEngine.getReferentialDtoType(entityType); Map<String, Long> localReferentialVersions = localReferentialStates.getReferentialVersions(entityName); - Collection<String> localReferentialDisabled = localReferentialStates.getReferentialDisabled(entityName); +// Collection<String> localReferentialDisabled = localReferentialStates.getReferentialDisabled(entityName); TopiaDao<E> dao = getTopiaPersistenceContext().getDao(entityType); for (E centralReferentialEntity : dao) { diff --git a/observe-services-topia/src/main/java/fr/ird/observe/services/service/actions/validate/ValidationMessageDetector.java b/observe-services-topia/src/main/java/fr/ird/observe/services/service/actions/validate/ValidationMessageDetector.java index 74230e2..52bcc9f 100644 --- a/observe-services-topia/src/main/java/fr/ird/observe/services/service/actions/validate/ValidationMessageDetector.java +++ b/observe-services-topia/src/main/java/fr/ird/observe/services/service/actions/validate/ValidationMessageDetector.java @@ -21,7 +21,6 @@ */ package fr.ird.observe.services.service.actions.validate; -import com.google.common.base.Predicate; import com.google.common.collect.HashMultimap; import com.google.common.collect.Multimap; import com.google.common.collect.Multimaps; @@ -118,13 +117,7 @@ public class ValidationMessageDetector { } public <E extends TopiaEntity> Map<TopiaEntity, Collection<ValidationMessage>> getDetectedMessages(final Class<E> entityType) { - return Multimaps.filterEntries(detectedMessages, new Predicate<Map.Entry<TopiaEntity, ValidationMessage>>() { - - @Override - public boolean apply(Map.Entry<TopiaEntity, ValidationMessage> input) { - return entityType.isAssignableFrom(input.getKey().getClass()); - } - }).asMap(); + return Multimaps.filterEntries(detectedMessages, input -> entityType.isAssignableFrom(input.getKey().getClass())).asMap(); } public String translateMessage(String message) { diff --git a/observe-services-topia/src/main/java/fr/ird/observe/services/service/longline/ActivityLonglineServiceTopia.java b/observe-services-topia/src/main/java/fr/ird/observe/services/service/longline/ActivityLonglineServiceTopia.java index 05a465e..fa454fa 100644 --- a/observe-services-topia/src/main/java/fr/ird/observe/services/service/longline/ActivityLonglineServiceTopia.java +++ b/observe-services-topia/src/main/java/fr/ird/observe/services/service/longline/ActivityLonglineServiceTopia.java @@ -281,6 +281,6 @@ public class ActivityLonglineServiceTopia extends ObserveServiceTopia implements protected int getActivityLonglinePositionInTripLongline(TripLongline tripLongline, ActivityLongline activityLongline) { return Iterables.size(Iterables.filter( tripLongline.getActivityLongline(), - ActivityLonglines.newTimeStampBeforePredicate(activityLongline.getTimeStamp()))); + ActivityLonglines.newTimeStampBeforePredicate(activityLongline.getTimeStamp())::apply)); } } diff --git a/observe-services-topia/src/main/java/fr/ird/observe/services/service/seine/ActivitySeineServiceTopia.java b/observe-services-topia/src/main/java/fr/ird/observe/services/service/seine/ActivitySeineServiceTopia.java index 48cda67..7071335 100644 --- a/observe-services-topia/src/main/java/fr/ird/observe/services/service/seine/ActivitySeineServiceTopia.java +++ b/observe-services-topia/src/main/java/fr/ird/observe/services/service/seine/ActivitySeineServiceTopia.java @@ -281,6 +281,6 @@ public class ActivitySeineServiceTopia extends ObserveServiceTopia implements Ac protected int getActivitySeinePositionInRoute(Route route, ActivitySeine activitySeine) { return Iterables.size(Iterables.filter( route.getActivitySeine(), - ActivitySeines.newDateBeforePredicate(activitySeine.getTime()))); + ActivitySeines.newDateBeforePredicate(activitySeine.getTime())::apply)); } } diff --git a/observe-services-topia/src/main/java/fr/ird/observe/services/service/seine/RouteServiceTopia.java b/observe-services-topia/src/main/java/fr/ird/observe/services/service/seine/RouteServiceTopia.java index 95c7558..2243a5f 100644 --- a/observe-services-topia/src/main/java/fr/ird/observe/services/service/seine/RouteServiceTopia.java +++ b/observe-services-topia/src/main/java/fr/ird/observe/services/service/seine/RouteServiceTopia.java @@ -57,6 +57,7 @@ import java.util.Date; import java.util.LinkedHashSet; import java.util.List; import java.util.Set; +import java.util.stream.Collectors; /** * @author Sylvain Bavencoff - bavencoff@codelutin.com @@ -115,7 +116,7 @@ public class RouteServiceTopia extends ObserveServiceTopia implements RouteServi TopiaEntities.entityHasId(activitySeineDto.getId())); boolean isFindeVeille = activitySeine.getVesselActivitySeine() != null - && ActivitySeineImpl.ACTIVITY_FIN_DE_VEILLE.equals(activitySeine.getVesselActivitySeine().getCode()); + && ActivitySeineImpl.ACTIVITY_FIN_DE_VEILLE.equals(activitySeine.getVesselActivitySeine().getCode()); activitySeineDto.setActivityFinDeVeille(isFindeVeille); @@ -323,8 +324,9 @@ public class RouteServiceTopia extends ObserveServiceTopia implements RouteServi } protected int getRoutePositionInTripSeine(TripSeine tripSeine, Route route) { - return Iterables.size(Iterables.filter( - tripSeine.getRoute(), - Routes.newDateBeforePredicate(route.getDate()))); + return Iterables.size(tripSeine.getRoute() + .stream() + .filter(Routes.newDateBeforePredicate(route.getDate())::apply) + .collect(Collectors.toList())); } } diff --git a/observe-services-topia/src/test/java/fr/ird/observe/entities/referentiel/LengthWeightParemetersTest.java b/observe-services-topia/src/test/java/fr/ird/observe/entities/referentiel/LengthWeightParemetersTest.java index 701393e..4c963b8 100644 --- a/observe-services-topia/src/test/java/fr/ird/observe/entities/referentiel/LengthWeightParemetersTest.java +++ b/observe-services-topia/src/test/java/fr/ird/observe/entities/referentiel/LengthWeightParemetersTest.java @@ -51,7 +51,7 @@ public class LengthWeightParemetersTest extends AbstractServiceTopiaTest { private ObserveTopiaPersistenceContext persistenceContext; @Before - public void setUp() throws Exception { + public void setUp() { persistenceContext = dataSourceResource.newPersistenceContext(); diff --git a/observe-services-topia/src/test/java/fr/ird/observe/services/binder/BinderEngineMetadataTest.java b/observe-services-topia/src/test/java/fr/ird/observe/services/binder/BinderEngineMetadataTest.java index 2efb0b3..6ec4f64 100644 --- a/observe-services-topia/src/test/java/fr/ird/observe/services/binder/BinderEngineMetadataTest.java +++ b/observe-services-topia/src/test/java/fr/ird/observe/services/binder/BinderEngineMetadataTest.java @@ -51,7 +51,7 @@ public class BinderEngineMetadataTest { private BinderEngine binderEngine; @Before - public void setUp() throws Exception { + public void setUp() { binderEngine = BinderEngine.get(); diff --git a/observe-services-topia/src/test/java/fr/ird/observe/services/binder/BinderEngineTest.java b/observe-services-topia/src/test/java/fr/ird/observe/services/binder/BinderEngineTest.java index 5fb10b0..dce0d53 100644 --- a/observe-services-topia/src/test/java/fr/ird/observe/services/binder/BinderEngineTest.java +++ b/observe-services-topia/src/test/java/fr/ird/observe/services/binder/BinderEngineTest.java @@ -143,9 +143,6 @@ import fr.ird.observe.services.dto.seine.TransmittingBuoyDto; import fr.ird.observe.services.dto.seine.TripSeineDto; import fr.ird.observe.services.dto.seine.TripSeineGearUseDto; import fr.ird.observe.services.service.AbstractServiceTopiaTest; -import fr.ird.observe.services.service.BabModelVersionException; -import fr.ird.observe.services.service.DatabaseConnexionNotAuthorizedException; -import fr.ird.observe.services.service.DatabaseNotFoundException; import fr.ird.observe.test.DatabaseName; import fr.ird.observe.test.spi.DatabaseNameConfiguration; import org.apache.commons.logging.Log; @@ -171,7 +168,7 @@ public class BinderEngineTest extends AbstractServiceTopiaTest { private BinderEngine binderEngine; @Before - public void setUp() throws Exception { + public void setUp() { binderEngine = BinderEngine.get(); @@ -304,7 +301,7 @@ public class BinderEngineTest extends AbstractServiceTopiaTest { } - protected <D extends DataDto, E extends ObserveDataEntity> void transformDataEntityToDto(Class<D> dtoType) throws DatabaseNotFoundException, BabModelVersionException, DatabaseConnexionNotAuthorizedException { + protected <D extends DataDto, E extends ObserveDataEntity> void transformDataEntityToDto(Class<D> dtoType) { Class<E> entityType = binderEngine.getDataEntityType(dtoType); @@ -340,7 +337,7 @@ public class BinderEngineTest extends AbstractServiceTopiaTest { } - protected <D extends ReferentialDto, E extends ObserveReferentialEntity> void transformReferentialEntityToDto(Class<D> dtoType) throws DatabaseNotFoundException, BabModelVersionException, DatabaseConnexionNotAuthorizedException { + protected <D extends ReferentialDto, E extends ObserveReferentialEntity> void transformReferentialEntityToDto(Class<D> dtoType) { Class<E> entityType = binderEngine.getReferentialEntityType(dtoType); diff --git a/observe-services-topia/src/test/java/fr/ird/observe/services/service/DataSourceServiceTopiaTest.java b/observe-services-topia/src/test/java/fr/ird/observe/services/service/DataSourceServiceTopiaTest.java index bb6690e..f5d5614 100644 --- a/observe-services-topia/src/test/java/fr/ird/observe/services/service/DataSourceServiceTopiaTest.java +++ b/observe-services-topia/src/test/java/fr/ird/observe/services/service/DataSourceServiceTopiaTest.java @@ -64,7 +64,7 @@ public class DataSourceServiceTopiaTest extends AbstractServiceTopiaTest { protected DataSourceService service; @Before - public void setUp() throws Exception { + public void setUp() { ObserveDataSourceConfigurationTopiaH2 dataSourceConfiguration = dataSourceResource.getDataSourceConfiguration(); diff --git a/observe-services-topia/src/test/java/fr/ird/observe/services/service/MigrateTestsDatabases.java b/observe-services-topia/src/test/java/fr/ird/observe/services/service/MigrateTestsDatabases.java index 8efa1a9..3567ade 100644 --- a/observe-services-topia/src/test/java/fr/ird/observe/services/service/MigrateTestsDatabases.java +++ b/observe-services-topia/src/test/java/fr/ird/observe/services/service/MigrateTestsDatabases.java @@ -107,7 +107,7 @@ public class MigrateTestsDatabases extends AbstractServiceTopiaTest { migrate(dataSourceResource.getDbName(), dump); } - protected void migrate(String dbName, byte[] dump) throws IOException, IncompatibleDataSourceCreateConfigurationException, DataSourceCreateWithNoReferentialImportException, DatabaseNotFoundException, BabModelVersionException, DatabaseConnexionNotAuthorizedException { + protected void migrate(String dbName, byte[] dump) throws IOException { File databasesRootDirectory = dataSourceResource.getDataSourceConfiguration().getDatabaseFile(); diff --git a/observe-services-topia/src/test/java/fr/ird/observe/services/service/actions/report/AbstractReportServiceTopiaTest.java b/observe-services-topia/src/test/java/fr/ird/observe/services/service/actions/report/AbstractReportServiceTopiaTest.java index d9551b4..b66857b 100644 --- a/observe-services-topia/src/test/java/fr/ird/observe/services/service/actions/report/AbstractReportServiceTopiaTest.java +++ b/observe-services-topia/src/test/java/fr/ird/observe/services/service/actions/report/AbstractReportServiceTopiaTest.java @@ -104,9 +104,6 @@ public abstract class AbstractReportServiceTopiaTest extends AbstractServiceTopi // creation de l'executeur de report report = service.populateVariables(report, ObserveFixtures.TRIP_SEINE_ID_1); - // les variables a utiliser (par defaut, pas de variable) - Map<String, Object> variables = new HashMap<>(); - // preparation des variables prepareVariables(); @@ -132,7 +129,7 @@ public abstract class AbstractReportServiceTopiaTest extends AbstractServiceTopi if (variableName.equals(variable.getName())) { - Object value = Iterables.find(variable.getValues(), AbstractReference.newIdPredicate(id)); + Object value = Iterables.find(variable.getValues(), AbstractReference.newIdPredicate(id)::apply); variable.setSelectedValue(value); diff --git a/observe-services-topia/src/test/java/fr/ird/observe/services/service/actions/report/ReportAccessoryCatch2Test.java b/observe-services-topia/src/test/java/fr/ird/observe/services/service/actions/report/ReportAccessoryCatch2Test.java index 31c48b8..2392f42 100644 --- a/observe-services-topia/src/test/java/fr/ird/observe/services/service/actions/report/ReportAccessoryCatch2Test.java +++ b/observe-services-topia/src/test/java/fr/ird/observe/services/service/actions/report/ReportAccessoryCatch2Test.java @@ -193,7 +193,7 @@ public class ReportAccessoryCatch2Test extends ReportAccessoryCatchTest { assertResultRow(result, row++, "[FAO]XXX* [sc] [fr]", "-", "-"); assertResultRow(result, row++, "[FAO]YMO [sc]Sthenoteuthis oualaniensis [fr]Encornet bande violette", "-", "-"); assertResultRow(result, row++, "[FAO]YTC [sc]Seriola lalandi [fr]Sériole chicard", "-", "-"); - assertResultRow(result, row++, "[FAO]ZAO [sc]Zanclus cornutus [fr]Zanclus cornutus", "-", "-"); + assertResultRow(result, row, "[FAO]ZAO [sc]Zanclus cornutus [fr]Zanclus cornutus", "-", "-"); } } diff --git a/observe-services-topia/src/test/java/fr/ird/observe/services/service/actions/report/ReportAccessoryCatchByGroup2Test.java b/observe-services-topia/src/test/java/fr/ird/observe/services/service/actions/report/ReportAccessoryCatchByGroup2Test.java index a0a5a4e..9f29500 100644 --- a/observe-services-topia/src/test/java/fr/ird/observe/services/service/actions/report/ReportAccessoryCatchByGroup2Test.java +++ b/observe-services-topia/src/test/java/fr/ird/observe/services/service/actions/report/ReportAccessoryCatchByGroup2Test.java @@ -62,7 +62,7 @@ public class ReportAccessoryCatchByGroup2Test extends ReportAccessoryCatchByGrou assertResultRow(result, row++, "[FAO]REO [sc]Remora remora [fr]Rémora", "2", "0", "0", "0", "2", "0", "0", "0", "0", "0.0"); assertResultRow(result, row++, "[FAO]GBA [sc]Sphyraena barracuda [fr]Barracuda", "0", "26", "0", "0", "3", "23", "0", "0", "0", "0.0"); assertResultRow(result, row++, "[FAO]BTS [sc]Tylosurus crocodilus [fr]Aiguille crocodile ", "0", "1", "0", "0", "1", "0", "0", "0", "0", "0.0"); - assertResultRow(result, row++, "[FAO]WAH [sc]Acanthocybium solandri [fr]Thazard bâtard", "0", "90", "0", "0", "3", "85", "0", "0", "2", "0.0"); + assertResultRow(result, row, "[FAO]WAH [sc]Acanthocybium solandri [fr]Thazard bâtard", "0", "90", "0", "0", "3", "85", "0", "0", "2", "0.0"); } } diff --git a/observe-services-topia/src/test/java/fr/ird/observe/services/service/actions/report/ReportAccessoryCatchByGroupTest.java b/observe-services-topia/src/test/java/fr/ird/observe/services/service/actions/report/ReportAccessoryCatchByGroupTest.java index 809ddfa..1383718 100644 --- a/observe-services-topia/src/test/java/fr/ird/observe/services/service/actions/report/ReportAccessoryCatchByGroupTest.java +++ b/observe-services-topia/src/test/java/fr/ird/observe/services/service/actions/report/ReportAccessoryCatchByGroupTest.java @@ -93,6 +93,6 @@ public class ReportAccessoryCatchByGroupTest extends AbstractReportServiceTopiaT assertResultRow(result, row++, "[FAO]RSK [sc]Carcharhinidae spp [fr]Famille Carcharhinidae", "0", "11", "0", "0", "5", "6", "0", "0", "0", "0.0"); assertResultRow(result, row++, "[FAO]STT [sc]Dasyatidae [fr]Famille Dasyatidae", "7", "0", "0", "0", "6", "0", "0", "0", "0", "1.0"); assertResultRow(result, row++, "[FAO]SPY [sc]Sphyrnidae [fr]Famille Sphyrnidae", "0", "1", "0", "0", "1", "0", "0", "0", "0", "0.0"); - assertResultRow(result, row++, "[FAO]RMB [sc]Manta birostris [fr]Mante atlantique", "9", "0", "0", "0", "9", "0", "0", "0", "0", "0.0"); + assertResultRow(result, row, "[FAO]RMB [sc]Manta birostris [fr]Mante atlantique", "9", "0", "0", "0", "9", "0", "0", "0", "0", "0.0"); } } diff --git a/observe-services-topia/src/test/java/fr/ird/observe/services/service/actions/report/ReportAccessoryCatchTest.java b/observe-services-topia/src/test/java/fr/ird/observe/services/service/actions/report/ReportAccessoryCatchTest.java index 2e93314..7fdd627 100644 --- a/observe-services-topia/src/test/java/fr/ird/observe/services/service/actions/report/ReportAccessoryCatchTest.java +++ b/observe-services-topia/src/test/java/fr/ird/observe/services/service/actions/report/ReportAccessoryCatchTest.java @@ -147,7 +147,7 @@ public class ReportAccessoryCatchTest extends AbstractReportServiceTopiaTest { assertResultRow(result, row++, "[FAO]SPL [sc]Sphyrna lewini [fr]Requin marteau halicorne", "-", "-"); assertResultRow(result, row++, "[FAO]SPK [sc]Sphyrna mokarran [fr]Grand requin marteau", "-", "-"); assertResultRow(result, row++, "[FAO]SPZ [sc]Sphyrna zygaena [fr]Requin marteau commun", "-", "-"); - assertResultRow(result, row++, "[FAO]TOD [sc]Torpedinidae [fr]Torpilles, raies électriq. nca ", "-", "-"); + assertResultRow(result, row, "[FAO]TOD [sc]Torpedinidae [fr]Torpilles, raies électriq. nca ", "-", "-"); } diff --git a/observe-services-topia/src/test/java/fr/ird/observe/services/service/actions/report/ReportActivityWithCommentTest.java b/observe-services-topia/src/test/java/fr/ird/observe/services/service/actions/report/ReportActivityWithCommentTest.java index 37919e1..85df1b6 100644 --- a/observe-services-topia/src/test/java/fr/ird/observe/services/service/actions/report/ReportActivityWithCommentTest.java +++ b/observe-services-topia/src/test/java/fr/ird/observe/services/service/actions/report/ReportActivityWithCommentTest.java @@ -342,6 +342,6 @@ public class ReportActivityWithCommentTest extends AbstractReportServiceTopiaTes assertResultRow(result, row++, "26/2/2013 13:7", "-4.6668053", "53.58347", "Recherche (général)", "Shiftage du 25.02.2013 de 13h à 16h35"); assertResultRow(result, row++, "26/2/2013 18:22", "-5.3168054", "54.566803", "Fin de veille", "Stopper pour la nuit."); assertResultRow(result, row++, "27/2/2013 15:36", "-4.5834723", "55.48347", "Autres (à préciser dans les notes)", "En attente pour rentrer au port avec le pilote"); - assertResultRow(result, row++, "27/2/2013 16:22", "-4.6168056", "55.450138", "Au port", "Fin de la première partie de calée.Loch totale marée: 5953.03"); + assertResultRow(result, row, "27/2/2013 16:22", "-4.6168056", "55.450138", "Au port", "Fin de la première partie de calée.Loch totale marée: 5953.03"); } } diff --git a/observe-services-topia/src/test/java/fr/ird/observe/services/service/actions/report/ReportAllActivitysTest.java b/observe-services-topia/src/test/java/fr/ird/observe/services/service/actions/report/ReportAllActivitysTest.java index fd39969..68b8a0b 100644 --- a/observe-services-topia/src/test/java/fr/ird/observe/services/service/actions/report/ReportAllActivitysTest.java +++ b/observe-services-topia/src/test/java/fr/ird/observe/services/service/actions/report/ReportAllActivitysTest.java @@ -935,7 +935,7 @@ public class ReportAllActivitysTest extends AbstractReportServiceTopiaTest { assertResultRow(result, row++, "27/2/2013 13:25", "-4.7001386", "55.600136", "Transit (route sans recherche)", null); assertResultRow(result, row++, "27/2/2013 14:25", "-4.5834723", "55.58347", "Transit (route sans recherche)", null); assertResultRow(result, row++, "27/2/2013 15:36", "-4.5834723", "55.48347", "Autres (à préciser dans les notes)", "En attente pour rentrer au port avec le pilote"); - assertResultRow(result, row++, "27/2/2013 16:22", "-4.6168056", "55.450138", "Au port", "Fin de la première partie de calée.Loch totale marée: 5953.03"); + assertResultRow(result, row, "27/2/2013 16:22", "-4.6168056", "55.450138", "Au port", "Fin de la première partie de calée.Loch totale marée: 5953.03"); } } \ No newline at end of file diff --git a/observe-services-topia/src/test/java/fr/ird/observe/services/service/actions/report/ReportDailySetAndCatchTest.java b/observe-services-topia/src/test/java/fr/ird/observe/services/service/actions/report/ReportDailySetAndCatchTest.java index 51f1453..9b3d04f 100644 --- a/observe-services-topia/src/test/java/fr/ird/observe/services/service/actions/report/ReportDailySetAndCatchTest.java +++ b/observe-services-topia/src/test/java/fr/ird/observe/services/service/actions/report/ReportDailySetAndCatchTest.java @@ -96,7 +96,7 @@ public class ReportDailySetAndCatchTest extends AbstractReportServiceTopiaTest { assertResultRow(result, row++, "23/2/2013", "3", "197.44"); assertResultRow(result, row++, "24/2/2013", "1", "12.0"); assertResultRow(result, row++, "25/2/2013", "1", "48.075"); - assertResultRow(result, row++, "26/2/2013", "1", "13.7"); + assertResultRow(result, row, "26/2/2013", "1", "13.7"); } } diff --git a/observe-services-topia/src/test/java/fr/ird/observe/services/service/actions/report/ReportDcpUsageTest.java b/observe-services-topia/src/test/java/fr/ird/observe/services/service/actions/report/ReportDcpUsageTest.java index b457533..ba49f0a 100644 --- a/observe-services-topia/src/test/java/fr/ird/observe/services/service/actions/report/ReportDcpUsageTest.java +++ b/observe-services-topia/src/test/java/fr/ird/observe/services/service/actions/report/ReportDcpUsageTest.java @@ -135,7 +135,7 @@ public class ReportDcpUsageTest extends AbstractReportServiceTopiaTest { assertResultRow(result, row++, "16 - Radeau ou bouée en dérive", "2", "0", "0", "0", "0", null); assertResultRow(result, row++, "3 - Arbre (ou branche)", "3", "0", "0", "0", "0", null); assertResultRow(result, row++, "6 - Radeau balisé en dérive (bambou et filet)", "19", "6", "13", "0", "0", null); - assertResultRow(result, row++, "99 - Autre (à préciser dans les notes)", "2", "0", "0", "0", "0", null); + assertResultRow(result, row, "99 - Autre (à préciser dans les notes)", "2", "0", "0", "0", "0", null); } } diff --git a/observe-services-topia/src/test/java/fr/ird/observe/services/service/actions/report/ReportSetByAssociationTest.java b/observe-services-topia/src/test/java/fr/ird/observe/services/service/actions/report/ReportSetByAssociationTest.java index 2daa3da..7676b5d 100644 --- a/observe-services-topia/src/test/java/fr/ird/observe/services/service/actions/report/ReportSetByAssociationTest.java +++ b/observe-services-topia/src/test/java/fr/ird/observe/services/service/actions/report/ReportSetByAssociationTest.java @@ -121,7 +121,7 @@ public class ReportSetByAssociationTest extends AbstractReportServiceTopiaTest { int row = 0; assertResultRow(result, row++, "19" ,"1" ,"0" ,"6" ,"26"); assertResultRow(result, row++, "9", "0", "0", "0", "9"); - assertResultRow(result, row++, "28" ,"1" ,"0" ,"6" ,"35"); + assertResultRow(result, row, "28" ,"1" ,"0" ,"6" ,"35"); } } diff --git a/observe-services-topia/src/test/java/fr/ird/observe/services/service/actions/report/ReportTargetCatchByAssociationTest.java b/observe-services-topia/src/test/java/fr/ird/observe/services/service/actions/report/ReportTargetCatchByAssociationTest.java index d630fca..bef0baa 100644 --- a/observe-services-topia/src/test/java/fr/ird/observe/services/service/actions/report/ReportTargetCatchByAssociationTest.java +++ b/observe-services-topia/src/test/java/fr/ird/observe/services/service/actions/report/ReportTargetCatchByAssociationTest.java @@ -108,7 +108,7 @@ public class ReportTargetCatchByAssociationTest extends AbstractReportServiceTop assertResultRow(result, row++, "26.0", "0.0", "0.0", "0.0", "0.0", "0.0", "26.0"); assertResultRow(result, row++, null, null, null, null, null, null, "0.0"); assertResultRow(result, row++, "32.0", "71.0", "10.0", "0.0", "0.0", "0.0", "113.0"); - assertResultRow(result, row++, "513.2", "71.0", "50.0", "0.0", "0.0", "2.2", "636.4"); + assertResultRow(result, row, "513.2", "71.0", "50.0", "0.0", "0.0", "2.2", "636.4"); } } diff --git a/observe-services-topia/src/test/java/fr/ird/observe/services/service/actions/report/ReportTargetDiscardedByAssociationTest.java b/observe-services-topia/src/test/java/fr/ird/observe/services/service/actions/report/ReportTargetDiscardedByAssociationTest.java index 006c906..d1ea99b 100644 --- a/observe-services-topia/src/test/java/fr/ird/observe/services/service/actions/report/ReportTargetDiscardedByAssociationTest.java +++ b/observe-services-topia/src/test/java/fr/ird/observe/services/service/actions/report/ReportTargetDiscardedByAssociationTest.java @@ -108,7 +108,7 @@ public class ReportTargetDiscardedByAssociationTest extends AbstractReportServic assertResultRow(result, row++, null, null, null, null, null, null, "0.0"); assertResultRow(result, row++, null, null, null, null, null, null, "0.0"); assertResultRow(result, row++, "2.775", "5.405", "0.0", "0.0", "0.0", "0.1", "8.28"); - assertResultRow(result, row++, "3.6159999999999997", "5.405", "0.29", "0.0", "0.08", "0.11", "9.501"); + assertResultRow(result, row, "3.6159999999999997", "5.405", "0.29", "0.0", "0.08", "0.11", "9.501"); } } diff --git a/observe-services-topia/src/test/java/fr/ird/observe/services/service/actions/validate/ValidateServiceTopiaTest.java b/observe-services-topia/src/test/java/fr/ird/observe/services/service/actions/validate/ValidateServiceTopiaTest.java index 713e9bd..f5a411d 100644 --- a/observe-services-topia/src/test/java/fr/ird/observe/services/service/actions/validate/ValidateServiceTopiaTest.java +++ b/observe-services-topia/src/test/java/fr/ird/observe/services/service/actions/validate/ValidateServiceTopiaTest.java @@ -26,7 +26,73 @@ import com.google.common.collect.ImmutableMap; import com.google.common.collect.ImmutableSet; import fr.ird.observe.services.ObserveServiceTopia; import fr.ird.observe.services.dto.IdDto; +import fr.ird.observe.services.dto.referential.CountryDto; +import fr.ird.observe.services.dto.referential.FpaZoneDto; +import fr.ird.observe.services.dto.referential.GearCaracteristicDto; +import fr.ird.observe.services.dto.referential.GearCaracteristicTypeDto; +import fr.ird.observe.services.dto.referential.GearDto; +import fr.ird.observe.services.dto.referential.HarbourDto; +import fr.ird.observe.services.dto.referential.LengthWeightParameterDto; +import fr.ird.observe.services.dto.referential.OceanDto; +import fr.ird.observe.services.dto.referential.OrganismDto; +import fr.ird.observe.services.dto.referential.PersonDto; +import fr.ird.observe.services.dto.referential.ProgramDto; import fr.ird.observe.services.dto.referential.ReferentialDto; +import fr.ird.observe.services.dto.referential.SexDto; +import fr.ird.observe.services.dto.referential.SpeciesDto; +import fr.ird.observe.services.dto.referential.SpeciesGroupDto; +import fr.ird.observe.services.dto.referential.SpeciesListDto; +import fr.ird.observe.services.dto.referential.VesselDto; +import fr.ird.observe.services.dto.referential.VesselSizeCategoryDto; +import fr.ird.observe.services.dto.referential.VesselTypeDto; +import fr.ird.observe.services.dto.referential.longline.BaitHaulingStatusDto; +import fr.ird.observe.services.dto.referential.longline.BaitSettingStatusDto; +import fr.ird.observe.services.dto.referential.longline.BaitTypeDto; +import fr.ird.observe.services.dto.referential.longline.CatchFateLonglineDto; +import fr.ird.observe.services.dto.referential.longline.EncounterTypeDto; +import fr.ird.observe.services.dto.referential.longline.HealthnessDto; +import fr.ird.observe.services.dto.referential.longline.HookPositionDto; +import fr.ird.observe.services.dto.referential.longline.HookSizeDto; +import fr.ird.observe.services.dto.referential.longline.HookTypeDto; +import fr.ird.observe.services.dto.referential.longline.ItemHorizontalPositionDto; +import fr.ird.observe.services.dto.referential.longline.ItemVerticalPositionDto; +import fr.ird.observe.services.dto.referential.longline.LightsticksColorDto; +import fr.ird.observe.services.dto.referential.longline.LightsticksTypeDto; +import fr.ird.observe.services.dto.referential.longline.LineTypeDto; +import fr.ird.observe.services.dto.referential.longline.MaturityStatusDto; +import fr.ird.observe.services.dto.referential.longline.MitigationTypeDto; +import fr.ird.observe.services.dto.referential.longline.SensorBrandDto; +import fr.ird.observe.services.dto.referential.longline.SensorDataFormatDto; +import fr.ird.observe.services.dto.referential.longline.SensorTypeDto; +import fr.ird.observe.services.dto.referential.longline.SettingShapeDto; +import fr.ird.observe.services.dto.referential.longline.SizeMeasureTypeDto; +import fr.ird.observe.services.dto.referential.longline.StomacFullnessDto; +import fr.ird.observe.services.dto.referential.longline.TripTypeDto; +import fr.ird.observe.services.dto.referential.longline.VesselActivityLonglineDto; +import fr.ird.observe.services.dto.referential.longline.WeightMeasureTypeDto; +import fr.ird.observe.services.dto.referential.seine.DetectionModeDto; +import fr.ird.observe.services.dto.referential.seine.ObjectFateDto; +import fr.ird.observe.services.dto.referential.seine.ObjectOperationDto; +import fr.ird.observe.services.dto.referential.seine.ObjectTypeDto; +import fr.ird.observe.services.dto.referential.seine.ObservedSystemDto; +import fr.ird.observe.services.dto.referential.seine.ReasonForDiscardDto; +import fr.ird.observe.services.dto.referential.seine.ReasonForNoFishingDto; +import fr.ird.observe.services.dto.referential.seine.ReasonForNullSetDto; +import fr.ird.observe.services.dto.referential.seine.SpeciesFateDto; +import fr.ird.observe.services.dto.referential.seine.SpeciesStatusDto; +import fr.ird.observe.services.dto.referential.seine.SurroundingActivityDto; +import fr.ird.observe.services.dto.referential.seine.TransmittingBuoyOperationDto; +import fr.ird.observe.services.dto.referential.seine.TransmittingBuoyTypeDto; +import fr.ird.observe.services.dto.referential.seine.VesselActivitySeineDto; +import fr.ird.observe.services.dto.referential.seine.WeightCategoryDto; +import fr.ird.observe.services.dto.referential.seine.WindDto; +import fr.ird.observe.services.dto.seine.ActivitySeineDto; +import fr.ird.observe.services.dto.seine.FloatingObjectDto; +import fr.ird.observe.services.dto.seine.NonTargetCatchDto; +import fr.ird.observe.services.dto.seine.RouteDto; +import fr.ird.observe.services.dto.seine.SetSeineDto; +import fr.ird.observe.services.dto.seine.TransmittingBuoyDto; +import fr.ird.observe.services.dto.seine.TripSeineDto; import fr.ird.observe.services.service.AbstractServiceTopiaTest; import fr.ird.observe.test.DatabaseName; import fr.ird.observe.test.ObserveFixtures; @@ -68,67 +134,67 @@ public class ValidateServiceTopiaTest extends AbstractServiceTopiaTest { // System.out.println("assertValidateResultForReferentialDtoType(resultByType, " + entry.getKey().getName() + ".class, " + entry.getValue().getValidationResultForDto().size() + ");"); // } - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.CountryDto.class, 53); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.FpaZoneDto.class, 41); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.GearCaracteristicDto.class, 22); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.GearCaracteristicTypeDto.class, 6); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.GearDto.class, 26); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.HarbourDto.class, 74); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.LengthWeightParameterDto.class, 352); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.OceanDto.class, 3); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.OrganismDto.class, 8); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.PersonDto.class, 390); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.ProgramDto.class, 27); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.SexDto.class, 5); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.SpeciesDto.class, 275); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.SpeciesGroupDto.class, 8); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.SpeciesListDto.class, 5); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.VesselDto.class, 977); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.VesselSizeCategoryDto.class, 13); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.VesselTypeDto.class, 14); - - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.longline.BaitHaulingStatusDto.class, 5); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.longline.BaitSettingStatusDto.class, 5); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.longline.BaitTypeDto.class, 16); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.longline.CatchFateLonglineDto.class, 5); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.longline.EncounterTypeDto.class, 12); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.longline.HealthnessDto.class, 6); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.longline.HookPositionDto.class, 13); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.longline.HookSizeDto.class, 22); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.longline.HookTypeDto.class, 13); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.longline.ItemHorizontalPositionDto.class, 3); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.longline.ItemVerticalPositionDto.class, 3); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.longline.LightsticksColorDto.class, 7); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.longline.LightsticksTypeDto.class, 2); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.longline.LineTypeDto.class, 8); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.longline.MaturityStatusDto.class, 12); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.longline.MitigationTypeDto.class, 15); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.longline.SensorBrandDto.class, 4); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.longline.SensorDataFormatDto.class, 2); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.longline.SensorTypeDto.class, 4); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.longline.SettingShapeDto.class, 6); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.longline.SizeMeasureTypeDto.class, 17); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.longline.StomacFullnessDto.class, 7); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.longline.TripTypeDto.class, 3); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.longline.VesselActivityLonglineDto.class, 5); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.longline.WeightMeasureTypeDto.class, 3); - - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.seine.DetectionModeDto.class, 10); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.seine.ObjectFateDto.class, 9); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.seine.ObjectOperationDto.class, 4); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.seine.ObjectTypeDto.class, 23); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.seine.ObservedSystemDto.class, 21); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.seine.ReasonForDiscardDto.class, 5); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.seine.ReasonForNoFishingDto.class, 13); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.seine.ReasonForNullSetDto.class, 10); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.seine.SpeciesFateDto.class, 9); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.seine.SpeciesStatusDto.class, 3); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.seine.SurroundingActivityDto.class, 8); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.seine.TransmittingBuoyOperationDto.class, 3); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.seine.TransmittingBuoyTypeDto.class, 12); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.seine.VesselActivitySeineDto.class, 23); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.seine.WeightCategoryDto.class, 101); - assertValidateResultForReferentialDtoType(resultByType, fr.ird.observe.services.dto.referential.seine.WindDto.class, 13); + assertValidateResultForReferentialDtoType(resultByType, CountryDto.class, 53); + assertValidateResultForReferentialDtoType(resultByType, FpaZoneDto.class, 41); + assertValidateResultForReferentialDtoType(resultByType, GearCaracteristicDto.class, 22); + assertValidateResultForReferentialDtoType(resultByType, GearCaracteristicTypeDto.class, 6); + assertValidateResultForReferentialDtoType(resultByType, GearDto.class, 26); + assertValidateResultForReferentialDtoType(resultByType, HarbourDto.class, 74); + assertValidateResultForReferentialDtoType(resultByType, LengthWeightParameterDto.class, 352); + assertValidateResultForReferentialDtoType(resultByType, OceanDto.class, 3); + assertValidateResultForReferentialDtoType(resultByType, OrganismDto.class, 8); + assertValidateResultForReferentialDtoType(resultByType, PersonDto.class, 390); + assertValidateResultForReferentialDtoType(resultByType, ProgramDto.class, 27); + assertValidateResultForReferentialDtoType(resultByType, SexDto.class, 5); + assertValidateResultForReferentialDtoType(resultByType, SpeciesDto.class, 275); + assertValidateResultForReferentialDtoType(resultByType, SpeciesGroupDto.class, 8); + assertValidateResultForReferentialDtoType(resultByType, SpeciesListDto.class, 5); + assertValidateResultForReferentialDtoType(resultByType, VesselDto.class, 977); + assertValidateResultForReferentialDtoType(resultByType, VesselSizeCategoryDto.class, 13); + assertValidateResultForReferentialDtoType(resultByType, VesselTypeDto.class, 14); + + assertValidateResultForReferentialDtoType(resultByType, BaitHaulingStatusDto.class, 5); + assertValidateResultForReferentialDtoType(resultByType, BaitSettingStatusDto.class, 5); + assertValidateResultForReferentialDtoType(resultByType, BaitTypeDto.class, 16); + assertValidateResultForReferentialDtoType(resultByType, CatchFateLonglineDto.class, 5); + assertValidateResultForReferentialDtoType(resultByType, EncounterTypeDto.class, 12); + assertValidateResultForReferentialDtoType(resultByType, HealthnessDto.class, 6); + assertValidateResultForReferentialDtoType(resultByType, HookPositionDto.class, 13); + assertValidateResultForReferentialDtoType(resultByType, HookSizeDto.class, 22); + assertValidateResultForReferentialDtoType(resultByType, HookTypeDto.class, 13); + assertValidateResultForReferentialDtoType(resultByType, ItemHorizontalPositionDto.class, 3); + assertValidateResultForReferentialDtoType(resultByType, ItemVerticalPositionDto.class, 3); + assertValidateResultForReferentialDtoType(resultByType, LightsticksColorDto.class, 7); + assertValidateResultForReferentialDtoType(resultByType, LightsticksTypeDto.class, 2); + assertValidateResultForReferentialDtoType(resultByType, LineTypeDto.class, 8); + assertValidateResultForReferentialDtoType(resultByType, MaturityStatusDto.class, 12); + assertValidateResultForReferentialDtoType(resultByType, MitigationTypeDto.class, 15); + assertValidateResultForReferentialDtoType(resultByType, SensorBrandDto.class, 4); + assertValidateResultForReferentialDtoType(resultByType, SensorDataFormatDto.class, 2); + assertValidateResultForReferentialDtoType(resultByType, SensorTypeDto.class, 4); + assertValidateResultForReferentialDtoType(resultByType, SettingShapeDto.class, 6); + assertValidateResultForReferentialDtoType(resultByType, SizeMeasureTypeDto.class, 17); + assertValidateResultForReferentialDtoType(resultByType, StomacFullnessDto.class, 7); + assertValidateResultForReferentialDtoType(resultByType, TripTypeDto.class, 3); + assertValidateResultForReferentialDtoType(resultByType, VesselActivityLonglineDto.class, 5); + assertValidateResultForReferentialDtoType(resultByType, WeightMeasureTypeDto.class, 3); + + assertValidateResultForReferentialDtoType(resultByType, DetectionModeDto.class, 10); + assertValidateResultForReferentialDtoType(resultByType, ObjectFateDto.class, 9); + assertValidateResultForReferentialDtoType(resultByType, ObjectOperationDto.class, 4); + assertValidateResultForReferentialDtoType(resultByType, ObjectTypeDto.class, 23); + assertValidateResultForReferentialDtoType(resultByType, ObservedSystemDto.class, 21); + assertValidateResultForReferentialDtoType(resultByType, ReasonForDiscardDto.class, 5); + assertValidateResultForReferentialDtoType(resultByType, ReasonForNoFishingDto.class, 13); + assertValidateResultForReferentialDtoType(resultByType, ReasonForNullSetDto.class, 10); + assertValidateResultForReferentialDtoType(resultByType, SpeciesFateDto.class, 9); + assertValidateResultForReferentialDtoType(resultByType, SpeciesStatusDto.class, 3); + assertValidateResultForReferentialDtoType(resultByType, SurroundingActivityDto.class, 8); + assertValidateResultForReferentialDtoType(resultByType, TransmittingBuoyOperationDto.class, 3); + assertValidateResultForReferentialDtoType(resultByType, TransmittingBuoyTypeDto.class, 12); + assertValidateResultForReferentialDtoType(resultByType, VesselActivitySeineDto.class, 23); + assertValidateResultForReferentialDtoType(resultByType, WeightCategoryDto.class, 101); + assertValidateResultForReferentialDtoType(resultByType, WindDto.class, 13); } @@ -152,13 +218,13 @@ public class ValidateServiceTopiaTest extends AbstractServiceTopiaTest { // System.out.println("assertValidateResultForDtoType(resultByType, " + entry.getKey().getName() + ".class, " + entry.getValue().getValidationResultForDto().size() + ");"); // } - assertValidateResultForDtoType(resultByType, fr.ird.observe.services.dto.seine.TripSeineDto.class, 2); - assertValidateResultForDtoType(resultByType, fr.ird.observe.services.dto.seine.RouteDto.class, 80); - assertValidateResultForDtoType(resultByType, fr.ird.observe.services.dto.seine.ActivitySeineDto.class, 1519); - assertValidateResultForDtoType(resultByType, fr.ird.observe.services.dto.seine.FloatingObjectDto.class, 99); - assertValidateResultForDtoType(resultByType, fr.ird.observe.services.dto.seine.TransmittingBuoyDto.class, 42); - assertValidateResultForDtoType(resultByType, fr.ird.observe.services.dto.seine.SetSeineDto.class, 77); - assertValidateResultForDtoType(resultByType, fr.ird.observe.services.dto.seine.NonTargetCatchDto.class, 3); + assertValidateResultForDtoType(resultByType, TripSeineDto.class, 2); + assertValidateResultForDtoType(resultByType, RouteDto.class, 80); + assertValidateResultForDtoType(resultByType, ActivitySeineDto.class, 1519); + assertValidateResultForDtoType(resultByType, FloatingObjectDto.class, 99); + assertValidateResultForDtoType(resultByType, TransmittingBuoyDto.class, 42); + assertValidateResultForDtoType(resultByType, SetSeineDto.class, 77); + assertValidateResultForDtoType(resultByType, NonTargetCatchDto.class, 3); } diff --git a/observe-topia-extension/src/main/java/org/nuiton/topia/service/sql/batch/actions/AbstractSqlAction.java b/observe-topia-extension/src/main/java/org/nuiton/topia/service/sql/batch/actions/AbstractSqlAction.java index 4cbc38b..f708367 100644 --- a/observe-topia-extension/src/main/java/org/nuiton/topia/service/sql/batch/actions/AbstractSqlAction.java +++ b/observe-topia-extension/src/main/java/org/nuiton/topia/service/sql/batch/actions/AbstractSqlAction.java @@ -73,23 +73,17 @@ public abstract class AbstractSqlAction<R extends AbstractSqlRequest> implements this.request = request; ImmutableSet.Builder<Closeable> closeableBuilder = ImmutableSet.builder(); - closeableBuilder.add(new Closeable() { - @Override - public void close() throws IOException { - if (sourcePersistenceContext != null) { - sourcePersistenceContext.close(); - } + closeableBuilder.add(() -> { + if (sourcePersistenceContext != null) { + sourcePersistenceContext.close(); } }); - closeableBuilder.add(new Closeable() { - @Override - public void close() throws IOException { - if (targetConnection != null) { - try { - targetConnection.close(); - } catch (SQLException e) { - throw new TopiaException("Could not close targetConnection", e); - } + closeableBuilder.add(() -> { + if (targetConnection != null) { + try { + targetConnection.close(); + } catch (SQLException e) { + throw new TopiaException("Could not close targetConnection", e); } } }); @@ -194,7 +188,7 @@ public abstract class AbstractSqlAction<R extends AbstractSqlRequest> implements } - protected final void after() throws SQLException { + protected final void after() { endTime = TIME_LOG.log(startTime, "Action executed", getClass().getName()); diff --git a/observe-topia-extension/src/main/java/org/nuiton/topia/service/sql/batch/actions/AbstractTablesAction.java b/observe-topia-extension/src/main/java/org/nuiton/topia/service/sql/batch/actions/AbstractTablesAction.java index e81aa30..0851106 100644 --- a/observe-topia-extension/src/main/java/org/nuiton/topia/service/sql/batch/actions/AbstractTablesAction.java +++ b/observe-topia-extension/src/main/java/org/nuiton/topia/service/sql/batch/actions/AbstractTablesAction.java @@ -119,7 +119,7 @@ public abstract class AbstractTablesAction<R extends AbstractTablesRequest> exte } - protected String generateWildcardArguments(Iterable<String> columnNames) throws SQLException { + protected String generateWildcardArguments(Iterable<String> columnNames) { StringBuilder argsBuilder = new StringBuilder(); diff --git a/observe-topia-extension/src/main/java/org/nuiton/topia/service/sql/batch/actions/DeleteTablesAction.java b/observe-topia-extension/src/main/java/org/nuiton/topia/service/sql/batch/actions/DeleteTablesAction.java index f4b66de..bec2b89 100644 --- a/observe-topia-extension/src/main/java/org/nuiton/topia/service/sql/batch/actions/DeleteTablesAction.java +++ b/observe-topia-extension/src/main/java/org/nuiton/topia/service/sql/batch/actions/DeleteTablesAction.java @@ -123,11 +123,9 @@ public class DeleteTablesAction extends AbstractTablesAction<DeleteTablesRequest } - protected String newDeleteStatementSql(TopiaSqlTable table) throws SQLException { + protected String newDeleteStatementSql(TopiaSqlTable table) { - String sql = String.format(DELETE_STATEMENT, - table.getSchemaName(), - table.getTableName()); + String sql = String.format(DELETE_STATEMENT, table.getSchemaName(), table.getTableName()); if (log.isDebugEnabled()) { log.debug("Delete sql: " + sql); } diff --git a/observe-topia-extension/src/main/java/org/nuiton/topia/service/sql/batch/actions/ReplicateTablesAction.java b/observe-topia-extension/src/main/java/org/nuiton/topia/service/sql/batch/actions/ReplicateTablesAction.java index 8a623e0..792d5e9 100644 --- a/observe-topia-extension/src/main/java/org/nuiton/topia/service/sql/batch/actions/ReplicateTablesAction.java +++ b/observe-topia-extension/src/main/java/org/nuiton/topia/service/sql/batch/actions/ReplicateTablesAction.java @@ -121,7 +121,7 @@ public class ReplicateTablesAction extends AbstractTablesAction<ReplicateTablesR } - protected String newInsertStatementSql(TopiaSqlTable table, List<String> columnNames) throws SQLException { + protected String newInsertStatementSql(TopiaSqlTable table, List<String> columnNames) { StringBuilder columnNamesBuilder = new StringBuilder(); diff --git a/observe-topia-extension/src/main/java/org/nuiton/topia/service/sql/batch/actions/UpdateTablesAction.java b/observe-topia-extension/src/main/java/org/nuiton/topia/service/sql/batch/actions/UpdateTablesAction.java index 0dde854..2b48710 100644 --- a/observe-topia-extension/src/main/java/org/nuiton/topia/service/sql/batch/actions/UpdateTablesAction.java +++ b/observe-topia-extension/src/main/java/org/nuiton/topia/service/sql/batch/actions/UpdateTablesAction.java @@ -177,7 +177,7 @@ public class UpdateTablesAction extends AbstractTablesAction<UpdateTablesRequest } - protected String newUpdateStatementSql(TopiaSqlTable table, Iterable<String> columnNames) throws SQLException { + protected String newUpdateStatementSql(TopiaSqlTable table, Iterable<String> columnNames) { StringBuilder columnNamesBuilder = new StringBuilder(); diff --git a/observe-topia-extension/src/main/java/org/nuiton/topia/service/sql/batch/tables/TopiaSqlTables.java b/observe-topia-extension/src/main/java/org/nuiton/topia/service/sql/batch/tables/TopiaSqlTables.java index a5f0cca..1b02f23 100644 --- a/observe-topia-extension/src/main/java/org/nuiton/topia/service/sql/batch/tables/TopiaSqlTables.java +++ b/observe-topia-extension/src/main/java/org/nuiton/topia/service/sql/batch/tables/TopiaSqlTables.java @@ -144,7 +144,7 @@ public class TopiaSqlTables implements Iterable<TopiaSqlTable> { tableName, whereClauseAlias, fromClause, - ImmutableSet.<String>of()); + ImmutableSet.of()); return new BuilderStepOnTableImpl(null, entityEnum); } -- To stop receiving notification emails like this one, please contact codelutin.com SCM administrator <admin+scm@codelutin.com>.