Tony CHEMIT pushed to branch develop at ultreiaio / ird-observe Commits: b135087c by tchemit at 2019-04-15T16:33:02Z [PS][FOB] Le calcul du type simplifié et des propriétés maillant/biodégradable ne se fait pas en passant l'algorithme de calcul - Closes #1268 - - - - - 3 changed files: - persistence/src/main/java/fr/ird/observe/entities/data/ps/observation/ActivitySeineImpl.java - persistence/src/main/java/fr/ird/observe/entities/data/ps/observation/ActivitySeines.java - services-local/src/main/java/fr/ird/observe/services/local/service/actions/consolidate/ConsolidateDataServiceLocal.java Changes: ===================================== persistence/src/main/java/fr/ird/observe/entities/data/ps/observation/ActivitySeineImpl.java ===================================== @@ -39,7 +39,7 @@ public class ActivitySeineImpl extends ActivitySeineAbstract { @Override public boolean isDCPOperation() { - return vesselActivitySeine != null && ActivitySeines.DCP_OPERATIONS.contains(vesselActivitySeine.getCode()); + return vesselActivitySeine != null && vesselActivitySeine.isAllowFad(); } @Override ===================================== persistence/src/main/java/fr/ird/observe/entities/data/ps/observation/ActivitySeines.java ===================================== @@ -57,8 +57,6 @@ public class ActivitySeines { public static final String ACTIVITY_FIN_DE_PECHE = "6"; public static final List<String> CALEE_OPERATIONS = Collections.singletonList(ACTIVITY_FIN_DE_PECHE); public static final String ACTIVITY_CHANGED_ZONE = "21"; - public static final List<String> DCP_OPERATIONS = Arrays.asList("13", "14", "15"); - /** Logger. */ private static final Logger log = LogManager.getLogger(ActivitySeines.class); ===================================== services-local/src/main/java/fr/ird/observe/services/local/service/actions/consolidate/ConsolidateDataServiceLocal.java ===================================== @@ -227,9 +227,14 @@ public class ConsolidateDataServiceLocal extends ObserveServiceLocal implements String activityPrefix = String.format("%s - Activity [%s/%s] ", routePrefix, ++activityIndex, activityMax); + boolean floatingObjectNotEmpty = activitySeine.isFloatingObjectNotEmpty(); if (!activitySeine.isSetOperation() && !activitySeine.isDCPOperation()) { - log.info(String.format("%s Skip activity (No set nor dcp): %s", activityPrefix, activitySeine.getTopiaId())); - continue; + if (floatingObjectNotEmpty) { + log.warn(String.format("%s Use activity with some FOB but his activity does not allow FAD (vessel activity code: %s) : %s", activityPrefix, activitySeine.getVesselActivitySeine().getCode(), activitySeine.getTopiaId())); + } else { + log.info(String.format("%s Skip activity (No set nor dcp): %s", activityPrefix, activitySeine.getTopiaId())); + continue; + } } ConsolidateActivitySeineDataResultBuilder resultBuilder = new ConsolidateActivitySeineDataResultBuilder(applicationLocale, referenceLocale, activitySeine.getTopiaId(), ActivitySeines.decorate(referenceLocale.ordinal(), activitySeine)); View it on GitLab: https://gitlab.com/ultreiaio/ird-observe/commit/b135087c920de7be5f49e078e759... -- View it on GitLab: https://gitlab.com/ultreiaio/ird-observe/commit/b135087c920de7be5f49e078e759... You're receiving this email because of your account on gitlab.com.