This is an automated email from the git hooks/post-receive script. New commit to branch develop in repository observe. See https://gitlab.nuiton.org/codelutin/observe.git commit 003c0b91f6a4128ede4d506ffd496ab80f0aaf1d Author: Tony CHEMIT <chemit@codelutin.com> Date: Tue Aug 30 13:12:33 2016 +0200 clean code --- .../validation/validators/ActivityFinDeVeilleExistsDtoValidator.java | 2 +- .../fr/ird/observe/application/swing/ui/util/JVetoableTabbedPane.java | 2 +- .../topia/validation/validators/ActivityFinDeVeilleExistsValidator.java | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/application-swing-validation/src/main/java/fr/ird/observe/application/swing/validation/validators/ActivityFinDeVeilleExistsDtoValidator.java b/application-swing-validation/src/main/java/fr/ird/observe/application/swing/validation/validators/ActivityFinDeVeilleExistsDtoValidator.java index 854fa2e..28ee80c 100644 --- a/application-swing-validation/src/main/java/fr/ird/observe/application/swing/validation/validators/ActivityFinDeVeilleExistsDtoValidator.java +++ b/application-swing-validation/src/main/java/fr/ird/observe/application/swing/validation/validators/ActivityFinDeVeilleExistsDtoValidator.java @@ -156,7 +156,7 @@ public class ActivityFinDeVeilleExistsDtoValidator extends FieldValidatorSupport } boolean detected = route.isActivityFindDeVeilleFound(); - boolean valid = required ? detected : !detected; + boolean valid = required == detected; if (log.isDebugEnabled()) { log.debug("detected activity fin de veille " + detected); log.debug("is valid = " + valid); diff --git a/application-swing/src/main/java/fr/ird/observe/application/swing/ui/util/JVetoableTabbedPane.java b/application-swing/src/main/java/fr/ird/observe/application/swing/ui/util/JVetoableTabbedPane.java index 216a629..24603c6 100644 --- a/application-swing/src/main/java/fr/ird/observe/application/swing/ui/util/JVetoableTabbedPane.java +++ b/application-swing/src/main/java/fr/ird/observe/application/swing/ui/util/JVetoableTabbedPane.java @@ -85,7 +85,7 @@ public class JVetoableTabbedPane extends JTabbedPane { } - public static interface ChangeSelectedIndex { + public interface ChangeSelectedIndex { /** * Ask to change tab from {@code selectedIndex} tab to {@code index}. diff --git a/services-topia-validation/src/main/java/fr/ird/observe/services/topia/validation/validators/ActivityFinDeVeilleExistsValidator.java b/services-topia-validation/src/main/java/fr/ird/observe/services/topia/validation/validators/ActivityFinDeVeilleExistsValidator.java index 9861003..0bd4359 100644 --- a/services-topia-validation/src/main/java/fr/ird/observe/services/topia/validation/validators/ActivityFinDeVeilleExistsValidator.java +++ b/services-topia-validation/src/main/java/fr/ird/observe/services/topia/validation/validators/ActivityFinDeVeilleExistsValidator.java @@ -166,7 +166,7 @@ public class ActivityFinDeVeilleExistsValidator extends FieldValidatorSupport { } boolean detected = ActivitySeines.isActivityFindDeVeilleFound(route); - boolean valid = required ? detected : !detected; + boolean valid = required == detected; if (log.isDebugEnabled()) { log.debug("detected activity fin de veille " + detected); log.debug("is valid = " + valid); -- To stop receiving notification emails like this one, please contact codelutin.com SCM administrator <admin+scm@codelutin.com>.